40790 2010-06-17 10:46:44 -0700 Fix build break with inspector disabled 2010-06-19 06:55:06 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 benm benm android-webkit-unforking commit-queue pfeldman oldest_to_newest 239464 0 benm 2010-06-17 10:46:44 -0700 With the inspector not enabled, the build breaks due to the #include of InspectorValues.h in InspectorController.h because the content of InspectorValues is guarded by #if ENABLE(INSPECTOR). Turns out we don't need the include at all and a forward declaration is enough. Patch coming. 239473 1 59013 benm 2010-06-17 10:54:12 -0700 Created attachment 59013 Patch. 240331 2 59013 commit-queue 2010-06-19 06:55:01 -0700 Comment on attachment 59013 Patch. Clearing flags on attachment: 59013 Committed r61485: <http://trac.webkit.org/changeset/61485> 240332 3 commit-queue 2010-06-19 06:55:06 -0700 All reviewed patches have been landed. Closing bug. 59013 2010-06-17 10:54:12 -0700 2010-06-19 06:55:01 -0700 Patch. 40790.txt text/plain 1399 benm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTMzOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMTcgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBi dWlsZCBicmVhayB3aXRoIGluc3BlY3RvciBkaXNhYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNzkwCisKKyAgICAgICAgUmVwbGFjZSBhICNp bmNsdWRlIHdpdGggYSBmb3J3YXJkIGRlY2xhcmF0aW9uLgorCisgICAgICAgIEZpeGluZyBhIGJ1 aWxkIGJyZWFrIHNvIG5vIG5ldyB0ZXN0cyByZXF1aXJlZC4KKworICAgICAgICAqIGluc3BlY3Rv ci9JbnNwZWN0b3JDb250cm9sbGVyLmg6IEZvcndhcmQgZGVjbGFyZSBJbnNwZWN0b3JWYWx1ZQor ICAgICAgICAgICByYXRoZXIgdGhhbiAjaW5jbHVkaW5nIGl0cyBoZWFkZXIgd2hpY2ggaGFzIGl0 cyBjb250ZW50IGd1YXJkZWQKKyAgICAgICAgICAgb3V0LgorCiAyMDEwLTA2LTE3ICBTaHUgQ2hh bmcgIDxjaGFuZy5zaHVAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGgg Um9oZGUgQ2hyaXN0aWFuc2VuLgpJbmRleDogV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29u dHJvbGxlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRy b2xsZXIuaAkocmV2aXNpb24gNjEzMzQpCisrKyBXZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JD b250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTMyLDcgKzMyLDYgQEAKICNpbmNsdWRlICJD b25zb2xlLmgiCiAjaW5jbHVkZSAiQ29va2llLmgiCiAjaW5jbHVkZSAiSW5zcGVjdG9yRE9NQWdl bnQuaCIKLSNpbmNsdWRlICJJbnNwZWN0b3JWYWx1ZXMuaCIKICNpbmNsdWRlICJQbGF0Zm9ybVN0 cmluZy5oIgogI2luY2x1ZGUgIlNjcmlwdEFycmF5LmgiCiAjaW5jbHVkZSAiU2NyaXB0QnJlYWtw b2ludC5oIgpAQCAtNzAsNiArNjksNyBAQCBjbGFzcyBJbnNwZWN0b3JDU1NTdG9yZTsKIGNsYXNz IEluc3BlY3RvckZyb250ZW5kOwogY2xhc3MgSW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ7CiBjbGFz cyBJbnNwZWN0b3JUaW1lbGluZUFnZW50OworY2xhc3MgSW5zcGVjdG9yVmFsdWU7CiBjbGFzcyBL VVJMOwogY2xhc3MgTm9kZTsKIGNsYXNzIFBhZ2U7Cg==