40780 2010-06-17 08:52:00 -0700 [Qt] Fail to compile with ENABLE_JIT=0 on Symbian 2010-07-22 23:26:06 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED P3 Normal --- 1 cshu cshu kenneth laszlo.gombos lucas.de.marchi oldest_to_newest 239409 0 cshu 2010-06-17 08:52:00 -0700 When disabling JIT using command: WebKitTools/Scripts/build-webkit --qt --symbian "JAVASCRIPTCORE_JIT=no" and sbs -c armv5_urel, a link error is reported complaining missing symbol of systemRelease in ExecutableAllocator.h One problem is we need a "if ENABLE(JIT)" guard in ExecutableAllocator.h. The 2nd problem is ENABLE_JIT is not set in WebCore and ExecutableAllocator.h is included with JIT enabled. The compiler on symbian reports error on static functions. 239411 1 58998 cshu 2010-06-17 08:59:53 -0700 Created attachment 58998 fix patch 239466 2 58998 cshu 2010-06-17 10:47:45 -0700 Comment on attachment 58998 fix patch committed patch manually. r61338. cleared flags. 253144 3 lucas.de.marchi 2010-07-19 05:07:55 -0700 Don't forget to close the bug. 255217 4 laszlo.gombos 2010-07-22 23:26:06 -0700 1./ Wouldn't the following work (we use DEFINES for all the other features)? WebKitTools/Scripts/build-webkit --qt --symbian "DEFINES+=ENABLE_JIT=0" 2./ Also we normally put common build logic into WebKit.pri (not sure if we need another common.pri). 58998 2010-06-17 08:59:53 -0700 2010-06-17 10:47:45 -0700 fix patch bug40780_1.patch text/plain 4107 cshu SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYxMzI3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYt MTcgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBGaXggdGhlIGxpbmsgZXJyb3Igb24g c3ltYmlhbiB3aXRoIEVOQUJMRV9KSVQ9MC4KKyAgICAgICAgMS4gQWRkICIjaWYgRU5BQkxFKEpJ VCkiIGluIHRoZSBoZWFkZXIgZmlsZTsKKyAgICAgICAgMi4gUHV0IGZlYXR1cmUgZW5hYmxlL2Rp c2FibGUgbG9naWMgdG8gYSBjb21tb24ucHJpIHNvCisgICAgICAgIHRoYXQgYm90aCBKYXZhU2Ny aXB0Q29yZS5wcmkgYW5kIFdlYkNvcmUucHJpIGNhbiBzaGFyZS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA3ODAKKworICAgICAgICAqIGNvbW1v bi5wcmk6IEFkZGVkLgorCiAyMDEwLTA2LTE3ICBBbGV4aXMgTWVuYXJkICA8YWxleGlzLm1lbmFy ZEBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4uCkluZGV4OiBjb21tb24ucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGNvbW1vbi5wcmkJKHJldmlz aW9uIDApCisrKyBjb21tb24ucHJpCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDUgQEAKKyMgY29t bW9uIHByb2plY3QgaW5jbHVkZSBmaWxlIGZvciBKYXZhU2NyaXB0Q29yZSBhbmQgV2ViQ29yZQor Citjb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQseWVzKTogREVGSU5FUys9RU5BQkxFX0pJVD0x Citjb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQsbm8pOiBERUZJTkVTKz1FTkFCTEVfSklUPTAK KwpJbmRleDogSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNjEzMjcpCisrKyBKYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNi0xNyAgU2h1IENo YW5nICA8Y2hhbmcuc2h1QG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbUXRdIEZpeCB0aGUgbGluayBlcnJvciBvbiBzeW1iaWFuIHdp dGggRU5BQkxFX0pJVD0wLgorICAgICAgICAxLiBBZGQgIiNpZiBFTkFCTEUoSklUKSIgaW4gdGhl IGhlYWRlciBmaWxlOworICAgICAgICAyLiBQdXQgZmVhdHVyZSBlbmFibGUvZGlzYWJsZSBsb2dp YyB0byBhIGNvbW1vbi5wcmkgc28KKyAgICAgICAgdGhhdCBib3RoIEphdmFTY3JpcHRDb3JlLnBy aSBhbmQgV2ViQ29yZS5wcmkgY2FuIHNoYXJlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDc4MAorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUu cHJpOgorICAgICAgICAqIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmg6CisKIDIwMTAtMDYtMTcg IERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNh bSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCShyZXZpc2lvbiA2MTE4 NikKKysrIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQkod29ya2luZyBjb3B5KQpA QCAtMSw0ICsxLDcgQEAKICMgSmF2YVNjcmlwdENvcmUgLSBRdDQgYnVpbGQgaW5mbworCitpbmNs dWRlKC4uL2NvbW1vbi5wcmkpCisKIFZQQVRIICs9ICQkUFdECiAhQ09ORklHKHJlbGVhc2UsIGRl YnVnfHJlbGVhc2UpIHsKICAgICAjIE91dHB1dCBpbiBKYXZhU2NyaXB0Q29yZS88Y29uZmlnPgpA QCAtNTEsOSArNTQsNiBAQCB3aW4zMi0qOiBERUZJTkVTICs9IF9IQVNfVFIxPTAKIAogREVGSU5F UyArPSBCVUlMRElOR19RVF9fIEJVSUxESU5HX0phdmFTY3JpcHRDb3JlIEJVSUxESU5HX1dURgog Ci1jb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQseWVzKTogREVGSU5FUys9RU5BQkxFX0pJVD0x Ci1jb250YWlucyhKQVZBU0NSSVBUQ09SRV9KSVQsbm8pOiBERUZJTkVTKz1FTkFCTEVfSklUPTAK LQogd2luY2UqIHsKICAgICBJTkNMVURFUEFUSCArPSAkJFFUX1NPVVJDRV9UUkVFL3NyYy8zcmRw YXJ0eS9jZS1jb21wYXQKICAgICBERUZJTkVTICs9IFdJTkNFQkFTSUMKSW5kZXg6IEphdmFTY3Jp cHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmgKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlw dENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3IuaAkocmV2aXNpb24gNjEyOTgpCisrKyBKYXZh U2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCSh3b3JraW5nIGNvcHkpCkBAIC0y Niw2ICsyNiw4IEBACiAjaWZuZGVmIEV4ZWN1dGFibGVBbGxvY2F0b3JfaAogI2RlZmluZSBFeGVj dXRhYmxlQWxsb2NhdG9yX2gKIAorI2lmIEVOQUJMRShKSVQpCisKICNpbmNsdWRlIDxzdGRkZWYu aD4gLy8gZm9yIHB0cmRpZmZfdAogI2luY2x1ZGUgPGxpbWl0cz4KICNpbmNsdWRlIDx3dGYvQXNz ZXJ0aW9ucy5oPgpAQCAtMzE4LDQgKzMyMCw2IEBAIGlubGluZSB2b2lkKiBFeGVjdXRhYmxlUG9v bDo6cG9vbEFsbG9jYXQKIAogI2VuZGlmIC8vIEVOQUJMRShBU1NFTUJMRVIpCiAKKyNlbmRpZiAv LyBFTkFCTEUoSklUKQorCiAjZW5kaWYgLy8gIWRlZmluZWQoRXhlY3V0YWJsZUFsbG9jYXRvcikK SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMTcgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBGaXggdGhlIGxpbmsgZXJyb3Igb24gc3ltYmlhbiB3aXRoIEVOQUJMRV9KSVQ9MC4KKyAgICAg ICAgMS4gQWRkICIjaWYgRU5BQkxFKEpJVCkiIGluIHRoZSBoZWFkZXIgZmlsZTsKKyAgICAgICAg Mi4gUHV0IGZlYXR1cmUgZW5hYmxlL2Rpc2FibGUgbG9naWMgdG8gYSBjb21tb24ucHJpIHNvCisg ICAgICAgIHRoYXQgYm90aCBKYXZhU2NyaXB0Q29yZS5wcmkgYW5kIFdlYkNvcmUucHJpIGNhbiBz aGFyZS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDA3ODAKKworICAgICAgICAqIFdlYkNvcmUucHJpOgorCiAyMDEwLTA2LTE3ICBBbGV4IE1pbG93 c2tpICA8YWxleEBtaWxvd3NraS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRs ZXIuCkluZGV4OiBXZWJDb3JlL1dlYkNvcmUucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2Vi Q29yZS5wcmkJKHJldmlzaW9uIDYxMTg2KQorKysgV2ViQ29yZS9XZWJDb3JlLnByaQkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDYgQEAKKworaW5jbHVkZSguLi9jb21tb24ucHJpKQorCiBDT05G SUcoc3RhbmRhbG9uZV9wYWNrYWdlKSB7CiAgICAgaXNFbXB0eShXQ19HRU5FUkFURURfU09VUkNF U19ESVIpOldDX0dFTkVSQVRFRF9TT1VSQ0VTX0RJUiA9ICQkUFdEL2dlbmVyYXRlZAogfSBlbHNl IHsK