40772 2010-06-17 05:37:24 -0700 Warnings in v8 bindings with possible bug 2010-06-18 09:47:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 thomasvl dumi dglazkov dumi oldest_to_newest 239348 0 thomasvl 2010-06-17 05:37:24 -0700 We're trying to turn on -Wextra in for Chromium on the Mac. All the core Chromium code is now clean, so we're down to a half dozen hits in WebKit and v8. The v8 hits are (paths are from chromium build): src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp: In static member function 'static v8::Handle<v8::Value> WebCore::V8SQLResultSetRowList::itemCallback(const v8::Arguments&)': src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:59: warning: comparison of unsigned expression < 0 is always false Is putting a signed value into an unsigned and then checking for < 0. Dropping the check would fix the warning, but the sign drop could be an real issue. src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp: In function 'void _NPN_DeallocateObject(NPObject*)': src/third_party/WebKit/WebCore/WebCore.gyp/../bindings/v8/npruntime.cpp:299: warning: comparison of unsigned expression >= 0 is always true This is an assert for npObject->referenceCount being >= 0, but since referenceCount appears to be an uint32, the assert can probably just be dropped. 239377 1 dglazkov 2010-06-17 07:28:22 -0700 Dumi, could you take a look at the first one? Yup, the second one we can just drop. 239799 2 59078 dumi 2010-06-18 01:15:06 -0700 Created attachment 59078 patch 239911 3 59078 dglazkov 2010-06-18 07:40:12 -0700 Comment on attachment 59078 patch ok. 239987 4 dumi 2010-06-18 09:47:37 -0700 Landed as r61412. 59078 2010-06-18 01:15:06 -0700 2010-06-18 07:40:12 -0700 patch patch text/plain 1951 dumi SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTM4NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTcgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBSZW1vdmUgc29tZSB1bm5lY2Vzc2FyeSBjaGVja3MgdGhhdCBjYXVzZSBjb21waWxlciB3YXJu aW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw NzcyCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhTUUxSZXN1bHRTZXRSb3dMaXN0 Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4U1FMUmVzdWx0U2V0Um93TGlzdDo6aXRl bUNhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ucHJ1bnRpbWUuY3BwOgorCiAyMDEw LTA2LTE3ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjEzNzkuCkluZGV4OiBXZWJDb3JlL2JpbmRp bmdzL3Y4L25wcnVudGltZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9u cHJ1bnRpbWUuY3BwCShyZXZpc2lvbiA2MTM4NCkKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvbnBy dW50aW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjk2LDcgKzI5Niw2IEBAIE5QT2JqZWN0KiBf TlBOX1JldGFpbk9iamVjdChOUE9iamVjdCogbnAKIHZvaWQgX05QTl9EZWFsbG9jYXRlT2JqZWN0 KE5QT2JqZWN0KiBucE9iamVjdCkKIHsKICAgICBBU1NFUlQobnBPYmplY3QpOwotICAgIEFTU0VS VChucE9iamVjdC0+cmVmZXJlbmNlQ291bnQgPj0gMCk7CiAKICAgICBpZiAobnBPYmplY3QpIHsK ICAgICAgICAgLy8gTlBPYmplY3RzIHRoYXQgcmVtYWluIGluIHB1cmUgQysrIG1heSBuZXZlciBo YXZlIHdyYXBwZXJzLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhTUUxSZXN1 bHRTZXRSb3dMaXN0Q3VzdG9tLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOFNRTFJlc3VsdFNldFJvd0xpc3RDdXN0b20uY3BwCShyZXZpc2lvbiA2MTM4NCkK KysrIFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4U1FMUmVzdWx0U2V0Um93TGlzdEN1c3Rv bS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2LDcgKzU2LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFs dWU+IFY4U1FMUmVzdWx0U2V0Um93TAogICAgIFNRTFJlc3VsdFNldFJvd0xpc3QqIHJvd0xpc3Qg PSBWOFNRTFJlc3VsdFNldFJvd0xpc3Q6OnRvTmF0aXZlKGFyZ3MuSG9sZGVyKCkpOwogCiAgICAg dW5zaWduZWQgbG9uZyBpbmRleCA9IGFyZ3NbMF0tPkludGVnZXJWYWx1ZSgpOwotICAgIGlmIChp bmRleCA8IDAgfHwgaW5kZXggPj0gcm93TGlzdC0+bGVuZ3RoKCkpIHsKKyAgICBpZiAoaW5kZXgg Pj0gcm93TGlzdC0+bGVuZ3RoKCkpIHsKICAgICAgICAgVjhQcm94eTo6dGhyb3dFcnJvcihWOFBy b3h5OjpSYW5nZUVycm9yLCAiSXRlbSBpbmRleCBpcyBvdXQgb2YgcmFuZ2UuIik7CiAgICAgICAg IHJldHVybiB2ODo6VW5kZWZpbmVkKCk7CiAgICAgfQpAQCAtOTEsNCArOTEsMyBAQCB2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4gVjhTUUxSZXN1bHRTZXRSb3dMCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3Jl CiAKICNlbmRpZgotCg==