40749 2010-06-16 17:14:06 -0700 ResourceLoader::willCacheResponse() needs to null-check m_frame->settings() 2010-06-16 17:28:17 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 239157 0 beidson 2010-06-16 17:14:06 -0700 ResourceLoader::willCacheResponse() needs to null-check m_frame->settings() We've seen crash reports at Apple (<rdar://problem/7249553>) where this method is called on a ResourceLoader, that belongs to a Frame, that no longer has a Page. Nominally, we think that any Frame without a Page shouldn't have loads occuring, but there is at least one code path where that is not the case, and it's proving elusive to figure out that code path by code inspection. Plenty of sites in the code null check frame->settings(), and we need to do so here to prevent this crash. 239159 1 58947 beidson 2010-06-16 17:19:47 -0700 Created attachment 58947 Patch v1 (null check and ASSERT) 239161 2 beidson 2010-06-16 17:28:17 -0700 http://trac.webkit.org/changeset/61296 58947 2010-06-16 17:19:47 -0700 2010-06-16 17:25:08 -0700 Patch v1 (null check and ASSERT) patch.txt text/plain 1981 beidson SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTI5NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTYgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83MjQ5NTUzPiBhbmQgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwNzQ5CisgICAgICAgIFJlc291cmNlTG9hZGVyOjp3aWxsQ2FjaGVSZXNwb25z ZSgpIG5lZWRzIHRvIG51bGwtY2hlY2sgRnJhbWU6OlNldHRpbmdzKCkKKworICAgICAgICBObyBu ZXcgdGVzdHMuIChEaXNjb3ZlcmVkIHZpYSBjcmFzaCByZXBvcnRzLCBubyByZXByb2R1Y2libGUg Y2FzZXMgbm90ZWQpCisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI6OndpbGxDYWNoZVJlc3BvbnNlKTogIE51bGwg Y2hlY2sgbV9mcmFtZS0+c2V0dGluZ3MoKSwgCisgICAgICAgICAgYnV0IGFsc28gYWRkIGFuIEFT U0VSVCBzbyBkZWJ1Zy1idWlsZCBkZXZlbG9wZXJzIGNhbiBsZWFybiBtb3JlIGFib3V0IHdoeQor ICAgICAgICAgIHRoaXMgbWlnaHQgYmUgaGFwcGVuaW5nLgorCiAyMDEwLTA2LTE2ICBEYXJpbiBB ZGxlciAgPGRhcmluQGFwcGxlLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IHRoZSBNYXRoTUwg YnVpbGQuCkluZGV4OiBXZWJDb3JlL2xvYWRlci9SZXNvdXJjZUxvYWRlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViQ29yZS9sb2FkZXIvUmVzb3VyY2VMb2FkZXIuY3BwCShyZXZpc2lvbiA2MTI2NSkK KysrIFdlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt NDk5LDggKzQ5OSwxNSBAQCB2b2lkIFJlc291cmNlTG9hZGVyOjpyZWNlaXZlZENhbmNlbGxhdGlv CiAKIHZvaWQgUmVzb3VyY2VMb2FkZXI6OndpbGxDYWNoZVJlc3BvbnNlKFJlc291cmNlSGFuZGxl KiwgQ2FjaGVTdG9yYWdlUG9saWN5JiBwb2xpY3kpCiB7CisgICAgLy8gPHJkYXI6Ly9wcm9ibGVt LzcyNDk1NTM+IC0gVGhlcmUgYXJlIHJlcG9ydHMgb2YgY3Jhc2hlcyB3aXRoIHRoaXMgbWV0aG9k IGJlaW5nIGNhbGxlZAorICAgIC8vIHdpdGggYSBudWxsIG1fZnJhbWUtPnNldHRpbmdzKCksIHdo aWNoIGNhbiBvbmx5IGhhcHBlbiBpZiB0aGUgZnJhbWUgZG9lc24ndCBoYXZlIGEgcGFnZS4KKyAg ICAvLyBTYWRseSB3ZSBoYXZlIG5vIHJlcHJvZHVjaWJsZSBjYXNlcyBvZiB0aGlzLgorICAgIC8v IFdlIHRoaW5rIHRoYXQgYW55IGZyYW1lIHdpdGhvdXQgYSBwYWdlIHNob3VsZG4ndCBoYXZlIGFu eSBsb2FkcyBoYXBwZW5pbmcgaW4gaXQsIHlldAorICAgIC8vIHRoZXJlIGlzIGF0IGxlYXN0IG9u ZSBjb2RlIHBhdGggd2hlcmUgdGhhdCBpcyBub3QgdHJ1ZS4KKyAgICBBU1NFUlQobV9mcmFtZS0+ c2V0dGluZ3MoKSk7CisgICAgCiAgICAgLy8gV2hlbiBpbiBwcml2YXRlIGJyb3dzaW5nIG1vZGUs IHByZXZlbnQgY2FjaGluZyB0byBkaXNrCi0gICAgaWYgKHBvbGljeSA9PSBTdG9yYWdlQWxsb3dl ZCAmJiBtX2ZyYW1lLT5zZXR0aW5ncygpLT5wcml2YXRlQnJvd3NpbmdFbmFibGVkKCkpCisgICAg aWYgKHBvbGljeSA9PSBTdG9yYWdlQWxsb3dlZCAmJiBtX2ZyYW1lLT5zZXR0aW5ncygpICYmIG1f ZnJhbWUtPnNldHRpbmdzKCktPnByaXZhdGVCcm93c2luZ0VuYWJsZWQoKSkKICAgICAgICAgcG9s aWN5ID0gU3RvcmFnZUFsbG93ZWRJbk1lbW9yeU9ubHk7ICAgIAogfQogCg==