40742 2010-06-16 15:34:40 -0700 WebCore crashes when removing a link element in a beforeload handler 2010-09-30 12:23:02 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED HasReduction, InRadar P1 Major --- 43813 1 aestes aestes aestes ap dglazkov eric oldest_to_newest 239117 0 58941 aestes 2010-06-16 15:34:40 -0700 Created attachment 58941 test case If a page has a beforeload handler that removes a stylesheet <link> element, WebCore will crash with the following backtrace: Crash is in WebCore::Node::createRendererIfNeeded: 0 com.apple.WebCore 0x00007fff8808d6bd WebCore::Node::createRendererIfNeeded() + 45 1 com.apple.WebCore 0x00007fff8808d5a0 WebCore::Element::attach() + 32 2 com.apple.WebCore 0x00007fff8808cbb1 WebCore::HTMLParser::insertNode(WebCore::Node*, bool) + 369 3 com.apple.WebCore 0x00007fff88110fd4 WebCore::HTMLParser::parseToken(WebCore::Token*) + 868 4 com.apple.WebCore 0x00007fff8808c621 WebCore::HTMLTokenizer::processToken() + 657 5 com.apple.WebCore 0x00007fff8810d786 WebCore::HTMLTokenizer::parseTag(WebCore::SegmentedString&, WebCore::HTMLTokenizer::State) + 4950 6 com.apple.WebCore 0x00007fff8810bc60 WebCore::HTMLTokenizer::write(WebCore::SegmentedString const&, bool) + 2720 7 com.apple.WebCore 0x00007fff8826607e WebCore::HTMLTokenizer::executeExternalScriptsIfReady() + 1694 8 com.apple.WebCore 0x00007fff882147fc WebCore::CachedScript::checkNotify() + 76 9 com.apple.WebCore 0x00007fff881e9226 WebCore::Loader::Host::didFinishLoading(WebCore::SubresourceLoader*) + 358 10 com.apple.WebCore 0x00007fff881e9021 WebCore::SubresourceLoader::didFinishLoading() + 49 The attached .html file demonstrates the crash. 239118 1 aestes 2010-06-16 15:34:56 -0700 <rdar://problem/8091385> 239789 2 59074 aestes 2010-06-18 00:30:21 -0700 Created attachment 59074 Patch 239795 3 59074 mitz 2010-06-18 00:45:57 -0700 Comment on attachment 59074 Patch > + Postpone loading of link elements until after they have been inserted into the DOM and > + attached. This prevents mutation events triggered by beforeload handlers from firing in the > + midst of DOM insertion, which can lead to assertion failures and crashes. Is the problem here really the mutation events, or merely the fact that the beforeload handler mutates the DOM during insertion of the link element? > +void HTMLLinkElement::processCallback(Node* n) > +{ > + static_cast<HTMLLinkElement*>(n)->process(); > +} I would assert (or ASSERT_ARG) that n is a link element before casting it. > + <link rel="stylesheet" href=""> href="" means that the base URL (the .html file in this case) will be loaded as the stylesheet in this case. Not a big deal, but perhaps href="data:text/css," is cleaner (if it doesn’t invalidate the test). 239796 4 aestes 2010-06-18 00:49:11 -0700 (In reply to comment #3) > (From update of attachment 59074 [details]) > > + Postpone loading of link elements until after they have been inserted into the DOM and > > + attached. This prevents mutation events triggered by beforeload handlers from firing in the > > + midst of DOM insertion, which can lead to assertion failures and crashes. > > Is the problem here really the mutation events, or merely the fact that the beforeload handler mutates the DOM during insertion of the link element? You're right, "mutation event" is the wrong term to use. I'll reword that before landing. > > > +void HTMLLinkElement::processCallback(Node* n) > > +{ > > + static_cast<HTMLLinkElement*>(n)->process(); > > +} > > I would assert (or ASSERT_ARG) that n is a link element before casting it. Will do. > > > + <link rel="stylesheet" href=""> > > href="" means that the base URL (the .html file in this case) will be loaded as the stylesheet in this case. Not a big deal, but perhaps href="data:text/css," is cleaner (if it doesn’t invalidate the test). Ahh, I didn't realize that. I'll change that and re-test before landing. Thanks for the review! 239907 5 59074 darin 2010-06-18 07:33:19 -0700 Comment on attachment 59074 Patch WebCore/html/HTMLLinkElement.cpp:234 + void HTMLLinkElement::processCallback(Node* n) We typically use words for variable and argument names, not letters. So "node" would be preferred over "n". 240069 6 aestes 2010-06-18 12:03:55 -0700 http://trac.webkit.org/changeset/61424 240129 7 eric 2010-06-18 14:08:47 -0700 Test appears to fail on Tiger. 240137 8 aestes 2010-06-18 14:22:50 -0700 (In reply to comment #7) > Test appears to fail on Tiger. The only test I see failing on Tiger is platform/mac/accessibility/inherited-presentational-lists.html. 287732 9 eric 2010-09-30 12:23:02 -0700 @ap: this seems like another symptom of StyleSheet's bad node-ownership design. If you fix that, we may be able to remove this code. 58941 2010-06-16 15:34:40 -0700 2010-06-16 15:34:40 -0700 test case beforeload_crash.html text/html 248 aestes PGh0bWw+DQo8aGVhZD4NCiAgICA8c2NyaXB0Pg0KICAgICAgICBkb2N1bWVudC5hZGRFdmVudExp c3RlbmVyKCJiZWZvcmVsb2FkIiwgZnVuY3Rpb24oZXZlbnQpIHsNCiAgICAgICAgICAgIGV2ZW50 LnRhcmdldC5wYXJlbnRFbGVtZW50LnJlbW92ZUNoaWxkKGV2ZW50LnRhcmdldCk7DQogICAgICAg IH0sIHRydWUpOw0KICAgIDwvc2NyaXB0Pg0KCTxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0i Ij4NCjwvaGVhZD4NCjwvaHRtbD4= 59074 2010-06-18 00:30:21 -0700 2010-06-18 07:33:19 -0700 Patch 40742.patch text/plain 7785 aestes SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTM4MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzEgQEAKKzIwMTAtMDYtMTcgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS84MDkxMzg1PiBQcmV2ZW50IGEgY3Jhc2ggaW4gV2ViQ29yZSB3aGVuIHJlbW92 aW5nIGEgc3R5bGVzaGVldCBsaW5rIGVsZW1lbnQgaW4KKyAgICAgICAgaW4gYSBsaXN0ZW5lciB0 byBpdHMgYmVmb3JlbG9hZCBldmVudC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwNzQyCisgICAgICAgIAorICAgICAgICBQb3N0cG9uZSBsb2FkaW5n IG9mIGxpbmsgZWxlbWVudHMgdW50aWwgYWZ0ZXIgdGhleSBoYXZlIGJlZW4gaW5zZXJ0ZWQgaW50 byB0aGUgRE9NIGFuZAorICAgICAgICBhdHRhY2hlZC4gVGhpcyBwcmV2ZW50cyBtdXRhdGlvbiBl dmVudHMgdHJpZ2dlcmVkIGJ5IGJlZm9yZWxvYWQgaGFuZGxlcnMgZnJvbSBmaXJpbmcgaW4gdGhl CisgICAgICAgIG1pZHN0IG9mIERPTSBpbnNlcnRpb24sIHdoaWNoIGNhbiBsZWFkIHRvIGFzc2Vy dGlvbiBmYWlsdXJlcyBhbmQgY3Jhc2hlcy4KKworICAgICAgICBUZXN0OiBmYXN0L2RvbS9iZWZv cmVsb2FkL3JlbW92ZS1saW5rLWluLWJlZm9yZWxvYWQtbGlzdGVuZXIuaHRtbAorCisgICAgICAg ICogaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTExpbmtF bGVtZW50OjpIVE1MTGlua0VsZW1lbnQpOiBJbml0aWFsaXplIG1fc2hvdWxkUHJvY2Vzc0FmdGVy QXR0YWNoIHRvIGZhbHNlLgorICAgICAgICAoV2ViQ29yZTo6SFRNTExpbmtFbGVtZW50Ojpwcm9j ZXNzQ2FsbGJhY2spOiBBZGQgYSBzdGF0aWMgY2FsbGJhY2sgZnVuY3Rpb24gd2hpY2ggY2FsbHMK KyAgICAgICAgSFRNTExpbmtFbGVtZW50Ojpwcm9jZXNzKCkuCisgICAgICAgIChXZWJDb3JlOjpI VE1MTGlua0VsZW1lbnQ6Omluc2VydGVkSW50b0RvY3VtZW50KTogSW5zdGVhZCBvZiBjYWxsaW5n IHByb2Nlc3MoKSBkaXJlY3RseSwgc2V0CisgICAgICAgIG1fc2hvdWxkUHJvY2Vzc0FmdGVyQXR0 YWNoIHRvIHRydWUgdG8gaW5kaWNhdGUgdGhhdCBwcm9jZXNzKCkgc2hvdWxkIGJlIGNhbGxlZCBh ZnRlciBhdHRhY2goKS4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6cmVtb3Zl ZEZyb21Eb2N1bWVudCk6IFNldCBtX3Nob3VsZFByb2Nlc3NBZnRlckF0dGFjaCB0byBmYWxzZS4K KyAgICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6YXR0YWNoKTogSWYgbV9zaG91bGRQ cm9jZXNzQWZ0ZXJBdHRhY2ggaXMgdHJ1ZSwgcmVnaXN0ZXIKKyAgICAgICAgSFRNTExpbmtFbGVt ZW50Ojpwcm9jZXNzQ2FsbGJhY2soKSBhcyBhIHBvc3QtYXR0YWNoIGNhbGxiYWNrLgorICAgICAg ICAqIGh0bWwvSFRNTExpbmtFbGVtZW50Lmg6IEFkZCBtX3Nob3VsZFByb2Nlc3NBZnRlckF0dGFj aC4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUxMaW5rRWxlbWVudDo6Y2FuTGF6eUF0dGFjaCk6IE92 ZXJyaWRlIGNhbkxhenlBdHRhY2goKSB0byByZXR1cm4gZmFsc2UgdG8KKyAgICAgICAgaW5kaWNh dGUgdGhhdCBhIGZ1bGwgYXR0YWNoIHNob3VsZCBiZSBwZXJmb3JtZWQuICBUaGlzIGVuc3VyZXMg dGhlIHBvc3QtYXR0YWNoIGNhbGxiYWNrcyBhcmUKKyAgICAgICAgZmlyZWQuCisKIDIwMTAtMDYt MTcgIFJvYiBCdWlzICA8cndsYnVpc0BnbWFpbC5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGF2ZSBIeWF0dC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCShyZXZpc2lvbiA2MTM4 MykKKysrIFdlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC01MSw2ICs1MSw3IEBAIGlubGluZSBIVE1MTGlua0VsZW1lbnQ6OkhUTUxMaW5rRWxlbWVudCgK ICAgICAsIG1fZGlzYWJsZWRTdGF0ZShVbnNldCkKICAgICAsIG1fbG9hZGluZyhmYWxzZSkKICAg ICAsIG1fY3JlYXRlZEJ5UGFyc2VyKGNyZWF0ZWRCeVBhcnNlcikKKyAgICAsIG1fc2hvdWxkUHJv Y2Vzc0FmdGVyQXR0YWNoKGZhbHNlKQogewogICAgIEFTU0VSVChoYXNUYWdOYW1lKGxpbmtUYWcp KTsKIH0KQEAgLTIyOSwxMiArMjMwLDIyIEBAIHZvaWQgSFRNTExpbmtFbGVtZW50Ojpwcm9jZXNz KCkKICAgICAgICAgZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVTZWxlY3RvcigpOwogICAgIH0KIH0K KyAgICAKK3ZvaWQgSFRNTExpbmtFbGVtZW50Ojpwcm9jZXNzQ2FsbGJhY2soTm9kZSogbikKK3sK KyAgICBzdGF0aWNfY2FzdDxIVE1MTGlua0VsZW1lbnQqPihuKS0+cHJvY2VzcygpOworfQogCiB2 b2lkIEhUTUxMaW5rRWxlbWVudDo6aW5zZXJ0ZWRJbnRvRG9jdW1lbnQoKQogewogICAgIEhUTUxF bGVtZW50OjppbnNlcnRlZEludG9Eb2N1bWVudCgpOwogICAgIGRvY3VtZW50KCktPmFkZFN0eWxl U2hlZXRDYW5kaWRhdGVOb2RlKHRoaXMsIG1fY3JlYXRlZEJ5UGFyc2VyKTsKLSAgICBwcm9jZXNz KCk7CisKKyAgICAvLyBTaW5jZSBwcm9jZXNzaW5nIGEgc3R5bGVzaGVldCBsaW5rIGNhdXNlcyBh IGJlZm9yZWxvYWQgZXZlbnQKKyAgICAvLyB0byBmaXJlLCBpdCBpcyBwb3NzaWJsZSBmb3IgSmF2 YVNjcmlwdCB0byByZW1vdmUgdGhlIGVsZW1lbnQgaW4gdGhlIG1pZHN0CisgICAgLy8gb2YgaXQg YmVpbmcgaW5zZXJ0ZWQgaW50byB0aGUgRE9NLCB3aGljaCBjYW4gbGVhZCB0byBhc3NlcnRpb24g ZXJyb3JzIG9yCisgICAgLy8gY3Jhc2hlcy4gQXZvaWQgdGhpcyBieSBwb3N0cG9uaW5nIHRoZSBi ZWZvcmVsb2FkL2xvYWQgdW50aWwgYWZ0ZXIgYXR0YWNoLgorICAgIG1fc2hvdWxkUHJvY2Vzc0Fm dGVyQXR0YWNoID0gdHJ1ZTsKIH0KIAogdm9pZCBIVE1MTGlua0VsZW1lbnQ6OnJlbW92ZWRGcm9t RG9jdW1lbnQoKQpAQCAtMjQ2LDggKzI1NywyMCBAQCB2b2lkIEhUTUxMaW5rRWxlbWVudDo6cmVt b3ZlZEZyb21Eb2N1bWVuCiAgICAgLy8gRklYTUU6IEl0J3MgdGVycmlibGUgdG8gZG8gYSBzeW5j aHJvbm91cyB1cGRhdGUgb2YgdGhlIHN0eWxlIHNlbGVjdG9yIGp1c3QgYmVjYXVzZSBhIDxzdHls ZT4gb3IgPGxpbms+IGVsZW1lbnQgZ290IHJlbW92ZWQuCiAgICAgaWYgKGRvY3VtZW50KCktPnJl bmRlcmVyKCkpCiAgICAgICAgIGRvY3VtZW50KCktPnVwZGF0ZVN0eWxlU2VsZWN0b3IoKTsKKyAg ICAKKyAgICBtX3Nob3VsZFByb2Nlc3NBZnRlckF0dGFjaCA9IGZhbHNlOwogfQogCit2b2lkIEhU TUxMaW5rRWxlbWVudDo6YXR0YWNoKCkKK3sKKyAgICBpZiAobV9zaG91bGRQcm9jZXNzQWZ0ZXJB dHRhY2gpIHsKKyAgICAgICAgbV9zaG91bGRQcm9jZXNzQWZ0ZXJBdHRhY2ggPSBmYWxzZTsKKyAg ICAgICAgcXVldWVQb3N0QXR0YWNoQ2FsbGJhY2soJkhUTUxMaW5rRWxlbWVudDo6cHJvY2Vzc0Nh bGxiYWNrLCB0aGlzKTsKKyAgICB9CisKKyAgICBIVE1MRWxlbWVudDo6YXR0YWNoKCk7Cit9Cisg ICAgCiB2b2lkIEhUTUxMaW5rRWxlbWVudDo6ZmluaXNoUGFyc2luZ0NoaWxkcmVuKCkKIHsKICAg ICBtX2NyZWF0ZWRCeVBhcnNlciA9IGZhbHNlOwpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxMaW5r RWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MTGlua0VsZW1lbnQuaAko cmV2aXNpb24gNjEzODMpCisrKyBXZWJDb3JlL2h0bWwvSFRNTExpbmtFbGVtZW50LmgJKHdvcmtp bmcgY29weSkKQEAgLTgxLDYgKzgxLDkgQEAgcHVibGljOgogICAgIGJvb2wgaXNEaXNhYmxlZCgp IGNvbnN0IHsgcmV0dXJuIG1fZGlzYWJsZWRTdGF0ZSA9PSBEaXNhYmxlZDsgfQogICAgIGJvb2wg aXNFbmFibGVkVmlhU2NyaXB0KCkgY29uc3QgeyByZXR1cm4gbV9kaXNhYmxlZFN0YXRlID09IEVu YWJsZWRWaWFTY3JpcHQ7IH0KICAgICBib29sIGlzSWNvbigpIGNvbnN0IHsgcmV0dXJuIG1fcmVs QXR0cmlidXRlLm1faXNJY29uOyB9CisgICAgCisgICAgdmlydHVhbCB2b2lkIGF0dGFjaCgpOwor ICAgIHZpcnR1YWwgYm9vbCBjYW5MYXp5QXR0YWNoKCkgeyByZXR1cm4gZmFsc2U7IH0KIAogcHJp dmF0ZToKICAgICB2aXJ0dWFsIEhUTUxUYWdTdGF0dXMgZW5kVGFnUmVxdWlyZW1lbnQoKSBjb25z dCB7IHJldHVybiBUYWdTdGF0dXNGb3JiaWRkZW47IH0KQEAgLTg5LDYgKzkyLDcgQEAgcHJpdmF0 ZToKICAgICB2aXJ0dWFsIHZvaWQgcGFyc2VNYXBwZWRBdHRyaWJ1dGUoQXR0cmlidXRlKik7CiAK ICAgICB2b2lkIHByb2Nlc3MoKTsKKyAgICBzdGF0aWMgdm9pZCBwcm9jZXNzQ2FsbGJhY2soTm9k ZSopOwogCiAgICAgdmlydHVhbCB2b2lkIGluc2VydGVkSW50b0RvY3VtZW50KCk7CiAgICAgdmly dHVhbCB2b2lkIHJlbW92ZWRGcm9tRG9jdW1lbnQoKTsKQEAgLTEwMiw3ICsxMDYsNyBAQCBwcml2 YXRlOgogICAgIHZvaWQgc2V0RGlzYWJsZWRTdGF0ZShib29sIF9kaXNhYmxlZCk7CiAKICAgICB2 aXJ0dWFsIGJvb2wgaXNVUkxBdHRyaWJ1dGUoQXR0cmlidXRlKikgY29uc3Q7Ci0gICAgCisKIHB1 YmxpYzoKICAgICBzdGF0aWMgdm9pZCB0b2tlbml6ZVJlbEF0dHJpYnV0ZShjb25zdCBBdG9taWNT dHJpbmcmIHZhbHVlLCBSZWxBdHRyaWJ1dGUmKTsKIApAQCAtMTI5LDYgKzEzMyw3IEBAIHByaXZh dGU6CiAgICAgUmVsQXR0cmlidXRlIG1fcmVsQXR0cmlidXRlOwogICAgIGJvb2wgbV9sb2FkaW5n OwogICAgIGJvb2wgbV9jcmVhdGVkQnlQYXJzZXI7CisgICAgYm9vbCBtX3Nob3VsZFByb2Nlc3NB ZnRlckF0dGFjaDsKIH07CiAKIH0gLy9uYW1lc3BhY2UKSW5kZXg6IExheW91dFRlc3RzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMzgz KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTAtMDYtMTcgIEFuZHkgRXN0ZXMgIDxhZXN0ZXNAYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84 MDkxMzg1PiBUZXN0IHRoYXQgcmVtb3ZpbmcgYSBzdHlsZXNoZWV0IGxpbmsgZWxlbWVudCBpbiBh IGxpc3RlbmVyIHRvIGl0cworICAgICAgICBiZWZvcmVsb2FkIGV2ZW50IGRvZXMgbm90IGNyYXNo IFdlYkNvcmUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MDc0MgorCisgICAgICAgICogZmFzdC9kb20vYmVmb3JlbG9hZC9yZW1vdmUtbGluay1pbi1i ZWZvcmVsb2FkLWxpc3RlbmVyLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9k b20vYmVmb3JlbG9hZC9yZW1vdmUtbGluay1pbi1iZWZvcmVsb2FkLWxpc3RlbmVyLmh0bWw6IEFk ZGVkLgorCiAyMDEwLTA2LTE3ICBSb2IgQnVpcyAgPHJ3bGJ1aXNAZ21haWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9i ZWZvcmVsb2FkL3JlbW92ZS1saW5rLWluLWJlZm9yZWxvYWQtbGlzdGVuZXItZXhwZWN0ZWQudHh0 Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL2JlZm9yZWxvYWQvcmVtb3ZlLWxp bmstaW4tYmVmb3JlbG9hZC1saXN0ZW5lci1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCisrKyBM YXlvdXRUZXN0cy9mYXN0L2RvbS9iZWZvcmVsb2FkL3JlbW92ZS1saW5rLWluLWJlZm9yZWxvYWQt bGlzdGVuZXItZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMgQEAKK1RoaXMg cGFnZSB0ZXN0cyB0aGF0IHlvdSBjYW4gY29ycmVjdGx5IHJlbW92ZSBhIHN0eWxlc2hlZXQgbGlu ayBlbGVtZW50IGluIGl0cyBiZWZvcmVsb2FkIGxpc3RlbmVyIHdpdGhvdXQgY2F1c2luZyBhIGNy YXNoLgorCitQQVNTCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9iZWZvcmVsb2FkL3JlbW92 ZS1saW5rLWluLWJlZm9yZWxvYWQtbGlzdGVuZXIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9mYXN0L2RvbS9iZWZvcmVsb2FkL3JlbW92ZS1saW5rLWluLWJlZm9yZWxvYWQtbGlzdGVu ZXIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2JlZm9yZWxvYWQv cmVtb3ZlLWxpbmstaW4tYmVmb3JlbG9hZC1saXN0ZW5lci5odG1sCShyZXZpc2lvbiAwKQpAQCAt MCwwICsxLDM0IEBACis8aHRtbD4KKzxoZWFkPgorICAgIDxzY3JpcHQ+CisgICAgICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5kdW1wQXNUZXh0KCk7CisKKyAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigi YmVmb3JlbG9hZCIsIGZ1bmN0aW9uKGV2ZW50KSB7CisgICAgICAgICAgICBldmVudC50YXJnZXQu cGFyZW50RWxlbWVudC5yZW1vdmVDaGlsZChldmVudC50YXJnZXQpOworICAgICAgICB9LCB0cnVl KTsKKyAgICA8L3NjcmlwdD4KKwk8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9IiI+Cis8L2hl YWQ+Cis8Ym9keT4KKyAgICA8cD5UaGlzIHBhZ2UgdGVzdHMgdGhhdCB5b3UgY2FuIGNvcnJlY3Rs eSByZW1vdmUgYSBzdHlsZXNoZWV0IGxpbmsgZWxlbWVudCBpbiBpdHMgYmVmb3JlbG9hZCBsaXN0 ZW5lciB3aXRob3V0IGNhdXNpbmcgYSBjcmFzaC48L3A+CisgICAgPGRpdiBpZD0iY29uc29sZSI+ PC9kaXY+CisgICAgPHNjcmlwdD4KKyAgICAgICAgZnVuY3Rpb24gcHJpbnQobWVzc2FnZSwgY29s b3IpIAorICAgICAgICB7CisgICAgICAgICAgICB2YXIgcGFyYWdyYXBoID0gZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgiZGl2Iik7CisgICAgICAgICAgICBwYXJhZ3JhcGguYXBwZW5kQ2hpbGQoZG9j dW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSkpOworICAgICAgICAgICAgcGFyYWdyYXBoLnN0 eWxlLmZvbnRGYW1pbHkgPSAibW9ub3NwYWNlIjsKKyAgICAgICAgICAgIGlmIChjb2xvcikKKyAg ICAgICAgICAgICAgICBwYXJhZ3JhcGguc3R5bGUuY29sb3IgPSBjb2xvcjsKKyAgICAgICAgICAg IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJjb25zb2xlIikuYXBwZW5kQ2hpbGQocGFyYWdyYXBo KTsKKyAgICAgICAgfQorICAgICAgICAKKyAgICAgICAgaWYgKGRvY3VtZW50LmdldEVsZW1lbnRz QnlUYWdOYW1lKCJsaW5rIikubGVuZ3RoKQorICAgICAgICAgICAgcHJpbnQoIkZBSUwiLCAicmVk Iik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIHByaW50KCJQQVNTIiwgImdyZWVuIik7Cisg ICAgPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CisK