40725 2010-06-16 11:28:08 -0700 fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer 2010-08-11 19:38:18 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth ap commit-queue oldest_to_newest 238984 0 eric 2010-06-16 11:28:08 -0700 fast/encoding/japanese-encoding-mix.html fails on Tiger after enabling HTML5 Lexer It looks like Tiger's decoders are not properly passing the --> off to the HTML Lexer so it never sees an end to the comment. --- /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/layout-test-results/fast/encoding/japanese-encoding-mix-expected.txt 2010-06-16 09:19:19.000000000 -0700 +++ /Volumes/Data/WebKit-BuildSlave/tiger-intel-release/build/layout-test-results/fast/encoding/japanese-encoding-mix-actual.txt 2010-06-16 09:19:19.000000000 -0700 @@ -1,5 +1,12 @@ -Some text here is encoded as EUC-JP, and some (in comment) as Shift_JIS. Since there is an explicit encoding declaration, auto-detection shouldn't change the encoding. - -ニッポンテレビ - -Should be EUC-JP: EUC-JP +layer at (0,0) size 800x600 + RenderView at (0,0) size 800x600 +layer at (0,0) size 800x600 + RenderBlock {HTML} at (0,0) size 800x600 + RenderBody {BODY} at (8,8) size 784x576 + RenderBlock {P} at (0,0) size 784x36 + RenderText {#text} at (0,0) size 774x36 + text run at (0,0) width 774: "Some text here is encoded as EUC-JP, and some (in comment) as Shift_JIS. Since there is an explicit encoding declaration," + text run at (0,18) width 288: "auto-detection shouldn't change the encoding." + RenderBlock {P} at (0,52) size 784x21 + RenderText {#text} at (0,3) size 112x18 + text run at (0,3) width 112: "\x{30CB}\x{30C3}\x{30DD}\x{30F3}\x{30C6}\x{30EC}\x{30D3}" 238985 1 eric 2010-06-16 11:28:35 -0700 Bug 40661 is the same failure except for Qt (which also has different decoders). 238990 2 eric 2010-06-16 11:33:13 -0700 Skipping the test for now. This bug should remain open to track the failure (at least for as long as Tiger is still a real platform... which can't be that much longer now). 238991 3 eric 2010-06-16 11:33:19 -0700 Committed r61266: <http://trac.webkit.org/changeset/61266> 239132 4 ap 2010-06-16 16:02:39 -0700 The fix would be to just add a space before --> to insulate the test from EUC-JP decoder differences. 239134 5 eric 2010-06-16 16:04:15 -0700 That's fine too. Do we care about testing the encoder differences? 239140 6 ap 2010-06-16 16:23:23 -0700 I don't think we should try to test edge cases of complex decoders like this, unless we suspect that particular bugs may have security implications. 239183 7 58952 abarth 2010-06-16 19:15:26 -0700 Created attachment 58952 Patch 239185 8 58952 ap 2010-06-16 19:26:50 -0700 Comment on attachment 58952 Patch + Qt and Tiger seem to have encoding problems that swallow the -- I think it's only one character after an invalid sequence that gets swallowed. r=me 263327 9 58952 abarth 2010-08-11 10:19:19 -0700 Comment on attachment 58952 Patch Wow. I don't think this was ever landed. :( 263341 10 58952 commit-queue 2010-08-11 10:55:56 -0700 Comment on attachment 58952 Patch Rejecting patch 58952 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Alexey Proskuryakov', u'--force']" exit_code: 1 Parsed 4 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/fast/encoding/japanese-encoding-mix.html patching file LayoutTests/platform/mac-tiger/Skipped Hunk #1 FAILED at 194. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac-tiger/Skipped.rej patching file LayoutTests/platform/qt/Skipped Hunk #1 FAILED at 5417. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt/Skipped.rej Full output: http://queues.webkit.org/results/3734061 263345 11 64136 abarth 2010-08-11 11:09:45 -0700 Created attachment 64136 Patch for landing 263572 12 64136 commit-queue 2010-08-11 19:38:13 -0700 Comment on attachment 64136 Patch for landing Clearing flags on attachment: 64136 Committed r65211: <http://trac.webkit.org/changeset/65211> 263573 13 commit-queue 2010-08-11 19:38:18 -0700 All reviewed patches have been landed. Closing bug. 58952 2010-06-16 19:15:26 -0700 2010-08-11 11:09:34 -0700 Patch bug-40725-20100616191525.patch text/plain 3036 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYxMjk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDYtMTYgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBmYXN0L2VuY29kaW5nL2phcGFuZXNlLWVuY29kaW5nLW1peC5odG1sIGZhaWxzIG9u IFRpZ2VyIGFmdGVyIGVuYWJsaW5nIEhUTUw1IExleGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDcyNQorCisgICAgICAgIFF0IGFuZCBUaWdlciBz ZWVtIHRvIGhhdmUgZW5jb2RpbmcgcHJvYmxlbXMgdGhhdCBzd2FsbG93IHRoZSAtLQorICAgICAg ICBjaGFyYWN0ZXJzIHRoYXQgdGVybWluYXRlIHRoZSBjb21tZW50LiAgV2UgY2FuIGF2b2lkIHRo b3NlIHByb2JsZW1zIGJ5CisgICAgICAgIGluc2VydGluZyBhIHNwYWNlIGJlZm9yZSB0aGUgLS0+ LiAgV2UncmUgbG9zaW5nIGNvdmVyYWdlIG9mIHRoZXNlCisgICAgICAgIGlzc3VlcywgYnV0IEkn bSBub3Qgc3VyZSB3ZSBzaG91bGQgYmUgaW4gdGhlIGJ1c2luZXNzIG9mIGRlYnVnZ2luZworICAg ICAgICB0aGVzZSBlbmNvZGVycyB1bmxlc3MgdGhlcmUncyBhIHNlY3VyaXR5IHByb2JsZW0uCisK KyAgICAgICAgVGhhbmtzIHRvIGFwIGZvciBpbnZlc3RpZ2F0aW5nIGFuZCBmaW5kaW5nIHRoaXMg d29ya2Fyb3VuZC4KKworICAgICAgICAqIGZhc3QvZW5jb2RpbmcvamFwYW5lc2UtZW5jb2Rpbmct bWl4Lmh0bWw6CisgICAgICAgICogcGxhdGZvcm0vbWFjLXRpZ2VyL1NraXBwZWQ6CisgICAgICAg ICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAxMC0wNi0xNiAgQW50b25pbyBHb21lcyAgPHRv bmlraXRvb0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvamFwYW5lc2UtZW5jb2RpbmctbWl4Lmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9qYXBhbmVzZS1lbmNv ZGluZy1taXguaHRtbAkocmV2aXNpb24gNjEyODYpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2VuY29k aW5nL2phcGFuZXNlLWVuY29kaW5nLW1peC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0yLDcgKzIs NyBAQAogPGh0bWwgZGlyPSJMVFIiIGxhbmc9ImphIj4KIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRl bnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUVVQy1KUCI+CiA8cD5Tb21lIHRl eHQgaGVyZSBpcyBlbmNvZGVkIGFzIEVVQy1KUCwgYW5kIHNvbWUgKGluIGNvbW1lbnQpIGFzIFNo aWZ0X0pJUy4gU2luY2UgdGhlcmUgaXMgYW4gZXhwbGljaXQgZW5jb2RpbmcgZGVjbGFyYXRpb24s IGF1dG8tZGV0ZWN0aW9uIHNob3VsZG4ndCBjaGFuZ2UgdGhlIGVuY29kaW5nLjwvcD48cD6ly6XD pd2l86XGpeyl0zwvcD4KLTwhLS2JRYNKg4mDgINSg4GDk4Nng0GDRYNnIIKxgrGCqYLnLS0+Cis8 IS0tiUWDSoOJg4CDUoOBg5ODZ4NBg0WDZyCCsYKxgqmC5yAtLT4KIDxzY3JpcHQ+CiBpZiAod2lu ZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBB c1RleHQoKTsKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkCShyZXZp c2lvbiA2MTI4NikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lwcGVkCSh3 b3JraW5nIGNvcHkpCkBAIC0xOTQsOCArMTk0LDMgQEAgZmFzdC9jc3MvY3VzdG9tLWZvbnQteGhl aWdodC5odG1sCiAKICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQw MDQ5CiBodHRwL3Rlc3RzL2luc3BlY3Rvci9yZXNvdXJjZS1wYXJhbWV0ZXJzLmh0bWwKLQotIyBU aWdlcidzIFRleHREZWNvZGVyIGRvZXNuJ3QgY29ycmVjdGx5IHBhc3MgLS0+IHRvIHRoZSBIVE1M IFBhcnNlcgotIyBhdCB0aGUgZW5kIG9mIGEgU2hpZnRfSklTIGNvbW1lbnQsIGNhdXNpbmcgdGhp cyB0ZXN0IHRvIGZhaWwuCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MDcyNQotZmFzdC9lbmNvZGluZy9qYXBhbmVzZS1lbmNvZGluZy1taXguaHRtbApJbmRleDog TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCShyZXZpc2lvbiA2MTI4NikKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL3F0L1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTU0MTcsOCArNTQxNywzIEBAIHN2 Zy9XM0MtU1ZHLTEuMS9maWx0ZXJzLWxpZ2h0LTA0LWYuc3ZnCiAjIG5ldyBza2lwcGVkIHRlc3Rz IHlldCB0byBiZSBzb3J0ZWQKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gIwogZmFzdC9kb20vR2Vv bG9jYXRpb24vY2FsbGJhY2stdG8tcmVtb3RlLWNvbnRleHQyLmh0bWwKLQotIyBGYWlsaW5nIGFm dGVyIGVuYWJsaW5nIEhUTUw1IHBhcnNlciBpbiByNjEyMzQKLSMgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNjYxCi1mYXN0L2VuY29kaW5nL2phcGFuZXNlLWVuY29k aW5nLW1peC5odG1sCi0K 64136 2010-08-11 11:09:45 -0700 2010-08-11 19:38:13 -0700 Patch for landing bug-40725-20100811110944.patch text/plain 3245 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY1MTY1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDgtMTEgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBBbGV4ZXkgUHJvc2t1cnlha292 LgorCisgICAgICAgIGZhc3QvZW5jb2RpbmcvamFwYW5lc2UtZW5jb2RpbmctbWl4Lmh0bWwgZmFp bHMgb24gVGlnZXIgYWZ0ZXIgZW5hYmxpbmcgSFRNTDUgTGV4ZXIKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNzI1CisKKyAgICAgICAgUXQgYW5kIFRp Z2VyIHNlZW0gdG8gaGF2ZSBlbmNvZGluZyBwcm9ibGVtcyB0aGF0IHN3YWxsb3cgdGhlIC0tCisg ICAgICAgIGNoYXJhY3RlcnMgdGhhdCB0ZXJtaW5hdGUgdGhlIGNvbW1lbnQuICBXZSBjYW4gYXZv aWQgdGhvc2UgcHJvYmxlbXMgYnkKKyAgICAgICAgaW5zZXJ0aW5nIGEgc3BhY2UgYmVmb3JlIHRo ZSAtLT4uICBXZSdyZSBsb3NpbmcgY292ZXJhZ2Ugb2YgdGhlc2UKKyAgICAgICAgaXNzdWVzLCBi dXQgSSdtIG5vdCBzdXJlIHdlIHNob3VsZCBiZSBpbiB0aGUgYnVzaW5lc3Mgb2YgZGVidWdnaW5n CisgICAgICAgIHRoZXNlIGVuY29kZXJzIHVubGVzcyB0aGVyZSdzIGEgc2VjdXJpdHkgcHJvYmxl bS4KKworICAgICAgICBUaGFua3MgdG8gYXAgZm9yIGludmVzdGlnYXRpbmcgYW5kIGZpbmRpbmcg dGhpcyB3b3JrYXJvdW5kLgorCisgICAgICAgICogZmFzdC9lbmNvZGluZy9qYXBhbmVzZS1lbmNv ZGluZy1taXguaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMtdGlnZXIvU2tpcHBlZDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTA4LTExICBOYXRlIENoYXBpbiAg PGphcGhldEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgQ2hyb21pdW0gcmVi YXNlbGluZS4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZW5jb2RpbmcvamFwYW5lc2UtZW5jb2Rp bmctbWl4Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9lbmNvZGluZy9qYXBh bmVzZS1lbmNvZGluZy1taXguaHRtbAkocmV2aXNpb24gNjUxNjUpCisrKyBMYXlvdXRUZXN0cy9m YXN0L2VuY29kaW5nL2phcGFuZXNlLWVuY29kaW5nLW1peC5odG1sCSh3b3JraW5nIGNvcHkpCkBA IC0yLDcgKzIsNyBAQAogPGh0bWwgZGlyPSJMVFIiIGxhbmc9ImphIj4KIDxtZXRhIGh0dHAtZXF1 aXY9IkNvbnRlbnQtVHlwZSIgY29udGVudD0idGV4dC9odG1sOyBjaGFyc2V0PUVVQy1KUCI+CiA8 cD5Tb21lIHRleHQgaGVyZSBpcyBlbmNvZGVkIGFzIEVVQy1KUCwgYW5kIHNvbWUgKGluIGNvbW1l bnQpIGFzIFNoaWZ0X0pJUy4gU2luY2UgdGhlcmUgaXMgYW4gZXhwbGljaXQgZW5jb2RpbmcgZGVj bGFyYXRpb24sIGF1dG8tZGV0ZWN0aW9uIHNob3VsZG4ndCBjaGFuZ2UgdGhlIGVuY29kaW5nLjwv cD48cD6ly6XDpd2l86XGpeyl0zwvcD4KLTwhLS2JRYNKg4mDgINSg4GDk4Nng0GDRYNnIIKxgrGC qYLnLS0+Cis8IS0tiUWDSoOJg4CDUoOBg5ODZ4NBg0WDZyCCsYKxgqmC5yAtLT4KIDxzY3JpcHQ+ CiBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKQogICAgIGxheW91dFRlc3RDb250cm9s bGVyLmR1bXBBc1RleHQoKTsKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9T a2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9Ta2lw cGVkCShyZXZpc2lvbiA2NTE2NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy10aWdlci9T a2lwcGVkCSh3b3JraW5nIGNvcHkpCkBAIC0xOTksMTEgKzE5OSw2IEBAIGZhc3QvY3NzL2N1c3Rv bS1mb250LXhoZWlnaHQuaHRtbAogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDAwNDkKIGh0dHAvdGVzdHMvaW5zcGVjdG9yL3Jlc291cmNlLXBhcmFtZXRlcnMuaHRt bAogCi0jIFRpZ2VyJ3MgVGV4dERlY29kZXIgZG9lc24ndCBjb3JyZWN0bHkgcGFzcyAtLT4gdG8g dGhlIEhUTUwgUGFyc2VyCi0jIGF0IHRoZSBlbmQgb2YgYSBTaGlmdF9KSVMgY29tbWVudCwgY2F1 c2luZyB0aGlzIHRlc3QgdG8gZmFpbC4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwNzI1Ci1mYXN0L2VuY29kaW5nL2phcGFuZXNlLWVuY29kaW5nLW1peC5odG1s Ci0KICMgTmV3IG1vZGFsIGRpYWxvZyB0ZXN0cyBmYWlsIG9uIFRpZ2VyLgogIyBUZXN0cyBpbnRy b2R1Y2VkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzYxNTk5LgogZmFzdC9l dmVudHMvc2hvdy1tb2RhbC1kaWFsb2ctb25ibHVyLW9uZm9jdXMuaHRtbApJbmRleDogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0 Zm9ybS9xdC9Ta2lwcGVkCShyZXZpc2lvbiA2NTE2NSkKKysrIExheW91dFRlc3RzL3BsYXRmb3Jt L3F0L1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTUzNzMsMTAgKzUzNzMsNiBAQCBmYXN0L2Rv bS9HZW9sb2NhdGlvbi9jYWxsYmFjay10by1yZW1vdGUtCiAjIExpbmsgcHJlZmV0Y2ggaXMgZGlz YWJsZWQgYnkgZGVmYXVsdAogZmFzdC9kb20vSFRNTExpbmtFbGVtZW50L3ByZWZldGNoLmh0bWwK IAotIyBGYWlsaW5nIGFmdGVyIGVuYWJsaW5nIEhUTUw1IHBhcnNlciBpbiByNjEyMzQKLSMgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNjYxCi1mYXN0L2VuY29kaW5n L2phcGFuZXNlLWVuY29kaW5nLW1peC5odG1sCi0KICMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM1MzUwCiBmYXN0L2V2ZW50cy9zaG93LW1vZGFsLWRpYWxvZy1vbmJs dXItb25mb2N1cy5odG1sCiBmYXN0L2hhcm5lc3Mvc2hvdy1tb2RhbC1kaWFsb2cuaHRtbAo=