40720 2010-06-16 10:43:40 -0700 CSSStyleSelector won't compile if WCSS is enabled 2010-06-19 05:32:18 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 gwright webkit-unassigned commit-queue oldest_to_newest 238955 0 gwright 2010-06-16 10:43:40 -0700 SVN commit 60418 made setWapInputFormat() private but CSSStyleSelector.cpp calls it here: HTMLFormControlElement* element = static_cast<HTMLFormControlElement*>(m_element); Resulting in the following compile error: "../../../../WebCore/css/CSSStyleSelector.cpp", line 5386: Error: #265-D: function "WebCore::HTMLInputElement::setWapInputFormat" (declared at line 337 of "../../../../WebCore/html/HTMLInputElement.h") is inaccessible static_cast<HTMLInputElement*>(m_element)->setWapInputFormat(mask); ^ 239003 1 58915 gwright 2010-06-16 11:54:04 -0700 Created attachment 58915 Make setWapInputFormat() public again. 239008 2 gwright 2010-06-16 12:01:31 -0700 (In reply to comment #0) > SVN commit 60418 made setWapInputFormat() private but CSSStyleSelector.cpp calls it here: > > HTMLFormControlElement* element = static_cast<HTMLFormControlElement*>(m_element); Oops, I meant this line: static_cast<HTMLInputElement*>(m_element)->setWapInputFormat(mask); 240321 3 58915 commit-queue 2010-06-19 05:32:14 -0700 Comment on attachment 58915 Make setWapInputFormat() public again. Clearing flags on attachment: 58915 Committed r61482: <http://trac.webkit.org/changeset/61482> 240322 4 commit-queue 2010-06-19 05:32:18 -0700 All reviewed patches have been landed. Closing bug. 58915 2010-06-16 11:54:04 -0700 2010-06-19 05:32:14 -0700 Make setWapInputFormat() public again. 40720.patch text/plain 1658 gwright Y29tbWl0IDk0NWY4MzAyMGRjYWE4ZTJiNmY4MDk4MzA0OTkwZmQ0NTI3OWRhNjQKQXV0aG9yOiBH ZW9yZ2UgV3JpZ2h0IDxnd3JpZ2h0QHJpbS5jb20+CkRhdGU6ICAgV2VkIEp1biAxNiAxNDo1MTow MSAyMDEwIC0wNDAwCgogICAgMjAxMC0wNi0xNiAgR2VvcmdlIFdyaWdodCAgPGd3cmlnaHRAcmlt LmNvbT4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KICAgIAog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA3MjAK ICAgIAogICAgICAgICAgICBNYWtlIHNldFdhcElucHV0Rm9ybWF0KCkgcHVibGljIGFnYWluIGFz IENTU1N0eWxlU2VsZWN0b3IuY3BwIGNhbGxzIHRoaXMgd2hlbiBXQ1NTIGlzIGVuYWJsZWQuCiAg ICAKICAgICAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVsZW1lbnQuaDoKICAgICAgICAgICAgKFdl YkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmRhdGEpOgoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hh bmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTVhODllMy4uYzNjMmYwZiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxNCBAQAorMjAxMC0wNi0xNiAgR2VvcmdlIFdyaWdodCAgPGd3cmlnaHRAcmltLmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA3MjAKKworICAgICAgICBNYWtlIHNldFdh cElucHV0Rm9ybWF0KCkgcHVibGljIGFnYWluIGFzIENTU1N0eWxlU2VsZWN0b3IuY3BwIGNhbGxz IHRoaXMgd2hlbiBXQ1NTIGlzIGVuYWJsZWQuCisKKyAgICAgICAgKiBodG1sL0hUTUxJbnB1dEVs ZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxJbnB1dEVsZW1lbnQ6OmRhdGEpOgorCiAy MDEwLTA2LTE2ICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTElu cHV0RWxlbWVudC5oIGIvV2ViQ29yZS9odG1sL0hUTUxJbnB1dEVsZW1lbnQuaAppbmRleCBhOWE3 YmIwLi5mZGYwNmRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRNTElucHV0RWxlbWVudC5o CisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MSW5wdXRFbGVtZW50LmgKQEAgLTIwNyw2ICsyMDcsMTAg QEAgcHVibGljOgogICAgIEhUTUxPcHRpb25FbGVtZW50KiBzZWxlY3RlZE9wdGlvbigpIGNvbnN0 OwogI2VuZGlmCiAKKyNpZiBFTkFCTEUoV0NTUykKKyAgICB2b2lkIHNldFdhcElucHV0Rm9ybWF0 KFN0cmluZyYgbWFzayk7CisjZW5kaWYKKwogcHJvdGVjdGVkOgogICAgIEhUTUxJbnB1dEVsZW1l bnQoY29uc3QgUXVhbGlmaWVkTmFtZSYsIERvY3VtZW50KiwgSFRNTEZvcm1FbGVtZW50KiA9IDAp OwogCkBAIC0zMzQsNyArMzM4LDYgQEAgcHJpdmF0ZToKICNlbmRpZgogCiAjaWYgRU5BQkxFKFdD U1MpCi0gICAgdm9pZCBzZXRXYXBJbnB1dEZvcm1hdChTdHJpbmcmIG1hc2spOwogICAgIHZpcnR1 YWwgSW5wdXRFbGVtZW50RGF0YSBkYXRhKCkgY29uc3QgeyByZXR1cm4gbV9kYXRhOyB9CiAjZW5k aWYKIAo=