40717 2010-06-16 10:26:30 -0700 [Qt] Bridge documentation: some snippets have the wrong indentation 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED Qt P2 Normal --- 1 noam webkit-unassigned commit-queue darin hausmann webkit.review.bot oldest_to_newest 238941 0 noam 2010-06-16 10:26:30 -0700 Mainly HTML code snippets 238945 1 58903 noam 2010-06-16 10:29:49 -0700 Created attachment 58903 Patch 238948 2 webkit.review.bot 2010-06-16 10:33:02 -0700 Attachment 58903 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:51: Should have a space between // and comment [whitespace/comments] [4] WebKit/qt/docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:53: Should have a space between // and comment [whitespace/comments] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 238952 3 noam 2010-06-16 10:35:18 -0700 Posted check-webkit-style false positives, see 40719 240317 4 58903 commit-queue 2010-06-19 04:58:35 -0700 Comment on attachment 58903 Patch Clearing flags on attachment: 58903 Committed r61480: <http://trac.webkit.org/changeset/61480> 240318 5 commit-queue 2010-06-19 04:58:40 -0700 All reviewed patches have been landed. Closing bug. 240345 6 hausmann 2010-06-19 08:47:03 -0700 Revision r61480 cherry-picked into qtwebkit-2.0 with commit 2094af9c87089572f6bc65196dcb40a9719db2cb 58903 2010-06-16 10:29:49 -0700 2010-06-19 04:58:35 -0700 Patch bug-40717-20100616102948.patch text/plain 3184 noam ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDkwNDkxYzY1MjQ4ZmZiZTk5NTdhOGIxYjNlZWIyOGNlZGVjYjMxNmQuLjM2ZGU3MTBhMjFh MWI5OGU1MmI4ZDg1MDhiNzkzNzk3OWVmZmJjYmQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEwLTA2 LTE2ICBObydhbSBSb3NlbnRoYWwgIDxub2FtLnJvc2VudGhhbEBub2tpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnJpZGdlIGRvY3VtZW50 YXRpb246IHNvbWUgc25pcHBldHMgaGF2ZSB0aGUgd3JvbmcgaW5kZW50YXRpb24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNzE3CisKKyAgICAgICAg Rml4ZWQgY29kZSBzbmlwcGV0cworCisgICAgICAgICogZG9jcy93ZWJraXRzbmlwcGV0cy9xdHdl YmtpdF9icmlkZ2Vfc25pcHBldHMuY3BwOgorICAgICAgICAod3JhcEluRnVuY3Rpb24pOgorCiAy MDEwLTA2LTE2ICBBbGV4aXMgTWVuYXJkIDxhbGV4aXMubWVuYXJkQG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9k b2NzL3dlYmtpdHNuaXBwZXRzL3F0d2Via2l0X2JyaWRnZV9zbmlwcGV0cy5jcHAgYi9XZWJLaXQv cXQvZG9jcy93ZWJraXRzbmlwcGV0cy9xdHdlYmtpdF9icmlkZ2Vfc25pcHBldHMuY3BwCmluZGV4 IDYyZWVlY2FhZjY0ZWI2MTdmZjVjM2I4NWJiNmI5NzQ2OWEzZGM5ZDYuLjZhNTE3YzI2NTljMWE0 MWIyZmU3NjEwMmI1NzUyYmE1MzRjMThmZWMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9kb2NzL3dl YmtpdHNuaXBwZXRzL3F0d2Via2l0X2JyaWRnZV9zbmlwcGV0cy5jcHAKKysrIGIvV2ViS2l0L3F0 L2RvY3Mvd2Via2l0c25pcHBldHMvcXR3ZWJraXRfYnJpZGdlX3NuaXBwZXRzLmNwcApAQCAtMTIs MTAgKzEyLDEwIEBAIHZvaWQgd3JhcEluRnVuY3Rpb24oKQogICAgIC8vISBbMV0KICAgICB7CiAg ICAgICAgIHdpZHRoOiAuLi4sCi0gICAgICAgICAgICBoZWlnaHQ6IC4uLiwKLSAgICAgICAgICAg ICAgICB0b0RhdGFVUkw6IGZ1bmN0aW9uKCkgeyAuLi4gfSwKLSAgICAgICAgICAgICAgICAgICAg YXNzaWduVG9IVE1MSW1hZ2VFbGVtZW50OiBmdW5jdGlvbihlbGVtZW50KSB7IC4uLiB9Ci0gICAg ICAgIH0KKyAgICAgICAgaGVpZ2h0OiAuLi4sCisgICAgICAgIHRvRGF0YVVSTDogZnVuY3Rpb24o KSB7IC4uLiB9LAorICAgICAgICBhc3NpZ25Ub0hUTUxJbWFnZUVsZW1lbnQ6IGZ1bmN0aW9uKGVs ZW1lbnQpIHsgLi4uIH0KKyAgICB9CiAgICAgLy8hIFsxXQogI2VuZGlmCiAgICAgLy8hIFsyXQpA QCAtMjQsNyArMjQsNyBAQCB2b2lkIHdyYXBJbkZ1bmN0aW9uKCkKICAgICAgICAgUV9QUk9QRVJU WShRUGl4bWFwIG15UGl4bWFwIFJFQUQgZ2V0UGl4bWFwKQogCiAgICAgcHVibGljOgotICAgICAg ICAgICAgICAgIFFQaXhtYXAgZ2V0UGl4bWFwKCkgY29uc3Q7CisgICAgICAgIFFQaXhtYXAgZ2V0 UGl4bWFwKCkgY29uc3Q7CiAgICAgfTsKIAogICAgIC8qIC4uLiAqLwpAQCAtMzYsMjEgKzM2LDIy IEBAIHZvaWQgd3JhcEluRnVuY3Rpb24oKQogI2lmIDAKICAgICAvLyEgWzNdCiAgICAgPGh0bWw+ Ci0gICAgICAgICAgICA8aGVhZD4KKyAgICAgICAgPGhlYWQ+CiAgICAgICAgICAgICA8c2NyaXB0 PgotICAgICAgICAgICAgZnVuY3Rpb24gbG9hZEltYWdlKCkgewotICAgICAgICBteU9iamVjdC5t eVBpeG1hcC5hc3NpZ25Ub0hUTUxJbWFnZUVsZW1lbnQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo ImltYWdlRWxlbWVudCIpKTsKLSAgICB9Ci0gICAgPC9zY3JpcHQ+Ci0gICAgICAgICAgICA8L2hl YWQ+Ci0gICAgICAgICAgICA8Ym9keSBvbmxvYWQ9ImxvYWRJbWFnZSgpIj4KLSAgICAgICAgICAg ICAgICAgICAgICAgICA8aW1nIGlkPSJpbWFnZUVsZW1lbnQiIHdpZHRoPSIzMDAiIGhlaWdodD0i MjAwIiAvPgotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDwvYm9keT4KLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8L2h0bWw+Ci0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Ly8hIFszXQorICAgICAgICAgICAgICAgIGZ1bmN0aW9uIGxvYWRJbWFnZSgpCisgICAgICAgICAg ICAgICAgeworICAgICAgICAgICAgICAgICAgICBteU9iamVjdC5teVBpeG1hcC5hc3NpZ25Ub0hU TUxJbWFnZUVsZW1lbnQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImltYWdlRWxlbWVudCIpKTsK KyAgICAgICAgICAgICAgICB9CisgICAgICAgICAgICA8L3NjcmlwdD4KKyAgICAgICAgPC9oZWFk PgorICAgICAgICA8Ym9keSBvbmxvYWQ9ImxvYWRJbWFnZSgpIj4KKyAgICAgICAgICAgIDxpbWcg aWQ9ImltYWdlRWxlbWVudCIgd2lkdGg9IjMwMCIgaGVpZ2h0PSIyMDAiIC8+CisgICAgICAgIDwv Ym9keT4KKyAgICA8L2h0bWw+CisvLyEgWzNdCiAjZW5kaWYKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAvLyEgWzRdCi0g ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgY2xhc3MgTXlPYmplY3QgOiBRT2JqZWN0IHsKKy8vISBbNF0KK2NsYXNzIE15T2Jq ZWN0IDogUU9iamVjdCB7CiAgICAgICAgIFFfT0JKRUNUCiAKICAgICBwdWJsaWMgc2xvdHM6CkBA IC0xNjEsMTEgKzE2Miw3IEBAIHZvaWQgd3JhcEluRnVuY3Rpb24oKQogICAgIG15UU9iamVjdC5l bmFibGVkID0gIW15UU9iamVjdC5lbmFibGVkOwogICAgIC8vISBbMjRdCiAgICAgLy8hIFsyNV0K LSAgICBteVFPYmplY3QuZW5hYmxlZCA9IHRydWU7Ci0KLSAgICAuLi4KLQotICAgIG15UU9iamVj dC5lbmFibGVkID0gIW15UU9iamVjdC5lbmFibGVkOworICAgIG15RGlhbG9nLm9rQnV0dG9uCiAg ICAgLy8hIFsyNV0KICAgICAvLyEgWzI2XQogICAgIG15RGlhbG9nLm9rQnV0dG9uCg==