40714 2010-06-16 08:58:42 -0700 [Qt] Compilation in QWebPagePrivate::timerEvent with clang 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other OS X 10.5 CLOSED FIXED Qt P2 Normal --- 0 ogoffart webkit-unassigned benjamin commit-queue hausmann oldest_to_newest 238910 0 ogoffart 2010-06-16 08:58:42 -0700 QtWebkit: Fix compilaiton with clang. QObject::timerEvent is protected and cannot be accessed by QWebPagePrivate with clang QWebPagePrivate is a friend of QWebPage and then should have access to all protected members of parents of QWebPage, including QObject. But the clang team do not want to conform to this aspect of the specification because "It is either a drafting error or a horrible mistake." See http://llvm.org/bugs/show_bug.cgi?id=6840 This change is better because QWebPage does not reimplement the timerEvent (QWebPagePrivate::timerEvent is called from QWebPage::event) So customers that would reimplement their own timerEvent for their own timer now get a chance to catch them. 238915 1 58897 ogoffart 2010-06-16 09:10:12 -0700 Created attachment 58897 Patch 238932 2 58897 kenneth 2010-06-16 09:59:39 -0700 Comment on attachment 58897 Patch Yes I read the thread on the clang bug report and mailing list some time ago :-) r=me! 240308 3 58897 commit-queue 2010-06-19 03:04:10 -0700 Comment on attachment 58897 Patch Clearing flags on attachment: 58897 Committed r61476: <http://trac.webkit.org/changeset/61476> 240309 4 commit-queue 2010-06-19 03:04:16 -0700 All reviewed patches have been landed. Closing bug. 240344 5 hausmann 2010-06-19 08:46:04 -0700 Revision r61476 cherry-picked into qtwebkit-2.0 with commit b44934b2fd56c3e9e19bd9e7d0d0a341d442b195 58897 2010-06-16 09:10:12 -0700 2010-06-19 03:04:09 -0700 Patch patch.diff text/plain 1767 ogoffart ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggZDQ5YWMxNC4uYWFlYTA0NiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTU5 Myw3ICs1OTMsNyBAQCB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6dGltZXJFdmVudChRVGltZXJFdmVu dCAqZXYpCiAgICAgaWYgKHRpbWVySWQgPT0gdHJpcGxlQ2xpY2tUaW1lci50aW1lcklkKCkpCiAg ICAgICAgIHRyaXBsZUNsaWNrVGltZXIuc3RvcCgpOwogICAgIGVsc2UKLSAgICAgICAgcS0+UU9i amVjdDo6dGltZXJFdmVudChldik7CisgICAgICAgIHEtPnRpbWVyRXZlbnQoZXYpOwogfQogCiB2 b2lkIFFXZWJQYWdlUHJpdmF0ZTo6bW91c2VNb3ZlRXZlbnQoUUdyYXBoaWNzU2NlbmVNb3VzZUV2 ZW50KiBldikKZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hh bmdlTG9nCmluZGV4IDkwNDkxYzYuLjA5NzAxOWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFu Z2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEwLTA2 LTE2ICBPbGl2aWVyIEdvZmZhcnQgIDxvbGl2aWVyLmdvZmZhcnRAbm9raWEuY29tPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQ29tcGlsYXRp b24gaW4gUVdlYlBhZ2VQcml2YXRlOjp0aW1lckV2ZW50IHdpdGggY2xhbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNzE0CisKKyAgICAgICAgUU9i amVjdDo6dGltZXJFdmVudCBpcyBwcm90ZWN0ZWQgYW5kIGNhbm5vdCBiZSBhY2Nlc3NlZCBieSBR V2ViUGFnZVByaXZhdGUKKyAgICAgICAgd2l0aCBjbGFuZworCisgICAgICAgIFFXZWJQYWdlUHJp dmF0ZSBpcyBhIGZyaWVuZCBvZiBRV2ViUGFnZSBhbmQgdGhlbiBzaG91bGQgaGF2ZSBhY2Nlc3Mg dG8KKyAgICAgICAgYWxsIHByb3RlY3RlZCBtZW1iZXJzIG9mIHBhcmVudHMgb2YgUVdlYlBhZ2Us IGluY2x1ZGluZyBRT2JqZWN0LgorICAgICAgICBCdXQgdGhlIGNsYW5nIHRlYW0gZG8gbm90IHdh bnQgdG8gY29uZm9ybSB0byB0aGlzIGFzcGVjdCBvZiB0aGUgc3BlY2lmaWNhdGlvbgorICAgICAg ICBiZWNhdXNlICJJdCBpcyBlaXRoZXIgYSBkcmFmdGluZyBlcnJvciBvciBhIGhvcnJpYmxlIG1p c3Rha2UuIgorICAgICAgICBTZWUgaHR0cDovL2xsdm0ub3JnL2J1Z3Mvc2hvd19idWcuY2dpP2lk PTY4NDAKKworICAgICAgICBUaGlzIGNoYW5nZSBpcyBiZXR0ZXIgYmVjYXVzZSBRV2ViUGFnZSBk b2VzIG5vdCByZWltcGxlbWVudCB0aGUgdGltZXJFdmVudAorICAgICAgICAoUVdlYlBhZ2VQcml2 YXRlOjp0aW1lckV2ZW50IGlzIGNhbGxlZCBmcm9tIFFXZWJQYWdlOjpldmVudCkKKyAgICAgICAg U28gY3VzdG9tZXJzIHRoYXQgd291bGQgcmVpbXBsZW1lbnQgdGhlaXIgb3duIHRpbWVyRXZlbnQK KyAgICAgICAgZm9yIHRoZWlyIG93biB0aW1lciBub3cgZ2V0IGEgY2hhbmNlIHRvIGNhdGNoIHRo ZW0uCisKKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZVBy aXZhdGU6OnRpbWVyRXZlbnQpOgorCiAyMDEwLTA2LTE2ICBBbGV4aXMgTWVuYXJkIDxhbGV4aXMu bWVuYXJkQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4K