40712 2010-06-16 08:51:09 -0700 webkit-patch failure-reason crashes at r61139 when using git (because that commit was on a branch) 2010-09-30 06:51:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED DUPLICATE 46866 P2 Normal --- 1 aroben webkit-unassigned abarth eric ojan oldest_to_newest 238905 0 aroben 2010-06-16 08:51:09 -0700 webkit-patch failure-reason crashes at r61139 when using git. Here's the exception you get: Traceback (most recent call last): File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkit-patch", line 64, in <module> main() File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkit-patch", line 59, in main WebKitPatch(__file__).main() File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main result = command.check_arguments_and_execute(options, args, self) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 274, in execute return self._explain_failures_for_builder(builder, start_revision=int(start_revision)) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 247, in _explain_failures_for_builder self._print_blame_information_for_transition(build, last_build_with_results, fixed_results) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/queries.py", line 206, in _print_blame_information_for_transition commit_info = self.tool.checkout().commit_info_for_revision(revision) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 63, in commit_info_for_revision committer_email = self._scm.committer_email_for_revision(revision) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 573, in committer_email_for_revision git_commit = self.git_commit_from_svn_revision(revision) File "/home/Adam Roben/dev/WebKit/OpenSource/WebKitTools/Scripts/webkitpy/common/checkout/scm.py", line 560, in git_commit_from_svn_revision raise ScriptError(message='Failed to find git commit for revision %s, your checkout likely needs an update.' % revision) webkitpy.common.system.executive.ScriptError: Failed to find git commit for revision 61139, your checkout likely needs an update. The problem is that r61139 was on a branch that I don't have included in my git repository. Maybe we should just skip over revisions like these? 238963 1 eric 2010-06-16 11:04:49 -0700 I assume you ran it bare? I think failure-reason will take a starting revision argument, but then again maybe that was in a patch I never landed. 238982 2 aroben 2010-06-16 11:26:55 -0700 (In reply to comment #1) > I assume you ran it bare? I think failure-reason will take a starting revision argument, but then again maybe that was in a patch I never landed. Yes, I did run it bare. And yes, it does take a starting revision argument which you could use to work around this bug. 238993 3 eric 2010-06-16 11:34:25 -0700 failure-reason could be made a lot more user friendly and smarter, and this is definitely a good bug to have around. I don't expect getting to fixing it any time soon though, but thank you for filing. :) If you're using failure-reason often, I'm happy to review patches to make it better! :) 287526 4 aroben 2010-09-30 06:51:56 -0700 *** This bug has been marked as a duplicate of bug 46866 ***