40651 2010-06-15 22:00:00 -0700 Use "typedef wchar_t JSChar" when compiled with RVCT 2010-09-22 15:05:51 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 skyul webkit-unassigned beergun commit-queue gustavo joybro201 laszlo.gombos loki webkit-ews webkit.review.bot xan.lopez xhiloh oldest_to_newest 238666 0 skyul 2010-06-15 22:00:00 -0700 Fix Brew MP RVCT build. defined(AEE_STATIC) || defined(DYNAMIC_APP) checks Brew MP. 238667 1 58851 skyul 2010-06-15 22:02:01 -0700 Created attachment 58851 Patch 238668 2 webkit-ews 2010-06-15 22:07:20 -0700 Attachment 58851 did not build on qt: Build output: http://webkit-commit-queue.appspot.com/results/3267195 238669 3 webkit.review.bot 2010-06-15 22:08:04 -0700 Attachment 58851 did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3331220 238670 4 58852 skyul 2010-06-15 22:08:46 -0700 Created attachment 58852 Patch Oops. ')' was missing. 239171 5 laszlo.gombos 2010-06-16 18:36:18 -0700 Is __CC_ARM or __ARMCC__ defined for BREW ? f it is maybe it is better to remove the "&& defined(__SYMBIAN32__)" test and make this rule generic for all RVCT platforms. 239177 6 skyul 2010-06-16 18:54:49 -0700 (In reply to comment #5) > Is __CC_ARM or __ARMCC__ defined for BREW ? > > f it is maybe it is better to remove the "&& defined(__SYMBIAN32__)" test and make this rule generic for all RVCT platforms. __CC_ARM or __ARMCC__ is defined when RVCT is used. Any suggestion? 239276 7 laszlo.gombos 2010-06-17 01:07:18 -0700 How about this ? - && !((defined(__CC_ARM) || defined(__ARMCC__)) && defined(__SYMBIAN32__)) + && !((defined(__CC_ARM) || defined(__ARMCC__))) 239681 8 skyul 2010-06-17 17:46:37 -0700 (In reply to comment #7) > How about this ? > > - && !((defined(__CC_ARM) || defined(__ARMCC__)) && defined(__SYMBIAN32__)) > + && !((defined(__CC_ARM) || defined(__ARMCC__))) Okay. I will update the patch as you suggested. 239685 9 59054 skyul 2010-06-17 17:55:54 -0700 Created attachment 59054 Patch 242323 10 skyul 2010-06-23 23:41:15 -0700 Ping, Laszlo! 242371 11 59054 loki 2010-06-24 01:20:14 -0700 Comment on attachment 59054 Patch The UChar typedef is different in wtf/unicode/qt4/UnicodeQt4.h in case of RVCT. The same type is required for UChar and JSChar as well. 270556 12 skyul 2010-08-27 09:49:19 -0700 (In reply to comment #11) > (From update of attachment 59054 [details]) > The UChar typedef is different in wtf/unicode/qt4/UnicodeQt4.h in case of RVCT. The same type is required for UChar and JSChar as well. Why don't we check !defined(__linux__) instead of defined(__SYMBIAN32__)? !defined(__linux__) covers both Symbian and Brew MP. I will modify wtf/unicode/qt4/UnicodeQt4.h as well. 270587 13 65732 skyul 2010-08-27 10:51:22 -0700 Created attachment 65732 Patch 272382 14 loki 2010-08-31 14:36:48 -0700 > Created an attachment (id=65732) [details] This looks good to me. Although I do not expect any problem, I will test it on Linux tomorrow. 272582 15 65732 abarth 2010-08-31 19:38:26 -0700 Comment on attachment 65732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=65732&action=prettypatch > JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h:59 > -#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && OS(SYMBIAN)) > +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && !OS(LINUX)) It's unclear to me why we're switching from a whitelist to a blacklist for something that's identified as a hack... 272624 16 skyul 2010-08-31 21:41:56 -0700 (In reply to comment #15) > (From update of attachment 65732 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=65732&action=prettypatch > > > JavaScriptCore/wtf/unicode/qt4/UnicodeQt4.h:59 > > -#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && OS(SYMBIAN)) > > +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && !OS(LINUX)) > It's unclear to me why we're switching from a whitelist to a blacklist for something that's identified as a hack... We can detect Linux with defined(__linux__) and Symbian with defined(__SYMBIAN32__), but there is no such macro in Brew MP. Therefore, it is very hard to check Brew MP in JSStringRef.h. Because Linux is the only exception for now, I think it is okay to switch. 272676 17 loki 2010-09-01 00:35:46 -0700 > > -#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && OS(SYMBIAN)) > > +#if defined(Q_OS_WIN) || COMPILER(WINSCW) || (COMPILER(RVCT) && !OS(LINUX)) > It's unclear to me why we're switching from a whitelist to a blacklist for something that's identified as a hack... I see no problem using this formula. As far as I know RVCT is used for the following target platforms: Symbian, Linux, WinCE, Brew MP. Symbian, WinCE and Brew MP use wchar_t. The only exception is the Linux (which uses uint16_t). Well, it looks like a blacklist, not a whitelist to me. 272838 18 65732 skyul 2010-09-01 09:19:10 -0700 Comment on attachment 65732 Patch r?, q? again for review. 274770 19 skyul 2010-09-06 13:51:18 -0700 (In reply to comment #14) > > Created an attachment (id=65732) [details] [details] > > This looks good to me. > Although I do not expect any problem, I will test it on Linux tomorrow. Ping. Have you tested the patch on Linux? 274782 20 loki 2010-09-06 14:32:01 -0700 > Ping. Have you tested the patch on Linux? Sorry, I forgot to mention that the patch is OK for RVCT and GCC as well. I am sure Laszlo will give an r+ on it. 283203 21 65732 laszlo.gombos 2010-09-22 13:28:05 -0700 Comment on attachment 65732 Patch r=me. I agree that we're switching from white-list to blacklist, but I'm not sure if this is really a hack anymore, despite the comment in the source. 283277 22 65732 commit-queue 2010-09-22 15:05:44 -0700 Comment on attachment 65732 Patch Clearing flags on attachment: 65732 Committed r68087: <http://trac.webkit.org/changeset/68087> 283278 23 commit-queue 2010-09-22 15:05:51 -0700 All reviewed patches have been landed. Closing bug. 58851 2010-06-15 22:02:01 -0700 2010-06-15 22:08:46 -0700 Patch buildfix.patch text/plain 1244 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMjMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTUgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBVc2UgInR5cGVkZWYgd2NoYXJfdCBKU0No YXIiIHdoZW4gY29tcGlsZWQgd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MDY1MQorCisgICAgICAgIEZpeCBCcmV3IE1QIFJWQ1QgYnVp bGQuIGRlZmluZWQoQUVFX1NUQVRJQykgfHwgZGVmaW5lZChEWU5BTUlDX0FQUCkgY2hlY2tzIEJy ZXcgTVAuCisKKyAgICAgICAgKiBBUEkvSlNTdHJpbmdSZWYuaDoKKwogMjAxMC0wNi0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAkocmV2aXNpb24gNjEx NzMpCisrKyBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAkod29ya2luZyBjb3B5KQpA QCAtMzgsNyArMzgsNyBAQCBleHRlcm4gIkMiIHsKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoV0lO MzIpICYmICFkZWZpbmVkKF9XSU4zMikgJiYgIWRlZmluZWQoX19XSU5TQ1dfXykgXAotICAgICYm ICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKSkgJiYgZGVmaW5lZChf X1NZTUJJQU4zMl9fKSkgLyogUlZDVCAqLworICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8 IGRlZmluZWQoX19BUk1DQ19fKSkgJiYgKGRlZmluZWQoX19TWU1CSUFOMzJfXykgfHwgZGVmaW5l ZChBRUVfU1RBVElDKSB8fCBkZWZpbmVkKERZTkFNSUNfQVBQKSkgLyogUlZDVCAqLwogLyohCiBA dHlwZWRlZiBKU0NoYXIKIEBhYnN0cmFjdCBBIFVuaWNvZGUgY2hhcmFjdGVyLgo= 58852 2010-06-15 22:08:46 -0700 2010-06-17 17:55:54 -0700 Patch buildfix.patch text/plain 1245 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMjMzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTUgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBVc2UgInR5cGVkZWYgd2NoYXJfdCBKU0No YXIiIHdoZW4gY29tcGlsZWQgd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MDY1MQorCisgICAgICAgIEZpeCBCcmV3IE1QIFJWQ1QgYnVp bGQuIGRlZmluZWQoQUVFX1NUQVRJQykgfHwgZGVmaW5lZChEWU5BTUlDX0FQUCkgY2hlY2tzIEJy ZXcgTVAuCisKKyAgICAgICAgKiBBUEkvSlNTdHJpbmdSZWYuaDoKKwogMjAxMC0wNi0xNSAgQW5k ZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAkocmV2aXNpb24gNjEx NzMpCisrKyBKYXZhU2NyaXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAkod29ya2luZyBjb3B5KQpA QCAtMzgsNyArMzgsNyBAQCBleHRlcm4gIkMiIHsKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoV0lO MzIpICYmICFkZWZpbmVkKF9XSU4zMikgJiYgIWRlZmluZWQoX19XSU5TQ1dfXykgXAotICAgICYm ICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKSkgJiYgZGVmaW5lZChf X1NZTUJJQU4zMl9fKSkgLyogUlZDVCAqLworICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8 IGRlZmluZWQoX19BUk1DQ19fKSkgJiYgKGRlZmluZWQoX19TWU1CSUFOMzJfXykgfHwgZGVmaW5l ZChBRUVfU1RBVElDKSB8fCBkZWZpbmVkKERZTkFNSUNfQVBQKSkpIC8qIFJWQ1QgKi8KIC8qIQog QHR5cGVkZWYgSlNDaGFyCiBAYWJzdHJhY3QgQSBVbmljb2RlIGNoYXJhY3Rlci4K 59054 2010-06-17 17:55:54 -0700 2010-08-27 10:51:22 -0700 Patch buildfix.patch text/plain 1143 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMzY0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTcgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBbQlJFV01QXSBVc2UgInR5cGVkZWYgd2NoYXJfdCBKU0No YXIiIHdoZW4gY29tcGlsZWQgd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD00MDY1MQorCisgICAgICAgIE1ha2UgdGhlIHJ1bGUgZ2VuZXJp YyBmb3IgYWxsIFJWQ1QgcGxhdGZvcm1zLgorCisgICAgICAgICogQVBJL0pTU3RyaW5nUmVmLmg6 CisKIDIwMTAtMDYtMTcgIFNodSBDaGFuZyAgPGNoYW5nLnNodUBub2tpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS9BUEkvSlNTdHJpbmdSZWYuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9B UEkvSlNTdHJpbmdSZWYuaAkocmV2aXNpb24gNjExNzMpCisrKyBKYXZhU2NyaXB0Q29yZS9BUEkv SlNTdHJpbmdSZWYuaAkod29ya2luZyBjb3B5KQpAQCAtMzgsNyArMzgsNyBAQCBleHRlcm4gIkMi IHsKICNlbmRpZgogCiAjaWYgIWRlZmluZWQoV0lOMzIpICYmICFkZWZpbmVkKF9XSU4zMikgJiYg IWRlZmluZWQoX19XSU5TQ1dfXykgXAotICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRl ZmluZWQoX19BUk1DQ19fKSkgJiYgZGVmaW5lZChfX1NZTUJJQU4zMl9fKSkgLyogUlZDVCAqLwor ICAgICYmICEoKGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKSkpIC8qIFJW Q1QgKi8KIC8qIQogQHR5cGVkZWYgSlNDaGFyCiBAYWJzdHJhY3QgQSBVbmljb2RlIGNoYXJhY3Rl ci4K 65732 2010-08-27 10:51:22 -0700 2010-09-22 15:05:44 -0700 Patch wchar_t.patch text/plain 1832 skyul SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDY2MjM1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDgtMjcgIEt3YW5nIFl1 bCBTZW8gIDxza3l1bEBjb21wYW55MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgInR5cGVkZWYgd2NoYXJfdCBKU0NoYXIiIHdoZW4g Y29tcGlsZWQgd2l0aCBSVkNUCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00MDY1MQorCisgICAgICAgIFVzZSB3Y2hhcl90IGZvciBKU0NoYXIgYW5kIFVD aGFyIHdoZW4gY29tcGlsZWQgd2l0aCBSVkNULgorICAgICAgICBMaW51eCBpcyB0aGUgZXhjZXB0 aW9uIGZvciB0aGlzIHJ1bGUuCisKKyAgICAgICAgKiBBUEkvSlNTdHJpbmdSZWYuaDoKKyAgICAg ICAgKiB3dGYvdW5pY29kZS9xdDQvVW5pY29kZVF0NC5oOgorCiAyMDEwLTA4LTI3ICBDaGFvLXlp bmcgRnUgIDxmdUBtaXBzLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4K SW5kZXg6IEphdmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEph dmFTY3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCShyZXZpc2lvbiA2NjIyOCkKKysrIEphdmFT Y3JpcHRDb3JlL0FQSS9KU1N0cmluZ1JlZi5oCSh3b3JraW5nIGNvcHkpCkBAIC0zOCw3ICszOCw3 IEBAIGV4dGVybiAiQyIgewogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChXSU4zMikgJiYgIWRlZmlu ZWQoX1dJTjMyKSAmJiAhZGVmaW5lZChfX1dJTlNDV19fKSBcCi0gICAgJiYgISgoZGVmaW5lZChf X0NDX0FSTSkgfHwgZGVmaW5lZChfX0FSTUNDX18pKSAmJiBkZWZpbmVkKF9fU1lNQklBTjMyX18p KSAvKiBSVkNUICovCisgICAgJiYgISgoZGVmaW5lZChfX0NDX0FSTSkgfHwgZGVmaW5lZChfX0FS TUNDX18pKSAmJiAhZGVmaW5lZChfX2xpbnV4X18pKSAvKiBSVkNUICovCiAvKiEKIEB0eXBlZGVm IEpTQ2hhcgogQGFic3RyYWN0IEEgVW5pY29kZSBjaGFyYWN0ZXIuCkluZGV4OiBKYXZhU2NyaXB0 Q29yZS93dGYvdW5pY29kZS9xdDQvVW5pY29kZVF0NC5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3Jp cHRDb3JlL3d0Zi91bmljb2RlL3F0NC9Vbmljb2RlUXQ0LmgJKHJldmlzaW9uIDY2MjI4KQorKysg SmF2YVNjcmlwdENvcmUvd3RmL3VuaWNvZGUvcXQ0L1VuaWNvZGVRdDQuaAkod29ya2luZyBjb3B5 KQpAQCAtNTYsNyArNTYsNyBAQCBuYW1lc3BhY2UgUVVuaWNvZGVUYWJsZXMgewogUVRfRU5EX05B TUVTUEFDRQogCiAvLyB1Z2x5IGhhY2sgdG8gbWFrZSBVQ2hhciBjb21wYXRpYmxlIHdpdGggSlND aGFyIGluIEFQSS9KU1N0cmluZ1JlZi5oCi0jaWYgZGVmaW5lZChRX09TX1dJTikgfHwgQ09NUElM RVIoV0lOU0NXKSB8fCAoQ09NUElMRVIoUlZDVCkgJiYgT1MoU1lNQklBTikpCisjaWYgZGVmaW5l ZChRX09TX1dJTikgfHwgQ09NUElMRVIoV0lOU0NXKSB8fCAoQ09NUElMRVIoUlZDVCkgJiYgIU9T KExJTlVYKSkKIHR5cGVkZWYgd2NoYXJfdCBVQ2hhcjsKICNlbHNlCiB0eXBlZGVmIHVpbnQxNl90 IFVDaGFyOwo=