40640 2010-06-15 15:33:26 -0700 [GTK] ClipboardGtk::setURL does not match the behavior of other platforms 2010-06-16 14:18:20 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 mrobinson webkit-unassigned oldest_to_newest 238586 0 mrobinson 2010-06-15 15:33:26 -0700 Other platforms set the clipboard text as the URL and escape the label when creating the markup portion. GTK+ should do this as well and also extend the logic to PasteboardGtk. 238588 1 58830 mrobinson 2010-06-15 15:41:57 -0700 Created attachment 58830 Patch for this issue 239066 2 58830 gustavo 2010-06-16 13:54:02 -0700 Comment on attachment 58830 Patch for this issue LGTM 239090 3 58830 mrobinson 2010-06-16 14:18:16 -0700 Comment on attachment 58830 Patch for this issue Clearing flags on attachment: 58830 Committed r61281: <http://trac.webkit.org/changeset/61281> 239091 4 mrobinson 2010-06-16 14:18:20 -0700 All reviewed patches have been landed. Closing bug. 58830 2010-06-15 15:41:57 -0700 2010-06-16 14:18:16 -0700 Patch for this issue bug-40640-20100615154158.patch text/plain 5324 mrobinson ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzM5YTYyN2VmNGMwZmI3MGQ0YWE4ZDczNTQ1ZmNhYzQzMTk3MjBkMC4uNTY0MmVjYzk5MzE4Mzhi OGQ2NTZlYmQxMTg3NmQwOTBjY2QxODJmNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOCBAQAorMjAxMC0wNi0xNSAgTWFy dGluIFJvYmluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gQ2xpcGJvYXJkR3RrOjpzZXRVUkwg ZG9lcyBub3QgbWF0Y2ggdGhlIGJlaGF2aW9yIG9mIG90aGVyIHBsYXRmb3JtcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA2NDAKKworICAgICAgICBJ bnN0ZWFkIG9mIHdyaXRpbmcgVVJMIGxhYmVscyB0byB0aGUgdGV4dCBwb3J0aW9uIG9mIHRoZSBj bGlwYm9hcmQgb3IKKyAgICAgICAgZHJhZy1hbmQtZHJvcCBkYXRhLCB3cml0ZSB0aGUgVVJMIGl0 c2VsZi4gQWxzbyBlc2NhcGUgdGhlIGxhYmVsIHRleHQKKyAgICAgICAgb2YgVVJMcy4gQWJzdHJh Y3RzIGxvZ2ljIGludG8gRGF0YU9iamVjdEd0aywgc28gQ2xpcGJvYXJkR3RrIGFuZAorICAgICAg ICBQYXN0ZWJvYXJkR3RrIGNhbiBzaGFyZSBpdC4KKworICAgICAgICBUZXN0cyBmb3IgdGhpcyBp c3N1ZSB3aWxsIGJlIGFjdGl2YXRlZCB3aGVuIGRyb3BwaW5nIHN1cHBvcnQgaGFzIGJlZW4KKyAg ICAgICAgYWRkZWQgdG8gdGhlIEdUSysgRXZlbnRTZW5kZXIuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ndGsvQ2xpcGJvYXJkR3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNsaXBib2FyZEd0azo6 d3JpdGVVUkwpOiBVc2UgRGF0YU9iamVjdEd0azo6c2V0VVJMLgorICAgICAgICAqIHBsYXRmb3Jt L2d0ay9EYXRhT2JqZWN0R3RrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRhdGFPYmplY3RHdGs6 OnNldFVSTCk6CisgICAgICAgIEFkZGVkLiBXcml0ZSBVUkwgdG8gdGhlIHRleHQgcG9ydGlvbiBh bmQgcmVtZW1iZXIgdG8gZXNjYXBlIHRoZQorICAgICAgICBsYWJlbCB3aGVuIGNyZWF0aW5nIHRo ZSBtYXJrdXAgcG9ydGlvbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvRGF0YU9iamVjdEd0ay5o OiBBZGQgZGVjbGFyYXRpb24gb2YgbmV3IG1ldGhvZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsv UGFzdGVib2FyZEd0ay5jcHA6IAorICAgICAgICAoV2ViQ29yZTo6UGFzdGVib2FyZDo6d3JpdGVV UkwpOiBVc2UgRGF0YU9iamVjdEd0azo6c2V0VVJMLgorCiAyMDEwLTA2LTE1ICBYYW4gTG9wZXog IDx4bG9wZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBUcnkgdG8gZml4IEdUSysgYnVpbGQuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRHdGsuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvQ2xpcGJvYXJkR3RrLmNwcAppbmRleCBjMjc0MzA5ZTkyNzBlODMyN2U3 ZmY4OTFiNGI4OTZkYTMxMjFkMzQ5Li45MjRmYWJjMTU4MWM3YTcyMjJjODRjNGUwNWNlOTNkYmJm NDM2OWFlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9DbGlwYm9hcmRHdGsuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0NsaXBib2FyZEd0ay5jcHAKQEAgLTMzMSwyMyAr MzMxLDcgQEAgdm9pZCBDbGlwYm9hcmRHdGs6OmRlY2xhcmVBbmRXcml0ZURyYWdJbWFnZShFbGVt ZW50KiBlbGVtZW50LCBjb25zdCBLVVJMJiB1cmwsIGMKIAogdm9pZCBDbGlwYm9hcmRHdGs6Ondy aXRlVVJMKGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBsYWJlbCwgRnJhbWUqKQogewot ICAgIFN0cmluZyBhY3R1YWxMYWJlbChsYWJlbCk7Ci0gICAgaWYgKGFjdHVhbExhYmVsLmlzRW1w dHkoKSkKLSAgICAgICAgYWN0dWFsTGFiZWwgPSB1cmw7Ci0gICAgbV9kYXRhT2JqZWN0LT5zZXRU ZXh0KGFjdHVhbExhYmVsKTsKLQotICAgIFZlY3RvcjxVQ2hhcj4gbWFya3VwOwotICAgIGFwcGVu ZChtYXJrdXAsICI8YSBocmVmPVwiIik7Ci0gICAgYXBwZW5kKG1hcmt1cCwgdXJsLnN0cmluZygp KTsKLSAgICBhcHBlbmQobWFya3VwLCAiXCI+Iik7Ci0gICAgYXBwZW5kKG1hcmt1cCwgbGFiZWwp OwotICAgIGFwcGVuZChtYXJrdXAsICI8L2E+Iik7Ci0gICAgbV9kYXRhT2JqZWN0LT5zZXRNYXJr dXAoU3RyaW5nOjphZG9wdChtYXJrdXApKTsKLQotICAgIFZlY3RvcjxLVVJMPiB1cmlMaXN0Owot ICAgIHVyaUxpc3QuYXBwZW5kKHVybCk7Ci0gICAgbV9kYXRhT2JqZWN0LT5zZXRVUklMaXN0KHVy aUxpc3QpOwotCisgICAgbV9kYXRhT2JqZWN0LT5zZXRVUkwodXJsLCBsYWJlbCk7CiAgICAgaWYg KG1fY2xpcGJvYXJkKQogICAgICAgICBtX2hlbHBlci0+d3JpdGVDbGlwYm9hcmRDb250ZW50cyht X2NsaXBib2FyZCk7CiB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9EYXRhT2Jq ZWN0R3RrLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0RhdGFPYmplY3RHdGsuY3BwCmluZGV4 IDg4NmQzYzFmNmMyYTdhN2E2ZTBlYzBlZjcxOTIxN2M1YjgyMWJjM2EuLmRiMTMzNDVlNmZkZjgx OGU0MmZkMzJjNTk5ZTUxZjc2OTMxZWNkMjQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL0RhdGFPYmplY3RHdGsuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0RhdGFPYmpl Y3RHdGsuY3BwCkBAIC0yMSw2ICsyMSw3IEBACiAKICNpbmNsdWRlICJtYXJrdXAuaCIKICNpbmNs dWRlIDxndGsvZ3RrLmg+CisjaW5jbHVkZSA8d3RmL2dvYmplY3QvR093blB0ci5oPgogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKQEAgLTU4LDYgKzU5LDI4IEBAIHZvaWQgRGF0YU9iamVjdEd0azo6 c2V0TWFya3VwKGNvbnN0IFN0cmluZyYgbmV3TWFya3VwKQogICAgIG1fbWFya3VwID0gbmV3TWFy a3VwOwogfQogCit2b2lkIERhdGFPYmplY3RHdGs6OnNldFVSTChjb25zdCBLVVJMJiB1cmwsIGNv bnN0IFN0cmluZyYgbGFiZWwpCit7CisgICAgc2V0VGV4dCh1cmwuc3RyaW5nKCkpOworCisgICAg U3RyaW5nIGFjdHVhbExhYmVsKGxhYmVsKTsKKyAgICBpZiAoYWN0dWFsTGFiZWwuaXNFbXB0eSgp KQorICAgICAgICBhY3R1YWxMYWJlbCA9IHVybDsKKworICAgIFZlY3RvcjxVQ2hhcj4gbWFya3Vw OworICAgIGFwcGVuZChtYXJrdXAsICI8YSBocmVmPVwiIik7CisgICAgYXBwZW5kKG1hcmt1cCwg dXJsLnN0cmluZygpKTsKKyAgICBhcHBlbmQobWFya3VwLCAiXCI+Iik7CisgICAgR093blB0cjxn Y2hhcj4gZXNjYXBlZChnX21hcmt1cF9lc2NhcGVfdGV4dChhY3R1YWxMYWJlbC51dGY4KCkuZGF0 YSgpLCAtMSkpOworICAgIGFwcGVuZChtYXJrdXAsIFN0cmluZzo6ZnJvbVVURjgoZXNjYXBlZC5n ZXQoKSkpOworICAgIGFwcGVuZChtYXJrdXAsICI8L2E+Iik7CisgICAgc2V0TWFya3VwKFN0cmlu Zzo6YWRvcHQobWFya3VwKSk7CisKKyAgICBWZWN0b3I8S1VSTD4gdXJpTGlzdDsKKyAgICB1cmlM aXN0LmFwcGVuZCh1cmwpOworICAgIHNldFVSSUxpc3QodXJpTGlzdCk7Cit9CisKIHZvaWQgRGF0 YU9iamVjdEd0azo6Y2xlYXJUZXh0KCkKIHsKICAgICBtX3JhbmdlID0gMDsKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vZ3RrL0RhdGFPYmplY3RHdGsuaCBiL1dlYkNvcmUvcGxhdGZvcm0v Z3RrL0RhdGFPYmplY3RHdGsuaAppbmRleCA0MWY4ZjQ5OGRhMjIzMTI1NTQxZDBmZjAzN2JkNjQ3 ZGE5M2EwMDNhLi44ZmJhOTM4NDAyMmYxODFhNjY1ZjNlYjQ2MGQ5YTViZGE1ZjZkMjIzIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9EYXRhT2JqZWN0R3RrLmgKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvRGF0YU9iamVjdEd0ay5oCkBAIC00Niw2ICs0Niw3IEBAIHB1YmxpYzoK ICAgICB2b2lkIHNldFVSSUxpc3QoY29uc3QgVmVjdG9yPEtVUkw+JiBuZXdVUklMaXN0KSB7ICBt X3VyaUxpc3QgPSBuZXdVUklMaXN0OyB9CiAgICAgdm9pZCBzZXRJbWFnZShHZGtQaXhidWYqIG5l d0ltYWdlKSB7IG1faW1hZ2UgPSBuZXdJbWFnZTsgfQogICAgIHZvaWQgc2V0RHJhZ0NvbnRleHQo R2RrRHJhZ0NvbnRleHQqIG5ld0RyYWdDb250ZXh0KSB7IG1fZHJhZ0NvbnRleHQgPSBuZXdEcmFn Q29udGV4dDsgfQorICAgIHZvaWQgc2V0VVJMKGNvbnN0IEtVUkwmLCBjb25zdCBTdHJpbmcmKTsK ICAgICBib29sIGhhc1RleHQoKSB7IHJldHVybiBtX3JhbmdlIHx8ICFtX3RleHQuaXNFbXB0eSgp OyB9CiAgICAgYm9vbCBoYXNNYXJrdXAoKSB7IHJldHVybiBtX3JhbmdlIHx8ICFtX21hcmt1cC5p c0VtcHR5KCk7IH0KICAgICBib29sIGhhc1VSSUxpc3QoKSB7IHJldHVybiAhbV91cmlMaXN0Lmlz RW1wdHkoKTsgfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0 ay5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3RrLmNwcAppbmRleCBkMTM5 YmQ5YTM5Y2NkMDMzYzBjZjQ3YzIxYzE0ZDZlZTI1M2Y0MjdmLi5hMDA2OWNmMjc4ZGRiYzNmNmJh NjY1MmNjOWM2ODE5ZmQ0YmM5NmU5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9Q YXN0ZWJvYXJkR3RrLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2d0ay9QYXN0ZWJvYXJkR3Rr LmNwcApAQCAtODAsMTcgKzgwLDE0IEBAIHZvaWQgUGFzdGVib2FyZDo6d3JpdGVQbGFpblRleHQo Y29uc3QgU3RyaW5nJiB0ZXh0KQogICAgIG1faGVscGVyLT53cml0ZUNsaXBib2FyZENvbnRlbnRz KGNsaXBib2FyZCk7CiB9CiAKLXZvaWQgUGFzdGVib2FyZDo6d3JpdGVVUkwoY29uc3QgS1VSTCYg dXJsLCBjb25zdCBTdHJpbmcmLCBGcmFtZSogZnJhbWUpCit2b2lkIFBhc3RlYm9hcmQ6OndyaXRl VVJMKGNvbnN0IEtVUkwmIHVybCwgY29uc3QgU3RyaW5nJiBsYWJlbCwgRnJhbWUqIGZyYW1lKQog ewogICAgIGlmICh1cmwuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm47CiAKICAgICBHdGtDbGlw Ym9hcmQqIGNsaXBib2FyZCA9IG1faGVscGVyLT5nZXRDbGlwYm9hcmQoZnJhbWUpOwogICAgIERh dGFPYmplY3RHdGsqIGRhdGFPYmplY3QgPSBEYXRhT2JqZWN0R3RrOjpmb3JDbGlwYm9hcmQoY2xp cGJvYXJkKTsKLQotICAgIFZlY3RvcjxLVVJMPiB1cmlMaXN0OwotICAgIHVyaUxpc3QuYXBwZW5k KHVybCk7Ci0gICAgZGF0YU9iamVjdC0+c2V0VVJJTGlzdCh1cmlMaXN0KTsKKyAgICBkYXRhT2Jq ZWN0LT5zZXRVUkwodXJsLCBsYWJlbCk7CiAgICAgbV9oZWxwZXItPndyaXRlQ2xpcGJvYXJkQ29u dGVudHMoY2xpcGJvYXJkKTsKIH0KIAo=