40628 2010-06-15 09:53:08 -0700 Update CMake build system to use new gperf code generation 2010-06-17 07:50:12 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED P1 Blocker --- 1 lucas.de.marchi lucas.de.marchi abecsi barbieri darin lucas.de.marchi oldest_to_newest 238424 0 lucas.de.marchi 2010-06-15 09:53:08 -0700 Update CMake build system to use new gperf code generation 238426 1 58790 lucas.de.marchi 2010-06-15 09:54:07 -0700 Created attachment 58790 Patch 238705 2 abecsi 2010-06-16 00:46:30 -0700 Seems ok to me. Thanks for doing that. (In reply to comment #1) > Created an attachment (id=58790) [details] > Patch 239330 3 lucas.de.marchi 2010-06-17 04:40:55 -0700 This is a build fix that is blocking our development so I'm raising the priority. 239360 4 58790 gustavo 2010-06-17 06:14:42 -0700 Comment on attachment 58790 Patch I thought you had a commiter by now? =) You should really consider setting up a build bot, asap too. 239379 5 58790 abecsi 2010-06-17 07:34:17 -0700 Comment on attachment 58790 Patch Removing cq+ to land the patch manually. 239385 6 58790 abecsi 2010-06-17 07:49:32 -0700 Comment on attachment 58790 Patch Sending ChangeLog Sending WebCore/CMakeLists.txt Sending WebCore/ChangeLog Sending cmake/WebKitGenerators.cmake Transmitting file data .... Committed revision 61323. Removing flags. 239386 7 abecsi 2010-06-17 07:50:12 -0700 All reviewed patches landed. Closing bug. 58790 2010-06-15 09:54:07 -0700 2010-06-17 07:49:32 -0700 Patch bug-40628-20100615135448.patch text/plain 6112 lucas.de.marchi ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4MzU5ZTNhOTE0Nzg3NWFl N2I4YjdlZTUwNzAyNWU5ZWZjNjQwYmQwLi4yMjE4MGZmMGU1MzcwNjU3OTkxZTYxNDkwZTBlZGZk ZjhhNGNiYTNmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMTAtMDYtMTUgIEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHBy b2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFVwZGF0ZSBDTWFrZSBidWlsZCBzeXN0ZW0gdG8gdXNlIG5ldyBzY3JpcHQgZm9yIGdl bmVyYXRpbmcgc291cmNlIGZpbGVzCisgICAgICAgIHdpdGggZ3BlcmYgKHI2MTA5MSkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDYyOAorCisgICAg ICAgICogY21ha2UvV2ViS2l0R2VuZXJhdG9ycy5jbWFrZToKKwogMjAxMC0wNi0wOSAgTGVhbmRy byBQZXJlaXJhICA8bGVhbmRyb0Bwcm9mdXNpb24ubW9iaT4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIFRyZWF0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dCBiL1dlYkNv cmUvQ01ha2VMaXN0cy50eHQKaW5kZXggMDhmNDM4NWYwZmFhNTNkOWRiYzkwZjBiYzhlMTNiMmIw MDhmMmUxZS4uYzM1NDAzODhlNzBhMGJiNTk2N2FjZWQ0ZTUyOTMwYjBiYjlhMzIyMyAxMDA2NDQK LS0tIGEvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9XZWJDb3JlL0NNYWtlTGlzdHMudHh0 CkBAIC0zNDYsNiArMzQ2LDggQEAgU0VUKFdlYkNvcmVfSURMX0ZJTEVTCiAgICAgc3RvcmFnZS9T dG9yYWdlLmlkbAogICAgIHN0b3JhZ2UvU3RvcmFnZUV2ZW50LmlkbAogCisgICAgd2Vic29ja2V0 cy9XZWJTb2NrZXQuaWRsCisKICAgICB3b3JrZXJzL0Fic3RyYWN0V29ya2VyLmlkbAogICAgIHdv cmtlcnMvRGVkaWNhdGVkV29ya2VyQ29udGV4dC5pZGwKICAgICB3b3JrZXJzL1NoYXJlZFdvcmtl ci5pZGwKQEAgLTUxMCw3ICs1MTIsNyBAQCBFTkRJRigpCiBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAg ICAgJHtERVJJVkVEX1NPVVJDRVNfRElSfS9DU1NHcmFtbWFyLmNwcAogICAgICR7REVSSVZFRF9T T1VSQ0VTX0RJUn0vSFRNTEVsZW1lbnRGYWN0b3J5LmNwcAotICAgICR7REVSSVZFRF9TT1VSQ0VT X0RJUn0vSFRNTEVudGl0eU5hbWVzLmMKKyAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L0hUTUxF bnRpdHlOYW1lcy5jcHAKICAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L0hUTUxOYW1lcy5jcHAK ICAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L0pTSFRNTEVsZW1lbnRXcmFwcGVyRmFjdG9yeS5j cHAKICAgICAke0RFUklWRURfU09VUkNFU19ESVJ9L1VzZXJBZ2VudFN0eWxlU2hlZXRzRGF0YS5j cHAKQEAgLTEwMTYsNiArMTAxOCw3IEBAIFNFVChXZWJDb3JlX1NPVVJDRVMKICAgICBpbnNwZWN0 b3IvSW5zcGVjdG9yRnJvbnRlbmRDbGllbnRMb2NhbC5jcHAKICAgICBpbnNwZWN0b3IvSW5zcGVj dG9yRnJvbnRlbmRIb3N0LmNwcAogICAgIGluc3BlY3Rvci9JbnNwZWN0b3JSZXNvdXJjZS5jcHAK KyAgICBpbnNwZWN0b3IvSW5zcGVjdG9yVmFsdWVzLmNwcAogICAgIGluc3BlY3Rvci9JbnNwZWN0 b3JUaW1lbGluZUFnZW50LmNwcAogICAgIGluc3BlY3Rvci9UaW1lbGluZVJlY29yZEZhY3Rvcnku Y3BwCiAKQEAgLTE0MDAsNiArMTQwMywxMyBAQCBTRVQoV2ViQ29yZV9TT1VSQ0VTCiAgICAgc3Rv cmFnZS9TdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAKICAgICBzdG9yYWdlL1N0b3JhZ2VTeW5jTWFu YWdlci5jcHAKIAorICAgIHdlYnNvY2tldHMvVGhyZWFkYWJsZVdlYlNvY2tldENoYW5uZWwuY3Bw CisgICAgd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCisgICAgd2Vic29ja2V0cy9XZWJTb2NrZXRD aGFubmVsLmNwcAorICAgIHdlYnNvY2tldHMvV2ViU29ja2V0SGFuZHNoYWtlLmNwcAorICAgIHdl YnNvY2tldHMvV2ViU29ja2V0SGFuZHNoYWtlUmVxdWVzdC5jcHAKKyAgICB3ZWJzb2NrZXRzL1dv cmtlclRocmVhZGFibGVXZWJTb2NrZXRDaGFubmVsLmNwcAorCiAgICAgd29ya2Vycy9BYnN0cmFj dFdvcmtlci5jcHAKICAgICB3b3JrZXJzL0RlZGljYXRlZFdvcmtlckNvbnRleHQuY3BwCiAgICAg d29ya2Vycy9EZWRpY2F0ZWRXb3JrZXJUaHJlYWQuY3BwCkBAIC0xNjY3LDkgKzE2NzcsOSBAQCBF TkRGT1JFQUNIICgpCiAKIExJU1QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUyAke0pTX0lETF9GSUxF U30pCiAKLUdFTkVSQVRFX0dQRVJGKCJjIiAke1dFQkNPUkVfRElSfS9odG1sL0hUTUxFbnRpdHlO YW1lcy5ncGVyZiBmaW5kRW50aXR5ICItYyIpCi1HRU5FUkFURV9HUEVSRigiYyIgJHtXRUJDT1JF X0RJUn0vcGxhdGZvcm0vQ29sb3JEYXRhLmdwZXJmIGZpbmRDb2xvciAiIikKLUdFTkVSQVRFX0dQ RVJGKCJjcHAiICR7V0VCQ09SRV9ESVJ9L2h0bWwvRG9jVHlwZVN0cmluZ3MuZ3BlcmYgZmluZERv Y3R5cGVFbnRyeSAiLUYsUHViSURJbmZvOjplQWxtb3N0U3RhbmRhcmRzLFB1YklESW5mbzo6ZUFs bW9zdFN0YW5kYXJkcyIpCitHRU5FUkFURV9HUEVSRigke1dFQkNPUkVfRElSfS9odG1sL0hUTUxF bnRpdHlOYW1lcy5ncGVyZikKK0dFTkVSQVRFX0dQRVJGKCR7V0VCQ09SRV9ESVJ9L3BsYXRmb3Jt L0NvbG9yRGF0YS5ncGVyZikKK0dFTkVSQVRFX0dQRVJGKCR7V0VCQ09SRV9ESVJ9L2h0bWwvRG9j VHlwZVN0cmluZ3MuZ3BlcmYpCiAKIEdFTkVSQVRFX1RPS0VOSVpFUigpCiBHRU5FUkFURV9VU0VS X0FHRU5UX1NUWUxFUygpCkBAIC0xNjg0LDkgKzE2OTQsMTAgQEAgQUREX1NPVVJDRV9ERVJJVkVE X0RFUEVOREVOQ0lFUygke0RFUklWRURfU09VUkNFU19ESVJ9L0NTU0dyYW1tYXIuY3BwIENTU1Zh bHVlS2UKIEFERF9TT1VSQ0VfREVSSVZFRF9ERVBFTkRFTkNJRVMoJHtERVJJVkVEX1NPVVJDRVNf RElSfS9DU1NHcmFtbWFyLmNwcCBDU1NQcm9wZXJ0eU5hbWVzLmgpCiBBRERfU09VUkNFX0RFUklW RURfREVQRU5ERU5DSUVTKCR7V0VCQ09SRV9ESVJ9L2Nzcy9DU1NQcmltaXRpdmVWYWx1ZU1hcHBp bmdzLmggQ1NTVmFsdWVLZXl3b3Jkcy5oKQogQUREX1NPVVJDRV9ERVJJVkVEX0RFUEVOREVOQ0lF Uygke1dFQkNPUkVfRElSfS9odG1sL0hUTUxEb2N1bWVudC5jcHAgRG9jVHlwZVN0cmluZ3MuY3Bw KQotQUREX1NPVVJDRV9ERVJJVkVEX0RFUEVOREVOQ0lFUygke1dFQkNPUkVfRElSfS9wbGF0Zm9y bS9ncmFwaGljcy9Db2xvci5jcHAgQ29sb3JEYXRhLmMpCitBRERfU09VUkNFX0RFUklWRURfREVQ RU5ERU5DSUVTKCR7V0VCQ09SRV9ESVJ9L3BsYXRmb3JtL2dyYXBoaWNzL0NvbG9yLmNwcCBDb2xv ckRhdGEuY3BwKQogQUREX1NPVVJDRV9ERVJJVkVEX0RFUEVOREVOQ0lFUygke1dFQkNPUkVfRElS fS9jc3MvQ1NTUGFyc2VyLmNwcCB0b2tlbml6ZXIuY3BwKQotQUREX1NPVVJDRV9ERVJJVkVEX0RF UEVOREVOQ0lFUygke1dFQkNPUkVfRElSfS9odG1sL1ByZWxvYWRTY2FubmVyLmNwcCBIVE1MRW50 aXR5TmFtZXMuYykKK0FERF9TT1VSQ0VfREVSSVZFRF9ERVBFTkRFTkNJRVMoJHtXRUJDT1JFX0RJ Un0vaHRtbC9QcmVsb2FkU2Nhbm5lci5jcHAgSFRNTEVudGl0eU5hbWVzLmNwcCkKK0FERF9TT1VS Q0VfREVSSVZFRF9ERVBFTkRFTkNJRVMoJHtXRUJDT1JFX0RJUn0vaHRtbC9IVE1MNUVudGl0eVBh cnNlci5jcHAgSFRNTEVudGl0eU5hbWVzLmNwcCkKIEFERF9TT1VSQ0VfREVSSVZFRF9ERVBFTkRF TkNJRVMoJHtXRUJDT1JFX0RJUn0vY3NzL0NTU1N0eWxlU2VsZWN0b3IuY3BwIFVzZXJBZ2VudFN0 eWxlU2hlZXRzRGF0YS5jcHAgVXNlckFnZW50U3R5bGVTaGVldHMuaCkKIAogR0VORVJBVEVfRE9N X05BTUVTX0ZBQ1RPUlkoSFRNTCAke1dFQkNPUkVfRElSfS9odG1sL0hUTUxUYWdOYW1lcy5pbiAk e1dFQkNPUkVfRElSfS9odG1sL0hUTUxBdHRyaWJ1dGVOYW1lcy5pbiAiJHtIVE1MX0ZFQVRVUkVT fSIpCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IGNhZjI4ZGIwZjNhYjFkMDExYjQ5YWI3ODVlZWEwNjIzMzUyZGI4MmYuLjI0MmFjNmE2NDI0 YjNjYTVkODAwYjUzY2MxODUzNjQ4ZDlhN2IwZGEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTUg IEx1Y2FzIERlIE1hcmNoaSAgPGx1Y2FzLmRlbWFyY2hpQHByb2Z1c2lvbi5tb2JpPgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBDTWFrZSBi dWlsZCBzeXN0ZW0gdG8gdXNlIG5ldyBzY3JpcHQgZm9yIGdlbmVyYXRpbmcgc291cmNlIGZpbGVz CisgICAgICAgIHdpdGggZ3BlcmYgKHI2MTA5MSkuCisgICAgICAgIFRoaXMgdXBkYXRlcyBhbHNv IHRoZSBidWlsZCBzeXN0ZW0gdG8gY29wZSB3aXRoIHJlY2VudCBjaGFuZ2VzIHRvCisgICAgICAg IHNvdXJjZSBmaWxlcyBsaXN0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDA2MjgKKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgaXQncyBqdXN0 IGNvbXBpbGF0aW9uIGZpeGVzLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTAt MDYtMTAgIFJhaW5lIE1ha2VsYWluZW4gIDxyYWluZS5tYWtlbGFpbmVuQG5va2lhLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdp dCBhL2NtYWtlL1dlYktpdEdlbmVyYXRvcnMuY21ha2UgYi9jbWFrZS9XZWJLaXRHZW5lcmF0b3Jz LmNtYWtlCmluZGV4IDZmZTAzOTk1OGY3ZDY4YzQyZWVjMTI1ZDA0OGE3ZDA0NDNhYmZlZjkuLjBl MDhlZGZlMWIxMzhkZjBkOTBhYWQ1ZDJmNmU0OTliMTBhNzQ0NTEgMTAwNjQ0Ci0tLSBhL2NtYWtl L1dlYktpdEdlbmVyYXRvcnMuY21ha2UKKysrIGIvY21ha2UvV2ViS2l0R2VuZXJhdG9ycy5jbWFr ZQpAQCAtNzQsMTggKzc0LDE4IEBAIElGIChOT1QgR1BFUkZfRVhFQ1VUQUJMRSkKICAgTUVTU0FH RShGQVRBTF9FUlJPUiAiTWlzc2luZyBncGVyZiIpCiBFTkRJRiAoKQogRklORF9QQUNLQUdFX0hB TkRMRV9TVEFOREFSRF9BUkdTKEdQZXJmIERFRkFVTFRfTVNHIEdQRVJGX0VYRUNVVEFCTEUpCitT RVQoUEVSRl9IQVNIX0dFTkVSQVRPUiAke1dFQkNPUkVfRElSfS9tYWtlLWhhc2gtdG9vbHMucGwp CiAKICMgLSBDcmVhdGUgcGVyZmVjdCBoYXNoIHRhYmxlcyB1c2luZyBncGVyZgotIyBHRU5FUkFU RV9HUEVSRihleHRlbnNpb24gc291cmNlX2ZpbGUgZmluZF9mdW5jdGlvbiBncGVyZl9vcHRpb25z KQorIyBHRU5FUkFURV9HUEVSRihleHRlbnNpb24gc291cmNlX2ZpbGUpCiAjCi0jIFRoZSBnZW5l cmF0ZWQgZmlsZXMgbGl2ZXMgaW4gJHtERVJJVkVEX1NPVVJDRVNfRElSfSBhbmQgZW5kcyBpbiB0 aGUKLSMgZ2l2ZW4gZXh0ZW5zaW9uLgotTUFDUk8oR0VORVJBVEVfR1BFUkYgX2V4dCBfc291cmNl IF9mdW5jIF9vcHRzKQorIyBUaGUgZ2VuZXJhdGVkIGZpbGVzIGxpdmVzIGluICR7REVSSVZFRF9T T1VSQ0VTX0RJUn0gYW5kIGVuZHMgaW4gLmNwcAorTUFDUk8oR0VORVJBVEVfR1BFUkYgX3NvdXJj ZSkKICAgR0VUX0ZJTEVOQU1FX0NPTVBPTkVOVChfbmFtZSAke19zb3VyY2V9IE5BTUVfV0UpCiAg IEFERF9DVVNUT01fQ09NTUFORCgKLSAgICBPVVRQVVQgJHtERVJJVkVEX1NPVVJDRVNfRElSfS8k e19uYW1lfS4ke19leHR9CisgICAgT1VUUFVUICR7REVSSVZFRF9TT1VSQ0VTX0RJUn0vJHtfbmFt ZX0uY3BwCiAgICAgREVQRU5EUyAke19zb3VyY2V9Ci0gICAgQ09NTUFORCAke0dQRVJGX0VYRUNV VEFCTEV9IC1DREVHSW90IC1MIEFOU0ktQyAtayAqIC1zIDIgLU4gJHtfZnVuY30gJHtfb3B0c30g LS1vdXRwdXQtZmlsZT0ke0RFUklWRURfU09VUkNFU19ESVJ9LyR7X25hbWV9LiR7X2V4dH0gJHtf c291cmNlfQorICAgIENPTU1BTkQgJHtQRVJMX0VYRUNVVEFCTEV9ICR7UEVSRl9IQVNIX0dFTkVS QVRPUn0gJHtERVJJVkVEX1NPVVJDRVNfRElSfSAke19zb3VyY2V9CiAgICAgVkVSQkFUSU0pCiBF TkRNQUNSTyAoKQogCg==