40622 2010-06-15 08:18:54 -0700 Fix return values of functions returning bool instead of pointer 2011-06-09 20:48:43 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Other All RESOLVED DUPLICATE 40503 P2 Normal --- 1 lucas.de.marchi lucas.de.marchi barbieri commit-queue oldest_to_newest 238387 0 lucas.de.marchi 2010-06-15 08:18:54 -0700 Fix return values of functions returning bool instead of pointer 238389 1 58779 lucas.de.marchi 2010-06-15 08:20:16 -0700 Created attachment 58779 Patch 238391 2 lucas.de.marchi 2010-06-15 08:26:11 -0700 When compiling WebKit the following warnings were appearing: WebCore/inspector/InspectorValues.cpp: In member function ‘WTF::PassRefPtr<WebCore::InspectorArray> WebCore::InspectorObject::getArray(const WebCore::String&) const’: WebCore/inspector/InspectorValues.cpp:610:16: warning: converting ‘false’ to pointer type for argument 1 of ‘WTF::PassRefPtr<T>::PassRefPtr(T*) [with T = WebCore::InspectorArray]’ The patch sent fixes this issue. 238525 3 58779 levin 2010-06-15 13:47:40 -0700 Comment on attachment 58779 Patch > diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog > index caf28db0f3ab1d011b49ab785eea0623352db82f..9d744124996a7431e9b4f2ff81ed67a52061ce58 100644 > --- a/WebCore/ChangeLog > +++ b/WebCore/ChangeLog > @@ -1,3 +1,17 @@ > +2010-06-15 Lucas De Marchi <lucas.demarchi@profusion.mobi> > + > + Reviewed by NOBODY (OOPS!). > + > + Return 0 instead of false when functions return a pointer instead of > + a boolean value. > + https://bugs.webkit.org/show_bug.cgi?id=40622 > + > + No new tests since this just removes compiler warnings. Typically you'd say "No change in functionality so no new tests." 239754 4 58779 commit-queue 2010-06-17 22:01:14 -0700 Comment on attachment 58779 Patch Rejecting patch 58779 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/inspector/InspectorValues.cpp Hunk #1 FAILED at 599. Hunk #2 FAILED at 607. 2 out of 2 hunks FAILED -- saving rejects to file WebCore/inspector/InspectorValues.cpp.rej Full output: http://webkit-commit-queue.appspot.com/results/3341328 239859 5 lucas.de.marchi 2010-06-18 04:26:11 -0700 (In reply to comment #4) > (From update of attachment 58779 [details]) > Rejecting patch 58779 from commit-queue. > > Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 A similar patch was first on commit queue and was applied today. *** This bug has been marked as a duplicate of bug 40503 *** 418485 6 58779 lucas.de.marchi 2011-06-09 20:48:06 -0700 Comment on attachment 58779 Patch clearing flags. 58779 2010-06-15 08:20:16 -0700 2011-06-09 20:48:43 -0700 Patch bug-40622-20100615122056.patch text/plain 1565 lucas.de.marchi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2FmMjhkYjBmM2FiMWQwMTFiNDlhYjc4NWVlYTA2MjMzNTJkYjgyZi4uOWQ3NDQxMjQ5OTZhNzQz MWU5YjRmMmZmODFlZDY3YTUyMDYxY2U1OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNi0xNSAgTHVj YXMgRGUgTWFyY2hpICA8bHVjYXMuZGVtYXJjaGlAcHJvZnVzaW9uLm1vYmk+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmV0dXJuIDAgaW5zdGVhZCBv ZiBmYWxzZSB3aGVuIGZ1bmN0aW9ucyByZXR1cm4gYSBwb2ludGVyIGluc3RlYWQgb2YKKyAgICAg ICAgYSBib29sZWFuIHZhbHVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDA2MjIKKworICAgICAgICBObyBuZXcgdGVzdHMgc2luY2UgdGhpcyBqdXN0 IHJlbW92ZXMgY29tcGlsZXIgd2FybmluZ3MuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVj dG9yVmFsdWVzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck9iamVjdDo6Z2V0T2Jq ZWN0KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3Rvck9iamVjdDo6Z2V0QXJyYXkpOgorCiAy MDEwLTA2LTEwICBSYWluZSBNYWtlbGFpbmVuICA8cmFpbmUubWFrZWxhaW5lbkBub2tpYS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYg LS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JWYWx1ZXMuY3BwIGIvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yVmFsdWVzLmNwcAppbmRleCAyMzYxMmU2NzVhYjQ1NTA5ZDQzOWM5 NmMyOTIyNTZmOTEyMGZjOTY3Li5iYmQzNjY3Mzk1NWVjMTg1N2Q2ZTdjYWRhMjQxOTBmNzA2ODVi NzJhIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JWYWx1ZXMuY3BwCisr KyBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvclZhbHVlcy5jcHAKQEAgLTU5OSw3ICs1OTks NyBAQCBQYXNzUmVmUHRyPEluc3BlY3Rvck9iamVjdD4gSW5zcGVjdG9yT2JqZWN0OjpnZXRPYmpl Y3QoY29uc3QgU3RyaW5nJiBuYW1lKSBjb25zdAogewogICAgIFBhc3NSZWZQdHI8SW5zcGVjdG9y VmFsdWU+IHZhbHVlID0gZ2V0KG5hbWUpOwogICAgIGlmICghdmFsdWUpCi0gICAgICAgIHJldHVy biBmYWxzZTsKKyAgICAgICAgcmV0dXJuIDA7CiAgICAgcmV0dXJuIHZhbHVlLT5hc09iamVjdCgp OwogfQogCkBAIC02MDcsNyArNjA3LDcgQEAgUGFzc1JlZlB0cjxJbnNwZWN0b3JBcnJheT4gSW5z cGVjdG9yT2JqZWN0OjpnZXRBcnJheShjb25zdCBTdHJpbmcmIG5hbWUpIGNvbnN0CiB7CiAgICAg UGFzc1JlZlB0cjxJbnNwZWN0b3JWYWx1ZT4gdmFsdWUgPSBnZXQobmFtZSk7CiAgICAgaWYgKCF2 YWx1ZSkKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICByZXR1cm4gMDsKICAgICByZXR1 cm4gdmFsdWUtPmFzQXJyYXkoKTsKIH0KIAo=