4062 2005-07-18 15:01:35 -0700 Word completion doesn't work at end of word (unless last word) 2005-11-28 14:39:53 -0800 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 duncan hyatt ap oldest_to_newest 14852 0 duncan 2005-07-18 15:01:35 -0700 Pressing cmd+esc will invoke the webview complete: method, that will popup a list of words that complete the text typed so far. This functionality only works if you hit cmd-esc after the last word on the page, or if you type cmd-esc while within a word. It doesn't work if you hit cmd-esc at the end of a word that is not the last one. In the attached sample hit cmd-esc when the cursor is just after "one", you will get a NSBeep(). If you hit cmd-esc with the cursor after "three" it will work. A rough guess is that this happens because -[WebTextCompleteController doCompletion] is calling [bridge rangeByExpandingSelectionWithGranularity:WebSelectByWord] that doesn't work when a space follows the cursor. The spelling suggestion functionality appears to be filtered away by safari, so it's not testable with a plain web page. 14854 1 3007 duncan 2005-07-18 15:07:32 -0700 Created attachment 3007 test case Create a cocoa app in xcode, replace main.m with the attachment and add the WebKit.framework to the project. 23004 2 ap 2005-10-26 12:49:49 -0700 Confirmed with ToT (running Blot) 23072 3 4490 ap 2005-10-27 12:12:48 -0700 Created attachment 4490 proposed patch (use rangeByAlteringCurrentSelection) I have also thought about changing rangeByExpandingSelectionWithGranularity: to work in this case, but this seems to require quite a number of changes to how a selection's affinity is set in various places, which may or may not be desirable... 23073 4 4491 ap 2005-10-27 12:14:11 -0700 Created attachment 4491 proposed patch (use rangeByAlteringCurrentSelection) An unrelated change sneaked into the patch... 23095 5 4491 darin 2005-10-27 21:47:12 -0700 Comment on attachment 4491 proposed patch (use rangeByAlteringCurrentSelection) Looks fine. r=me 3007 2005-07-18 15:07:32 -0700 2005-07-18 15:07:32 -0700 test case main.m text/plain 1467 duncan I2ltcG9ydCA8Q29jb2EvQ29jb2EuaD4KI2ltcG9ydCA8V2ViS2l0L1dlYktpdC5oPgoKQGludGVy ZmFjZSBUZXN0IDogTlNPYmplY3QKQGVuZAoKQGltcGxlbWVudGF0aW9uIFRlc3QKLSAoQk9PTCl3 ZWJWaWV3OihXZWJWaWV3ICopd2ViVmlldwogc2hvdWxkSW5zZXJ0VGV4dDooTlNTdHJpbmcgKil0 ZXh0CiByZXBsYWNpbmdET01SYW5nZTooRE9NUmFuZ2UgKilyYW5nZQoJZ2l2ZW5BY3Rpb246KFdl YlZpZXdJbnNlcnRBY3Rpb24pYWN0aW9uCnsKCU5TTXV0YWJsZVN0cmluZyAqY2hhbmdlZCA9IFtO U011dGFibGVTdHJpbmcgc3RyaW5nV2l0aFN0cmluZzp0ZXh0XTsKCVtjaGFuZ2VkIHJlcGxhY2VP Y2N1cnJlbmNlc09mU3RyaW5nOkAiZSIgd2l0aFN0cmluZzpAImkiIG9wdGlvbnM6MCByYW5nZTpO U01ha2VSYW5nZSgwLCBbY2hhbmdlZCBsZW5ndGhdKV07Cglbd2ViVmlldyByZXBsYWNlU2VsZWN0 aW9uV2l0aFRleHQ6Y2hhbmdlZF07CiAgICBET01SYW5nZSAqciA9IFt3ZWJWaWV3IHNlbGVjdGVk RE9NUmFuZ2VdOwogICAgW3IgY29sbGFwc2U6Tk9dOwogICAgW3dlYlZpZXcgc2V0U2VsZWN0ZWRE T01SYW5nZTpyIGFmZmluaXR5Ok5TU2VsZWN0aW9uQWZmaW5pdHlVcHN0cmVhbV07CglyZXR1cm4g Tk87Cn0KCi0gKHZvaWQpd2ViVmlld0RpZENoYW5nZTooTlNOb3RpZmljYXRpb24gKilub3RpZmlj YXRpb24KewoJTlNMb2coQCJ3ZWJWaWV3RGlkQ2hhbmdlIik7Cn0KQGVuZAoKaW50IG1haW4oaW50 IGFyZ2MsIGNoYXIgKmFyZ3ZbXSkKewoJTlNBdXRvcmVsZWFzZVBvb2wgKnBvb2wgPSBbW05TQXV0 b3JlbGVhc2VQb29sIGFsbG9jXSBpbml0XTsKCVRlc3QgKnQgPSBbW1Rlc3QgYWxsb2NdIGluaXRd OwoJW05TQXBwbGljYXRpb24gc2hhcmVkQXBwbGljYXRpb25dOwoJTlNSZWN0IGNvbnRlbnRSZWN0 ID0gTlNNYWtlUmVjdCgyMDAsIDE4MCwgMzAwLCAzMDApOwoJTlNSZWN0IHd2UmVjdCA9IE5TTWFr ZVJlY3QoMCwgMCwgMzAwLCAzMDApOwoJTlNXaW5kb3cgKncgPSBbW05TV2luZG93IGFsbG9jXSBp bml0V2l0aENvbnRlbnRSZWN0OmNvbnRlbnRSZWN0CgkJc3R5bGVNYXNrOk5TTWluaWF0dXJpemFi bGVXaW5kb3dNYXNrIHwgTlNDbG9zYWJsZVdpbmRvd01hc2sgfCBOU1RpdGxlZFdpbmRvd01hc2sK CQliYWNraW5nOk5TQmFja2luZ1N0b3JlQnVmZmVyZWQgZGVmZXI6Tk9dOwoJV2ViVmlldyAqd3Yg PSBbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6d3ZSZWN0XTsKCVtbdyBjb250ZW50Vmll d10gYWRkU3Vidmlldzp3dl07Cglbd3Ygc2V0RWRpdGFibGU6WUVTXTsKCVt3diBzZXRFZGl0aW5n RGVsZWdhdGU6dF07CglbW3d2IG1haW5GcmFtZV0gbG9hZEhUTUxTdHJpbmc6QCI8aHRtbD48Ym9k eT48cD5vbmUgdHdvIHRocmVlPC9wPjwvYm9keT48L2h0bWw+IiBiYXNlVVJMOm5pbF07CglbdyBt YWtlS2V5QW5kT3JkZXJGcm9udDpuaWxdOwoJW05TQXBwIHJ1bl07Cn0K 4490 2005-10-27 12:12:48 -0700 2005-10-27 12:14:11 -0700 proposed patch (use rangeByAlteringCurrentSelection) WordCompletionPatch.txt text/plain 3561 ap SW5kZXg6IFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0sdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNDc3CmRpZmYgLXAgLXUgLXIxLjQ3NyBXZWJWaWV3LnN1YnByb2ovV2Vi SFRNTFZpZXcubQotLS0gV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0JMjQgT2N0IDIwMDUg MDI6MTM6MTggLTAwMDAJMS40NzcKKysrIFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCTI3 IE9jdCAyMDA1IDE5OjA3OjQ5IC0wMDAwCkBAIC00ODc4LDMxICs0ODc4LDQxIEBAIHN0YXRpYyBO U0FycmF5ICp2YWxpZEF0dHJpYnV0ZXMgPSBuaWw7CiAKIC0gKHVuc2lnbmVkIGludCljaGFyYWN0 ZXJJbmRleEZvclBvaW50OihOU1BvaW50KXRoZVBvaW50CiB7Ci0gICAgRVJST1IoIlRFWFRJTlBV VDogY2hhcmFjdGVySW5kZXhGb3JQb2ludDogbm90IHlldCBpbXBsZW1lbnRlZCIpOwotICAgIHJl dHVybiAwOworICAgIE5TV2luZG93ICp3aW5kb3cgPSBbc2VsZiB3aW5kb3ddOworICAgIFdlYkJy aWRnZSAqYnJpZGdlID0gW3NlbGYgX2JyaWRnZV07CisKKyAgICBpZiAod2luZG93KQorICAgICAg ICB0aGVQb2ludCA9IFt3aW5kb3cgY29udmVydFNjcmVlblRvQmFzZTp0aGVQb2ludF07CisgICAg dGhlUG9pbnQgPSBbc2VsZiBjb252ZXJ0UG9pbnQ6dGhlUG9pbnQgZnJvbVZpZXc6bmlsXTsKKwor ICAgIERPTVJhbmdlICpyYW5nZSA9IFticmlkZ2UgY2hhcmFjdGVyUmFuZ2VBdFBvaW50OnRoZVBv aW50XTsKKyAgICBpZiAoIXJhbmdlKQorICAgICAgICByZXR1cm4gTlNOb3RGb3VuZDsKKyAgICAK KyAgICByZXR1cm4gW2JyaWRnZSBjb252ZXJ0RE9NUmFuZ2VUb05TUmFuZ2U6cmFuZ2VdLmxvY2F0 aW9uOwogfQogCiAtIChOU1JlY3QpZmlyc3RSZWN0Rm9yQ2hhcmFjdGVyUmFuZ2U6KE5TUmFuZ2Up dGhlUmFuZ2UKIHsKICAgICBXZWJCcmlkZ2UgKmJyaWRnZSA9IFtzZWxmIF9icmlkZ2VdOwogICAg IAotICAgIERPTVJhbmdlICpyYW5nZTsKKyAgICAvLyBKdXN0IHRvIG1hdGNoIE5TVGV4dFZpZXcn cyBiZWhhdmlvci4gUmVncmVzc2lvbiB0ZXN0cyBjYW5ub3QgZGV0ZWN0IHRoaXM7CisgICAgLy8g dG8gcmVwcm9kdWNlLCB1c2UgYSB0ZXN0IGFwcGxpY2F0aW9uIGZyb20gaHR0cDovL2J1Z3ppbGxh Lm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD00NjgyCisgICAgLy8gKHR5cGUgc29tZXRo aW5nOyBzZXQgc3RhcnQ9MSwgbGVuZ3RoPS0xKS4KKyAgICBpZiAoKHRoZVJhbmdlLmxvY2F0aW9u ICsgdGhlUmFuZ2UubGVuZ3RoIDwgdGhlUmFuZ2UubG9jYXRpb24pICYmICh0aGVSYW5nZS5sb2Nh dGlvbiArIHRoZVJhbmdlLmxlbmd0aCAhPSAwKSkKKyAgICAgICAgdGhlUmFuZ2UubGVuZ3RoID0g MDsKICAgICAKLSAgICBpZiAoW3NlbGYgaGFzTWFya2VkVGV4dF0pIHsKLSAgICAgICAgcmFuZ2Ug PSBbYnJpZGdlIGNvbnZlcnRUb09iakNET01SYW5nZTp0aGVSYW5nZV07Ci0gICAgfQotICAgIGVs c2UgewotICAgICAgICByYW5nZSA9IFtzZWxmIF9zZWxlY3RlZFJhbmdlXTsKLSAgICB9CisgICAg RE9NUmFuZ2UgKnJhbmdlID0gW2JyaWRnZSBjb252ZXJ0TlNSYW5nZVRvRE9NUmFuZ2U6dGhlUmFu Z2VdOworICAgIGlmICghcmFuZ2UpCisgICAgICAgIHJldHVybiBOU01ha2VSZWN0KDAsMCwwLDAp OworICAgIAorICAgIE5TUmVjdCByZXN1bHRSZWN0ID0gW2JyaWRnZSBmaXJzdFJlY3RGb3JET01S YW5nZTpyYW5nZV07CisgICAgcmVzdWx0UmVjdCA9IFtzZWxmIGNvbnZlcnRSZWN0OnJlc3VsdFJl Y3QgdG9WaWV3Om5pbF07CisKKyAgICBOU1dpbmRvdyAqd2luZG93ID0gW3NlbGYgd2luZG93XTsK KyAgICBpZiAod2luZG93KQorICAgICAgICByZXN1bHRSZWN0Lm9yaWdpbiA9IFt3aW5kb3cgY29u dmVydEJhc2VUb1NjcmVlbjpyZXN1bHRSZWN0Lm9yaWdpbl07CiAgICAgCi0gICAgTlNSZWN0IHJl c3VsdFJlY3Q7Ci0gICAgaWYgKFtyYW5nZSBzdGFydENvbnRhaW5lcl0pIHsKLSAgICAgICAgcmVz dWx0UmVjdCA9IFtzZWxmIGNvbnZlcnRSZWN0OlticmlkZ2UgZmlyc3RSZWN0Rm9yRE9NUmFuZ2U6 cmFuZ2VdIHRvVmlldzpuaWxdOwotICAgICAgICByZXN1bHRSZWN0Lm9yaWdpbiA9IFtbc2VsZiB3 aW5kb3ddIGNvbnZlcnRCYXNlVG9TY3JlZW46cmVzdWx0UmVjdC5vcmlnaW5dOwotICAgIH0KLSAg ICBlbHNlIHsKLSAgICAgICAgcmVzdWx0UmVjdCA9IE5TTWFrZVJlY3QoMCwwLDAsMCk7Ci0gICAg fQogICAgIHJldHVybiByZXN1bHRSZWN0OwogfQogCkBAIC00OTI4LDggKzQ5MzgsMTIgQEAgc3Rh dGljIE5TQXJyYXkgKnZhbGlkQXR0cmlidXRlcyA9IG5pbDsKIAogLSAoTlNBdHRyaWJ1dGVkU3Ry aW5nICopYXR0cmlidXRlZFN1YnN0cmluZ0Zyb21SYW5nZTooTlNSYW5nZSl0aGVSYW5nZQogewot ICAgIEVSUk9SKCJURVhUSU5QVVQ6IGF0dHJpYnV0ZWRTdWJzdHJpbmdGcm9tUmFuZ2U6IG5vdCB5 ZXQgaW1wbGVtZW50ZWQiKTsKLSAgICByZXR1cm4gbmlsOworICAgIFdlYkJyaWRnZSAqYnJpZGdl ID0gW3NlbGYgX2JyaWRnZV07CisgICAgRE9NUmFuZ2UgKnJhbmdlID0gW2JyaWRnZSBjb252ZXJ0 TlNSYW5nZVRvRE9NUmFuZ2U6dGhlUmFuZ2VdOworICAgIGlmICghcmFuZ2UpCisgICAgICAgIHJl dHVybiBuaWw7CisgICAgCisgICAgcmV0dXJuIFticmlkZ2UgYXR0cmlidXRlZFN0cmluZ0Zyb206 W3JhbmdlIHN0YXJ0Q29udGFpbmVyXSBzdGFydE9mZnNldDpbcmFuZ2Ugc3RhcnRPZmZzZXRdIHRv OltyYW5nZSBlbmRDb250YWluZXJdIGVuZE9mZnNldDpbcmFuZ2UgZW5kT2Zmc2V0XV07CiB9CiAK IC8vIHRlc3QgZm9yIDEwLjQgYmVjYXVzZSBvZiA8cmRhcjovL3Byb2JsZW0vNDI0MzQ2Mz4KQEAg LTUyODQsNyArNTI5OCw3IEBAIHN0YXRpYyBOU0FycmF5ICp2YWxpZEF0dHJpYnV0ZXMgPSBuaWw7 CiAgICAgICAgIC8vIEdldCBwcmVjZWVkaW5nIHdvcmQgc3RlbQogICAgICAgICBXZWJCcmlkZ2Ug KmJyaWRnZSA9IFtfdmlldyBfYnJpZGdlXTsKICAgICAgICAgRE9NUmFuZ2UgKnNlbGVjdGlvbiA9 IFticmlkZ2Ugc2VsZWN0ZWRET01SYW5nZV07Ci0gICAgICAgIERPTVJhbmdlICp3aG9sZVdvcmQg PSBbYnJpZGdlIHJhbmdlQnlFeHBhbmRpbmdTZWxlY3Rpb25XaXRoR3JhbnVsYXJpdHk6V2ViQnJp ZGdlU2VsZWN0QnlXb3JkXTsKKyAgICAgICAgRE9NUmFuZ2UgKndob2xlV29yZCA9IFticmlkZ2Ug cmFuZ2VCeUFsdGVyaW5nQ3VycmVudFNlbGVjdGlvbjpXZWJTZWxlY3RCeUV4dGVuZGluZyBkaXJl Y3Rpb246V2ViQnJpZGdlU2VsZWN0QmFja3dhcmQgZ3JhbnVsYXJpdHk6V2ViQnJpZGdlU2VsZWN0 QnlXb3JkXTsKICAgICAgICAgRE9NUmFuZ2UgKnByZWZpeCA9IFt3aG9sZVdvcmQgY2xvbmVSYW5n ZV07CiAgICAgICAgIFtwcmVmaXggc2V0RW5kOltzZWxlY3Rpb24gc3RhcnRDb250YWluZXJdIDpb c2VsZWN0aW9uIHN0YXJ0T2Zmc2V0XV07CiAK 4491 2005-10-27 12:14:11 -0700 2005-10-27 21:47:12 -0700 proposed patch (use rangeByAlteringCurrentSelection) WordCompletionPatch.txt text/plain 967 ap SW5kZXg6IFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6 IC9jdnMvcm9vdC9XZWJLaXQvV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0sdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuNDc3CmRpZmYgLXAgLXUgLXIxLjQ3NyBXZWJWaWV3LnN1YnByb2ovV2Vi SFRNTFZpZXcubQotLS0gV2ViVmlldy5zdWJwcm9qL1dlYkhUTUxWaWV3Lm0JMjQgT2N0IDIwMDUg MDI6MTM6MTggLTAwMDAJMS40NzcKKysrIFdlYlZpZXcuc3VicHJvai9XZWJIVE1MVmlldy5tCTI3 IE9jdCAyMDA1IDE5OjA3OjQ5IC0wMDAwCkBAIC01Mjg0LDcgKzUyOTgsNyBAQCBzdGF0aWMgTlNB cnJheSAqdmFsaWRBdHRyaWJ1dGVzID0gbmlsOwogICAgICAgICAvLyBHZXQgcHJlY2VlZGluZyB3 b3JkIHN0ZW0KICAgICAgICAgV2ViQnJpZGdlICpicmlkZ2UgPSBbX3ZpZXcgX2JyaWRnZV07CiAg ICAgICAgIERPTVJhbmdlICpzZWxlY3Rpb24gPSBbYnJpZGdlIHNlbGVjdGVkRE9NUmFuZ2VdOwot ICAgICAgICBET01SYW5nZSAqd2hvbGVXb3JkID0gW2JyaWRnZSByYW5nZUJ5RXhwYW5kaW5nU2Vs ZWN0aW9uV2l0aEdyYW51bGFyaXR5OldlYkJyaWRnZVNlbGVjdEJ5V29yZF07CisgICAgICAgIERP TVJhbmdlICp3aG9sZVdvcmQgPSBbYnJpZGdlIHJhbmdlQnlBbHRlcmluZ0N1cnJlbnRTZWxlY3Rp b246V2ViU2VsZWN0QnlFeHRlbmRpbmcgZGlyZWN0aW9uOldlYkJyaWRnZVNlbGVjdEJhY2t3YXJk IGdyYW51bGFyaXR5OldlYkJyaWRnZVNlbGVjdEJ5V29yZF07CiAgICAgICAgIERPTVJhbmdlICpw cmVmaXggPSBbd2hvbGVXb3JkIGNsb25lUmFuZ2VdOwogICAgICAgICBbcHJlZml4IHNldEVuZDpb c2VsZWN0aW9uIHN0YXJ0Q29udGFpbmVyXSA6W3NlbGVjdGlvbiBzdGFydE9mZnNldF1dOwogCg==