40606 2010-06-14 19:55:06 -0700 Fix compilation errors in BlobBuilder with FILE_WRITER enabled 2010-06-15 16:36:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kinuko webkit-unassigned jianli oldest_to_newest 238209 0 kinuko 2010-06-14 19:55:06 -0700 There're some compilation erros in BlobBuilder when it's built with FILE_WRITER_ENABLED flag. 238214 1 58743 kinuko 2010-06-14 20:10:42 -0700 Created attachment 58743 Patch 238250 2 58743 levin 2010-06-14 23:21:28 -0700 Comment on attachment 58743 Patch WebCore/ChangeLog:1 + 2010-06-14 Kinuko Yasuda <kinuko@kinuko2-macpro.mtv.corp.google.com> The email address needs to be fixed. WebCore/ChangeLog:8 + No new tests. This should explain why no new tests were added. For example: "No functionality change so no new tests." WebCore/html/BlobBuilder.h:38 + #include "PlatformString.h" Actually why is PlatformString.h included? (Can't a forward declaration for String suffice?) WebCore/html/BlobBuilder.h:41 + #include <wtf/text/CString.h> I believe you're including this due to the destructor needing it. If you explicitly define the destructor for BlobBuilder or even ~StringBlobItem and put it in a cpp file, then this include shouldn't be needed. But this header already "#include BlobItem.h" which "#include <wtf/text/CString.h>", so it is unclear why this is needed to fix the build. WebCore/html/BlobBuilder.h: 43 + class ExceptionCode; Typically Exception code is defined like this: typedef int ExceptionCode; and ExceptionCode.h isn't included. (Also if you add this line, it should come after the class Blob; forward declaration.) 238270 3 58761 kinuko 2010-06-15 00:12:52 -0700 Created attachment 58761 Patch 238271 4 kinuko 2010-06-15 00:20:23 -0700 Thanks for reviewing; the patch was a bit rough. (In reply to comment #2) > (From update of attachment 58743 [details]) > WebCore/ChangeLog:1 > + 2010-06-14 Kinuko Yasuda <kinuko@kinuko2-macpro.mtv.corp.google.com> > The email address needs to be fixed. Fixed. > WebCore/ChangeLog:8 > + No new tests. > This should explain why no new tests were added. For example: > "No functionality change so no new tests." Fixed. > WebCore/html/BlobBuilder.h:38 > + #include "PlatformString.h" > WebCore/html/BlobBuilder.h:41 > + #include <wtf/text/CString.h> Both lines weren't necessary. Removed them and added a forward declaration for String. (I had needed to include wtf/text/CString.h because I had included PlatformString.h that wasn't really necessary.) > WebCore/html/BlobBuilder.h: 43 > + class ExceptionCode; > > Typically Exception code is defined like this: > typedef int ExceptionCode; > and ExceptionCode.h isn't included. (Also if you add this line, it should come after the class Blob; forward declaration.) Right, the forward declaration actually didn't work (so I had removed the line and added '#include "BlobBuilder.h"' in the previous patch). I replaced the line with a typedef. 238339 5 58761 levin 2010-06-15 05:51:50 -0700 Comment on attachment 58761 Patch \ 238608 6 kinuko 2010-06-15 16:36:24 -0700 Committed r61225: <http://trac.webkit.org/changeset/61225> 58743 2010-06-14 20:10:42 -0700 2010-06-15 00:12:48 -0700 Patch bug-40606-20100614201041.patch text/plain 1579 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjVjNDBhYzQ4NGZhNTY4ZmI0OTRmZDk3M2VkNjMzYzY0ODk5NGVkMC4uMDE2ZmYyM2EyMjI5YWVj ZGMyNjNkMjA4Y2YyMDFiNDc0Y2E5MDllMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0xNCAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0BraW51a28yLW1hY3Byby5tdHYuY29ycC5nb29nbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBjb21w aWxhdGlvbiBlcnJvcnMgaW4gQmxvYkJ1aWxkZXIgd2l0aCBGSUxFX1dSSVRFUiBlbmFibGVkCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDYwNgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIGh0bWwvQmxvYkJ1aWxkZXIuY3BwOgor ICAgICAgICAqIGh0bWwvQmxvYkJ1aWxkZXIuaDoKKwogMjAxMC0wNi0xNCAgRHVtaXRydSBEYW5p bGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGJ1aWxkIGZp eC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9CbG9iQnVpbGRlci5jcHAgYi9XZWJDb3JlL2h0 bWwvQmxvYkJ1aWxkZXIuY3BwCmluZGV4IDA4MDA1NzNiZmY4ZTM2OTI2ZjNlYTJlMzRlMDAyM2Fh N2M0NDU3NWEuLjBjZjdmNTAwN2JkYzNhNjk1ZjZmZWJlNmM4YWE4YjkzN2I0NmI5ZmQgMTAwNjQ0 Ci0tLSBhL1dlYkNvcmUvaHRtbC9CbG9iQnVpbGRlci5jcHAKKysrIGIvV2ViQ29yZS9odG1sL0Js b2JCdWlsZGVyLmNwcApAQCAtMzcsNyArMzcsNiBAQAogI2luY2x1ZGUgIkF0b21pY1N0cmluZy5o IgogI2luY2x1ZGUgIkJsb2IuaCIKICNpbmNsdWRlICJUZXh0RW5jb2RpbmcuaCIKLSNpbmNsdWRl IDx3dGYvdGV4dC9DU3RyaW5nLmg+CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIApkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9odG1sL0Jsb2JCdWlsZGVyLmggYi9XZWJDb3JlL2h0bWwvQmxvYkJ1aWxkZXIu aAppbmRleCA2NzFhNTVlNjhlMGU3MjJmN2E2OTk1MjcwY2U3ZDAzNjVkOWFlOGMwLi4yMjQyOTY1 MmU0Njg5NjRkYTRmNjQwMWQxNjU1YWQyYTIyYjllYTAwIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0 bWwvQmxvYkJ1aWxkZXIuaAorKysgYi9XZWJDb3JlL2h0bWwvQmxvYkJ1aWxkZXIuaApAQCAtMzQs MTMgKzM0LDE0IEBACiAjaWYgRU5BQkxFKEZJTEVfV1JJVEVSKQogCiAjaW5jbHVkZSAiQmxvYkl0 ZW0uaCIKKyNpbmNsdWRlICJFeGNlcHRpb25Db2RlLmgiCiAjaW5jbHVkZSAiUGxhdGZvcm1TdHJp bmcuaCIKICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgogI2luY2x1ZGUgPHd0Zi9SZWZDb3Vu dGVkLmg+CisjaW5jbHVkZSA8d3RmL3RleHQvQ1N0cmluZy5oPgogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKLWNsYXNzIEV4Y2VwdGlvbkNvZGU7CiBjbGFzcyBCbG9iOwogCiBjbGFzcyBCbG9iQnVp bGRlciA6IHB1YmxpYyBSZWZDb3VudGVkPEJsb2JCdWlsZGVyPiB7Cg== 58761 2010-06-15 00:12:52 -0700 2010-06-15 11:50:57 -0700 Patch bug-40606-20100615001251.patch text/plain 1649 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjVjNDBhYzQ4NGZhNTY4ZmI0OTRmZDk3M2VkNjMzYzY0ODk5NGVkMC4uMWIzZDM2NDQ2YzE3YzQw Y2RmOTBkNmY0ODI4YmYzN2I2MzViNWEyYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0xNCAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIGVycm9ycyBpbiBCbG9i QnVpbGRlciB3aXRoIEZJTEVfV1JJVEVSIGVuYWJsZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNjA2CisKKyAgICAgICAgTm8gZnVuY3Rpb25hbGl0 eSBjaGFuZ2Ugc28gbm8gbmV3IHRlc3RzLgorCisgICAgICAgICogaHRtbC9CbG9iQnVpbGRlci5j cHA6CisgICAgICAgICogaHRtbC9CbG9iQnVpbGRlci5oOgorCiAyMDEwLTA2LTE0ICBEdW1pdHJ1 IERhbmlsaXVjICA8ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVp bGQgZml4LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0Jsb2JCdWlsZGVyLmNwcCBiL1dlYkNv cmUvaHRtbC9CbG9iQnVpbGRlci5jcHAKaW5kZXggMDgwMDU3M2JmZjhlMzY5MjZmM2VhMmUzNGUw MDIzYWE3YzQ0NTc1YS4uMGNmN2Y1MDA3YmRjM2E2OTVmNmZlYmU2YzhhYThiOTM3YjQ2YjlmZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL0Jsb2JCdWlsZGVyLmNwcAorKysgYi9XZWJDb3JlL2h0 bWwvQmxvYkJ1aWxkZXIuY3BwCkBAIC0zNyw3ICszNyw2IEBACiAjaW5jbHVkZSAiQXRvbWljU3Ry aW5nLmgiCiAjaW5jbHVkZSAiQmxvYi5oIgogI2luY2x1ZGUgIlRleHRFbmNvZGluZy5oIgotI2lu Y2x1ZGUgPHd0Zi90ZXh0L0NTdHJpbmcuaD4KIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvQmxvYkJ1aWxkZXIuaCBiL1dlYkNvcmUvaHRtbC9CbG9iQnVp bGRlci5oCmluZGV4IDY3MWE1NWU2OGUwZTcyMmY3YTY5OTUyNzBjZTdkMDM2NWQ5YWU4YzAuLjBk NDM0YTMwNDFlMmZkMzBjYTUxNWU0OTgyYjU3MzJmZjkzNWY0OGYgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaHRtbC9CbG9iQnVpbGRlci5oCisrKyBiL1dlYkNvcmUvaHRtbC9CbG9iQnVpbGRlci5oCkBA IC0zNCwxNSArMzQsMTUgQEAKICNpZiBFTkFCTEUoRklMRV9XUklURVIpCiAKICNpbmNsdWRlICJC bG9iSXRlbS5oIgotI2luY2x1ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAjaW5jbHVkZSA8d3RmL1Bh c3NSZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRlZC5oPgogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLWNsYXNzIEV4Y2VwdGlvbkNvZGU7CiBjbGFzcyBCbG9iOwogCit0eXBlZGVmIGlu dCBFeGNlcHRpb25Db2RlOworCiBjbGFzcyBCbG9iQnVpbGRlciA6IHB1YmxpYyBSZWZDb3VudGVk PEJsb2JCdWlsZGVyPiB7CiBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NSZWZQdHI8QmxvYkJ1aWxk ZXI+IGNyZWF0ZSgpIHsgcmV0dXJuIGFkb3B0UmVmKG5ldyBCbG9iQnVpbGRlcigpKTsgfQo=