40603 2010-06-14 18:14:44 -0700 Remove input parameter validation for "level" upper limit in *tex* functions 2010-06-17 09:39:52 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 38145 1 zmo zmo cmarrin commit-queue dglazkov gman kbr levin oliver oldest_to_newest 238177 0 zmo 2010-06-14 18:14:44 -0700 According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE). It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE). In this case, we should remove the code that checks the level upper limit. 238186 1 58738 zmo 2010-06-14 18:24:56 -0700 Created attachment 58738 patch 238264 2 levin 2010-06-15 00:00:10 -0700 (In reply to comment #0) > According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE). It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE). > > In this case, we should remove the code that checks the level upper limit. Would have been nice to say some version of this in the ChangeLog (imo) as it would help anyone trying to understand why the change was done. Regardless, at least it is in the bug so they can't find it if needed. 239425 3 58738 commit-queue 2010-06-17 09:39:48 -0700 Comment on attachment 58738 patch Clearing flags on attachment: 58738 Committed r61332: <http://trac.webkit.org/changeset/61332> 239426 4 commit-queue 2010-06-17 09:39:52 -0700 All reviewed patches have been landed. Closing bug. 58738 2010-06-14 18:24:56 -0700 2010-06-17 09:39:48 -0700 patch level.patch text/plain 2088 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTE2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDYtMTQgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg aW5wdXQgcGFyYW1ldGVyIHZhbGlkYXRpb24gZm9yICJsZXZlbCIgdXBwZXIgbGltaXQgaW4gKnRl eCogZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MDYwMworCisgICAgICAgICogaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYkdMUmVuZGVyaW5nQ29udGV4dDo6dmFsaWRhdGVU ZXhGdW5jUGFyYW1ldGVycyk6IERvbid0IGNoZWNrIGZvciAibGV2ZWwiIHVwcGVyIGxpbWl0Lgor CiAyMDEwLTA2LTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAg VW5yZXZpZXdlZC4KSW5kZXg6IFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250 ZXh0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5jcHAJKHJldmlzaW9uIDYxMTMyKQorKysgV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJH TFJlbmRlcmluZ0NvbnRleHQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Miw3ICs1Miw2IEBACiAj aW5jbHVkZSAiV2ViR0xVbmlmb3JtTG9jYXRpb24uaCIKIAogI2luY2x1ZGUgPHd0Zi9CeXRlQXJy YXkuaD4KLSNpbmNsdWRlIDx3dGYvTWF0aEV4dHJhcy5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKQEAgLTMzNzUsOSArMzM3NCw3IEBAIGJvb2wgV2ViR0xSZW5kZXJpbmdDb250ZXh0Ojp2YWxp ZGF0ZVRleEYKIAogICAgIHN3aXRjaCAodGFyZ2V0KSB7CiAgICAgY2FzZSBHcmFwaGljc0NvbnRl eHQzRDo6VEVYVFVSRV8yRDoKLSAgICAgICAgaWYgKHdpZHRoID4gbV9tYXhUZXh0dXJlU2l6ZSB8 fAotICAgICAgICAgICAgaGVpZ2h0ID4gbV9tYXhUZXh0dXJlU2l6ZSB8fAotICAgICAgICAgICAg bGV2ZWwgPiBsb2coc3RhdGljX2Nhc3Q8ZG91YmxlPihtX21heFRleHR1cmVTaXplKSkgLyBsb2co Mi4wKSkgeworICAgICAgICBpZiAod2lkdGggPiBtX21heFRleHR1cmVTaXplIHx8IGhlaWdodCA+ IG1fbWF4VGV4dHVyZVNpemUpIHsKICAgICAgICAgICAgIG1fY29udGV4dC0+c3ludGhlc2l6ZUdM RXJyb3IoR3JhcGhpY3NDb250ZXh0M0Q6OklOVkFMSURfVkFMVUUpOwogICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOwogICAgICAgICB9CkBAIC0zMzg4LDkgKzMzODUsNyBAQCBib29sIFdlYkdMUmVu ZGVyaW5nQ29udGV4dDo6dmFsaWRhdGVUZXhGCiAgICAgY2FzZSBHcmFwaGljc0NvbnRleHQzRDo6 VEVYVFVSRV9DVUJFX01BUF9ORUdBVElWRV9ZOgogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6 OlRFWFRVUkVfQ1VCRV9NQVBfUE9TSVRJVkVfWjoKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNE OjpURVhUVVJFX0NVQkVfTUFQX05FR0FUSVZFX1o6Ci0gICAgICAgIGlmICh3aWR0aCAhPSBoZWln aHQgfHwKLSAgICAgICAgICAgIHdpZHRoID4gbV9tYXhDdWJlTWFwVGV4dHVyZVNpemUgfHwKLSAg ICAgICAgICAgIGxldmVsID4gbG9nKHN0YXRpY19jYXN0PGRvdWJsZT4obV9tYXhDdWJlTWFwVGV4 dHVyZVNpemUpKSAvIGxvZygyLjApKSB7CisgICAgICAgIGlmICh3aWR0aCAhPSBoZWlnaHQgfHwg d2lkdGggPiBtX21heEN1YmVNYXBUZXh0dXJlU2l6ZSkgewogICAgICAgICAgICAgbV9jb250ZXh0 LT5zeW50aGVzaXplR0xFcnJvcihHcmFwaGljc0NvbnRleHQzRDo6SU5WQUxJRF9WQUxVRSk7CiAg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0K