40580 2010-06-14 11:54:03 -0700 [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop. 2010-08-10 22:40:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken webkit-unassigned commit-queue hausmann jedrzej.nowacki oldest_to_newest 237960 0 agbakken 2010-06-14 11:54:03 -0700 [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop. 237964 1 58679 agbakken 2010-06-14 11:56:52 -0700 Created attachment 58679 Patch 237968 2 58680 agbakken 2010-06-14 12:04:30 -0700 Created attachment 58680 Patch 238341 3 jedrzej.nowacki 2010-06-15 05:59:57 -0700 Are you sure that we need to keep this function for different define values? Maybe we can remove it completely. According to an information in comment it should be safely to remove the function, because the bug (http://bugreports.qt.nokia.com/browse/QTBUG-7578) is closed. Simon what do you think? 262997 4 58680 abarth 2010-08-10 22:10:26 -0700 Comment on attachment 58680 Patch This patch looks ready to land. 263022 5 58680 commit-queue 2010-08-10 22:40:22 -0700 Comment on attachment 58680 Patch Clearing flags on attachment: 58680 Committed r65124: <http://trac.webkit.org/changeset/65124> 263023 6 commit-queue 2010-08-10 22:40:26 -0700 All reviewed patches have been landed. Closing bug. 58679 2010-06-14 11:56:52 -0700 2010-06-14 12:04:24 -0700 Patch bug-40580-20100614115652.patch text/plain 2940 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAgYi9XZWJLaXQv cXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCmluZGV4IDE3OGY1YzIzOTliZDE5OTg1MThjZTY1 OTQzNTM5OGRiOWVkNzNiZjguLmI5MWQ0ZjRjZDI4MzgxZjM2ZjI3YWNlOTEyZDM5ZDgzMWNmMGRh ZWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKKysrIGIv V2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtNjcsNyArNjcsOSBAQCBwdWJs aWM6CiAgICAgdm9pZCBfcV9jb250ZW50c1NpemVDaGFuZ2VkKGNvbnN0IFFTaXplJik7CiAgICAg dm9pZCBfcV9zY2FsZUNoYW5nZWQoKTsKIAorI2lmICFkZWZpbmVkKFFUX05PX0lNKSAmJiAoZGVm aW5lZChRX1dTX1gxMSkgfHwgZGVmaW5lZChRX1dTX1FXUykgfHwgZGVmaW5lZChRX09TX1NZTUJJ QU4pKQogICAgIHZvaWQgX3FfdXBkYXRlTWljcm9Gb2N1cygpOworI2VuZGlmCiAgICAgdm9pZCBf cV9wYWdlRGVzdHJveWVkKCk7CiAKICAgICBRR3JhcGhpY3NXZWJWaWV3KiBxOwpAQCAtOTksOSAr MTAxLDkgQEAgdm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6X3FfZG9Mb2FkRmluaXNoZWQo Ym9vbCBzdWNjZXNzKQogICAgIGVtaXQgcS0+bG9hZEZpbmlzaGVkKHN1Y2Nlc3MpOwogfQogCisj aWYgIWRlZmluZWQoUVRfTk9fSU0pICYmIChkZWZpbmVkKFFfV1NfWDExKSB8fCBkZWZpbmVkKFFf V1NfUVdTKSB8fCBkZWZpbmVkKFFfT1NfU1lNQklBTikpCiB2b2lkIFFHcmFwaGljc1dlYlZpZXdQ cml2YXRlOjpfcV91cGRhdGVNaWNyb0ZvY3VzKCkKIHsKLSNpZiAhZGVmaW5lZChRVF9OT19JTSkg JiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8IGRlZmluZWQoUV9P U19TWU1CSUFOKSkKICAgICAvLyBJZGVhbGx5LCB0aGlzIHNob3VsZCBiZSBoYW5kbGVkIGJ5IGEg Y29tbW9uIGNhbGwgdG8gYW4gdXBkYXRlTWljcm9Gb2N1cyBmdW5jdGlvbgogICAgIC8vIGluIFFH cmFwaGljc0l0ZW0uIFNlZSBodHRwOi8vYnVncmVwb3J0cy5xdC5ub2tpYS5jb20vYnJvd3NlL1FU QlVHLTc1NzguCiAgICAgUUxpc3Q8UUdyYXBoaWNzVmlldyo+IHZpZXdzID0gcS0+c2NlbmUoKS0+ dmlld3MoKTsKQEAgLTExMCw4ICsxMTIsOCBAQCB2b2lkIFFHcmFwaGljc1dlYlZpZXdQcml2YXRl OjpfcV91cGRhdGVNaWNyb0ZvY3VzKCkKICAgICAgICAgaWYgKGljKQogICAgICAgICAgICAgaWMt PnVwZGF0ZSgpOwogICAgIH0KLSNlbmRpZgogfQorI2VuZGlmCiAKIHZvaWQgUUdyYXBoaWNzV2Vi Vmlld1ByaXZhdGU6Ol9xX3BhZ2VEZXN0cm95ZWQoKQogewpAQCAtNDg0LDEwICs0ODYsMTIgQEAg dm9pZCBRR3JhcGhpY3NXZWJWaWV3OjpzZXRQYWdlKFFXZWJQYWdlKiBwYWdlKQogICAgICAgICAg ICAgdGhpcywgU0lHTkFMKHN0YXR1c0Jhck1lc3NhZ2UoUVN0cmluZykpKTsKICAgICBjb25uZWN0 KGQtPnBhZ2UsIFNJR05BTChsaW5rQ2xpY2tlZChRVXJsKSksCiAgICAgICAgICAgICB0aGlzLCBT SUdOQUwobGlua0NsaWNrZWQoUVVybCkpKTsKLSAgICBjb25uZWN0KGQtPnBhZ2UsIFNJR05BTCht aWNyb0ZvY3VzQ2hhbmdlZCgpKSwKLSAgICAgICAgICAgIHRoaXMsIFNMT1QoX3FfdXBkYXRlTWlj cm9Gb2N1cygpKSk7CiAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoZGVzdHJveWVkKCkpLAog ICAgICAgICAgICAgdGhpcywgU0xPVChfcV9wYWdlRGVzdHJveWVkKCkpKTsKKyNpZiAhZGVmaW5l ZChRVF9OT19JTSkgJiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8 IGRlZmluZWQoUV9PU19TWU1CSUFOKSkKKyAgICBjb25uZWN0KGQtPnBhZ2UsIFNJR05BTChtaWNy b0ZvY3VzQ2hhbmdlZCgpKSwKKyAgICAgICAgICAgIHRoaXMsIFNMT1QoX3FfdXBkYXRlTWljcm9G b2N1cygpKSk7CisjZW5kaWYKIH0KIAogLyohCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAwYzcwODAwZjFiMGEyYjFkZjg4NDYyY2Yy YTY3YjljN2M4YjJlZmM2Li5kMzk4NjliNjI1YmFmNDU4ZDYyYjhiZTUzOTk5MWQyYzNlNjg2ODIz IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMC0wNi0xNCAgQW5kZXJzIEJha2tlbiAgPGFnYmFra2Vu QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBbUXRdIERvbid0IGNvbm5lY3QgdG8gbWljcm9Gb2N1c0NoYW5nZWQoKSBpZiBfcV91cGRh dGVNaWNyb0ZvY3VzIGlzIGEgbm9vcC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwNTgwCisKKyAgICAgICAgX3FfdXBkYXRlTWljcm9Gb2N1cygpIGlz IGEgbm9vcCB1bmxlc3MgdGhpcyBpZmRlZiBldmFsdWF0ZXMgdG8gdHJ1ZToKKyAgICAgICAgI2lm ICFkZWZpbmVkKFFUX05PX0lNKSAmJiAoZGVmaW5lZChRX1dTX1gxMSkgfHwgZGVmaW5lZChRX1dT X1FXUykgfHwgZGVmaW5lZChRX09TX1NZTUJJQU4pKQorCisgICAgICAgIEluIHN1Y2ggY2FzZXMg dGhlcmUncyBubyBuZWVkIHRvIGNhcnJ5IHRoZSBvdmVyaGVhZCBvZiB0aGUgZXh0cmEKKyAgICAg ICAgc2lnbmFsL3Nsb3QgY29ubmVjdGlvbi4KKworICAgICAgICAqIEFwaS9xZ3JhcGhpY3N3ZWJ2 aWV3LmNwcDoKKyAgICAgICAgKFFHcmFwaGljc1dlYlZpZXdQcml2YXRlOjpfcV91cGRhdGVNaWNy b0ZvY3VzKToKKyAgICAgICAgKFFHcmFwaGljc1dlYlZpZXc6OnNldFBhZ2UpOgorCiAyMDEwLTA2 LTE0ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCBTeW1iaWFuIGJ1aWxkIGZpeC4K 58680 2010-06-14 12:04:30 -0700 2010-08-10 22:40:22 -0700 Patch bug-40580-20100614120429.patch text/plain 3650 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAgYi9XZWJLaXQv cXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCmluZGV4IDE3OGY1YzIzOTliZDE5OTg1MThjZTY1 OTQzNTM5OGRiOWVkNzNiZjguLmI5MWQ0ZjRjZDI4MzgxZjM2ZjI3YWNlOTEyZDM5ZDgzMWNmMGRh ZWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKKysrIGIv V2ViS2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcApAQCAtNjcsNyArNjcsOSBAQCBwdWJs aWM6CiAgICAgdm9pZCBfcV9jb250ZW50c1NpemVDaGFuZ2VkKGNvbnN0IFFTaXplJik7CiAgICAg dm9pZCBfcV9zY2FsZUNoYW5nZWQoKTsKIAorI2lmICFkZWZpbmVkKFFUX05PX0lNKSAmJiAoZGVm aW5lZChRX1dTX1gxMSkgfHwgZGVmaW5lZChRX1dTX1FXUykgfHwgZGVmaW5lZChRX09TX1NZTUJJ QU4pKQogICAgIHZvaWQgX3FfdXBkYXRlTWljcm9Gb2N1cygpOworI2VuZGlmCiAgICAgdm9pZCBf cV9wYWdlRGVzdHJveWVkKCk7CiAKICAgICBRR3JhcGhpY3NXZWJWaWV3KiBxOwpAQCAtOTksOSAr MTAxLDkgQEAgdm9pZCBRR3JhcGhpY3NXZWJWaWV3UHJpdmF0ZTo6X3FfZG9Mb2FkRmluaXNoZWQo Ym9vbCBzdWNjZXNzKQogICAgIGVtaXQgcS0+bG9hZEZpbmlzaGVkKHN1Y2Nlc3MpOwogfQogCisj aWYgIWRlZmluZWQoUVRfTk9fSU0pICYmIChkZWZpbmVkKFFfV1NfWDExKSB8fCBkZWZpbmVkKFFf V1NfUVdTKSB8fCBkZWZpbmVkKFFfT1NfU1lNQklBTikpCiB2b2lkIFFHcmFwaGljc1dlYlZpZXdQ cml2YXRlOjpfcV91cGRhdGVNaWNyb0ZvY3VzKCkKIHsKLSNpZiAhZGVmaW5lZChRVF9OT19JTSkg JiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8IGRlZmluZWQoUV9P U19TWU1CSUFOKSkKICAgICAvLyBJZGVhbGx5LCB0aGlzIHNob3VsZCBiZSBoYW5kbGVkIGJ5IGEg Y29tbW9uIGNhbGwgdG8gYW4gdXBkYXRlTWljcm9Gb2N1cyBmdW5jdGlvbgogICAgIC8vIGluIFFH cmFwaGljc0l0ZW0uIFNlZSBodHRwOi8vYnVncmVwb3J0cy5xdC5ub2tpYS5jb20vYnJvd3NlL1FU QlVHLTc1NzguCiAgICAgUUxpc3Q8UUdyYXBoaWNzVmlldyo+IHZpZXdzID0gcS0+c2NlbmUoKS0+ dmlld3MoKTsKQEAgLTExMCw4ICsxMTIsOCBAQCB2b2lkIFFHcmFwaGljc1dlYlZpZXdQcml2YXRl OjpfcV91cGRhdGVNaWNyb0ZvY3VzKCkKICAgICAgICAgaWYgKGljKQogICAgICAgICAgICAgaWMt PnVwZGF0ZSgpOwogICAgIH0KLSNlbmRpZgogfQorI2VuZGlmCiAKIHZvaWQgUUdyYXBoaWNzV2Vi Vmlld1ByaXZhdGU6Ol9xX3BhZ2VEZXN0cm95ZWQoKQogewpAQCAtNDg0LDEwICs0ODYsMTIgQEAg dm9pZCBRR3JhcGhpY3NXZWJWaWV3OjpzZXRQYWdlKFFXZWJQYWdlKiBwYWdlKQogICAgICAgICAg ICAgdGhpcywgU0lHTkFMKHN0YXR1c0Jhck1lc3NhZ2UoUVN0cmluZykpKTsKICAgICBjb25uZWN0 KGQtPnBhZ2UsIFNJR05BTChsaW5rQ2xpY2tlZChRVXJsKSksCiAgICAgICAgICAgICB0aGlzLCBT SUdOQUwobGlua0NsaWNrZWQoUVVybCkpKTsKLSAgICBjb25uZWN0KGQtPnBhZ2UsIFNJR05BTCht aWNyb0ZvY3VzQ2hhbmdlZCgpKSwKLSAgICAgICAgICAgIHRoaXMsIFNMT1QoX3FfdXBkYXRlTWlj cm9Gb2N1cygpKSk7CiAgICAgY29ubmVjdChkLT5wYWdlLCBTSUdOQUwoZGVzdHJveWVkKCkpLAog ICAgICAgICAgICAgdGhpcywgU0xPVChfcV9wYWdlRGVzdHJveWVkKCkpKTsKKyNpZiAhZGVmaW5l ZChRVF9OT19JTSkgJiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8 IGRlZmluZWQoUV9PU19TWU1CSUFOKSkKKyAgICBjb25uZWN0KGQtPnBhZ2UsIFNJR05BTChtaWNy b0ZvY3VzQ2hhbmdlZCgpKSwKKyAgICAgICAgICAgIHRoaXMsIFNMT1QoX3FfdXBkYXRlTWljcm9G b2N1cygpKSk7CisjZW5kaWYKIH0KIAogLyohCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3Fn cmFwaGljc3dlYnZpZXcuaCBiL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5oCmluZGV4 IDg4NzI5ZDMxZTRkODg3NjI1Yjk1ZjUyNWUxYjgyMjljNGRkNzViYTcuLmJhZDEzZjI2NGY2ZjRh YTcwMDFkZmIzZDM0OWJiOTI4MzUzMmY2ZWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcWdy YXBoaWNzd2Vidmlldy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5oCkBA IC0xNDIsNyArMTQyLDkgQEAgcHJvdGVjdGVkOgogCiBwcml2YXRlOgogICAgIFFfUFJJVkFURV9T TE9UKGQsIHZvaWQgX3FfZG9Mb2FkRmluaXNoZWQoYm9vbCBzdWNjZXNzKSkKKyNpZiAhZGVmaW5l ZChRVF9OT19JTSkgJiYgKGRlZmluZWQoUV9XU19YMTEpIHx8IGRlZmluZWQoUV9XU19RV1MpIHx8 IGRlZmluZWQoUV9PU19TWU1CSUFOKSkKICAgICBRX1BSSVZBVEVfU0xPVChkLCB2b2lkIF9xX3Vw ZGF0ZU1pY3JvRm9jdXMoKSkKKyNlbmRpZgogICAgIFFfUFJJVkFURV9TTE9UKGQsIHZvaWQgX3Ff cGFnZURlc3Ryb3llZCgpKQogICAgIC8vIHdlIGRvbid0IHdhbnQgdG8gY2hhbmdlIHRoZSBtb2Mg YmFzZWQgb24gVVNFKCkgbWFjcm8sIHNvIHRoaXMgZnVuY3Rpb24gaXMgaGVyZQogICAgIC8vIGJ1 dCB3aWxsIGJlIGVtcHR5IGlmIEFDQ0xFUkFURURfQ09NUE9TSVRJTkcgaXMgZGlzYWJsZWQKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IDBjNzA4MDBmMWIwYTJiMWRmODg0NjJjZjJhNjdiOWM3YzhiMmVmYzYuLmQzOTg2OWI2MjViYWY0 NThkNjJiOGJlNTM5OTkxZDJjM2U2ODY4MjMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEwLTA2LTE0 ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRG9uJ3QgY29ubmVjdCB0byBtaWNy b0ZvY3VzQ2hhbmdlZCgpIGlmIF9xX3VwZGF0ZU1pY3JvRm9jdXMgaXMgYSBub29wLgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1ODAKKworICAgICAg ICBfcV91cGRhdGVNaWNyb0ZvY3VzKCkgaXMgYSBub29wIHVubGVzcyB0aGlzIGlmZGVmIGV2YWx1 YXRlcyB0byB0cnVlOgorICAgICAgICAjaWYgIWRlZmluZWQoUVRfTk9fSU0pICYmIChkZWZpbmVk KFFfV1NfWDExKSB8fCBkZWZpbmVkKFFfV1NfUVdTKSB8fCBkZWZpbmVkKFFfT1NfU1lNQklBTikp CisKKyAgICAgICAgSW4gc3VjaCBjYXNlcyB0aGVyZSdzIG5vIG5lZWQgdG8gY2FycnkgdGhlIG92 ZXJoZWFkIG9mIHRoZSBleHRyYQorICAgICAgICBzaWduYWwvc2xvdCBjb25uZWN0aW9uLgorCisg ICAgICAgICogQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwOgorICAgICAgICAoUUdyYXBoaWNzV2Vi Vmlld1ByaXZhdGU6Ol9xX3VwZGF0ZU1pY3JvRm9jdXMpOgorICAgICAgICAoUUdyYXBoaWNzV2Vi Vmlldzo6c2V0UGFnZSk6CisKIDIwMTAtMDYtMTQgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5n b21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIFN5bWJpYW4gYnVpbGQgZml4 Lgo=