40565 2010-06-14 05:15:23 -0700 [WebKitSite] Improve assertion macro documentation 2010-06-16 22:08:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 playmobil webkit-unassigned abarth commit-queue darin sam oldest_to_newest 237779 0 playmobil 2010-06-14 05:15:23 -0700 Address review comments (https://bugs.webkit.org/show_bug.cgi?id=39950#c7) and improve assertion macro documentation. 237780 1 58637 playmobil 2010-06-14 05:18:12 -0700 Created attachment 58637 Improve assertion documentation 237903 2 58637 darin 2010-06-14 10:47:38 -0700 Comment on attachment 58637 Improve assertion documentation These changes look good. I think that it’s overstating the case to say that out of memory errors are not recoverable. Maybe there’s a more nuanced way to talk about this. Because of virtual memory systems we program assuming we will not run out of memory for small allocation, and we don't wish to rewrite all the code to handle out-of-memory errors. In those cases we want to terminate the program if we can’t get the memory. But we do have functions that return 0 if there is not sufficient memory. We tend to use those for larger allocations that might fail in practice even if the program has ample space to continue. The topic is generally subtle and just stating that memory errors are unrecoverable is imprecise. 239219 3 58637 commit-queue 2010-06-16 22:08:03 -0700 Comment on attachment 58637 Improve assertion documentation Clearing flags on attachment: 58637 Committed r61305: <http://trac.webkit.org/changeset/61305> 239220 4 commit-queue 2010-06-16 22:08:08 -0700 All reviewed patches have been landed. Closing bug. 58637 2010-06-14 05:18:12 -0700 2010-06-16 22:08:03 -0700 Improve assertion documentation assert.patch text/plain 2499 playmobil Y29tbWl0IGY5ZjVjMWUyOTNlYTFhM2JmMDFkN2E3MjM1Njc5MjJlMTM4YzEzNmEKQXV0aG9yOiBK ZXJlbXkgTW9za292aWNoIDxqZXJlbXlAY2hyb21pdW0ub3JnPgpEYXRlOiAgIE1vbiBKdW4gMTQg MTU6MjI6MTAgMjAxMCArMDMwMAoKICAgIEltcHJvdmUgYXNzZXJ0aW9uIG1hY3JvIGRvY3VtZW50 YXRpb24uCgpkaWZmIC0tZ2l0IGEvV2ViS2l0U2l0ZS9DaGFuZ2VMb2cgYi9XZWJLaXRTaXRlL0No YW5nZUxvZwppbmRleCAyODI0YzA4Li43OTUzMjEyIDEwMDY0NAotLS0gYS9XZWJLaXRTaXRlL0No YW5nZUxvZworKysgYi9XZWJLaXRTaXRlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEw LTA2LTE0ICBKZXJlbXkgTW9za292aWNoICA8amVyZW15QGNocm9taXVtLm9yZz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbXByb3ZlIGFzc2VydGlv biBtYWNybyBkb2N1bWVudGF0aW9uLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDU2NQorCisgICAgICAgICogY29kaW5nL2Fzc2VydGlvbi1ndWlk ZWxpbmVzLmh0bWw6CisKIDIwMTAtMDYtMDcgIEplcmVteSBNb3Nrb3ZpY2ggIDxqZXJlbXlAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0U2l0ZS9jb2RpbmcvYXNzZXJ0aW9uLWd1aWRlbGluZXMuaHRtbCBiL1dlYktpdFNp dGUvY29kaW5nL2Fzc2VydGlvbi1ndWlkZWxpbmVzLmh0bWwKaW5kZXggNGU4NGI5Ni4uY2VmZGRh YSAxMDA2NDQKLS0tIGEvV2ViS2l0U2l0ZS9jb2RpbmcvYXNzZXJ0aW9uLWd1aWRlbGluZXMuaHRt bAorKysgYi9XZWJLaXRTaXRlL2NvZGluZy9hc3NlcnRpb24tZ3VpZGVsaW5lcy5odG1sCkBAIC05 OCw5ICs5OCw5IEBAIHZvaWQgRXhlY3V0YWJsZVBvb2w6OnN5c3RlbVJlbGVhc2UoY29uc3QgRXhl Y3V0YWJsZVBvb2w6OkFsbG9jYXRpb24mYW1wOyBhbGxvYykKIDx1bD4KICAgPGxpPlVzZSBBU1NF UlQoKSBmb3IgdGhpbmdzIHRoYXQgc2hvdWxkIG5ldmVyIGhhcHBlbiwgYnV0IGlmIHRoZXkgZG8g d2lsbCBjYXVzZSBpbmNvcnJlY3QgcmVzdWx0cyByYXRoZXIgdGhhbiBhIGNyYXNoIG9yIG1lbW9y eSBjb3JydXB0aW9uLgogICA8L2xpPgotICA8bGk+VXNlIENSQVNIKCkgZm9yIGNhc2VzIHRoYXQg c2hvdWxkbid0IGhhcHBlbiwgYnV0IGlmIHRoZXkgZG8gd291bGQgYmUgdW5yZWNvdmVyYWJsZS4g ZS5nLiBvdXQgb2YgbWVtb3J5IGVycm9ycy4KKyAgPGxpPkFzc2VydGlvbnMgYXJlIGNsYWltcyB0 aGF0IGEgcHJvZ3JhbW1lciBrbm93cyB0byBiZSB0cnVlLCBhbmQgdGhleSBmaXJlIG9ubHkgd2hl biB0aGF0IHByb2dyYW1tZXIgdHVybnMgb3V0IHRvIGJlIHdyb25nIGJlY2F1c2UgdGhlcmUgaXMg c29tZSBraW5kIG9mIHByb2dyYW1taW5nIG1pc3Rha2UuIFRoZXJlIHNob3VsZCBiZSBubyAid2lz aGZ1bCB0aGlua2luZyIgaW52b2x2ZWQuIEZvciBleGFtcGxlLCBBU1NFUlQoKSBzaG91bGQgbm90 IGJlIHVzZWQgdG8gdmVyaWZ5IHRoYXQgYSBmaWxlIHN5c3RlbSBjYWxsIGhhcyBzdWNjZWVkZWQs IGJlY2F1c2UgdGhlcmUgaXMgbm8gd2F5IGZvciBhIHByb2dyYW1tZXIgdG8gZ3VhcmFudGVlIHRo YXQuCiAgIDwvbGk+Ci0gIDxsaT5XaGVuIHBvc3NpYmxlLCBpdCBpcyBvZnRlbiBwcmVmZXJhYmxl IHRvIHJlY292ZXIgZnJvbSBub24tZmF0YWwgZXJyb3JzLiBUaGUgQVNTRVJUIG1hY3JvIGNhbiBi ZSB1c2VkIGlmIHRoZSBlcnJvciBjb25kaXRpb24gY291bGQgaW5kaWNhdGUgYSBwcm9ncmFtbWlu ZyBtaXN0YWtlIG9yIG90aGVyIGJhZCBiZWhhdmlvciBkZXNlcnZpbmcgYXR0ZW50aW9uLgorICA8 bGk+VXNlIENSQVNIKCkgZm9yIGNhc2VzIHRoYXQgc2hvdWxkbid0IGhhcHBlbiwgYnV0IGlmIHRo ZXkgZG8gd291bGQgYmUgdW5yZWNvdmVyYWJsZS4gZS5nLiBvdXQgb2YgbWVtb3J5IGVycm9ycy4K ICAgPC9saT4KIDwvdWw+CiA8aDM+CkBAIC0xMTAsOCArMTEwLDggQEAgdm9pZCBFeGVjdXRhYmxl UG9vbDo6c3lzdGVtUmVsZWFzZShjb25zdCBFeGVjdXRhYmxlUG9vbDo6QWxsb2NhdGlvbiZhbXA7 IGFsbG9jKQogPHNwYW4gY2xhc3M9ImNvbW1lbnQiPi8vIE5vdCBoYXZpbmcgYW55IGNoaWxkcmVu IGluZGljYXRlcyBhIHByb2dyYW1taW5nIGVycm9yLjwvc3Bhbj4KIEFTU0VSVChvYmplY3QtJmd0 O251bUNoaWxkcmVuKCkgJmd0OyAwKTsKIAotQWxsb2NhdGlvbiBtZW0gPSBzeXN0ZW1BbGxvYyhh bGxvY1NpemUpOwotaWYgKCFtZW0ucGFnZXMpCitBbGxvY2F0aW9uIGJpdG1hcFN0b3JhZ2UgPSBz eXN0ZW1BbGxvYyhhbGxvY1NpemUpOworaWYgKCFiaXRtYXBTdG9yYWdlLnBhZ2VzKQogICAgIENS QVNIKCk7IDxzcGFuIGNsYXNzPSJjb21tZW50Ij4vLyBOb3QgcG9zc2libGUgdG8gcmVjb3ZlciBm cm9tIGFuIG91dCBvZiBtZW1vcnkgZXJyb3IuPC9zcGFuPgogPC9wcmU+CiA8cD4K