40553 2010-06-13 17:57:06 -0700 fix chromium compile after r61094 (id attribute refactor) 2010-06-13 18:10:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony darin dglazkov oldest_to_newest 237640 0 tony 2010-06-13 17:57:06 -0700 fix chromium compile after r61094 (id attribute refactor) 237641 1 58609 tony 2010-06-13 17:57:43 -0700 Created attachment 58609 Patch 237642 2 tony 2010-06-13 17:58:44 -0700 Committed r61097: <http://trac.webkit.org/changeset/61097> 237645 3 tony 2010-06-13 18:10:23 -0700 I think this is correct, but it seems like WebFormControlElement.cpp should have a "hasID()" check. 58609 2010-06-13 17:57:43 -0700 2010-06-13 18:00:05 -0700 Patch bug-40553-20100613175742.patch text/plain 3319 tony ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDQ3M2Y2NzFmMGJjY2JlNWVjMjdiYzkyYzBjYWFhOGQ0ZGYyYmQ2MS4uYzg2NjI5MmMxNDM5NTIz NjY1MTVlM2RhNGMyODFlM2Q3ZDUzY2ZlMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0xMyAgVG9u eSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEJ1aWxkIGZpeCwgbm90IHJl dmlld2VkLgorCisgICAgICAgIGZpeCBjaHJvbWl1bSBjb21waWxlIGFmdGVyIHI2MTA5NCAoaWQg YXR0cmlidXRlIHJlZmFjdG9yKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDA1NTMKKworICAgICAgICBObyBuZXcgdGVzdHMuIChPT1BTISkKKworICAg ICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOE5hbWVkTm9kZXNDb2xsZWN0aW9uLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlY4TmFtZWROb2Rlc0NvbGxlY3Rpb246Oml0ZW1XaXRoTmFtZSk6CisK IDIwMTAtMDYtMTMgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL3Y4L2N1c3RvbS9WOE5hbWVkTm9kZXNDb2xsZWN0aW9uLmNwcCBiL1dlYkNvcmUvYmluZGlu Z3MvdjgvY3VzdG9tL1Y4TmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwCmluZGV4IDkwNWIyM2QxMGQ3 NTdiZDM2MTUzYzU2MDA0MGQ0YjRiN2QzYmNkNjEuLmQ5ZGExNzRiNjE3MjBlMmM5ZTA3NzJlNmQ3 NTVjZjkxNWMwNDI4YTYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 TmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9t L1Y4TmFtZWROb2Rlc0NvbGxlY3Rpb24uY3BwCkBAIC00Niw3ICs0Niw3IEBAIE5vZGUqIFY4TmFt ZWROb2Rlc0NvbGxlY3Rpb246Oml0ZW1XaXRoTmFtZShjb25zdCBBdG9taWNTdHJpbmcmIGlkKSBj b25zdAogewogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBtX25vZGVzLnNpemUoKTsgKytp KSB7CiAgICAgICAgIE5vZGUqIG5vZGUgPSBtX25vZGVzW2ldLmdldCgpOwotICAgICAgICBpZiAo bm9kZS0+aGFzQXR0cmlidXRlcygpICYmIG5vZGUtPmF0dHJpYnV0ZXMoKS0+aWQoKSA9PSBpZCkK KyAgICAgICAgaWYgKG5vZGUtPmhhc0lEKCkgJiYgc3RhdGljX2Nhc3Q8RWxlbWVudCo+KG5vZGUp LT5nZXRJZEF0dHJpYnV0ZSgpID09IGlkKQogICAgICAgICAgICAgcmV0dXJuIG5vZGU7CiAgICAg fQogICAgIHJldHVybiAwOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBi L1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggYmU1NTEzNGEyZDEyNmY2MmY0Njk3Y2Zh OWQyMWQyZGI2MzZkODYwOC4uOGZjZTBlZmEyZjhiODljNWM5ZWI1Y2RlYTc5YzcyMDA4ZGNkZDEw MSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTMgIFRvbnkgQ2hhbmcg IDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBCdWlsZCBmaXgsIG5vdCByZXZpZXdlZC4K KworICAgICAgICBmaXggY2hyb21pdW0gY29tcGlsZSBhZnRlciByNjEwOTQgKGlkIGF0dHJpYnV0 ZSByZWZhY3RvcikKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwNTUzCisKKyAgICAgICAgKiBzcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHA6CisgICAgICAg ICogc3JjL1dlYkZvcm1Db250cm9sRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZv cm1Db250cm9sRWxlbWVudDo6bmFtZUZvckF1dG9maWxsKToKKwogMjAxMC0wNi0xMyAgQW5kcmFz IEJlY3NpICA8YWJlY3NpQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50 SW1wbC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4 IGE5NDRkNDhlNTk3NDAyZjBmYzZhNWE2YWExYmY4MjQ2YzdmMzIyNzIuLjU1OWE2MmI2NzUxMzAx NGRmYmNlYzdiZjg5MGJlMGExNmQwMzUwNjkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVD bGllbnRJbXBsLmNwcApAQCAtNDgsNiArNDgsNyBAQAogI2luY2x1ZGUgIldlYkdlb2xvY2F0aW9u U2VydmljZS5oIgogI2luY2x1ZGUgIkdlb2xvY2F0aW9uU2VydmljZUNocm9taXVtLmgiCiAjaW5j bHVkZSAiR3JhcGhpY3NMYXllci5oIgorI2luY2x1ZGUgIkhUTUxOYW1lcy5oIgogI2luY2x1ZGUg IkhpdFRlc3RSZXN1bHQuaCIKICNpbmNsdWRlICJJbnRSZWN0LmgiCiAjaW5jbHVkZSAiTm9kZS5o IgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGb3JtQ29udHJvbEVsZW1lbnQu Y3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGb3JtQ29udHJvbEVsZW1lbnQuY3BwCmluZGV4 IDAwNzY3M2U2ODM0ZWQ4YmE4ODIzZmE1NjE2YTQzY2EzMDc5NDBlZmEuLmE3NWZlNWM1OGE1NzNh OGY5MTJhOTgwNmJmMGJjM2EzYjBmOTgyMDggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRm9ybUNvbnRyb2xFbGVtZW50LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZvcm1Db250cm9sRWxlbWVudC5jcHAKQEAgLTU5LDcgKzU5LDcgQEAgV2ViU3RyaW5nIFdlYkZv cm1Db250cm9sRWxlbWVudDo6bmFtZUZvckF1dG9maWxsKCkgY29uc3QKICAgICBTdHJpbmcgdHJp bW1lZE5hbWUgPSBuYW1lLnN0cmlwV2hpdGVTcGFjZSgpOwogICAgIGlmICghdHJpbW1lZE5hbWUu aXNFbXB0eSgpKQogICAgICAgICByZXR1cm4gdHJpbW1lZE5hbWU7Ci0gICAgbmFtZSA9IGNvbnN0 VW53cmFwPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+KCktPmdldEF0dHJpYnV0ZShIVE1MTmFtZXM6 OmlkQXR0cik7CisgICAgbmFtZSA9IGNvbnN0VW53cmFwPEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ+ KCktPmdldElkQXR0cmlidXRlKCk7CiAgICAgdHJpbW1lZE5hbWUgPSBuYW1lLnN0cmlwV2hpdGVT cGFjZSgpOwogICAgIGlmICghdHJpbW1lZE5hbWUuaXNFbXB0eSgpKQogICAgICAgICByZXR1cm4g dHJpbW1lZE5hbWU7Cg==