<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>40543</bug_id>
          
          <creation_ts>2010-06-13 02:29:01 -0700</creation_ts>
          <short_desc>return QWebElement&amp; from QWebElement::setAttribute()</short_desc>
          <delta_ts>2010-06-16 02:12:31 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>WONTFIX</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Piotr Dobrogost">pd</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>kent.hansen</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>237530</commentid>
    <comment_count>0</comment_count>
    <who name="Piotr Dobrogost">pd</who>
    <bug_when>2010-06-13 02:29:01 -0700</bug_when>
    <thetext>How about returning QWebElement&amp; from QWebElement::setAttribute() to make chaining possible?
I guess other methods of QWebElement could take advantage from this change as well.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238472</commentid>
    <comment_count>1</comment_count>
    <who name="Kent Hansen">kent.hansen</who>
    <bug_when>2010-06-15 11:07:45 -0700</bug_when>
    <thetext>Changing the return type is not binary compatible (see http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Change_the_return_type).
It could be done for Qt 5, though.
Tor Arne, what do you think? Was this considered in the API reviews?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238624</commentid>
    <comment_count>2</comment_count>
    <who name="Antonio Gomes">tonikitoo</who>
    <bug_when>2010-06-15 17:17:38 -0700</bug_when>
    <thetext>maybe RESOLVED - LATER instead of INVALID, so we can revisit it at some point?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>238746</commentid>
    <comment_count>3</comment_count>
    <who name="Tor Arne Vestbø">vestbo</who>
    <bug_when>2010-06-16 02:12:21 -0700</bug_when>
    <thetext>Chaining was not considered a goal for this API, as in most cases a normal semi-colon and multiple statements does the same job and is more in line with Qt&apos;s existing APIs.

foo.setAttribute(&quot;foo&quot;, &quot;bar&quot;);
foo.setAttribute(&quot;biz&quot;, &quot;baz&quot;);</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>