40531 2010-06-12 12:53:23 -0700 -webkit-column-break-* properties don’t do anything 2010-06-12 13:05:58 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 mitz webkit-unassigned hyatt oldest_to_newest 237327 0 mitz 2010-06-12 12:53:23 -0700 <rdar://problem/7882140> Patch forthcoming. 237328 1 58564 mitz 2010-06-12 12:57:35 -0700 Created attachment 58564 Check for -webkit-column-break-* in column layout I know that Hyatt is working on a new architecture for pagination and columns, and intends to support the unified page/column break-* properties, but this is a very simple patch that enables properties that WebKit has had all along. 237329 2 58564 hyatt 2010-06-12 12:59:37 -0700 Comment on attachment 58564 Check for -webkit-column-break-* in column layout R=me 237331 3 mitz 2010-06-12 13:05:58 -0700 Fixed in <http://trac.webkit.org/changeset/61065>. 58564 2010-06-12 12:57:35 -0700 2010-06-12 13:00:30 -0700 Check for -webkit-column-break-* in column layout 40531_r1.diff text/plain 6376 mitz SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTA2NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMTIgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFwcGxlLmNv bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICA8cmRh cjovL3Byb2JsZW0vNzg4MjE0MD4gLXdlYmtpdC1jb2x1bW4tYnJlYWstKiBwcm9wZXJ0aWVzIGRv buKAmXQgZG8gYW55dGhpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwNTMxCisKKyAgICAgICAgVGVzdDogZmFzdC9tdWx0aWNvbC9icmVhay1wcm9w ZXJ0aWVzLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpSZW5kZXJCbG9jazo6cGFpbnRDaGlsZHJlbik6IENoZWNrIGZvciAtd2Vi a2l0LWNvbHVtbi1icmVhay17YmVmb3JlLGFmdGVyfTogYWx3YXlzCisgICAgICAgIGFuZCAtd2Vi a2l0LWNvbHVtbi1icmVhay1pbnNpZGU6IGF2b2lkIHdoZW4gZG9pbmcgY29sdW1uIGxheW91dC4K KwogMjAxMC0wNi0xMyAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IFdlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCbG9jay5jcHAJKHJldmlzaW9uIDYxMDYzKQorKysgV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy QmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTAxLDEwICsyMTAxLDEyIEBAIHZvaWQgUmVu ZGVyQmxvY2s6OnBhaW50Q2hpbGRyZW4oUGFpbnRJbmYKICAgICBpbmZvLnBoYXNlID0gbmV3UGhh c2U7CiAgICAgaW5mby5wYWludGluZ1Jvb3QgPSBwYWludGluZ1Jvb3RGb3JDaGlsZHJlbihwYWlu dEluZm8pOwogICAgIGJvb2wgY2hlY2tQYWdlQnJlYWtzID0gZG9jdW1lbnQoKS0+cHJpbnRpbmco KSAmJiAhZG9jdW1lbnQoKS0+c2V0dGluZ3MoKS0+cGFnaW5hdGVEdXJpbmdMYXlvdXRFbmFibGVk KCk7CisgICAgYm9vbCBjaGVja0NvbHVtbkJyZWFrcyA9ICFjaGVja1BhZ2VCcmVha3MgJiYgIXZp ZXcoKS0+cHJpbnRSZWN0KCkuaXNFbXB0eSgpICYmICFkb2N1bWVudCgpLT5zZXR0aW5ncygpLT5w YWdpbmF0ZUR1cmluZ0xheW91dEVuYWJsZWQoKTsKIAogICAgIGZvciAoUmVuZGVyQm94KiBjaGls ZCA9IGZpcnN0Q2hpbGRCb3goKTsgY2hpbGQ7IGNoaWxkID0gY2hpbGQtPm5leHRTaWJsaW5nQm94 KCkpIHsgICAgICAgIAogICAgICAgICAvLyBDaGVjayBmb3IgcGFnZS1icmVhay1iZWZvcmU6IGFs d2F5cywgYW5kIGlmIGl0J3Mgc2V0LCBicmVhayBhbmQgYmFpbC4KLSAgICAgICAgaWYgKGNoZWNr UGFnZUJyZWFrcyAmJiAhY2hpbGRyZW5JbmxpbmUoKSAmJiBjaGlsZC0+c3R5bGUoKS0+cGFnZUJy ZWFrQmVmb3JlKCkgPT0gUEJBTFdBWVMKKyAgICAgICAgYm9vbCBjaGVja0JlZm9yZUFsd2F5cyA9 ICFjaGlsZHJlbklubGluZSgpICYmIChjaGVja1BhZ2VCcmVha3MgJiYgY2hpbGQtPnN0eWxlKCkt PnBhZ2VCcmVha0JlZm9yZSgpID09IFBCQUxXQVlTIHx8IGNoZWNrQ29sdW1uQnJlYWtzICYmIGNo aWxkLT5zdHlsZSgpLT5jb2x1bW5CcmVha0JlZm9yZSgpID09IFBCQUxXQVlTKTsKKyAgICAgICAg aWYgKGNoZWNrQmVmb3JlQWx3YXlzCiAgICAgICAgICAgICAmJiAodHkgKyBjaGlsZC0+eSgpKSA+ IHBhaW50SW5mby5yZWN0LnkoKQogICAgICAgICAgICAgJiYgKHR5ICsgY2hpbGQtPnkoKSkgPCBw YWludEluZm8ucmVjdC5ib3R0b20oKSkgewogICAgICAgICAgICAgdmlldygpLT5zZXRCZXN0VHJ1 bmNhdGVkQXQodHkgKyBjaGlsZC0+eSgpLCB0aGlzLCB0cnVlKTsKQEAgLTIxMTIsNyArMjExNCw4 IEBAIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50Q2hpbGRyZW4oUGFpbnRJbmYKICAgICAgICAgfQog CiAgICAgICAgIC8vIENoZWNrIGZvciBwYWdlLWJyZWFrLWluc2lkZTogYXZvaWQsIGFuZCBpdCBp dCdzIHNldCwgYnJlYWsgYW5kIGJhaWwuCi0gICAgICAgIGlmIChjaGVja1BhZ2VCcmVha3MgJiYg IWNoaWxkcmVuSW5saW5lKCkgJiYgY2hpbGQtPnN0eWxlKCktPnBhZ2VCcmVha0luc2lkZSgpID09 IFBCQVZPSUQKKyAgICAgICAgYm9vbCBjaGVja0luc2lkZUF2b2lkID0gIWNoaWxkcmVuSW5saW5l KCkgJiYgKGNoZWNrUGFnZUJyZWFrcyAmJiBjaGlsZC0+c3R5bGUoKS0+cGFnZUJyZWFrSW5zaWRl KCkgPT0gUEJBVk9JRCB8fCBjaGVja0NvbHVtbkJyZWFrcyAmJiBjaGlsZC0+c3R5bGUoKS0+Y29s dW1uQnJlYWtJbnNpZGUoKSA9PSBQQkFWT0lEKTsKKyAgICAgICAgaWYgKGNoZWNrSW5zaWRlQXZv aWQKICAgICAgICAgICAgICYmIHR5ICsgY2hpbGQtPnkoKSA+IHBhaW50SW5mby5yZWN0LnkoKQog ICAgICAgICAgICAgJiYgdHkgKyBjaGlsZC0+eSgpIDwgcGFpbnRJbmZvLnJlY3QuYm90dG9tKCkK ICAgICAgICAgICAgICYmIHR5ICsgY2hpbGQtPnkoKSArIGNoaWxkLT5oZWlnaHQoKSA+IHBhaW50 SW5mby5yZWN0LmJvdHRvbSgpKSB7CkBAIC0yMTI0LDcgKzIxMjcsOCBAQCB2b2lkIFJlbmRlckJs b2NrOjpwYWludENoaWxkcmVuKFBhaW50SW5mCiAgICAgICAgICAgICBjaGlsZC0+cGFpbnQoaW5m bywgdHgsIHR5KTsKIAogICAgICAgICAvLyBDaGVjayBmb3IgcGFnZS1icmVhay1hZnRlcjogYWx3 YXlzLCBhbmQgaWYgaXQncyBzZXQsIGJyZWFrIGFuZCBiYWlsLgotICAgICAgICBpZiAoY2hlY2tQ YWdlQnJlYWtzICYmICFjaGlsZHJlbklubGluZSgpICYmIGNoaWxkLT5zdHlsZSgpLT5wYWdlQnJl YWtBZnRlcigpID09IFBCQUxXQVlTCisgICAgICAgIGJvb2wgY2hlY2tBZnRlckFsd2F5cyA9ICFj aGlsZHJlbklubGluZSgpICYmIChjaGVja1BhZ2VCcmVha3MgJiYgY2hpbGQtPnN0eWxlKCktPnBh Z2VCcmVha0FmdGVyKCkgPT0gUEJBTFdBWVMgfHwgY2hlY2tDb2x1bW5CcmVha3MgJiYgY2hpbGQt PnN0eWxlKCktPmNvbHVtbkJyZWFrQWZ0ZXIoKSA9PSBQQkFMV0FZUyk7CisgICAgICAgIGlmIChj aGVja0FmdGVyQWx3YXlzCiAgICAgICAgICAgICAmJiAodHkgKyBjaGlsZC0+eSgpICsgY2hpbGQt PmhlaWdodCgpKSA+IHBhaW50SW5mby5yZWN0LnkoKQogICAgICAgICAgICAgJiYgKHR5ICsgY2hp bGQtPnkoKSArIGNoaWxkLT5oZWlnaHQoKSkgPCBwYWludEluZm8ucmVjdC5ib3R0b20oKSkgewog ICAgICAgICAgICAgdmlldygpLT5zZXRCZXN0VHJ1bmNhdGVkQXQodHkgKyBjaGlsZC0+eSgpICsg Y2hpbGQtPmhlaWdodCgpICsgbWF4KDAsIGNoaWxkLT5jb2xsYXBzZWRNYXJnaW5Cb3R0b20oKSks IHRoaXMsIHRydWUpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNjEwNjQpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xMiAgRGFu IEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83ODgyMTQwPiAtd2Via2l0LWNv bHVtbi1icmVhay0qIHByb3BlcnRpZXMgZG9u4oCZdCBkbyBhbnl0aGluZworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1MzEKKworICAgICAgICAqIGZh c3QvbXVsdGljb2wvYnJlYWstcHJvcGVydGllcy1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvbXVsdGljb2wvYnJlYWstcHJvcGVydGllcy5odG1sOiBBZGRlZC4KKwogMjAxMC0w Ni0xMyAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvbXVsdGlj b2wvYnJlYWstcHJvcGVydGllcy1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9tdWx0aWNvbC9icmVhay1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24g MCkKKysrIExheW91dFRlc3RzL2Zhc3QvbXVsdGljb2wvYnJlYWstcHJvcGVydGllcy1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsNCBAQAorUEFTUzogJ2JyZWFrLWJlZm9yZScg aXMgYXQgKDIxOCwgOCkKK1BBU1M6ICdhZnRlci1icmVhaycgaXMgYXQgKDQyOCwgOCkKK1BBU1M6 ICduby1icmVhaycgaXMgYXQgKDUzMywgOCkKKwpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9tdWx0 aWNvbC9icmVhay1wcm9wZXJ0aWVzLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9tdWx0aWNvbC9icmVhay1wcm9wZXJ0aWVzLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRU ZXN0cy9mYXN0L211bHRpY29sL2JyZWFrLXByb3BlcnRpZXMuaHRtbAkocmV2aXNpb24gMCkKQEAg LTAsMCArMSwzNiBAQAorPHN0eWxlPgorICAgIGRpdi5ib3ggeyAtd2Via2l0LWJveC1zaXppbmc6 IGJvcmRlcjsgYm9yZGVyOiBzb2xpZCBibHVlOyB9CisgICAgZGl2LnNob3J0ZXIgeyBoZWlnaHQ6 IDU0cHg7IH0KKyAgICBkaXYudGFsbGVyIHsgaGVpZ2h0OiA3MnB4OyB9Cis8L3N0eWxlPgorPGRp diBzdHlsZT0iaGVpZ2h0OiAxMDBweDsgd2lkdGg6IDYzMDsgLXdlYmtpdC1jb2x1bW4tZ2FwOiA1 cHg7IC13ZWJraXQtY29sdW1uczogNjsiPgorICAgIDxkaXYgY2xhc3M9InRhbGxlciBib3giPjwv ZGl2PgorICAgIDxkaXYgY2xhc3M9InRhbGxlciBib3giPjwvZGl2PgorICAgIDxkaXYgaWQ9ImJy ZWFrLWJlZm9yZSIgY2xhc3M9InNob3J0ZXIgYm94IiBzdHlsZT0iLXdlYmtpdC1jb2x1bW4tYnJl YWstYmVmb3JlOiBhbHdheXM7Ij48L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJzaG9ydGVyIGJveCIg c3R5bGU9Ii13ZWJraXQtY29sdW1uLWJyZWFrLWFmdGVyOiBhbHdheXM7Ij48L2Rpdj4KKyAgICA8 ZGl2IGlkPSJhZnRlci1icmVhayIgY2xhc3M9InNob3J0ZXIgYm94Ij48L2Rpdj4KKyAgICA8ZGl2 IGlkPSJuby1icmVhayIgY2xhc3M9InNob3J0ZXIgYm94IiBzdHlsZT0iLXdlYmtpdC1jb2x1bW4t YnJlYWstaW5zaWRlOiBhdm9pZDsiPjwvZGl2PgorPC9kaXY+Cis8cHJlIGlkPSJjb25zb2xlIj48 L3ByZT4KKzxzY3JpcHQ+CisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOworCisgICAgZnVuY3Rpb24g bG9nKG1lc3NhZ2UpCisgICAgeworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiY29u c29sZSIpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKG1lc3NhZ2UgKyAiXG4i KSk7CisgICAgfQorCisgICAgZnVuY3Rpb24gdGVzdEJveFBvc2l0aW9uKGlkLCBleHBlY3RlZExl ZnQsIGV4cGVjdGVkVG9wKQorICAgIHsKKyAgICAgICAgdmFyIHJlY3QgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZChpZCkuZ2V0Qm91bmRpbmdDbGllbnRSZWN0KCk7CisgICAgICAgIGlmIChyZWN0 LmxlZnQgPT09IGV4cGVjdGVkTGVmdCAmJiByZWN0LnRvcCA9PT0gZXhwZWN0ZWRUb3ApCisgICAg ICAgICAgICBsb2coIlBBU1M6ICciICsgaWQgKyAiJyBpcyBhdCAoIiArIGV4cGVjdGVkTGVmdCAr ICIsICIgKyBleHBlY3RlZFRvcCArICIpIik7CisgICAgICAgIGVsc2UKKyAgICAgICAgICAgIGxv ZygiRkFJTDogJyIgKyBpZCArICInIGlzIGF0ICgiICsgcmVjdC5sZWZ0ICsgIiwgIiArIHJlY3Qu dG9wICsgIikgaW5zdGVhZCBvZiAoIiArIGV4cGVjdGVkTGVmdCArICIgLCIgKyBleHBlY3RlZFRv cCArICIpIik7CisgICAgfQorCisgICAgdGVzdEJveFBvc2l0aW9uKCJicmVhay1iZWZvcmUiLCAy MTgsIDgpOworICAgIHRlc3RCb3hQb3NpdGlvbigiYWZ0ZXItYnJlYWsiLCA0MjgsIDgpOworICAg IHRlc3RCb3hQb3NpdGlvbigibm8tYnJlYWsiLCA1MzMsIDgpOworPC9zY3JpcHQ+Cg==