40526 2010-06-12 08:01:44 -0700 [GStreamer] can't seek past maxTimeLoaded value 2010-07-06 10:18:15 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 41515 1 pnormand webkit-unassigned abarth eric gustavo slomo webkit.review.bot oldest_to_newest 237295 0 pnormand 2010-06-12 08:01:44 -0700 When progressive download of the media is enabled it is currently impossible to seek pas to the maxTimeLoaded value because maxTimeSeekable() returns it. Making that method return the value of duration() should fix the issue. 243740 1 59904 pnormand 2010-06-28 09:56:44 -0700 Created attachment 59904 proposed patch 243831 2 slomo 2010-06-28 12:50:44 -0700 Works good for me, thanks. Please get this into the next 1.2 release too 245554 3 59904 xan.lopez 2010-07-01 14:31:54 -0700 Comment on attachment 59904 proposed patch Makes sense to me. 245829 4 pnormand 2010-07-02 01:49:04 -0700 Landed in http://trac.webkit.org/changeset/62371 Thanks! 245835 5 webkit.review.bot 2010-07-02 02:10:00 -0700 http://trac.webkit.org/changeset/62371 might have broken GTK Linux 32-bit Release 245841 6 pnormand 2010-07-02 02:54:15 -0700 Breaks media/controls-drag-timebar.html on 32-Bit GTK Release. --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/controls-drag-timebar-expected.txt 2010-07-02 02:44:46.000000000 -0700 +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/media/controls-drag-timebar-actual.txt 2010-07-02 02:44:46.000000000 -0700 @@ -8,6 +8,6 @@ EVENT(seeked) Time: 2.7 EVENT(seeked) -Time: 3.2 +Time: 3.5 END OF TEST 245842 7 59904 pnormand 2010-07-02 02:54:40 -0700 Comment on attachment 59904 proposed patch Clearing flags 245844 8 pnormand 2010-07-02 02:58:11 -0700 (In reply to comment #6) > Breaks media/controls-drag-timebar.html on 32-Bit GTK Release. > And of course this test passes fine for me :P I'll try to reproduce it on my laptop and investigate the failure if I reproduce it. Otherwise I'd appreciate a gst debug log from kov's bot when it runs DRT with the patch applied for the failing test. 245906 9 pnormand 2010-07-02 07:11:26 -0700 I was able to reproduce the failure on my laptop. The patch introduced a change of behavior of updateStates() that triggered the issue. A new patch is coming ;) 245907 10 60365 pnormand 2010-07-02 07:17:30 -0700 Created attachment 60365 proposed patch 247105 11 60365 xan.lopez 2010-07-06 09:46:50 -0700 Comment on attachment 60365 proposed patch OK! 247114 12 pnormand 2010-07-06 10:18:15 -0700 Landed as http://trac.webkit.org/changeset/62561 with a new comment, as discussed with Xan. Thanks! 59904 2010-06-28 09:56:44 -0700 2010-07-02 07:17:30 -0700 proposed patch proposed-patch.patch text/plain 2215 pnormand RnJvbSA3OGVhYzA5ZThmNjMyNWVjMzhmZmYwNGVjMzYwMmVmMjAyYmI3ODc2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBNb24sIDI4IEp1biAyMDEwIDE4OjU2OjM0ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cHJvcG9zZWQgcGF0Y2gKCi0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgIDE1ICsrKysrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgICAgfCAgICA3ICsrLS0tLS0KIDIgZmlsZXMg Y2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDI4NGJmNGEuLjkxM2Jh N2UgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDYtMjggIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFu ZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtHU3RyZWFtZXJdIGNhbid0IHNlZWsgcGFzdCBtYXhUaW1lTG9hZGVkIHZhbHVlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDUyNgorCisg ICAgICAgIEV4dGVuZGVkIHRoZSBzZWVrYWJsZSByYW5nZSB0byB0aGUgd2hvbGUgbWVkaWEuIFRo aXMgYWxsb3dzIHZpZGVvCisgICAgICAgIHBsYXllZCB3aXRoIHByb2dyZXNzaXZlIGRvd25sb2Fk IHRvIGJlIHNlZWtlZCBwYXN0IHRoZSBjdXJyZW50CisgICAgICAgIGJ1ZmZlcmVkIHBvc2l0aW9u LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXI6Om1heFRpbWVTZWVrYWJsZSk6CisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXI6OnVwZGF0ZVN0YXRlcyk6CisKIDIwMTAtMDYtMjggIFhhbiBMb3Bl eiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBs YXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCAyOWFjMzU2Li5mNjll Mzc4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTc2NCw3ICs3 NjQsNyBAQCBmbG9hdCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Om1heFRpbWVTZWVrYWJs ZSgpIGNvbnN0CiAgICAgaWYgKGlzaW5mKGR1cmF0aW9uKCkpKQogICAgICAgICByZXR1cm4gMC4w ZjsKIAotICAgIHJldHVybiBtYXhUaW1lTG9hZGVkKCk7CisgICAgcmV0dXJuIGR1cmF0aW9uKCk7 CiB9CiAKIGZsb2F0IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6bWF4VGltZUxvYWRlZCgp IGNvbnN0CkBAIC05MjAsMTAgKzkyMCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVh bWVyOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICAgICAgZ3N0X2VsZW1lbnRfc3RhdGVfZ2V0X25h bWUocGVuZGluZykpOwogICAgICAgICAvLyBDaGFuZ2UgaW4gcHJvZ3Jlc3MKIAotICAgICAgICBp ZiAoIW1faXNTdHJlYW1pbmcpCi0gICAgICAgICAgICByZXR1cm47Ci0KLSAgICAgICAgLy8gUmVz dW1lIHBsYXliYWNrIGlmIGEgc2VlayB3YXMgcGVyZm9ybWVkIGluIGEgbGl2ZSBwaXBlbGluZS4K KyAgICAgICAgLy8gUmVzdW1lIHBsYXliYWNrIGlmIGEgc2VlayB3YXMgcGVyZm9ybWVkLgogICAg ICAgICBpZiAobV9zZWVraW5nKSB7CiAgICAgICAgICAgICBzaG91bGRVcGRhdGVBZnRlclNlZWsg PSB0cnVlOwogICAgICAgICAgICAgbV9zZWVraW5nID0gZmFsc2U7Ci0tIAoxLjcuMQ== 60365 2010-07-02 07:17:30 -0700 2010-07-06 09:46:50 -0700 proposed patch proposed-patch.patch text/plain 2114 pnormand RnJvbSA2NWMyYzEyODZmYTE1YmUzYTRkZTAxNDlhMjYwNTQ0Mzg1ODI1NTIxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBGcmksIDIgSnVsIDIwMTAgMTY6MDc6MzAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBw cm9wb3NlZCBwYXRjaAoKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKysrKysrKysrCiAuLi4vZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICAgICB8ICAgIDQgKystLQogMiBmaWxlcyBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzRiOTRjNi4uZTVlNzA5NyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMC0wNy0wMiAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGln YWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0dTdHJlYW1lcl0gY2FuJ3Qgc2VlayBwYXN0IG1heFRpbWVMb2FkZWQgdmFsdWUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNTI2CisKKyAgICAg ICAgRXh0ZW5kZWQgdGhlIHNlZWthYmxlIHJhbmdlIHRvIHRoZSB3aG9sZSBtZWRpYS4gVGhpcyBh bGxvd3MgdmlkZW8KKyAgICAgICAgcGxheWVkIHdpdGggcHJvZ3Jlc3NpdmUgZG93bmxvYWQgdG8g YmUgc2Vla2VkIHBhc3QgdGhlIGN1cnJlbnQKKyAgICAgICAgYnVmZmVyZWQgcG9zaXRpb24uCisK KyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lcjo6bWF4VGltZVNlZWthYmxlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lcjo6dXBkYXRlU3RhdGVzKToKKwogMjAxMC0wNy0wMiAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBG ZWxkbWFuLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggMjlhYzM1 Ni4uODg0YTFhNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFt ZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC03 NjQsNyArNzY0LDcgQEAgZmxvYXQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjptYXhUaW1l U2Vla2FibGUoKSBjb25zdAogICAgIGlmIChpc2luZihkdXJhdGlvbigpKSkKICAgICAgICAgcmV0 dXJuIDAuMGY7CiAKLSAgICByZXR1cm4gbWF4VGltZUxvYWRlZCgpOworICAgIHJldHVybiBkdXJh dGlvbigpOwogfQogCiBmbG9hdCBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6Om1heFRpbWVM b2FkZWQoKSBjb25zdApAQCAtOTIwLDcgKzkyMCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyOjp1cGRhdGVTdGF0ZXMoKQogICAgICAgICAgICAgZ3N0X2VsZW1lbnRfc3RhdGVf Z2V0X25hbWUocGVuZGluZykpOwogICAgICAgICAvLyBDaGFuZ2UgaW4gcHJvZ3Jlc3MKIAotICAg ICAgICBpZiAoIW1faXNTdHJlYW1pbmcpCisgICAgICAgIGlmICghbV9pc1N0cmVhbWluZyAmJiAh bV9idWZmZXJpbmcpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgLy8gUmVzdW1lIHBs YXliYWNrIGlmIGEgc2VlayB3YXMgcGVyZm9ybWVkIGluIGEgbGl2ZSBwaXBlbGluZS4KLS0gCjEu Ni4zLjM=