40520 2010-06-12 04:47:29 -0700 Support interactive form validation in quirks mode 2011-05-05 15:08:14 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 40218 28649 1 Ms2ger webkit-unassigned ap ayg darin dglazkov ian mike mjs tkent oldest_to_newest 237277 0 Ms2ger 2010-06-12 04:47:29 -0700 HTML5 requires interactive form validation in all modes. 237658 1 tkent 2010-06-13 18:52:26 -0700 (In reply to comment #0) As you know, I disabled the interactive validation in non-strict modes in http://trac.webkit.org/changeset/61059 > HTML5 requires interactive form validation in all modes. I don't think so. If the specification asked to do so, we would violate it in WebKit. Safari 5 and Chrome 5 support the interactive validation in all modes for now, but it made multiple compatibility issues or users faced form validation bugs unnecessarily. http://crbug.com/44048 http://crbug.com/45640 http://crbug.com/45831 http://crbug.com/46335 http://crbug.com/46358 https://bugs.webkit.org/show_bug.cgi?id=40429 237676 2 ian 2010-06-13 20:07:32 -0700 > > HTML5 requires interactive form validation in all modes. > > I don't think so. Where does it say otherwise? > If the specification asked to do so, we would violate it in WebKit. That's not how standards work. When you find something in the spec you don't like, you bring it up with the working group, you don't just unilaterally get to ignore the spec. Otherwise, you're no better than Microsoft. Send an e-mail to whatwg@whatwg.org saying what the problems were, and we'll fix the spec. It won't be by adding yet more quirks differences. Note that Chrome is very buggy if it is just blocking form submission without telling the user why. 237699 3 tkent 2010-06-13 21:38:23 -0700 (In reply to comment #2) > > > HTML5 requires interactive form validation in all modes. > > > > I don't think so. > > Where does it say otherwise? [1] says: Note: DOCTYPEs are required for legacy reasons. When omitted, browsers tend to use a different rendering mode that is incompatible with some specifications. Including the DOCTYPE in a document ensures that the browser makes a best-effort attempt at following the relevant specifications. The interactive form validation is incompatible with prior HTMLs. So browsers may disable it for non-HTML5 modes to follow prior HTML specifications. > That's not how standards work. When you find something in the spec you don't like, you bring it up with the working group, you don't just unilaterally get to ignore the spec. Otherwise, you're no better than Microsoft. Send an e-mail to whatwg@whatwg.org saying what the problems were, and we'll fix the spec. It won't be by adding yet more quirks differences. I posted a part of issues to whatwg. See the thread with subject "Form validation against invisible controls", and my conclusion is to disable the interactive validation in non-HTML5 modes. I'll post this conclusion soon. > Note that Chrome is very buggy if it is just blocking form submission without telling the user why. yeah, I understand it. [1] http://www.whatwg.org/specs/web-apps/current-work/multipage/syntax.html#the-doctype 238079 4 mjs 2010-06-14 15:21:25 -0700 I think the fix for bug 40218 was wrong. Limiting a new feature to strict mode is not an appropriate way to deal with Web compatibility problems. Instead, we should get the standard changed. Here are my comments from that bug: --------- Existing HTML4 sites can also be in strict mode. In fact, a fair number of HTML4 sites have a standards mode or almost standards mode doctype. I don't think we should make new features be based on a modeswitch. The philosophy of HTML5 is to make new features backwards-compatible so they can be progressively deployed on existing sites. If HTML5 @required causes too much compatibility fallout, then we should: (a) Remove HTML5 @required support entirely for now. (b) Report our findings to the HTML WG and proposed renaming the attribute. I don't think making the feature strict-mode only is an appropriate fix. ---------- 238193 5 tkent 2010-06-14 18:50:20 -0700 ok, I'll revert r61059 when - The current whatwg discussion makes an agreement and a WebKit change for it is landed if needed, and - Bug#31718 and some platform implementation are completed. I have received some complaints about no validation message when form submission is blocked. Make sense? 244575 6 mjs 2010-06-29 17:44:30 -0700 (In reply to comment #5) > ok, I'll revert r61059 when > - The current whatwg discussion makes an agreement and a WebKit change for it is landed if needed, and > - Bug#31718 and some platform implementation are completed. > I have received some complaints about no validation message when form submission is blocked. > > Make sense? I think the right thing to do in the short term would be to disable @required entirely, or to make it a non-default runtime switch, rather than to disable it only in quirks mode. Making it a standards-mode-only feature is worse than disabling it entirely, in my opinion. 244577 7 darin 2010-06-29 17:49:38 -0700 (In reply to comment #6) > I think the right thing to do in the short term would be to disable @required entirely, or to make it a non-default runtime switch, rather than to disable it only in quirks mode. Making it a standards-mode-only feature is worse than disabling it entirely, in my opinion. I agree with Maciej about the short term. 245234 8 60218 tkent 2010-07-01 03:02:11 -0700 Created attachment 60218 Patch 255071 9 60218 ojan 2010-07-22 16:54:22 -0700 Comment on attachment 60218 Patch > + // This setting will be removed when an HTML5 compatibility issue is > + // resolvled and WebKit implementation of interactive validation is Typo: resolved 256419 10 tkent 2010-07-27 00:17:01 -0700 (In reply to comment #9) > (From update of attachment 60218 [details]) > > + // This setting will be removed when an HTML5 compatibility issue is > > + // resolvled and WebKit implementation of interactive validation is > > Typo: resolved Fixed. 256424 11 tkent 2010-07-27 00:32:16 -0700 Landed as r64110. 399037 12 60218 webkit.review.bot 2011-05-05 14:26:40 -0700 Comment on attachment 60218 Patch Attachment 92436 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8571537 399090 13 60218 webkit.review.bot 2011-05-05 15:08:14 -0700 Comment on attachment 60218 Patch Attachment 92436 did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/8589039 60218 2010-07-01 03:02:11 -0700 2011-05-05 15:08:14 -0700 Patch bug-40520-20100701190209.patch text/plain 13479 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMjI4ODEwNDM1MmFiZDdhOWI3M2E0NjlmNzc3ZDMyMTc1OTFmN2IwLi43M2E5ZTA2 OGE0ODJkM2VjZThmZjU3OTA5YzA0NGExMjQxMWM2NmU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAK KzIwMTAtMDctMDEgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIHJ1bnRpbWUgc2V0 dGluZyBmb3IgaW50ZXJhY3RpdmUgZm9ybSB2YWxpZGF0aW9uLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1MjAKKworICAgICAgICBSZW1vdmUgdGhl IG1vZGUtc3BlY2lmaWMgdGVzdHMgYW5kIHNraXAgdGVzdHMgd2hpY2ggZG9uJ3Qgd29yaworICAg ICAgICB3aXRob3V0IHRoZSBpbnRlcmFjdGl2ZSB2YWxpZGF0aW9uIGZlYXR1cmUuCisKKyAgICAg ICAgKiBmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUtZXhwZWN0 ZWQudHh0OiBSZW1vdmVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRh dGlvbi1jb21wYXQtbW9kZS5odG1sOiBSZW1vdmVkLgorICAgICAgICAqIGZhc3QvZm9ybXMvaW50 ZXJhY3RpdmUtdmFsaWRhdGlvbi1odG1sNC1leHBlY3RlZC50eHQ6IFJlbW92ZWQuCisgICAgICAg ICogZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWh0bWw0Lmh0bWw6IFJlbW92ZWQu CisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0OgorICAg ICAgICAqIHBsYXRmb3JtL2d0ay9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lw cGVkOgorICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6CisgICAgICAgICogcGxhdGZvcm0v d2luL1NraXBwZWQ6CisKIDIwMTAtMDYtMzAgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGZpeC4gVXBkYXRlIFF0IHNwZWNpZmljIGV4 cGVjdGVkIGZpbGVzIGFmdGVyIHI2MjIxNS4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Zm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUt ZXhwZWN0ZWQudHh0CmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCBhOTQ2MGJlMjMzMGYw NzZmOGQxYTNhMjk4ZmE2NmRlYTE3NjA5ZDFhLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFs aWRhdGlvbi1jb21wYXQtbW9kZS1leHBlY3RlZC50eHQKKysrIC9kZXYvbnVsbApAQCAtMSw5ICsw LDAgQEAKLVRlc3QgaWYgYW4gaW52YWxpZCBmb3JtIGluIGEgZG9jdW1lbnQgd2l0aG91dCBET0NU WVBFIGlzIHN1Ym1pdHRlZC4KLQotT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9m ICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgotCi0KLVBBU1Mg VGhlIGZvcm0gc2hvdWxkIGJlIHN1Ym1pdHRlZC4KLVBBU1MgbG9jYXRpb24uc2VhcmNoLmluZGV4 T2YoImkwPSIpICE9IC0xIGlzIHRydWUKLVRFU1QgQ09NUExFVEUKLSAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS5o dG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWNvbXBh dC1tb2RlLmh0bWwKZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDU4ZDg4NjJkMzE0YWNj ZjdjMWI5MGIxZWFkOWE4MzBmMmE0N2YxNzEuLjAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxp ZGF0aW9uLWNvbXBhdC1tb2RlLmh0bWwKKysrIC9kZXYvbnVsbApAQCAtMSwzNyArMCwwIEBACi08 aHRtbD4KLTxoZWFkPgotPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8uLi9mYXN0L2pz L3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Ci08c2NyaXB0IHNyYz0iLi4vLi4vZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgotPC9oZWFkPgotPGJvZHk+Ci08 cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KLTxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgotPGZvcm0g aWQ9ZiBhY3Rpb249ImludGVyYWN0aXZlLXZhbGlkYXRpb24tY29tcGF0LW1vZGUuaHRtbCI+Ci08 aW5wdXQgdHlwZT1oaWRkZW4gbmFtZT1zdWJtaXR0ZWQgdmFsdWU9InRydWUiPgotPGlucHV0IG5h bWU9aTAgcmVxdWlyZWQgaWQ9ImkwIj4KLTxpbnB1dCB0eXBlPXN1Ym1pdCBpZD0icyI+Ci08L2Zv cm0+Ci08c2NyaXB0PgotZGVzY3JpcHRpb24oJ1Rlc3QgaWYgYW4gaW52YWxpZCBmb3JtIGluIGEg ZG9jdW1lbnQgd2l0aG91dCBET0NUWVBFIGlzIHN1Ym1pdHRlZC4nKTsKLQotZnVuY3Rpb24gc3Rh cnRPclZlcmlmeSgpIHsKLSAgICB2YXIgcXVlcnkgPSB3aW5kb3cubG9jYXRpb24uc2VhcmNoOwot ICAgIGlmIChxdWVyeS5pbmRleE9mKCdzdWJtaXR0ZWQ9dHJ1ZScpICE9IC0xKSB7Ci0gICAgICAg IHRlc3RQYXNzZWQoJ1RoZSBmb3JtIHNob3VsZCBiZSBzdWJtaXR0ZWQuJyk7Ci0gICAgICAgIHNo b3VsZEJlVHJ1ZSgnbG9jYXRpb24uc2VhcmNoLmluZGV4T2YoImkwPSIpICE9IC0xJyk7Ci0gICAg ICAgIGRlYnVnKCdURVNUIENPTVBMRVRFJyk7Ci0gICAgICAgIGlmICh3aW5kb3cubGF5b3V0VGVz dENvbnRyb2xsZXIpCi0gICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5ub3RpZnlEb25l KCk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgLy8gSFRNTEZvcm1FbGVtZW50OjpzdWJtaXQoKSBz a2lwcyB2YWxpZGF0aW9uLiBVc2UgdGhlIHN1Ym1pdCBidXR0b24uCi0gICAgICAgIGRvY3VtZW50 LmdldEVsZW1lbnRCeUlkKCdzJykuY2xpY2soKTsKLSAgICAgICAgdGVzdEZhaWxlZCgnVGhlIGZv cm0gd2FzIG5vdCBzdWJtaXR0ZWQuJyk7Ci0gICAgfQotfQotCi1pZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQotICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsK LXdpbmRvdy5vbmxvYWQgPSBzdGFydE9yVmVyaWZ5OwotPC9zY3JpcHQ+Ci08L2JvZHk+Ci08L2h0 bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlk YXRpb24taHRtbDQtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9pbnRlcmFj dGl2ZS12YWxpZGF0aW9uLWh0bWw0LWV4cGVjdGVkLnR4dApkZWxldGVkIGZpbGUgbW9kZSAxMDA2 NDQKaW5kZXggYTk0NjBiZTIzMzBmMDc2ZjhkMWEzYTI5OGZhNjZkZWExNzYwOWQxYS4uMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0 L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24taHRtbDQtZXhwZWN0ZWQudHh0CisrKyAvZGV2 L251bGwKQEAgLTEsOSArMCwwIEBACi1UZXN0IGlmIGFuIGludmFsaWQgZm9ybSBpbiBhIGRvY3Vt ZW50IHdpdGhvdXQgRE9DVFlQRSBpcyBzdWJtaXR0ZWQuCi0KLU9uIHN1Y2Nlc3MsIHlvdSB3aWxs IHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBM RVRFIi4KLQotCi1QQVNTIFRoZSBmb3JtIHNob3VsZCBiZSBzdWJtaXR0ZWQuCi1QQVNTIGxvY2F0 aW9uLnNlYXJjaC5pbmRleE9mKCJpMD0iKSAhPSAtMSBpcyB0cnVlCi1URVNUIENPTVBMRVRFCi0g CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRp b24taHRtbDQuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRh dGlvbi1odG1sNC5odG1sCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAzM2ZhNDRkMzI3 ODk2ZThkNzQ1ZjNhNjdmODc3NjAyY2U5OGJhZTUyLi4wMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwCi0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUt dmFsaWRhdGlvbi1odG1sNC5odG1sCisrKyAvZGV2L251bGwKQEAgLTEsMzkgKzAsMCBAQAotPCFE T0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFsLy9F TiIKLSAiaHR0cDovL3d3dy53My5vcmcvVFIvaHRtbDQvbG9vc2UuZHRkIj4KLTxodG1sPgotPGhl YWQ+Ci08bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2Zhc3QvanMvcmVzb3VyY2Vz L2pzLXRlc3Qtc3R5bGUuY3NzIj4KLTxzY3JpcHQgc3JjPSIuLi8uLi9mYXN0L2pzL3Jlc291cmNl cy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Ci08L2hlYWQ+Ci08Ym9keT4KLTxwIGlkPSJkZXNj cmlwdGlvbiI+PC9wPgotPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+Ci08Zm9ybSBpZD1mIGFjdGlv bj0iaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1jb21wYXQtbW9kZS5odG1sIj4KLTxpbnB1dCB0eXBl PWhpZGRlbiBuYW1lPXN1Ym1pdHRlZCB2YWx1ZT0idHJ1ZSI+Ci08aW5wdXQgbmFtZT1pMCByZXF1 aXJlZCBpZD0iaTAiPgotPGlucHV0IHR5cGU9c3VibWl0IGlkPSJzIj4KLTwvZm9ybT4KLTxzY3Jp cHQ+Ci1kZXNjcmlwdGlvbignVGVzdCBpZiBhbiBpbnZhbGlkIGZvcm0gaW4gYSBkb2N1bWVudCB3 aXRoIEhUTUw0LjAxIERPQ1RZUEUgaXMgc3VibWl0dGVkLicpOwotCi1mdW5jdGlvbiBzdGFydE9y VmVyaWZ5KCkgewotICAgIHZhciBxdWVyeSA9IHdpbmRvdy5sb2NhdGlvbi5zZWFyY2g7Ci0gICAg aWYgKHF1ZXJ5LmluZGV4T2YoJ3N1Ym1pdHRlZD10cnVlJykgIT0gLTEpIHsKLSAgICAgICAgdGVz dFBhc3NlZCgnVGhlIGZvcm0gc2hvdWxkIGJlIHN1Ym1pdHRlZC4nKTsKLSAgICAgICAgc2hvdWxk QmVUcnVlKCdsb2NhdGlvbi5zZWFyY2guaW5kZXhPZigiaTA9IikgIT0gLTEnKTsKLSAgICAgICAg ZGVidWcoJ1RFU1QgQ09NUExFVEUnKTsKLSAgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikKLSAgICAgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLm5vdGlmeURvbmUoKTsK LSAgICB9IGVsc2UgewotICAgICAgICAvLyBIVE1MRm9ybUVsZW1lbnQ6OnN1Ym1pdCgpIHNraXBz IHZhbGlkYXRpb24uIFVzZSB0aGUgc3VibWl0IGJ1dHRvbi4KLSAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoJ3MnKS5jbGljaygpOwotICAgICAgICB0ZXN0RmFpbGVkKCdUaGUgZm9ybSB3 YXMgbm90IHN1Ym1pdHRlZC4nKTsKLSAgICB9Ci19Ci0KLWlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpCi0gICAgbGF5b3V0VGVzdENvbnRyb2xsZXIud2FpdFVudGlsRG9uZSgpOwotd2lu ZG93Lm9ubG9hZCA9IHN0YXJ0T3JWZXJpZnk7Ci08L3NjcmlwdD4KLTwvYm9keT4KLTwvaHRtbD4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRp b25zLnR4dCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL3Rlc3RfZXhwZWN0YXRpb25z LnR4dAppbmRleCBjZmIxYzliZWU4NTdiOGIzNWNjODQwNGQ2MDk2NDVjZjAxZDEzMDgyLi4zMWNk NjJkZWI1YzQ4MDQ1Zjg2NGE2ZjQxNzI2MTFmMzFlZjJhMTM5IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS90ZXN0X2V4cGVjdGF0aW9ucy50eHQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vdGVzdF9leHBlY3RhdGlvbnMudHh0CkBAIC03MTcsNiAr NzE3LDEwIEBAIEJVRzIwMjI2IERFRkVSIDogZmFzdC9mb3Jtcy9kYXRhbGlzdC5odG1sID0gVEVY VAogQlVHMjAyMjYgREVGRVIgOiBmYXN0L2Zvcm1zL2lucHV0LWxpc3QuaHRtbCA9IEZBSUwKIEJV RzIwMjI2IERFRkVSIDogZmFzdC9mb3Jtcy9pbnB1dC1zZWxlY3RlZG9wdGlvbi5odG1sID0gRkFJ TAogCisvLyBUaGUgZmVhdHVyZSB3YXMgZGlzYWJsZWQgZHVlIHRvIGEgY29tcGF0aWJpbGl0eSBp c3N1ZS4KK0JVR1dLNDA1MjAgREVGRVIgOiBmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRp b24tbG9zdC1mb2N1c2FibGUuaHRtbCA9IFRFWFQKK0JVR1dLNDA1MjAgREVGRVIgOiBmYXN0L2Zv cm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tcHJldmVudGVkLmh0bWwgPSBURVhUCisKIC8vIEFk ZCBzdXBwb3J0IGZvciBpbnNwZWN0b3IgbGF5b3V0IHRlc3RzLgogQlVHMjY3MzQgTElOVVggTUFD IFNLSVAgOiBpbnNwZWN0b3IgPSBQQVNTCiBCVUcyNjczNCBMSU5VWCBNQUMgU0tJUCA6IGh0dHAv dGVzdHMvaW5zcGVjdG9yID0gUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL1NraXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZAppbmRleCA3MWU0 NGIzNTllZDFhNGJlZDlhYmUzNzM0MmM2ZDMzZGFiM2MxODI2Li5kOTAxNGIwMDIwZmU1ODc2NzIw NGVlMjAzZDA2NDFiOTNiN2E5MTFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n dGsvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZApAQCAtNTgy MywzICs1ODIzLDggQEAgZmFzdC9qcy9zcHV0bmlrL0NvbmZvcm1hbmNlLzEwX0V4ZWN1dGlvbl9D b250ZXh0cy8xMC4yX0VudGVyaW5nX0FuX0V4ZWN1dGlvbl9Db24KICMgcGFzdGVzIGEgc3BhY2Ug aW5zdGVhZCBvZiBhIHRhYgogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mzg0MzcKIGVkaXRpbmcvcGFzdGVib2FyZC81NzYxNTMwLTEuaHRtbAorCisjIFRoZSBmZWF0 dXJlIHdhcyBkaXNhYmxlZCBkdWUgdG8gYSBjb21wYXRpYmlsaXR5IGlzc3VlLgorIyBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1MjAKK2Zhc3QvZm9ybXMvaW50ZXJh Y3RpdmUtdmFsaWRhdGlvbi1sb3N0LWZvY3VzYWJsZS5odG1sCitmYXN0L2Zvcm1zL2ludGVyYWN0 aXZlLXZhbGlkYXRpb24tcHJldmVudGVkLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQKaW5k ZXggMTg1YjBmMTNjNGQ1NWY1NzE4YTY4OTcwYjAzNTY3YjRhYjc5Njk1MC4uNjIzOTQxOTU5NDg3 OGE4NTUyNjUyNmVhMWM4NTgxMTMzNTBiOWY1YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxh dGZvcm0vbWFjL1NraXBwZWQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL1NraXBwZWQK QEAgLTMwMiwzICszMDIsOCBAQCBodHRwL3Rlc3RzL211bHRpcGFydC9wb2xpY3ktaWdub3JlLWNy YXNoLnBocAogIyBwYXN0ZXMgYSBzcGFjZSBpbnN0ZWFkIG9mIGEgdGFiCiAjIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODQzNwogZWRpdGluZy9wYXN0ZWJvYXJkLzU3 NjE1MzAtMS5odG1sCisKKyMgVGhlIGZlYXR1cmUgd2FzIGRpc2FibGVkIGR1ZSB0byBhIGNvbXBh dGliaWxpdHkgaXNzdWUuCisjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD00MDUyMAorZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLWxvc3QtZm9jdXNhYmxl Lmh0bWwKK2Zhc3QvZm9ybXMvaW50ZXJhY3RpdmUtdmFsaWRhdGlvbi1wcmV2ZW50ZWQuaHRtbApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggYzMyOWRlZTFmNWY0NTc5NDgxMTA0ZDE5YzU3ZmZj ODkzNzhhNWM0NC4uZDY0MTAyNjRlMGUxMjRlYmE4N2ZjNzU2OGRkNWFlZmUxZDRhNzBkNiAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC01NDMwLDMgKzU0MzAsOCBAQCBpbnNwZWN0b3IvZGVi dWdnZXItcHJvdG8tcHJvcGVydHkuaHRtbAogIyBbUXRdIGZhc3QvdGV4dC9iaWRpLWV4cGxpY2l0 LWVtYmVkZGluZy1wYXN0LWVuZC5odG1sIGZhaWxzCiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MTI0MQogZmFzdC90ZXh0L2JpZGktZXhwbGljaXQtZW1iZWRkaW5n LXBhc3QtZW5kLmh0bWwKKworIyBUaGUgZmVhdHVyZSB3YXMgZGlzYWJsZWQgZHVlIHRvIGEgY29t cGF0aWJpbGl0eSBpc3N1ZS4KKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwNTIwCitmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tbG9zdC1mb2N1c2Fi bGUuaHRtbAorZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLXByZXZlbnRlZC5odG1s CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCmluZGV4IDg1ZWMyZWI3YmQwY2FlYWQ2MjFlY2YzOWQz NjdlZTU1MjU2OThjNWIuLjc0MzQxOWU5OGQ1N2YxNjI3YzEwNDdjNjAwNmQ2YzBhNWVkNjJiMTYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCisrKyBiL0xheW91 dFRlc3RzL3BsYXRmb3JtL3dpbi9Ta2lwcGVkCkBAIC05MzYsNCArOTM2LDcgQEAgZmFzdC9qcy9z cHV0bmlrL0NvbmZvcm1hbmNlLzEwX0V4ZWN1dGlvbl9Db250ZXh0cy8xMC4yX0VudGVyaW5nX0Fu X0V4ZWN1dGlvbl9Db24KICMgTGF5b3V0VGVzdENvbnRyb2xsZXI6OmlzUGFnZUJveFZpc2libGUs IHBhZ2VBcmVhUmVjdEluUGl4ZWxzLCBhbmQgcHJlZmVycmVkUGFnZVNpemVJblBpeGVscyBhcmUg bm90IGltcGxlbWVudGVkIHlldCBmb3IgV0lOLgogcHJpbnRpbmcvcGFnZS1mb3JtYXQtZGF0YS5o dG1sCiAKLQorIyBUaGUgZmVhdHVyZSB3YXMgZGlzYWJsZWQgZHVlIHRvIGEgY29tcGF0aWJpbGl0 eSBpc3N1ZS4KKyMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNTIw CitmYXN0L2Zvcm1zL2ludGVyYWN0aXZlLXZhbGlkYXRpb24tbG9zdC1mb2N1c2FibGUuaHRtbAor ZmFzdC9mb3Jtcy9pbnRlcmFjdGl2ZS12YWxpZGF0aW9uLXByZXZlbnRlZC5odG1sCmRpZmYgLS1n aXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ3ZGViNWFi ZTQ0Yjg2NjVlMTgyYTU0ODQ1MjE4YzhmMzgyMTE0NzMuLjA4YTBlYWJiYjJiN2YyZDgxMjUxOGJh NTZmNTY4YmRlMThkNzllOWMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYgQEAKKzIwMTAtMDctMDEgIEtlbnQgVGFtdXJh ICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBhIHJ1bnRpbWUgc2V0dGluZyBmb3IgaW50ZXJhY3RpdmUgZm9y bSB2YWxpZGF0aW9uLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDA1MjAKKworICAgICAgICBUaGUgaW50ZXJhY3RpdmUgdmFsaWRhdGlvbiBmZWF0dXJl IHdhcyBkaXNhYmxlZCBmb3Igbm9uLXN0cmljdAorICAgICAgICBtb2RlcyBieSByNjEwNTkgdG8g YXZvaWQgYSBjb21wYXRpYmlsaXR5IGlzc3VlLiBUaGlzIHJlbW92ZXMgdGhlCisgICAgICAgIG1v ZGUgY2hlY2tpbmcgYW5kIGludHJvZHVjZSBhIHJ1bnRpbWUgc2V0dGluZyB0byBlbmFibGUvZGlz YWJsZQorICAgICAgICB0aGUgZmVhdHVyZSBpbnN0ZWFkLgorICAgICAgICBUaGUgZGVmYXVsdCB2 YWx1ZSBpcyAnZGlzYWJsZScgYW5kIHdlJ2xsIHJlbW92ZSB0aGUgc2V0dGluZyB3aGVuCisgICAg ICAgIHRoZSBjb21wYXRpYmlsaXR5IGlzc3VlIGlzIHJlc29sdmVkIGFuZCBpbnRlcmFjdGl2ZSB2 YWxpZGF0aW9uCisgICAgICAgIGltcGxlbWVudGF0aW9uIGlzIGNvbXBsZXRlZC4KKworICAgICAg ICAqIGh0bWwvSFRNTEZvcm1FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3Jt RWxlbWVudDo6dmFsaWRhdGVJbnRlcmFjdGl2ZWx5KToKKyAgICAgICAgKiBwYWdlL1NldHRpbmdz LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpTZXR0aW5ncyk6CisgICAgICAgICog cGFnZS9TZXR0aW5ncy5oOgorICAgICAgICAoV2ViQ29yZTo6U2V0dGluZ3M6OnNldEludGVyYWN0 aXZlRm9ybVZhbGlkYXRpb25FbmFibGVkKToKKyAgICAgICAgKFdlYkNvcmU6OlNldHRpbmdzOjpp bnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCk6CisKIDIwMTAtMDYtMzAgIENzYWJhIE9z enRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxk Zml4IGFmdGVyIHI2MjE5NiBhbmQgcjYyMjE0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hU TUxGb3JtRWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcAppbmRl eCAyZWZhY2UyZWJkNjkxNzQwZTRhZmIxZjdkNWQ4NDcyYmVmMTI3YzExLi44MDYzYTIzMTRkMzI0 M2E5MDJiZGM1MmE3ZTViN2Q1YmE4NGMzZTY0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvSFRN TEZvcm1FbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTEZvcm1FbGVtZW50LmNwcApA QCAtNDYsOCArNDYsMTAgQEAKICNpbmNsdWRlICJIVE1MSW5wdXRFbGVtZW50LmgiCiAjaW5jbHVk ZSAiSFRNTE5hbWVzLmgiCiAjaW5jbHVkZSAiTUlNRVR5cGVSZWdpc3RyeS5oIgorI2luY2x1ZGUg IlBhZ2UuaCIKICNpbmNsdWRlICJSZW5kZXJUZXh0Q29udHJvbC5oIgogI2luY2x1ZGUgIlNjcmlw dEV2ZW50TGlzdGVuZXIuaCIKKyNpbmNsdWRlICJTZXR0aW5ncy5oIgogI2luY2x1ZGUgIlZhbGlk aXR5U3RhdGUuaCIKICNpbmNsdWRlIDxsaW1pdHM+CiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1l Lmg+CkBAIC0yNzksNyArMjgxLDcgQEAgc3RhdGljIGlubGluZSBIVE1MRm9ybUNvbnRyb2xFbGVt ZW50KiBzdWJtaXRFbGVtZW50RnJvbUV2ZW50KGNvbnN0IEV2ZW50KiBldmVudCkKIGJvb2wgSFRN TEZvcm1FbGVtZW50Ojp2YWxpZGF0ZUludGVyYWN0aXZlbHkoRXZlbnQqIGV2ZW50KQogewogICAg IEFTU0VSVChldmVudCk7Ci0gICAgaWYgKCFkb2N1bWVudCgpLT5pblN0cmljdE1vZGUoKSB8fCBu b1ZhbGlkYXRlKCkpCisgICAgaWYgKCFkb2N1bWVudCgpLT5wYWdlKCkgfHwgIWRvY3VtZW50KCkt PnBhZ2UoKS0+c2V0dGluZ3MoKS0+aW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbkVuYWJsZWQoKSB8 fCBub1ZhbGlkYXRlKCkpCiAgICAgICAgIHJldHVybiB0cnVlOwogCiAgICAgSFRNTEZvcm1Db250 cm9sRWxlbWVudCogc3VibWl0RWxlbWVudCA9IHN1Ym1pdEVsZW1lbnRGcm9tRXZlbnQoZXZlbnQp OwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcCBiL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5jcHAKaW5kZXggNGNkZjVmODYxMzNkOTg1NDBiZjE4Y2JiNTNjMmI3NzExZDhlMDAw OC4uMWMyNmFkZjI5ZjAwMTk2OTcyZGNmZWI2MzM2M2YyYzMxNThlMTc1MiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wYWdlL1NldHRpbmdzLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvU2V0dGluZ3MuY3Bw CkBAIC0xMzUsNiArMTM1LDcgQEAgU2V0dGluZ3M6OlNldHRpbmdzKFBhZ2UqIHBhZ2UpCiAgICAg LCBtX2h0bWw1UGFyc2VyRW5hYmxlZCh0cnVlKQogICAgICwgbV9odG1sNVRyZWVCdWlsZGVyRW5h YmxlZChmYWxzZSkgLy8gV2lsbCBiZSBkZWxldGVkIHNvb24sIGRvIG5vdCB1c2UuCiAgICAgLCBt X3BhZ2luYXRlRHVyaW5nTGF5b3V0RW5hYmxlZChmYWxzZSkKKyAgICAsIG1faW50ZXJhY3RpdmVG b3JtVmFsaWRhdGlvbihmYWxzZSkKIHsKICAgICAvLyBBIEZyYW1lIG1heSBub3QgaGF2ZSBiZWVu IGNyZWF0ZWQgeWV0LCBzbyB3ZSBpbml0aWFsaXplIHRoZSBBdG9taWNTdHJpbmcgCiAgICAgLy8g aGFzaCBiZWZvcmUgdHJ5aW5nIHRvIHVzZSBpdC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFnZS9T ZXR0aW5ncy5oIGIvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKaW5kZXggNzAyYWMwZDc3Nzg1ZDBm Mjc1ZThiMGY5YmQ3YTQyMWQ3MTM4ZjYxYS4uYWIyNjFlNzYwNDUzMGE0ZTI3MzI5N2E3MmRkZWU2 ZTcwNWE2M2M2YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1NldHRpbmdzLmgKKysrIGIvV2Vi Q29yZS9wYWdlL1NldHRpbmdzLmgKQEAgLTMwNyw2ICszMDcsMTMgQEAgbmFtZXNwYWNlIFdlYkNv cmUgewogICAgICAgICB2b2lkIHNldFBhZ2luYXRlRHVyaW5nTGF5b3V0RW5hYmxlZChib29sIGZs YWcpIHsgbV9wYWdpbmF0ZUR1cmluZ0xheW91dEVuYWJsZWQgPSBmbGFnOyB9CiAgICAgICAgIGJv b2wgcGFnaW5hdGVEdXJpbmdMYXlvdXRFbmFibGVkKCkgY29uc3QgeyByZXR1cm4gbV9wYWdpbmF0 ZUR1cmluZ0xheW91dEVuYWJsZWQ7IH0KIAorICAgICAgICAvLyBUaGlzIHNldHRpbmcgd2lsbCBi ZSByZW1vdmVkIHdoZW4gYW4gSFRNTDUgY29tcGF0aWJpbGl0eSBpc3N1ZSBpcworICAgICAgICAv LyByZXNvbHZsZWQgYW5kIFdlYktpdCBpbXBsZW1lbnRhdGlvbiBvZiBpbnRlcmFjdGl2ZSB2YWxp ZGF0aW9uIGlzCisgICAgICAgIC8vIGNvbXBsZXRlZC4gU2VlIGh0dHA6Ly93ZWJraXQub3JnL2Iv NDA1MjAsIGh0dHA6Ly93ZWJraXQub3JnL2IvNDA3NDcsCisgICAgICAgIC8vIGFuZCBodHRwOi8v d2Via2l0Lm9yZy9iLzQwOTA4CisgICAgICAgIHZvaWQgc2V0SW50ZXJhY3RpdmVGb3JtVmFsaWRh dGlvbkVuYWJsZWQoYm9vbCBmbGFnKSB7IG1faW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbiA9IGZs YWc7IH0KKyAgICAgICAgYm9vbCBpbnRlcmFjdGl2ZUZvcm1WYWxpZGF0aW9uRW5hYmxlZCgpIGNv bnN0IHsgcmV0dXJuIG1faW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlvbjsgfQorCiAgICAgcHJpdmF0 ZToKICAgICAgICAgUGFnZSogbV9wYWdlOwogICAgICAgICAKQEAgLTM4OSw2ICszOTYsNyBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIGJvb2wgbV9odG1sNVBhcnNlckVuYWJsZWQ6IDE7 CiAgICAgICAgIGJvb2wgbV9odG1sNVRyZWVCdWlsZGVyRW5hYmxlZDogMTsgLy8gV2lsbCBiZSBk ZWxldGVkIHNvb24sIGRvIG5vdCB1c2UuCiAgICAgICAgIGJvb2wgbV9wYWdpbmF0ZUR1cmluZ0xh eW91dEVuYWJsZWQgOiAxOworICAgICAgICBib29sIG1faW50ZXJhY3RpdmVGb3JtVmFsaWRhdGlv bjogMTsKICAgICAKICNpZiBVU0UoU0FGQVJJX1RIRU1FKQogICAgICAgICBzdGF0aWMgYm9vbCBn U2hvdWxkUGFpbnROYXRpdmVDb250cm9sczsK