40506 2010-06-11 16:31:16 -0700 getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy 2010-06-11 18:17:39 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr cmarrin dglazkov eric oliver simon.fraser zmo oldest_to_newest 237121 0 kbr 2010-06-11 16:31:16 -0700 The new code added to getParameter in 40318 to support the new UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL parameters is buggy and causes test failures on some machines. 237132 1 58525 kbr 2010-06-11 16:40:10 -0700 Created attachment 58525 Patch From the ChangeLog: Return the data members of WebGLRenderingContext for these parameter queries rather than asking OpenGL, which knows nothing about them. 237136 2 58525 dglazkov 2010-06-11 16:42:13 -0700 Comment on attachment 58525 Patch Whoops. 237141 3 kbr 2010-06-11 16:44:53 -0700 Committed r61046: <http://trac.webkit.org/changeset/61046> 237180 4 simon.fraser 2010-06-11 17:29:21 -0700 fast/canvas/webgl/gl-get-calls.html is still failing. 237195 5 kbr 2010-06-11 18:17:39 -0700 (In reply to comment #4) > fast/canvas/webgl/gl-get-calls.html is still failing. Not from what I see on the buildbot console. I think the Leopard Intel Debug slave was lost while the buggy test was still checked in, but the other bots are now passing the test. 58525 2010-06-11 16:40:10 -0700 2010-06-11 16:42:13 -0700 Patch getparameter.patch text/plain 4157 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MTA0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTEgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGdl dFBhcmFtZXRlciB3aXRoIFVOUEFDS19GTElQX1lfV0VCR0wgYW5kIFVOUEFDS19QUkVNVUxUSVBM WV9BTFBIQV9XRUJHTCBpcyBidWdneQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9NDA1MDYKKworICAgICAgICBSZXR1cm4gdGhlIGRhdGEgbWVtYmVycyBv ZiBXZWJHTFJlbmRlcmluZ0NvbnRleHQgZm9yIHRoZXNlCisgICAgICAgIHBhcmFtZXRlciBxdWVy aWVzIHJhdGhlciB0aGFuIGFza2luZyBPcGVuR0wsIHdoaWNoIGtub3dzIG5vdGhpbmcKKyAgICAg ICAgYWJvdXQgdGhlbS4KKworICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29u dGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmdldFBh cmFtZXRlcik6CisKIDIwMTAtMDYtMTEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRHIgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IFdl YkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAJKHJldmlzaW9u IDYxMDQ0KQorKysgV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0xMjczLDkgKzEyNzMsOSBAQCBXZWJHTEdldEluZm8gV2ViR0xS ZW5kZXJpbmdDb250ZXh0OjpnZXRQCiAgICAgICAgIC8vIEZJWE1FOiBzaG91bGQgdGhpcyBiZSAi bG9uZyIgaW4gdGhlIHNwZWM/CiAgICAgICAgIHJldHVybiBnZXRJbnRQYXJhbWV0ZXIocG5hbWUp OwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlVOUEFDS19GTElQX1lfV0VCR0w6Ci0gICAg ICAgIHJldHVybiBnZXRCb29sZWFuUGFyYW1ldGVyKHBuYW1lKTsKKyAgICAgICAgcmV0dXJuIFdl YkdMR2V0SW5mbyhtX3VucGFja0ZsaXBZKTsKICAgICBjYXNlIEdyYXBoaWNzQ29udGV4dDNEOjpV TlBBQ0tfUFJFTVVMVElQTFlfQUxQSEFfV0VCR0w6Ci0gICAgICAgIHJldHVybiBnZXRCb29sZWFu UGFyYW1ldGVyKHBuYW1lKTsKKyAgICAgICAgcmV0dXJuIFdlYkdMR2V0SW5mbyhtX3VucGFja1By ZW11bHRpcGx5QWxwaGEpOwogICAgIGNhc2UgR3JhcGhpY3NDb250ZXh0M0Q6OlZJRVdQT1JUOgog ICAgICAgICByZXR1cm4gZ2V0V2ViR0xJbnRBcnJheVBhcmFtZXRlcihwbmFtZSk7CiAgICAgZGVm YXVsdDoKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRU ZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYxMDQ1KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMTEgIEtlbm5ldGggUnVz c2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIGdldFBhcmFtZXRlciB3aXRoIFVOUEFDS19GTElQX1lfV0VCR0wgYW5k IFVOUEFDS19QUkVNVUxUSVBMWV9BTFBIQV9XRUJHTCBpcyBidWdneQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA1MDYKKworICAgICAgICBSZXR1cm4g dGhlIGRhdGEgbWVtYmVycyBvZiBXZWJHTFJlbmRlcmluZ0NvbnRleHQgZm9yIHRoZXNlCisgICAg ICAgIHBhcmFtZXRlciBxdWVyaWVzIHJhdGhlciB0aGFuIGFza2luZyBPcGVuR0wsIHdoaWNoIGtu b3dzIG5vdGhpbmcKKyAgICAgICAgYWJvdXQgdGhlbS4KKworICAgICAgICAqIGZhc3QvY2FudmFz L3dlYmdsL2dsLWdldC1jYWxscy1leHBlY3RlZC50eHQ6CisgICAgICAgICogZmFzdC9jYW52YXMv d2ViZ2wvZ2wtZ2V0LWNhbGxzLmh0bWw6CisKIDIwMTAtMDYtMTEgIFNpbW9uIEZyYXNlciAgPHNp bW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRHIgRGFuIEJlcm5z dGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wv Z2wtZ2V0LWNhbGxzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjEwNDQpCisrKyBMYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC9nbC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNv cHkpCkBAIC02Myw2ICs2Myw3IEBAIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5T VEVOQ0kKIFBBU1MgY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5TVEVOQ0lMX1RFU1QpIGlz IGZhbHNlCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVEVYVFVSRV9CSU5ESU5H XzJEKSBpcyBudWxsCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVEVYVFVSRV9C SU5ESU5HX0NVQkVfTUFQKSBpcyBudWxsCitQQVNTIGNvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRl eHQuVU5QQUNLX0FMSUdOTUVOVCkgaXMgNAogUEFTUyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250 ZXh0LlVOUEFDS19GTElQX1lfV0VCR0wpIGlzIGZhbHNlCiBQQVNTIGNvbnRleHQuZ2V0UGFyYW1l dGVyKGNvbnRleHQuVU5QQUNLX1BSRU1VTFRJUExZX0FMUEhBX1dFQkdMKSBpcyBmYWxzZQogUEFT UyBjb250ZXh0LmdldFBhcmFtZXRlcihjb250ZXh0LlZJRVdQT1JUKSBpcyBbMCwgMCwgMiwgMl0K SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy5odG1sCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLWdldC1jYWxscy5o dG1sCShyZXZpc2lvbiA2MTA0NCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ds LWdldC1jYWxscy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC05NSw4ICs5NSw3IEBAIGVsc2Ugewog ICAgIC8vc2hvdWxkQmUoJ2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuU1RFTkNJTF9XUklU RU1BU0spJywgJzB4RkZGRkZGRkYnKTsKICAgICBzaG91bGRCZSgnY29udGV4dC5nZXRQYXJhbWV0 ZXIoY29udGV4dC5URVhUVVJFX0JJTkRJTkdfMkQpJywgJ251bGwnKTsKICAgICBzaG91bGRCZSgn Y29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5URVhUVVJFX0JJTkRJTkdfQ1VCRV9NQVApJywg J251bGwnKTsKLSAgICAvLyBGSVhNRTogdGhpcyBpcyBhcHBhcmVudGx5IGZhaWxpbmcgb24gc29t ZSBvZiB0aGUgYm90cwotICAgIC8vIHNob3VsZEJlKCdjb250ZXh0LmdldFBhcmFtZXRlcihjb250 ZXh0LlVOUEFDS19BTElHTk1FTlQpJywgJzQnKTsKKyAgICBzaG91bGRCZSgnY29udGV4dC5nZXRQ YXJhbWV0ZXIoY29udGV4dC5VTlBBQ0tfQUxJR05NRU5UKScsICc0Jyk7CiAgICAgc2hvdWxkQmUo J2NvbnRleHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVU5QQUNLX0ZMSVBfWV9XRUJHTCknLCAnZmFs c2UnKTsKICAgICBzaG91bGRCZSgnY29udGV4dC5nZXRQYXJhbWV0ZXIoY29udGV4dC5VTlBBQ0tf UFJFTVVMVElQTFlfQUxQSEFfV0VCR0wpJywgJ2ZhbHNlJyk7CiAgICAgc2hvdWxkQmUoJ2NvbnRl eHQuZ2V0UGFyYW1ldGVyKGNvbnRleHQuVklFV1BPUlQpJywgJ1swLCAwLCAyLCAyXScpOwo=