40497 2010-06-11 14:06:03 -0700 do-webcore-rename should have a --verbose option 2010-06-12 22:19:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 40491 1 eric eric abarth cjerdonek commit-queue darin dbates oldest_to_newest 237021 0 eric 2010-06-11 14:06:03 -0700 do-webcore-rename should have a --verbose option 237024 1 58506 eric 2010-06-11 14:09:39 -0700 Created attachment 58506 Patch 237042 2 58509 eric 2010-06-11 14:36:37 -0700 Created attachment 58509 Fixed --help support per wms's comment 237043 3 58509 eric 2010-06-11 14:36:58 -0700 Comment on attachment 58509 Fixed --help support per wms's comment I keep forgetting to pass --request-commit. sigh. 237310 4 58509 dbates 2010-06-12 10:22:26 -0700 Comment on attachment 58509 Fixed --help support per wms's comment > - if ($file =~ /^\../) { > + # Ignore excluded and hidden files/directories. > + if ($directoriesToIgnore{$file} or $file =~ /^\../ or $file =~ /^ChangeLog/) { > + print "Ignoring $File::Find::name\n" if $verbose; > $File::Find::prune = 1; As far as I can tell, $File::Find::prune only makes sense with respects to directories (to prevent descending into a directory), but I don't anticipate any issues with setting this on a file, say the ChangeLog files. > return; r=me. 237446 5 58509 eric 2010-06-12 20:34:20 -0700 Comment on attachment 58509 Fixed --help support per wms's comment Yup the "extra" prune causes no harm. 237487 6 58509 commit-queue 2010-06-12 22:19:47 -0700 Comment on attachment 58509 Fixed --help support per wms's comment Clearing flags on attachment: 58509 Committed r61080: <http://trac.webkit.org/changeset/61080> 237488 7 commit-queue 2010-06-12 22:19:54 -0700 All reviewed patches have been landed. Closing bug. 58506 2010-06-11 14:09:39 -0700 2010-06-11 14:36:31 -0700 Patch bug-40497-20100611140937.patch text/plain 3360 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZjA1NzVlMmJjODg4YmZmMDQwYzI3NmRlMDE2YjJhMDFmMThiOTFkLi4yZTBlYTc2 YWUwZWM0NzMyMGNkMTIxYmU1YzI4ODZkNzEyYzkzZDdkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDYtMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGRvLXdlYmNvcmUtcmVuYW1lIHNo b3VsZCBoYXZlIGEgLS12ZXJib3NlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA0OTcKKworICAgICAgICAqIFNjcmlwdHMvZG8td2ViY29y ZS1yZW5hbWU6CisgICAgICAgICAtIFVuaWZpZWQgaG93IHdlIGhhbmRsZSBza2lwcGluZyBmaWxl cy9kaXJlY3RvcmllcworICAgICAgICAgICB0aGlzIHdpbGwgYWxsb3cgdXMgdG8gImJsYWNrIGxp c3QiIGNlcnRhaW4gZmlsZXMgYW5kCisgICAgICAgICAgIGRpcmVjdG9yaWVzIHdoZW4gcGVyZm9y bWluZyByZW5hbWVzLgorICAgICAgICAgLSBNYWRlIGRvLXdlYmNvcmUtcmVuYW1lIGxvZyB3aGF0 IGl0J3Mgc2tpcHBpbmcgd2hlbiBwYXNzZWQgLS12ZXJib3NlLgorCiAyMDEwLTA2LTEwICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g RmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9kby13ZWJjb3JlLXJlbmFt ZSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvZG8td2ViY29yZS1yZW5hbWUKaW5kZXggMTJmZDc4ZDVl OTM1YzBiNDlkYmI0OWI1MGM1MTAxNjYwNjZlN2VjYi4uYWQzNjY0ZDdlNzQ1NjBlY2ZjM2FkOGVl ZjM4MDBiYWIwZDhlZjNhZCAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9kby13ZWJj b3JlLXJlbmFtZQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2RvLXdlYmNvcmUtcmVuYW1lCkBA IC0yOSwxNiArMjksNDAgQEAKICMgU2NyaXB0IHRvIGRvIGEgcmVuYW1lIGluIEphdmFTY3JpcHRD b3JlLCBXZWJDb3JlLCBhbmQgV2ViS2l0LgogCiB1c2Ugc3RyaWN0OworCit1c2UgRmlsZTo6Rmlu ZDsKIHVzZSBGaW5kQmluOwordXNlIEdldG9wdDo6TG9uZyBxdyg6Y29uZmlnIHBhc3NfdGhyb3Vn aCk7CisKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwotdXNlIEZpbGU6 OkZpbmQ7CiB1c2UgVkNTVXRpbHM7CiAKIHNldENvbmZpZ3VyYXRpb24oKTsKIGNoZGlyV2ViS2l0 KCk7CiAKLW15ICV3b3JkczsKK215ICRzaG93SGVscDsKK215ICR2ZXJib3NlOworCitteSAkcHJv Z3JhbU5hbWUgPSBiYXNlbmFtZSgkMCk7CitteSAkdXNhZ2UgPSA8PEVPRjsKK1VzYWdlOiAkcHJv Z3JhbU5hbWUgW29wdGlvbnNdCisgIC12fC0tdmVyYm9zZSAgICAgICAgICAgICAgICAgICAgTW9y ZSB2ZXJib3NlIG91dHB1dAorRU9GCisKK215ICRnZXRPcHRpb25zUmVzdWx0ID0gR2V0T3B0aW9u cygKKyAgICAndmVyYm9zZXx2JyA9PiBcJHZlcmJvc2UsCispOworCitpZiAoISRnZXRPcHRpb25z UmVzdWx0IHx8ICRzaG93SGVscCkgeworICAgIHByaW50IFNUREVSUiAkdXNhZ2U7CisgICAgZXhp dCAxOworfQorCitteSBAZGlyZWN0b3JpZXNUb0lnbm9yZUxpc3QgPSAoCisgICAgImljdSIsCisp OworbXkgJWRpcmVjdG9yaWVzVG9JZ25vcmUgPSBtYXAgeyAkXyA9PiAxIH0gQGRpcmVjdG9yaWVz VG9JZ25vcmVMaXN0OwogCiAjIGZpbmQgYWxsIGZpbGVzIHdlIHdhbnQgdG8gcHJvY2VzcwogCkBA IC01MiwxNyArNzYsMTMgQEAgc3ViIHdhbnRlZAogewogICAgIG15ICRmaWxlID0gJF87CiAKLSAg ICBpZiAoJGZpbGUgZXEgImljdSIpIHsKLSAgICAgICAgJEZpbGU6OkZpbmQ6OnBydW5lID0gMTsK LSAgICAgICAgcmV0dXJuOwotICAgIH0KLQotICAgIGlmICgkZmlsZSA9fiAvXlwuLi8pIHsKKyAg ICAjIElnbm9yZSBleGNsdWRlZCBhbmQgaGlkZGVuIGZpbGVzL2RpcmVjdG9yaWVzLgorICAgIGlm ICgkZGlyZWN0b3JpZXNUb0lnbm9yZXskZmlsZX0gb3IgJGZpbGUgPX4gL15cLi4vIG9yICRmaWxl ID1+IC9eQ2hhbmdlTG9nLykgeworICAgICAgICBwcmludCAiSWdub3JpbmcgJEZpbGU6OkZpbmQ6 Om5hbWVcbiIgaWYgJHZlcmJvc2U7CiAgICAgICAgICRGaWxlOjpGaW5kOjpwcnVuZSA9IDE7CiAg ICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICByZXR1cm4gaWYgJGZpbGUgPX4gL15DaGFuZ2VM b2cvOwogICAgIHJldHVybiBpZiAtZCAkZmlsZTsKIAogICAgIHB1c2ggQHBhdGhzLCAkRmlsZTo6 RmluZDo6bmFtZTsKQEAgLTcwLDExICs5MCwxMCBAQCBzdWIgd2FudGVkCiAKICMgU2V0dGluZyBp c0RPTVR5cGVSZW5hbWUgdG8gMSByYXRoZXIgdGhhbiAwIGV4cGFuZHMgdGhlIHJlZ2V4cHMgdXNl ZAogIyBiZWxvdyB0byBoYW5kbGUgY3VzdG9tIEphdmFTY3JpcHQgYmluZGluZ3MuCi1teSAkaXNE T01UeXBlUmVuYW1lID0gMTsKK215ICRpc0RPTVR5cGVSZW5hbWUgPSAwOwogbXkgJXJlbmFtZXMg PSAoCi0gICAgIkZsb2F0QXJyYXkiID0+ICJGbG9hdDMyQXJyYXkiLAotICAgICMgSlNET01XaW5k b3cgY29uc3RydWN0b3JzLgotICAgICJmbG9hdEFycmF5IiA9PiAiZmxvYXQzMkFycmF5IiwKKyAg ICAjIFJlbmFtZXMgZ28gaGVyZSBpbiB0aGUgZm9ybSBvZjoKKyAgICAjICJUb2tlbml6ZXIiID0+ ICJEb2N1bWVudFBhcnNlciIsCiApOwogCiBteSAlcmVuYW1lc0NvbnRlbXBsYXRlZEZvclRoZUZ1 dHVyZSA9ICgKQEAgLTIwNyw3ICsyMjYsNyBAQCBmb3IgbXkgJGZpbGUgKHNvcnQgQHBhdGhzKSB7 CiAgICAgbXkgJGNvbnRlbnRzOwogICAgIHsKICAgICAgICAgbG9jYWwgJC87Ci0gICAgICAgIG9w ZW4gRklMRSwgJGZpbGUgb3IgZGllOworICAgICAgICBvcGVuIEZJTEUsICRmaWxlIG9yIGRpZSAi RmFpbGVkIHRvIG9wZW4gJGZpbGUiOwogICAgICAgICAkY29udGVudHMgPSA8RklMRT47CiAgICAg ICAgIGNsb3NlIEZJTEU7CiAgICAgfQpAQCAtMjI1LDcgKzI0NCw3IEBAIGZvciBteSAkZmlsZSAo c29ydCBAcGF0aHMpIHsKICAgICB9CiAKICAgICBpZiAoJG5ld0NvbnRlbnRzIG5lICRjb250ZW50 cykgewotICAgICAgICBvcGVuIEZJTEUsICI+IiwgJGZpbGUgb3IgZGllOworICAgICAgICBvcGVu IEZJTEUsICI+IiwgJGZpbGUgb3IgZGllICJGYWlsZWQgdG8gb3BlbiAkZmlsZSI7CiAgICAgICAg IHByaW50IEZJTEUgJG5ld0NvbnRlbnRzOwogICAgICAgICBjbG9zZSBGSUxFOwogICAgIH0K 58509 2010-06-11 14:36:37 -0700 2010-06-12 22:19:47 -0700 Fixed --help support per wms's comment bug-40497-20100611143635.patch text/plain 3447 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA3ZjA1NzVlMmJjODg4YmZmMDQwYzI3NmRlMDE2YjJhMDFmMThiOTFkLi4yZTBlYTc2 YWUwZWM0NzMyMGNkMTIxYmU1YzI4ODZkNzEyYzkzZDdkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMDYtMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGRvLXdlYmNvcmUtcmVuYW1lIHNo b3VsZCBoYXZlIGEgLS12ZXJib3NlIG9wdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA0OTcKKworICAgICAgICAqIFNjcmlwdHMvZG8td2ViY29y ZS1yZW5hbWU6CisgICAgICAgICAtIFVuaWZpZWQgaG93IHdlIGhhbmRsZSBza2lwcGluZyBmaWxl cy9kaXJlY3RvcmllcworICAgICAgICAgICB0aGlzIHdpbGwgYWxsb3cgdXMgdG8gImJsYWNrIGxp c3QiIGNlcnRhaW4gZmlsZXMgYW5kCisgICAgICAgICAgIGRpcmVjdG9yaWVzIHdoZW4gcGVyZm9y bWluZyByZW5hbWVzLgorICAgICAgICAgLSBNYWRlIGRvLXdlYmNvcmUtcmVuYW1lIGxvZyB3aGF0 IGl0J3Mgc2tpcHBpbmcgd2hlbiBwYXNzZWQgLS12ZXJib3NlLgorCiAyMDEwLTA2LTEwICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4g RmlzaGVyLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9kby13ZWJjb3JlLXJlbmFt ZSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvZG8td2ViY29yZS1yZW5hbWUKaW5kZXggMTJmZDc4ZDVl OTM1YzBiNDlkYmI0OWI1MGM1MTAxNjYwNjZlN2VjYi4uZTJjZTAxOTA3NGU4NTcyYjY5MWZkYzk4 ZGU1MTM3MjAyYjkzNzk4YSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9kby13ZWJj b3JlLXJlbmFtZQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL2RvLXdlYmNvcmUtcmVuYW1lCkBA IC0yOSwxNiArMjksNDIgQEAKICMgU2NyaXB0IHRvIGRvIGEgcmVuYW1lIGluIEphdmFTY3JpcHRD b3JlLCBXZWJDb3JlLCBhbmQgV2ViS2l0LgogCiB1c2Ugc3RyaWN0OworCit1c2UgRmlsZTo6Rmlu ZDsKIHVzZSBGaW5kQmluOwordXNlIEdldG9wdDo6TG9uZyBxdyg6Y29uZmlnIHBhc3NfdGhyb3Vn aCk7CisKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVzZSB3ZWJraXRkaXJzOwotdXNlIEZpbGU6 OkZpbmQ7CiB1c2UgVkNTVXRpbHM7CiAKIHNldENvbmZpZ3VyYXRpb24oKTsKIGNoZGlyV2ViS2l0 KCk7CiAKLW15ICV3b3JkczsKK215ICRzaG93SGVscDsKK215ICR2ZXJib3NlOworCitteSAkcHJv Z3JhbU5hbWUgPSBiYXNlbmFtZSgkMCk7CitteSAkdXNhZ2UgPSA8PEVPRjsKK1VzYWdlOiAkcHJv Z3JhbU5hbWUgW29wdGlvbnNdCisgIC1ofC0taGVscCAgICAgICAgICAgICAgICAgICAgICAgU2hv dyB0aGlzIGhlbHAgbWVzc2FnZQorICAtdnwtLXZlcmJvc2UgICAgICAgICAgICAgICAgICAgIE1v cmUgdmVyYm9zZSBvdXRwdXQKK0VPRgorCitteSAkZ2V0T3B0aW9uc1Jlc3VsdCA9IEdldE9wdGlv bnMoCisgICAgJ2hlbHB8aCcgPT4gXCRzaG93SGVscCwKKyAgICAndmVyYm9zZXx2JyA9PiBcJHZl cmJvc2UsCispOworCitpZiAoISRnZXRPcHRpb25zUmVzdWx0IHx8ICRzaG93SGVscCkgeworICAg IHByaW50IFNUREVSUiAkdXNhZ2U7CisgICAgZXhpdCAxOworfQorCitteSBAZGlyZWN0b3JpZXNU b0lnbm9yZUxpc3QgPSAoCisgICAgImljdSIsCispOworbXkgJWRpcmVjdG9yaWVzVG9JZ25vcmUg PSBtYXAgeyAkXyA9PiAxIH0gQGRpcmVjdG9yaWVzVG9JZ25vcmVMaXN0OwogCiAjIGZpbmQgYWxs IGZpbGVzIHdlIHdhbnQgdG8gcHJvY2VzcwogCkBAIC01MiwxNyArNzgsMTMgQEAgc3ViIHdhbnRl ZAogewogICAgIG15ICRmaWxlID0gJF87CiAKLSAgICBpZiAoJGZpbGUgZXEgImljdSIpIHsKLSAg ICAgICAgJEZpbGU6OkZpbmQ6OnBydW5lID0gMTsKLSAgICAgICAgcmV0dXJuOwotICAgIH0KLQot ICAgIGlmICgkZmlsZSA9fiAvXlwuLi8pIHsKKyAgICAjIElnbm9yZSBleGNsdWRlZCBhbmQgaGlk ZGVuIGZpbGVzL2RpcmVjdG9yaWVzLgorICAgIGlmICgkZGlyZWN0b3JpZXNUb0lnbm9yZXskZmls ZX0gb3IgJGZpbGUgPX4gL15cLi4vIG9yICRmaWxlID1+IC9eQ2hhbmdlTG9nLykgeworICAgICAg ICBwcmludCAiSWdub3JpbmcgJEZpbGU6OkZpbmQ6Om5hbWVcbiIgaWYgJHZlcmJvc2U7CiAgICAg ICAgICRGaWxlOjpGaW5kOjpwcnVuZSA9IDE7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAg ICByZXR1cm4gaWYgJGZpbGUgPX4gL15DaGFuZ2VMb2cvOwogICAgIHJldHVybiBpZiAtZCAkZmls ZTsKIAogICAgIHB1c2ggQHBhdGhzLCAkRmlsZTo6RmluZDo6bmFtZTsKQEAgLTcwLDExICs5Miwx MCBAQCBzdWIgd2FudGVkCiAKICMgU2V0dGluZyBpc0RPTVR5cGVSZW5hbWUgdG8gMSByYXRoZXIg dGhhbiAwIGV4cGFuZHMgdGhlIHJlZ2V4cHMgdXNlZAogIyBiZWxvdyB0byBoYW5kbGUgY3VzdG9t IEphdmFTY3JpcHQgYmluZGluZ3MuCi1teSAkaXNET01UeXBlUmVuYW1lID0gMTsKK215ICRpc0RP TVR5cGVSZW5hbWUgPSAwOwogbXkgJXJlbmFtZXMgPSAoCi0gICAgIkZsb2F0QXJyYXkiID0+ICJG bG9hdDMyQXJyYXkiLAotICAgICMgSlNET01XaW5kb3cgY29uc3RydWN0b3JzLgotICAgICJmbG9h dEFycmF5IiA9PiAiZmxvYXQzMkFycmF5IiwKKyAgICAjIFJlbmFtZXMgZ28gaGVyZSBpbiB0aGUg Zm9ybSBvZjoKKyAgICAjICJUb2tlbml6ZXIiID0+ICJEb2N1bWVudFBhcnNlciIsCiApOwogCiBt eSAlcmVuYW1lc0NvbnRlbXBsYXRlZEZvclRoZUZ1dHVyZSA9ICgKQEAgLTIwNyw3ICsyMjgsNyBA QCBmb3IgbXkgJGZpbGUgKHNvcnQgQHBhdGhzKSB7CiAgICAgbXkgJGNvbnRlbnRzOwogICAgIHsK ICAgICAgICAgbG9jYWwgJC87Ci0gICAgICAgIG9wZW4gRklMRSwgJGZpbGUgb3IgZGllOworICAg ICAgICBvcGVuIEZJTEUsICRmaWxlIG9yIGRpZSAiRmFpbGVkIHRvIG9wZW4gJGZpbGUiOwogICAg ICAgICAkY29udGVudHMgPSA8RklMRT47CiAgICAgICAgIGNsb3NlIEZJTEU7CiAgICAgfQpAQCAt MjI1LDcgKzI0Niw3IEBAIGZvciBteSAkZmlsZSAoc29ydCBAcGF0aHMpIHsKICAgICB9CiAKICAg ICBpZiAoJG5ld0NvbnRlbnRzIG5lICRjb250ZW50cykgewotICAgICAgICBvcGVuIEZJTEUsICI+ IiwgJGZpbGUgb3IgZGllOworICAgICAgICBvcGVuIEZJTEUsICI+IiwgJGZpbGUgb3IgZGllICJG YWlsZWQgdG8gb3BlbiAkZmlsZSI7CiAgICAgICAgIHByaW50IEZJTEUgJG5ld0NvbnRlbnRzOwog ICAgICAgICBjbG9zZSBGSUxFOwogICAgIH0K