40489 2010-06-11 12:29:15 -0700 Chromium shouldn't build inside the source directory 2010-09-02 13:53:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned dglazkov fishd jamesr tkent tony yaar oldest_to_newest 236971 0 eric 2010-06-11 12:29:15 -0700 Chromium shouldn't build inside the source directory It breaks assumptions of some of our scripts at least: Renaming WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloatArray.cpp to WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloat32Array.cpp fatal: not under version control, source=WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloatArray.cpp, destination=WebKit/chromium/xcodebuild/DerivedSources/Debug/webcore/bindings/V8WebGLFloat32Array.cpp Renaming WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloatArray.h to WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloat32Array.h fatal: not under version control, source=WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloatArray.h, destination=WebKit/chromium/xcodebuild/DerivedSources/Debug/webkit/bindings/V8WebGLFloat32Array.h Renaming WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloatArrayCustom.o to WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloat32ArrayCustom.o fatal: not under version control, source=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloatArrayCustom.o, destination=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/V8WebGLFloat32ArrayCustom.o Renaming WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloatArray.o to WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloat32Array.o fatal: not under version control, source=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloatArray.o, destination=WebKit/chromium/xcodebuild/WebCore.build/Debug/webcore.build/Objects-normal/i386/WebGLFloat32Array.o Died at /Projects/WebKit/WebKitTools/Scripts/do-webcore-rename line 210. 236973 1 eric 2010-06-11 12:30:38 -0700 Related. Chromium should either not unpack files inside the source directory, or it should gitignore/svn ignore them: # WebKit/chromium/app/ # WebKit/chromium/base/ # WebKit/chromium/chromium_deps/ # WebKit/chromium/gfx/ # WebKit/chromium/googleurl/ # WebKit/chromium/gpu/ # WebKit/chromium/media/ # WebKit/chromium/net/ # WebKit/chromium/sdch/ # WebKit/chromium/skia/ # WebKit/chromium/testing/ # WebKit/chromium/third_party/ # WebKit/chromium/tools/ # WebKit/chromium/v8/ # WebKit/chromium/webkit/ 237623 2 tony 2010-06-13 16:57:14 -0700 I think we can just svn/git ignore the related directories. I seems better that WebKit Mac and WebKit Chromium Mac build into different directories. WebKit Chromium Mac happens to use WebKit/chromium/xcodebuild. 237660 3 58614 tony 2010-06-13 18:57:50 -0700 Created attachment 58614 Patch 237661 4 tony 2010-06-13 18:59:07 -0700 svn diff shows: Property changes on: . ___________________________________________________________________ Modified: svn:ignore - configure depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh + configure depcomp compile config.guess GNUmakefile.in config.sub ltmain.sh aconfig.h.in autom4te.cache missing aclocal.m4 install-sh out Makefile.chromium Property changes on: WebKit/chromium ___________________________________________________________________ Added: svn:ignore + app base build chromium_deps gfx googleurl gpu media net sdch skia testing third_party tools v8 webkit xcodebuild 238146 5 tony 2010-06-14 17:00:45 -0700 Committed r61162: <http://trac.webkit.org/changeset/61162> 238147 6 tony 2010-06-14 17:05:26 -0700 r61162 Adds the directories to svn:ignore, however, some scripts will still error out. For example, do-webcore-rename will still crawl every file in WebKit. It would probably take some effort to unpack in a different directory. I'm not sure how hard it is to move the build directory on Mac/Win (on Linux, I already moved it to the top level for correctness issues with the Makefile). It might be easier to make the scripts skip these directories. 58614 2010-06-13 18:57:50 -0700 2010-06-14 10:57:20 -0700 Patch bug-40489-20100613185749.patch text/plain 1192 tony SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDYxMDk5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYt MTMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaHJvbWl1bSBzaG91bGRuJ3QgYnVpbGQgaW5z aWRlIHRoZSBzb3VyY2UgZGlyZWN0b3J5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDQ4OQorCisgICAgICAgIElnbm9yZSBDaHJvbWl1bSBMaW51eCBi dWlsZCBmaWxlcy4KKworICAgICAgICAqIC46IEFkZGVkIHByb3BlcnR5IHN2bjppZ25vcmUuIE1v ZGlmaWVkIHByb3BlcnR5IHN2bjppZ25vcmUuCisKIDIwMTAtMDYtMDkgIExlYW5kcm8gUGVyZWly YSAgPGxlYW5kcm9AcHJvZnVzaW9uLm1vYmk+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBU cmVhdC4KSW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5n ZUxvZwkocmV2aXNpb24gNjEwOTkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD aHJvbWl1bSBzaG91bGRuJ3QgYnVpbGQgaW5zaWRlIHRoZSBzb3VyY2UgZGlyZWN0b3J5CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQ4OQorCisgICAg ICAgIElnbm9yZSBkaXJlY3RvcmllcyBmZXRjaGVkIGJ5IGNocm9taXVtIGFuZCBjaHJvbWl1bSBt YWMgb3V0cHV0IGRpci4KKworICAgICAgICAqIGNocm9taXVtOiBBZGRlZCBwcm9wZXJ0eSBzdm46 aWdub3JlLgorCiAyMDEwLTA2LTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdt YWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjA4ODkuCg==