40485 2010-06-11 11:31:30 -0700 tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling 2010-06-12 00:34:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 eric eric abarth commit-queue eric tonyg webkit.review.bot oldest_to_newest 236936 0 eric 2010-06-11 11:31:30 -0700 tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling 236948 1 58492 eric 2010-06-11 11:42:08 -0700 Created attachment 58492 Patch 236949 2 58492 eric 2010-06-11 11:43:49 -0700 Comment on attachment 58492 Patch I've validated with hyatt and by reading https://bugzilla.mozilla.org/show_bug.cgi?id=1188 that it's OK to modify this test and that the modification does not change what the test was testing. As far as I can understand, the </table> in the table was causing some sort of corruption of mozilla's column cache. 236964 3 58492 abarth 2010-06-11 12:20:11 -0700 Comment on attachment 58492 Patch Ok. Shouldn't the new test fail in test-html5-parser? If so, where's the updated expectation? 236969 4 58492 eric 2010-06-11 12:25:11 -0700 Comment on attachment 58492 Patch Nope. It fails with the new parser, but not the old one. The old one gets this case "right". The one one doesn't correctly coalesce text nodes yet. But for now that's an acceptable "regression" in behavior. Once we add text node coalescing we'll likely break more tests, but in the other direction. :) 236979 5 58492 commit-queue 2010-06-11 12:37:38 -0700 Comment on attachment 58492 Patch Clearing flags on attachment: 58492 Committed r61033: <http://trac.webkit.org/changeset/61033> 236980 6 commit-queue 2010-06-11 12:37:44 -0700 All reviewed patches have been landed. Closing bug. 237019 7 abarth 2010-06-11 14:03:19 -0700 Right, but test-html5-parser tests the new parser. You need to update the -html5-expected.txt results or else you're not testing what you think you're testing. 237025 8 eric 2010-06-11 14:11:28 -0700 Oh true. 237036 9 58507 eric 2010-06-11 14:30:53 -0700 Created attachment 58507 Patch for landing 237038 10 eric 2010-06-11 14:31:18 -0700 re-opening so the commit-queue will see this to land. 237250 11 58507 commit-queue 2010-06-12 00:10:03 -0700 Comment on attachment 58507 Patch for landing Clearing flags on attachment: 58507 Committed r61054: <http://trac.webkit.org/changeset/61054> 237251 12 commit-queue 2010-06-12 00:10:10 -0700 All reviewed patches have been landed. Closing bug. 237254 13 webkit.review.bot 2010-06-12 00:34:13 -0700 http://trac.webkit.org/changeset/61054 might have broken SnowLeopard Intel Release (Tests) 58492 2010-06-11 11:42:08 -0700 2010-06-11 14:30:33 -0700 Patch bug-40485-20100611114206.patch text/plain 4010 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhOWIyOGQ4NmJkMjAzZmI5NjYyYjA2MTQwZjhlMzRlMjUyMWJkODk2Li5mNzQwOWVi ZTI0Mzg2MDVmNzE0NTMwYjQxNjM4ZDA4MjIwMWIwNmY4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzYgQEAK KzIwMTAtMDYtMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHRhYmxlcy9tb3ppbGxhL2J1Z3Mv YnVnMTE4OC5odG1sIG5lZWRsZXNzbHkgZGVwZW5kcyBvbiBIVE1MIFBhcnNlciB0ZXh0IG5vZGUg aGFuZGxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQwNDg1CisKKyAgICAgICAgVGhlIG9sZCBIVE1MVG9rZW5pemVyIGhhbmRsZWQgaW52YWxpZCBj bG9zZSB0YWdzIGxpa2UgIjwgL0E+IiBhcyBwYXJ0CisgICAgICAgIG9mIHRoZSBsZXhpbmcgc3Rl cC4gIFRoZSBIVE1MNSBwYXJzZXIgc3BlY2lmaWNhdGlvbiBkaWN0YXRlcyB0aGF0CisgICAgICAg IHRoZSB0b2tlbml6YXRpb24vbGV4aW5nIHN0ZXAgaXMgdG8gb3V0cHV0IGVhY2ggY2hhcmFjdGVy IHRva2VuIGluIHNlcXVlbmNlCisgICAgICAgIGFuZCB0aGF0IHRoZSBwYXJzZXIgaXMgdG8gaW5z ZXJ0IGVtaXR0ZWQgY2hhcmFjdGVyIHRva2VucyBpbnRvIHRoZSBsYXN0CisgICAgICAgIHBhcnNl ci1jcmVhdGVkIHRleHQgbm9kZS4gIEluIG91ciBjdXJyZW50IEhUTUw1TGV4ZXItd2l0aC1vbGQt SFRNTFBhcnNlcgorICAgICAgICBzZXR1cCwgd2UgZ2F0aGVyIHVwIGNoYXJhY3RlciB0b2tlbnMg YW5kIG91dHB1dCB0aGVtIGFsbCBpbiBvbmUgYnVuY2gKKyAgICAgICAgKHRvIG1hdGNoIHRoZSBl eHBlY3RhdGlvbnMgb2YgdGhlIG9sZCBwYXJzZXIpLgorICAgICAgICAKKyAgICAgICAgSW4gdGhl IGNhc2Ugb2YgImZvbzwgL0E+IiB0aGUgSFRNTDVMZXhlciBzZWVzIHRoZSAnPCcsIHN3aXRjaGVk IG91dCBvZiB0aGUKKyAgICAgICAgImRhdGEiIHN0YXRlIGFuZCBlbWl0cyBhbGwgcGVuZGluZyBj aGFyYWN0ZXJzIGFzc3VtaW5nIHRoZSBzdGFydCBvZiBhIGNsb3NlIHRhZy4KKyAgICAgICAgV2hl biBpdCBzZWVzIHRoZSAnICcgaXQgc3dpdGNoZXMgYmFjayB0byB0aGUgImRhdGEiIHN0YXRlLiAg VGhlIEhUTUw1TGV4ZXIKKyAgICAgICAgZXhwZWN0cyB0aGF0IHRoZSBwYXJzZXIgd2lsbCBjb2Fs ZXNjZSB0aGUgc2VwYXJhdGUgY2hhcmFjdGVycyBpdCBlbWl0dGVkCisgICAgICAgIGludG8gb25l IHRleHQgbm9kZS4gIFNpbmNlIHdlIGhhdmVuJ3QgaW1wbGVtZW50ZWQgdGhlIHBhcnNlciBzaWRl IG9mIHRoZQorICAgICAgICBIVE1MNSBzcGVjLCBmb3Igbm93IHdlIGRvbid0LiAgVGhpcyBpcyBh IGtub3duIGlzc3VlIHdlIHdpbGwgYWRkcmVzcyBhZnRlcgorICAgICAgICBlbmFibGluZyB0aGUg SFRNTDVMZXhlciwgYXMgd2Ugc3RhcnQgdG8gd3JpdGUgYW4gSFRNTDUtY29tcGxpYW50IHBhcnNl ci4KKworICAgICAgICBUaGlzIHRleHQtbm9kZS1jb2FsZXNjaW5nIGJlaGF2aW9yIGlzIGFscmVh ZHkgdGVzdGVkIGJ5IG51bWVyb3VzIGh0bWw1bGliCisgICAgICAgIHRlc3RzLCBob3dldmVyIHRo aXMgd2FzIHRoZSBvbmx5IGxheW91dCB0ZXN0IHdoaWNoIGhpdCB0aGlzIHF1aXJrLiAgSSd2ZQor ICAgICAgICBhZGRlZCB5ZXQgYW5vdGhlciBodG1sNWxpYiB0ZXN0IG9mIHRoaXMgZXhhY3QgY2Fz ZSBqdXN0IGZvciBnb29kIG1lYXN1cmUuCisKKyAgICAgICAgKiBodG1sNWxpYi9yZXNvdXJjZXMv d2Via2l0MDEuZGF0OgorICAgICAgICAgLSBBZGQgYSB0ZXN0IG9mIHRoaXMgZXhhY3QgY2FzZSB0 byBtYWtlIHN1cmUgd2UgZG9uJ3QgbWlzcyBpdCB3aGVuIGltcGxlbWVudGluZworICAgICAgICAg ICBhbiBIVE1MNS1jb21wbGlhbnQgcGFyc2VyLgorICAgICAgICAqIHRhYmxlcy9tb3ppbGxhL2J1 Z3MvYnVnMTE4OC5odG1sOgorICAgICAgICAgLSBSZXBsYWNlICI8IC9BPiIgd2l0aCAiJmx0IC9B PiIgdG8gYXZvaWQgaGl0dGluZyB0aGlzIGxleGluZyBxdWlyay4KKwogMjAxMC0wNi0xMSAgWmhl bnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkg R2xhemtvdi4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0bWw1bGliL3Jlc291cmNlcy93ZWJr aXQwMS5kYXQgYi9MYXlvdXRUZXN0cy9odG1sNWxpYi9yZXNvdXJjZXMvd2Via2l0MDEuZGF0Cmlu ZGV4IGQ2MzNjNmVlMzcyYTE2YWY1M2E5ZDNhY2NjY2Y2NDQ2ZWQ5YjU2NTIuLjU0NGRhOWU4YTIx NGRhNWZiNGYyNzNhYTkwNjE5ZDBhMTE4YTcxYzYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2h0 bWw1bGliL3Jlc291cmNlcy93ZWJraXQwMS5kYXQKKysrIGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIv cmVzb3VyY2VzL3dlYmtpdDAxLmRhdApAQCAtMTk5LDMgKzE5OSwxMyBAQCBjb25zb2xlLmxvZygi Rk9PPHNwYW4+QkFSPC9zcGFuPkJBWiIpOwogfCAgICAgPHJkYXI6PgogfCAgICAgICA2ODY5Njg3 PSIiCiB8ICAgICAgIHByb2JsZW09IiIKKworI2RhdGEKKzxBPnRlc3Q8IC9BPgorI2Vycm9ycwor I2RvY3VtZW50Cit8IDxodG1sPgorfCAgIDxoZWFkPgorfCAgIDxib2R5PgorfCAgICAgPGE+Cit8 ICAgICAgICJ0ZXN0PCAvQT4iCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy90YWJsZXMvbW96aWxs YS9idWdzL2J1ZzExODguaHRtbCBiL0xheW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVn MTE4OC5odG1sCmluZGV4IDQ3M2QxOTUxMDQyOTRlMTYzYTI2MTI3OTIwODk1NGMyZTE3ZmFjOTMu LmFkMTFkNDgyYzIxNmMzZGQxM2M2ODBmMzQyZTJkN2RhZmEyZGZkZWYgMTAwNjQ0Ci0tLSBhL0xh eW91dFRlc3RzL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnMTE4OC5odG1sCisrKyBiL0xheW91dFRl c3RzL3RhYmxlcy9tb3ppbGxhL2J1Z3MvYnVnMTE4OC5odG1sCkBAIC0xNyw3ICsxNyw3IEBAIEhF SUdIVD00MiBCT1JERVI9MCBBTFQ9TmV0Y2VudGVyPgogVkFMVUU9U2VhcmNoPjxCUj4KICAgICAg ICAgICAgICAgICA8c21hbGw+PEEgCiBIUkVGPSJodHRwOi8vaW5mby5uZXRzY2FwZS5jb20vZndk L2hvbTEwc2NsYS9odHRwOi8vZXhjaXRlY2xhc3NpZmllZHMubmV0c2NhcGUuYwotb20vY2dpLWNs cy9kaXNwbGF5LmV4ZT9wYXJ0bmVyPW5ldGNlbnRlciZwYXRoPWNsYXNzJnRlbXBsYXRlPW5vbmUm Ij5DbGFzc2lmaWVkczwKK29tL2NnaS1jbHMvZGlzcGxheS5leGU/cGFydG5lcj1uZXRjZW50ZXIm cGF0aD1jbGFzcyZ0ZW1wbGF0ZT1ub25lJiI+Q2xhc3NpZmllZHMmbHQ7CiAvQT4gJm5ic3A7IDxB IEhSRUY9Ii9lc2NhcGVzL3NlYXJjaC9uZXRzZWFyY2h2MC5odG1sP2NwPWhvbTEwc25ldCI+TmV0 IAogU2VhcmNoPC9BPiAmbmJzcDsgPEEgSFJFRj0iL2RpcmVjdG9yeS9pbmRleC5odG1sP2NwPWhv bTEwc2RpciI+RmluZCBXZWIgCiBTaXRlczwvQT4gCkBAIC01OSw3ICs1OSw3IEBAIGRiMDAuaHRt bD5JbnN0YW50IE1lc3NlbmdlcjwvQT4gLSA8QQogSFJFRj0iL3F3ZXN0L2xvbmdfZGlzdGFuY2Uv aW5kZXguaHRtbD9jcD1ob20xMHlxc3QiPkxvbmcgRGlzdGFuY2U8L0E+IC0gPEEgCiBIUkVGPSJo dHRwOi8vaW5mby5uZXRzY2FwZS5jb20vZndkL2hvbTEweW1lbS9odHRwOi8vZm9ybS5uZXRzY2Fw ZS5jb20vbWVtYmVycy9pbgogZGV4Lmh0bWwiPk1lbWJlcnM8L0E+IC0gPEEgCi1IUkVGPWh0dHA6 Ly9pbmZvLm5ldHNjYXBlLmNvbS9md2QvaG9tMTB5bWFsL2h0dHA6Ly93ZWJtYWlsLm5ldHNjYXBl LmNvbT5XZWJNYWlsPAorSFJFRj1odHRwOi8vaW5mby5uZXRzY2FwZS5jb20vZndkL2hvbTEweW1h bC9odHRwOi8vd2VibWFpbC5uZXRzY2FwZS5jb20+V2ViTWFpbCZsdDsKIC9BPjwvc21hbGw+CiAg ICAgICAgIDwvVEQ+CiA8L1RSPgo= 58507 2010-06-11 14:30:53 -0700 2010-06-12 00:10:03 -0700 Patch for landing bug-40485-20100611143051.patch text/plain 1811 eric ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNGY1ODkyZTc3YTE3OGJjODg5ZDZhMmU3YWM0NjdkM2QwMzZhYjhkLi44OGM3MzJi Y2ZlZGE4Yjc4ZWQxZGY0Y2I0MWY2ODg1NWM5OWFmM2IzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDYtMTEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFVu cmV2aWV3ZWQuICBKdXN0IHVwZGF0aW5nIGV4cGVjdGF0aW9ucy4KKworICAgICAgICB0YWJsZXMv bW96aWxsYS9idWdzL2J1ZzExODguaHRtbCBuZWVkbGVzc2x5IGRlcGVuZHMgb24gSFRNTCBQYXJz ZXIgdGV4dCBub2RlIGhhbmRsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MDQ4NQorCisgICAgICAgIFRoZSBjdXJyZW50IEhUTUw1IHBhcnNlciBp cyBleHBlY3RlZCB0byBmYWlsIHRoZSBuZXcgd2Via2l0MDEgdGVzdC4KKyAgICAgICAgSXQgd2ls bCBiZSBmaXhlZCB3aGVuIHdlIGZpeCB0ZXh0LW5vZGUgY29hbGVzY2luZyBhcyBkaXNjdXNzZWQg aW4KKyAgICAgICAgdGhlIHByZXZpb3VzIGNvbW1pdC4KKworICAgICAgICAqIGh0bWw1bGliL3J1 bm5lci1leHBlY3RlZC1odG1sNS50eHQ6CisgICAgICAgICogaHRtbDVsaWIvd2Via2l0LXJlc3Vt ZXItZXhwZWN0ZWQtaHRtbDUudHh0OgorCiAyMDEwLTA2LTExICBKYW1lcyBSb2JpbnNvbiAgPGph bWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292 LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHRtbDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0bWw1 LnR4dCBiL0xheW91dFRlc3RzL2h0bWw1bGliL3J1bm5lci1leHBlY3RlZC1odG1sNS50eHQKaW5k ZXggZDQ3MzdiZDI3NWEzNjBiNDljZGNiMDJhNTY0MzFhYWU0MzE1ZjJkYi4uNTgxNjczZmVlOTc0 ZTUzMDMwNzMwNDJhNDA3OTQ3M2UzNzM2MjkwNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHRt bDVsaWIvcnVubmVyLWV4cGVjdGVkLWh0bWw1LnR4dAorKysgYi9MYXlvdXRUZXN0cy9odG1sNWxp Yi9ydW5uZXItZXhwZWN0ZWQtaHRtbDUudHh0CkBAIC0yNzAsNyArMjcwLDggQEAgcmVzb3VyY2Vz L3Rlc3RzMTYuZGF0OgogMTgwCiAxODYKIAotcmVzb3VyY2VzL3dlYmtpdDAxLmRhdDogUEFTUwor cmVzb3VyY2VzL3dlYmtpdDAxLmRhdDoKKzE3CiAKIHJlc291cmNlcy9kb2N0eXBlMDEuZGF0OiBQ QVNTCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0bWw1bGliL3dlYmtpdC1yZXN1bWVyLWV4 cGVjdGVkLWh0bWw1LnR4dCBiL0xheW91dFRlc3RzL2h0bWw1bGliL3dlYmtpdC1yZXN1bWVyLWV4 cGVjdGVkLWh0bWw1LnR4dAppbmRleCAxYzBlOWZlYjMyZGU5NzAxZDBiZTQ2MGQzNzhlOTM5YWZk MDBjOGY5Li5hZmJmMDZiMWY2ZGE1NDE0MDQyMjgzNzdjMWY1NDQ0NzhjZTM0MWY5IDEwMDY0NAot LS0gYS9MYXlvdXRUZXN0cy9odG1sNWxpYi93ZWJraXQtcmVzdW1lci1leHBlY3RlZC1odG1sNS50 eHQKKysrIGIvTGF5b3V0VGVzdHMvaHRtbDVsaWIvd2Via2l0LXJlc3VtZXItZXhwZWN0ZWQtaHRt bDUudHh0CkBAIC0xNjMsNCArMTYzLDE1IEBAIHJlc291cmNlcy93ZWJraXQwMS5kYXQ6CiA1MjEu NQogNTIyLjYKIDUyMy43Cis1OTMuMQorNTk0LjIKKzU5NS4zCis1OTYuNAorNTk3LjUKKzU5OC42 Cis1OTkuNworNjAwLjgKKzYwMS45Cis2MDIuMTAKKzYwMy4xMQogI0VPRgo=