40482 2010-06-11 11:02:38 -0700 [V8] Clean up SerializedScriptValue 2010-06-14 05:43:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 40499 1 jorlow jorlow abarth commit-queue eric webkit.review.bot oldest_to_newest 236913 0 jorlow 2010-06-11 11:02:38 -0700 [V8] Clean up SerializedScriptValue 236915 1 58487 jorlow 2010-06-11 11:05:45 -0700 Created attachment 58487 Patch 237008 2 58487 commit-queue 2010-06-11 13:41:43 -0700 Comment on attachment 58487 Patch Clearing flags on attachment: 58487 Committed r61036: <http://trac.webkit.org/changeset/61036> 237009 3 commit-queue 2010-06-11 13:41:49 -0700 All reviewed patches have been landed. Closing bug. 237017 4 webkit.review.bot 2010-06-11 14:00:52 -0700 http://trac.webkit.org/changeset/61036 might have broken Chromium Win Release 237784 5 jorlow 2010-06-14 05:35:44 -0700 Committed r61114: <http://trac.webkit.org/changeset/61114> 237785 6 webkit.review.bot 2010-06-14 05:43:47 -0700 http://trac.webkit.org/changeset/61114 might have broken Chromium Linux Release 58487 2010-06-11 11:05:45 -0700 2010-06-11 13:41:43 -0700 Patch bug-40482-20100611190542.patch text/plain 7208 jorlow ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YjkwMTkwOTVkNGQ3YTkzZTNhNzZlZWQzZDcxMjc1YzQ0MGYxYjY5MS4uNTUzZTAyYjZjMjg1Mjhk OWZjNTUwNmIyNzljMDM5MmVhM2M0NTY1YiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAxMC0wNi0xMSAgSmVy ZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbVjhdIENsZWFuIHVwIFNlcmlhbGl6ZWRTY3JpcHRW YWx1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA0 ODIKKworICAgICAgICBTZXJpYWxpemVkU2NyaXB0VmFsdWUgZG9lc24ndCBmb2xsb3cgV2ViS2l0 J3Mgc3R5bGUgZ3VpZGVsaW5lcyB2ZXJ5IHdlbGwKKyAgICAgICAgYW5kIG5lZWRsZXNzbHkgaW5s aW5lcyBxdWl0ZSBhIGJpdCB3aXRoaW4gdGhlIC5oIGZpbGUuIFRoaXMgY2hhbmdlIGNsZWFucwor ICAgICAgICB0aGluZ3MgdXAuIE5vIGZ1bmNpdG9uYWwgY2hhbmdlcy4KKworICAgICAgICBObyBj aGFuZ2UgaW4gYmVoYXZpb3IuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TZXJpYWxpemVkU2Ny aXB0VmFsdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFsaXplZFNjcmlwdFZhbHVlOjpk ZXNlcmlhbGl6ZUFuZFNldFByb3BlcnR5KToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRT Y3JpcHRWYWx1ZTo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3JpcHRW YWx1ZTo6Y3JlYXRlRnJvbVdpcmUpOgorICAgICAgICAoV2ViQ29yZTo6U2VyaWFsaXplZFNjcmlw dFZhbHVlOjpyZWxlYXNlKToKKyAgICAgICAgKFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZTo6U2VyaWFsaXplZFNjcmlwdFZhbHVlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9TZXJpYWxp emVkU2NyaXB0VmFsdWUuaDoKKwogMjAxMC0wNi0xMSAgTHVpeiBBZ29zdGluaSAgPGx1aXouYWdv c3RpbmlAb3BlbmJvc3NhLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnR0aSBLb2l2aXN0 by4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVl LmNwcCBiL1dlYkNvcmUvYmluZGluZ3MvdjgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmNwcAppbmRl eCAwMDBmZDNiMjg1YTc1NjczZTAxOGZmMTc4ZDIzNTYyZTFhYTJlNzFlLi44ZTkxOTIwOTBjNjQ2 ZTViNWE0YzQ1MjUzMDU4NzM3NmUzMzNkZDliIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKKysrIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9T ZXJpYWxpemVkU2NyaXB0VmFsdWUuY3BwCkBAIC0zOCw2ICszOCw3IEBACiAjaW5jbHVkZSAiRmls ZUxpc3QuaCIKICNpbmNsdWRlICJJbWFnZURhdGEuaCIKICNpbmNsdWRlICJTaGFyZWRCdWZmZXIu aCIKKyNpbmNsdWRlICJWOEJpbmRpbmcuaCIKICNpbmNsdWRlICJWOEJsb2IuaCIKICNpbmNsdWRl ICJWOEZpbGUuaCIKICNpbmNsdWRlICJWOEZpbGVMaXN0LmgiCkBAIC0xMDExLDYgKzEwMTIsNTIg QEAgcHJpdmF0ZToKIAogfSAvLyBuYW1lc3BhY2UKIAordm9pZCBTZXJpYWxpemVkU2NyaXB0VmFs dWU6OmRlc2VyaWFsaXplQW5kU2V0UHJvcGVydHkodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBvYmpl Y3QsIGNvbnN0IGNoYXIqIHByb3BlcnR5TmFtZSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHY4OjpQcm9wZXJ0eUF0dHJpYnV0ZSBhdHRyaWJ1 dGUsIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSogdmFsdWUpCit7CisgICAgaWYgKCF2YWx1ZSkKKyAg ICAgICAgcmV0dXJuOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBkZXNlcmlhbGl6ZWQgPSB2 YWx1ZS0+ZGVzZXJpYWxpemUoKTsKKyAgICBvYmplY3QtPkZvcmNlU2V0KHY4OjpTdHJpbmc6Ok5l d1N5bWJvbChwcm9wZXJ0eU5hbWUpLCBkZXNlcmlhbGl6ZWQsIGF0dHJpYnV0ZSk7Cit9CisKK1Bh c3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNy ZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wmIGRpZFRocm93KQoreworICAg IHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKHZhbHVlLCBkaWRUaHJv dykpOworfQorCitQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNj cmlwdFZhbHVlOjpjcmVhdGUodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQoreworICAgIGJv b2wgZGlkVGhyb3c7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTZXJpYWxpemVkU2NyaXB0VmFs dWUodmFsdWUsIGRpZFRocm93KSk7Cit9CisKK1Bhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZh bHVlPiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OmNyZWF0ZUZyb21XaXJlKFN0cmluZyBkYXRhKQor eworICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKGRhdGEsIFdp cmVEYXRhKSk7Cit9CisKK1Bhc3NSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBTZXJpYWxp emVkU2NyaXB0VmFsdWU6OmNyZWF0ZShTdHJpbmcgZGF0YSkKK3sKKyAgICByZXR1cm4gYWRvcHRS ZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZShkYXRhLCBTdHJpbmdWYWx1ZSkpOworfQorCitQ YXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpj cmVhdGUoKQoreworICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVl KCkpOworfQorCitQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gU2VyaWFsaXplZFNj cmlwdFZhbHVlOjpyZWxlYXNlKCkKK3sKKyAgICBSZWZQdHI8U2VyaWFsaXplZFNjcmlwdFZhbHVl PiByZXN1bHQgPSBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKG1fZGF0YSwgV2ly ZURhdGEpKTsKKyAgICBtX2RhdGEgPSBTdHJpbmcoKTsKKyAgICByZXR1cm4gcmVzdWx0LnJlbGVh c2UoKTsKK30KKworU2VyaWFsaXplZFNjcmlwdFZhbHVlOjpTZXJpYWxpemVkU2NyaXB0VmFsdWUo KQoreworfQorCiBTZXJpYWxpemVkU2NyaXB0VmFsdWU6OlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSh2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wmIGRpZFRocm93KQogewogICAgIGRpZFRo cm93ID0gZmFsc2U7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NlcmlhbGl6ZWRT Y3JpcHRWYWx1ZS5oIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TZXJpYWxpemVkU2NyaXB0VmFsdWUu aAppbmRleCA4MjA1YTQyMGE3Mjc2Y2RiNDViOGY4ZDFiYmEzNDQ2MjM5NTUzY2JhLi4zNzEwYjVh MjMxMDVhNmYxNjkzMTY1MGVhNTA4YjAyYjQ3ZTllMGQyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mv djgvU2VyaWFsaXplZFNjcmlwdFZhbHVlLmgKQEAgLTMyLDcgKzMyLDYgQEAKICNkZWZpbmUgU2Vy aWFsaXplZFNjcmlwdFZhbHVlX2gKIAogI2luY2x1ZGUgIlNjcmlwdFZhbHVlLmgiCi0jaW5jbHVk ZSAiVjhCaW5kaW5nLmgiCiAjaW5jbHVkZSA8djguaD4KICNpbmNsdWRlIDx3dGYvUmVmQ291bnRl ZC5oPgogCkBAIC00MCw2MyArMzksMjEgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBT ZXJpYWxpemVkU2NyaXB0VmFsdWUgOiBwdWJsaWMgUmVmQ291bnRlZDxTZXJpYWxpemVkU2NyaXB0 VmFsdWU+IHsKIHB1YmxpYzoKLSAgICAvLyBEZXNlcmlhbGl6ZXMgdGhlIGdpdmVuIHZhbHVlIGFu ZCBzZXRzIGl0IGFzIGEgcHJvcGVydHkgb24gdGhlCi0gICAgLy8gb2JqZWN0LgotICAgIHN0YXRp YyB2b2lkIGRlc2VyaWFsaXplQW5kU2V0UHJvcGVydHkodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBv YmplY3QsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBjb25zdCBj aGFyKiBwcm9wZXJ0eU5hbWUsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB2ODo6UHJvcGVydHlBdHRyaWJ1dGUgYXR0cmlidXRlLAotICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgU2VyaWFsaXplZFNjcmlwdFZhbHVlKiB2YWx1ZSkKLSAg ICB7Ci0gICAgICAgIGlmICghdmFsdWUpCi0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIHY4 OjpIYW5kbGU8djg6OlZhbHVlPiBkZXNlcmlhbGl6ZWQgPSB2YWx1ZS0+ZGVzZXJpYWxpemUoKTsK LSAgICAgICAgb2JqZWN0LT5Gb3JjZVNldCh2ODo6U3RyaW5nOjpOZXdTeW1ib2wocHJvcGVydHlO YW1lKSwgZGVzZXJpYWxpemVkLCBhdHRyaWJ1dGUpOwotICAgIH0KKyAgICBzdGF0aWMgdm9pZCBk ZXNlcmlhbGl6ZUFuZFNldFByb3BlcnR5KHY4OjpIYW5kbGU8djg6Ok9iamVjdD4gb2JqZWN0LCBj b25zdCBjaGFyKiBwcm9wZXJ0eU5hbWUsCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB2ODo6UHJvcGVydHlBdHRyaWJ1dGUsIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSop OwogCi0gICAgLy8gQ3JlYXRlcyBhIHNlcmlhbGl6ZWQgcmVwcmVzZW50YXRpb24gb2YgdGhlIGdp dmVuIFY4IHZhbHVlLgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRWYWx1 ZT4gY3JlYXRlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSkKLSAgICB7Ci0gICAgICAgIGJv b2wgZGlkVGhyb3c7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlw dFZhbHVlKHZhbHVlLCBkaWRUaHJvdykpOwotICAgIH0KLQotICAgIC8vIENyZWF0ZXMgYSBzZXJp YWxpemVkIHJlcHJlc2VudGF0aW9uIG9mIHRoZSBnaXZlbiBWOCB2YWx1ZS4KLSAgICAvLwogICAg IC8vIElmIGEgc2VyaWFsaXphdGlvbiBlcnJvciBvY2N1cnMgKGUuZy4sIGN5Y2xpYyBpbnB1dCB2 YWx1ZSkgdGhpcwogICAgIC8vIGZ1bmN0aW9uIHJldHVybnMgYW4gZW1wdHkgcmVwcmVzZW50YXRp b24sIHNjaGVkdWxlcyBhIFY4IGV4Y2VwdGlvbiB0bwogICAgIC8vIGJlIHRocm93biB1c2luZyB2 ODo6VGhyb3dFeGNlcHRpb24oKSwgYW5kIHNldHMgfGRpZFRocm93fC4gSW4gdGhpcyBjYXNlCiAg ICAgLy8gdGhlIGNhbGxlciBtdXN0IG5vdCBpbnZva2UgYW55IFY4IG9wZXJhdGlvbnMgdW50aWwg Y29udHJvbCByZXR1cm5zIHRvCiAgICAgLy8gVjguIFdoZW4gc2VyaWFsaXphdGlvbiBpcyBzdWNj ZXNzZnVsLCB8ZGlkVGhyb3d8IGlzIGZhbHNlLgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlh bGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSwgYm9v bCYgZGlkVGhyb3cpCi0gICAgewotICAgICAgICByZXR1cm4gYWRvcHRSZWYobmV3IFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZSh2YWx1ZSwgZGlkVGhyb3cpKTsKLSAgICB9Ci0KLSAgICAvLyBDcmVhdGVz IGEgc2VyaWFsaXplZCB2YWx1ZSB3aXRoIHRoZSBnaXZlbiBkYXRhIG9idGFpbmVkIGZyb20gYQot ICAgIC8vIHByaW9yIGNhbGwgdG8gdG9XaXJlU3RyaW5nKCkuCi0gICAgc3RhdGljIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGVGcm9tV2lyZShTdHJpbmcgZGF0YSkKLSAg ICB7Ci0gICAgICAgIHJldHVybiBhZG9wdFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKGRh dGEsIFdpcmVEYXRhKSk7Ci0gICAgfQotCi0gICAgLy8gQ3JlYXRlcyBhIHNlcmlhbGl6ZWQgcmVw cmVzZW50YXRpb24gb2YgV2ViQ29yZSBzdHJpbmcuCi0gICAgc3RhdGljIFBhc3NSZWZQdHI8U2Vy aWFsaXplZFNjcmlwdFZhbHVlPiBjcmVhdGUoU3RyaW5nIGRhdGEpCi0gICAgewotICAgICAgICBy ZXR1cm4gYWRvcHRSZWYobmV3IFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZShkYXRhLCBTdHJpbmdWYWx1 ZSkpOwotICAgIH0KKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+ IGNyZWF0ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdmFsdWUsIGJvb2wmIGRpZFRocm93KTsKKyAg ICBzdGF0aWMgUGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IGNyZWF0ZSh2ODo6SGFu ZGxlPHY4OjpWYWx1ZT4pOworICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNlcmlhbGl6ZWRTY3JpcHRW YWx1ZT4gY3JlYXRlRnJvbVdpcmUoU3RyaW5nIGRhdGEpOworICAgIHN0YXRpYyBQYXNzUmVmUHRy PFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKFN0cmluZyBkYXRhKTsKKyAgICBzdGF0aWMg UGFzc1JlZlB0cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IGNyZWF0ZSgpOwogCi0gICAgLy8gQ3Jl YXRlcyBhbiBlbXB0eSBzZXJpYWxpemVkIHZhbHVlLgotICAgIHN0YXRpYyBQYXNzUmVmUHRyPFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZT4gY3JlYXRlKCkKLSAgICB7Ci0gICAgICAgIHJldHVybiBhZG9w dFJlZihuZXcgU2VyaWFsaXplZFNjcmlwdFZhbHVlKCkpOwotICAgIH0KLQotICAgIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiByZWxlYXNlKCkKLSAgICB7Ci0gICAgICAgIFJlZlB0 cjxTZXJpYWxpemVkU2NyaXB0VmFsdWU+IHJlc3VsdCA9IGFkb3B0UmVmKG5ldyBTZXJpYWxpemVk U2NyaXB0VmFsdWUobV9kYXRhLCBXaXJlRGF0YSkpOwotICAgICAgICBtX2RhdGEgPSBTdHJpbmco KTsKLSAgICAgICAgcmV0dXJuIHJlc3VsdC5yZWxlYXNlKCk7Ci0gICAgfQorICAgIFBhc3NSZWZQ dHI8U2VyaWFsaXplZFNjcmlwdFZhbHVlPiByZWxlYXNlKCk7CiAKICAgICBTdHJpbmcgdG9XaXJl U3RyaW5nKCkgY29uc3QgeyByZXR1cm4gbV9kYXRhOyB9CiAKQEAgLTExMCwxMCArNjcsOCBAQCBw cml2YXRlOgogICAgICAgICBXaXJlRGF0YQogICAgIH07CiAKLSAgICBTZXJpYWxpemVkU2NyaXB0 VmFsdWUoKSB7IH0KLQorICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSgpOwogICAgIFNlcmlhbGl6 ZWRTY3JpcHRWYWx1ZSh2ODo6SGFuZGxlPHY4OjpWYWx1ZT4sIGJvb2wmIGRpZFRocm93KTsKLQog ICAgIFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZShTdHJpbmcgZGF0YSwgU3RyaW5nRGF0YU1vZGUgbW9k ZSk7CiAKICAgICBTdHJpbmcgbV9kYXRhOwo=