40476 2010-06-11 08:06:06 -0700 [Qt] Support custom open() verbs/methods in XMLHttpRequest 2010-10-18 01:16:00 -0700 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 kling webkit-qt-unassigned dinu.jacob webkit-ews oldest_to_newest 236829 0 kling 2010-06-11 08:06:06 -0700 For Qt 4.7 we can implement this by falling back to QNetworkAccessManager::CustomOperation for any verb that's not specifically supported by QNAM. 236833 1 kling 2010-06-11 08:11:31 -0700 It should be noted that current QtWebKit hangs completely when attempting to use an unknown verb with XHR. 236834 2 58475 kling 2010-06-11 08:12:18 -0700 Created attachment 58475 Proposed patch 236861 3 58475 kenneth 2010-06-11 09:13:24 -0700 Comment on attachment 58475 Proposed patch Are there any security implications of this? 237380 4 kling 2010-06-12 17:54:25 -0700 (In reply to comment #3) > (From update of attachment 58475 [details]) > Are there any security implications of this? The verb is sanitized in XMLHttpRequest::open() (WebCore/xml/XMLHttpRequest.cpp) AFAICT the Mac port does the same thing as this patch (passes the method argument verbatim.) 237397 5 58475 eric 2010-06-12 18:47:11 -0700 Comment on attachment 58475 Proposed patch This needs a layout test. It should be possible to test this with an http test. 294756 6 dinu.jacob 2010-10-15 08:26:15 -0700 (In reply to comment #5) > (From update of attachment 58475 [details]) > This needs a layout test. It should be possible to test this with an http test. Layout test with custom verb already exists under xmlhttprequest. For example: methods.html uses the verbs "WKFOOBAR", "HEAD", "SEARCH" etc 294757 7 dinu.jacob 2010-10-15 08:28:52 -0700 (In reply to comment #6) > (In reply to comment #5) > > (From update of attachment 58475 [details] [details]) > > This needs a layout test. It should be possible to test this with an http test. > > Layout test with custom verb already exists under xmlhttprequest. For example: methods.html uses the verbs "WKFOOBAR", "HEAD", "SEARCH" etc Test File: LayoutTests/http/tests/xmlhttprequest/methods.html 294758 8 58475 kling 2010-10-15 08:30:16 -0700 Comment on attachment 58475 Proposed patch Resetting r? since this is covered by existing (skipped) tests. They will be unskipped once the Qt buildbot is updated to Qt 4.7. 294801 9 58475 kenneth 2010-10-15 10:18:26 -0700 Comment on attachment 58475 Proposed patch the ChangeLog doesn't explain why this is a good thing. 295240 10 70978 kling 2010-10-17 11:20:26 -0700 Created attachment 70978 Proposed patch v2 Updated patch with more elaborate ChangeLog. 295241 11 kling 2010-10-17 11:25:52 -0700 Thanks for the review Kenneth :) There's a missing 4.7 guard in httpMethod(), I'll land with that tomorrow, gotta run. 295244 12 webkit-ews 2010-10-17 11:28:24 -0700 Attachment 70978 did not build on qt: Build output: http://queues.webkit.org/results/4456062 295395 13 kling 2010-10-18 01:16:00 -0700 Committed r69946: <http://trac.webkit.org/changeset/69946> 58475 2010-06-11 08:12:18 -0700 2010-10-17 11:20:26 -0700 Proposed patch bug-40476.diff text/plain 1612 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTlhZDM1NS4uYmJhODVlNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNi0xMSAgQW5kcmVhcyBLbGlu ZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gU3VwcG9ydCBjdXN0b20gb3BlbigpIHZlcmJzL21l dGhvZHMgaW4gWE1MSHR0cFJlcXVlc3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwNDc2CisKKyAgICAgICAgRmFsbCBiYWNrIHRvIFFOZXR3b3JrQWNj ZXNzTWFuYWdlcjo6Q3VzdG9tT3BlcmF0aW9uIGZvciBhbnkgSFRUUCB2ZXJiCisgICAgICAgIHRo YXQncyBub3Qgc3BlY2lmaWNhbGx5IHN1cHBvcnRlZCBieSBRTmV0d29ya0FjY2Vzc01hbmFnZXIu CisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpRTmV0d29ya1JlcGx5 SGFuZGxlcik6CisKIDIwMTAtMDYtMTEgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRpZmYgLS1naXQgYS9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwIGIvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAppbmRleCBlNTJkZDFk Li4zYmUzMDBmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdv cmtSZXBseUhhbmRsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0 d29ya1JlcGx5SGFuZGxlci5jcHAKQEAgLTE1NiwxMiArMTU2LDE0IEBAIFFOZXR3b3JrUmVwbHlI YW5kbGVyOjpRTmV0d29ya1JlcGx5SGFuZGxlcihSZXNvdXJjZUhhbmRsZSogaGFuZGxlLCBMb2Fk TW9kZSBsb2FkCiAgICAgZWxzZSBpZiAoci5odHRwTWV0aG9kKCkgPT0gIkRFTEVURSIpCiAgICAg ICAgIG1fbWV0aG9kID0gUU5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpEZWxldGVPcGVyYXRpb247CiAj ZW5kaWYKKyAgICBlbHNlIHsKICNpZiBRVF9WRVJTSU9OID49IDB4MDQwNzAwCi0gICAgZWxzZSBp ZiAoci5odHRwTWV0aG9kKCkgPT0gIk9QVElPTlMiKQorICAgICAgICAvLyBGYWxsIGJhY2sgdG8g Q3VzdG9tT3BlcmF0aW9uIGZvciBvdGhlciB2ZXJicyAoT1BUSU9OUywgUFJPUEZJTkQsIC4uLikK ICAgICAgICAgbV9tZXRob2QgPSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6OkN1c3RvbU9wZXJhdGlv bjsKLSNlbmRpZgotICAgIGVsc2UKKyNlbHNlCiAgICAgICAgIG1fbWV0aG9kID0gUU5ldHdvcmtB Y2Nlc3NNYW5hZ2VyOjpVbmtub3duT3BlcmF0aW9uOworI2VuZGlmCisgICAgfQogCiAgICAgbV9y ZXF1ZXN0ID0gci50b05ldHdvcmtSZXF1ZXN0KG1fcmVzb3VyY2VIYW5kbGUtPmdldEludGVybmFs KCktPm1fZnJhbWUpOwogCg== 70978 2010-10-17 11:20:26 -0700 2010-10-17 11:21:46 -0700 Proposed patch v2 bug-40476-v2.diff text/plain 3822 kling ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTk1N2M4My4uMDVmMDhlYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxMC0xMC0xNyAgQW5kcmVhcyBLbGlu ZyAgPGtsaW5nQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBTdXBwb3J0IGN1c3RvbSBvcGVuKCkgdmVyYnMvbWV0aG9kcyBp biBYTUxIdHRwUmVxdWVzdAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA0NzYKKworICAgICAgICBGYWxsIGJhY2sgdG8gUU5ldHdvcmtBY2Nlc3NNYW5h Z2VyOjpDdXN0b21PcGVyYXRpb24gZm9yIGFueSBIVFRQIHZlcmIKKyAgICAgICAgdGhhdCdzIG5v dCBzcGVjaWZpY2FsbHkgc3VwcG9ydGVkIGJ5IFFOZXR3b3JrQWNjZXNzTWFuYWdlci4KKworICAg ICAgICBUaGlzIHByZXZlbnRzIHRoZSBpbmZpbml0ZSBsb29wIHRoYXQgb3RoZXJ3aXNlIG9jY3Vy cyBhZnRlciBzZW5kaW5nCisgICAgICAgIGFuIFVua25vd25PcGVyYXRpb24gcmVxdWVzdC4KKwor ICAgICAgICBUaGlzIGNoYW5nZSBpcyBjb3ZlcmVkIGJ5IGV4aXN0aW5nIChza2lwcGVkKSB0ZXN0 cyB0aGF0IHdpbGwgYmUKKyAgICAgICAgdW5za2lwcGVkIG9uY2UgdGhlIFF0IGJvdHMgYXJlIHJ1 bm5pbmcgUXQgNC43LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6 aHR0cE1ldGhvZCk6CisgICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6UU5l dHdvcmtSZXBseUhhbmRsZXIpOgorICAgICAgICAoV2ViQ29yZTo6UU5ldHdvcmtSZXBseUhhbmRs ZXI6OnNlbmRSZXNwb25zZUlmTmVlZGVkKToKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0 L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmg6CisKIDIwMTAtMTAtMTcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRs ZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVy LmNwcAppbmRleCBmMGY0MDA0Li44M2Q3ZDZkIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKQEAgLTE1NSw5ICsxNTUsOSBA QCBib29sIEZvcm1EYXRhSU9EZXZpY2U6OmlzU2VxdWVudGlhbCgpIGNvbnN0CiAgICAgcmV0dXJu IHRydWU7CiB9CiAKLXN0YXRpYyBRU3RyaW5nIGh0dHBNZXRob2RTdHJpbmcoUU5ldHdvcmtBY2Nl c3NNYW5hZ2VyOjpPcGVyYXRpb24gbWV0aG9kKQorU3RyaW5nIFFOZXR3b3JrUmVwbHlIYW5kbGVy OjpodHRwTWV0aG9kKCkgY29uc3QKIHsKLSAgICBzd2l0Y2ggKG1ldGhvZCkgeworICAgIHN3aXRj aCAobV9tZXRob2QpIHsKICAgICBjYXNlIFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6R2V0T3BlcmF0 aW9uOgogICAgICAgICByZXR1cm4gIkdFVCI7CiAgICAgY2FzZSBRTmV0d29ya0FjY2Vzc01hbmFn ZXI6OkhlYWRPcGVyYXRpb246CkBAIC0xNjYsMTUgKzE2NiwxMiBAQCBzdGF0aWMgUVN0cmluZyBo dHRwTWV0aG9kU3RyaW5nKFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6T3BlcmF0aW9uIG1ldGhvZCkK ICAgICAgICAgcmV0dXJuICJQT1NUIjsKICAgICBjYXNlIFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6 UHV0T3BlcmF0aW9uOgogICAgICAgICByZXR1cm4gIlBVVCI7Ci0jaWYgUVRfVkVSU0lPTiA+PSBR VF9WRVJTSU9OX0NIRUNLKDQsIDYsIDApCiAgICAgY2FzZSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6 OkRlbGV0ZU9wZXJhdGlvbjoKICAgICAgICAgcmV0dXJuICJERUxFVEUiOwotI2VuZGlmCi0jaWYg UVRfVkVSU0lPTiA+PSBRVF9WRVJTSU9OX0NIRUNLKDQsIDcsIDApCiAgICAgY2FzZSBRTmV0d29y a0FjY2Vzc01hbmFnZXI6OkN1c3RvbU9wZXJhdGlvbjoKLSAgICAgICAgcmV0dXJuICJPUFRJT05T IjsKLSNlbmRpZgorICAgICAgICByZXR1cm4gbV9yZXNvdXJjZUhhbmRsZS0+Zmlyc3RSZXF1ZXN0 KCkuaHR0cE1ldGhvZCgpOwogICAgIGRlZmF1bHQ6CisgICAgICAgIEFTU0VSVF9OT1RfUkVBQ0hF RCgpOwogICAgICAgICByZXR1cm4gIkdFVCI7CiAgICAgfQogfQpAQCAtMjA2LDExICsyMDMsMTIg QEAgUU5ldHdvcmtSZXBseUhhbmRsZXI6OlFOZXR3b3JrUmVwbHlIYW5kbGVyKFJlc291cmNlSGFu ZGxlKiBoYW5kbGUsIExvYWRNb2RlIGxvYWQKICAgICBlbHNlIGlmIChyLmh0dHBNZXRob2QoKSA9 PSAiREVMRVRFIikKICAgICAgICAgbV9tZXRob2QgPSBRTmV0d29ya0FjY2Vzc01hbmFnZXI6OkRl bGV0ZU9wZXJhdGlvbjsKICNpZiBRVF9WRVJTSU9OID49IFFUX1ZFUlNJT05fQ0hFQ0soNCwgNywg MCkKLSAgICBlbHNlIGlmIChyLmh0dHBNZXRob2QoKSA9PSAiT1BUSU9OUyIpCisgICAgZWxzZQog ICAgICAgICBtX21ldGhvZCA9IFFOZXR3b3JrQWNjZXNzTWFuYWdlcjo6Q3VzdG9tT3BlcmF0aW9u OwotI2VuZGlmCisjZWxzZQogICAgIGVsc2UKICAgICAgICAgbV9tZXRob2QgPSBRTmV0d29ya0Fj Y2Vzc01hbmFnZXI6OlVua25vd25PcGVyYXRpb247CisjZW5kaWYKIAogICAgIFFPYmplY3QqIG9y aWdpbmF0aW5nT2JqZWN0ID0gMDsKICAgICBpZiAobV9yZXNvdXJjZUhhbmRsZS0+Z2V0SW50ZXJu YWwoKS0+bV9jb250ZXh0KQpAQCAtNDEwLDcgKzQwOCw3IEBAIHZvaWQgUU5ldHdvcmtSZXBseUhh bmRsZXI6OnNlbmRSZXNwb25zZUlmTmVlZGVkKCkKICAgICAgICAgICAgIG1fbWV0aG9kID0gUU5l dHdvcmtBY2Nlc3NNYW5hZ2VyOjpHZXRPcGVyYXRpb247CiAKICAgICAgICAgUmVzb3VyY2VSZXF1 ZXN0IG5ld1JlcXVlc3QgPSBtX3Jlc291cmNlSGFuZGxlLT5maXJzdFJlcXVlc3QoKTsKLSAgICAg ICAgbmV3UmVxdWVzdC5zZXRIVFRQTWV0aG9kKGh0dHBNZXRob2RTdHJpbmcobV9tZXRob2QpKTsK KyAgICAgICAgbmV3UmVxdWVzdC5zZXRIVFRQTWV0aG9kKGh0dHBNZXRob2QoKSk7CiAgICAgICAg IG5ld1JlcXVlc3Quc2V0VVJMKG5ld1VybCk7CiAKICAgICAgICAgLy8gU2hvdWxkIG5vdCBzZXQg UmVmZXJlciBhZnRlciBhIHJlZGlyZWN0IGZyb20gYSBzZWN1cmUgcmVzb3VyY2UgdG8gbm9uLXNl Y3VyZSBvbmUuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdv cmtSZXBseUhhbmRsZXIuaCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1Jl cGx5SGFuZGxlci5oCmluZGV4IGI2NGQ1ZmYuLjg4NGExYTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCisrKyBiL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5oCkBAIC02Nyw2ICs2Nyw3 IEBAIHByaXZhdGUgc2xvdHM6CiBwcml2YXRlOgogICAgIHZvaWQgc3RhcnQoKTsKICAgICB2b2lk IHJlc2V0U3RhdGUoKTsKKyAgICBTdHJpbmcgaHR0cE1ldGhvZCgpIGNvbnN0OwogCiAgICAgUU5l dHdvcmtSZXBseSogbV9yZXBseTsKICAgICBSZXNvdXJjZUhhbmRsZSogbV9yZXNvdXJjZUhhbmRs ZTsK