40458 2010-06-10 19:00:19 -0700 HTML5Tokenizer should not delete itself while running scripts 2010-06-11 08:29:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 eric eric abarth commit-queue tonyg oldest_to_newest 236642 0 eric 2010-06-10 19:00:19 -0700 HTML5Tokenizer should not delete itself while running scripts 236643 1 58433 eric 2010-06-10 19:02:02 -0700 Created attachment 58433 Patch 236645 2 58433 eric 2010-06-10 19:04:01 -0700 Comment on attachment 58433 Patch Changes like this reenforce in my mind that we've chosen a sane architecture. :) It's not 100% clear to me why endIfDelayed does not allow ending in recursive write() calls, but attemptToEnd() does. That may be another bug. If these two checks match then we should abstract the if contents into a canEnd() helper. 236673 3 58433 abarth 2010-06-10 21:37:34 -0700 Comment on attachment 58433 Patch Nice. 236846 4 58433 commit-queue 2010-06-11 08:28:59 -0700 Comment on attachment 58433 Patch Clearing flags on attachment: 58433 Committed r61021: <http://trac.webkit.org/changeset/61021> 236847 5 commit-queue 2010-06-11 08:29:08 -0700 All reviewed patches have been landed. Closing bug. 58433 2010-06-10 19:02:02 -0700 2010-06-11 08:28:59 -0700 Patch bug-40458-20100610190200.patch text/plain 1382 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODY2NzJlY2JkNWFkZmZmMTgxYTA2YTg1YmE5MjY4NGM3YTkzMGJjMC4uODRlNTU0ZjNhMmI1NGM0 ZTZlM2E4Nzc4YzYxZjE2NjhkZDNkYWM5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNi0xMCAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSFRNTDVUb2tlbml6ZXIgc2hvdWxkIG5vdCBkZWxldGUgaXRz ZWxmIHdoaWxlIHJ1bm5pbmcgc2NyaXB0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDA0NTgKKworICAgICAgICBUZXN0ZWQgYnkgZmFzdC9kb20vZG9j dW1lbnQtY2xlYXIuaHRtbAorCisgICAgICAgICogaHRtbC9IVE1MNVRva2VuaXplci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpIVE1MNVRva2VuaXplcjo6YXR0ZW1wdFRvRW5kKToKKyAgICAgICAg IC0gRG9uJ3QgZXZlciBlbmQoKSB3aGlsZSBydW5uaW5nIHNjcmlwdHMuCisgICAgICAgICAgIFRo aXMgbWF0Y2hlcyB0aGUgb2xkIEhUTUxUb2tlbml6ZXIuY3BwCisKIDIwMTAtMDYtMTAgIFRvbnkg Q2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW50IFRh bXVyYS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9IVE1MNVRva2VuaXplci5jcHAgYi9XZWJD b3JlL2h0bWwvSFRNTDVUb2tlbml6ZXIuY3BwCmluZGV4IGEyZjljM2Y5YzJiZWEwYzAzMmM3NzVh Y2RjMzIwMWFkOWNhNWU1MjAuLmE1NDI3NzU4MTM2NGEzNzhjMmJlMTMwM2UwZTgwZGY2OTI4OTEx ZmUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1MNVRva2VuaXplci5jcHAKKysrIGIvV2Vi Q29yZS9odG1sL0hUTUw1VG9rZW5pemVyLmNwcApAQCAtMTUzLDcgKzE1Myw3IEBAIHZvaWQgSFRN TDVUb2tlbml6ZXI6OmF0dGVtcHRUb0VuZCgpCiAgICAgLy8gZmluaXNoKCkgaW5kaWNhdGVzIHdl IHdpbGwgbm90IHJlY2VpdmUgYW55IG1vcmUgZGF0YS4gSWYgd2UgYXJlIHdhaXRpbmcgb24KICAg ICAvLyBhbiBleHRlcm5hbCBzY3JpcHQgdG8gbG9hZCwgd2UgY2FuJ3QgZmluaXNoIHBhcnNpbmcg cXVpdGUgeWV0LgogCi0gICAgaWYgKGluV3JpdGUoKSB8fCBpc1dhaXRpbmdGb3JTY3JpcHRzKCkp IHsKKyAgICBpZiAoaW5Xcml0ZSgpIHx8IGlzV2FpdGluZ0ZvclNjcmlwdHMoKSB8fCBleGVjdXRp bmdTY3JpcHQoKSkgewogICAgICAgICBtX2VuZFdhc0RlbGF5ZWQgPSB0cnVlOwogICAgICAgICBy ZXR1cm47CiAgICAgfQo=