40445 2010-06-10 14:26:45 -0700 [Qt] Regression(r59956) - Return usable property names from DRT's computedStyleIncludingVisitedInfo() 2010-07-03 14:37:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 robert robert hausmann kenneth tonikitoo oldest_to_newest 236533 0 robert 2010-06-10 14:26:45 -0700 [Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo() 236538 1 58413 robert 2010-06-10 14:31:30 -0700 Created attachment 58413 Patch 237399 2 58413 eric 2010-06-12 18:49:43 -0700 Comment on attachment 58413 Patch Really!? Do other DRTs need to do this dance too? Seems sub-optimal if so. 240327 3 robert 2010-06-19 06:19:47 -0700 (In reply to comment #2) > (From update of attachment 58413 [details]) > Really!? Do other DRTs need to do this dance too? Seems sub-optimal if so. No, because they can access objects like JSContextRef and JSString directly. The Qt bridge converts JSCore objects to the appropriate Qt counterpart (e.g. QString) and QVariant if all else fails. These QVariant objects are basically large property maps - hence the need to translate the names containing hypens to JS variable-style names. 246305 4 58413 kenneth 2010-07-03 07:43:15 -0700 Comment on attachment 58413 Patch Maybe our bridge should be doing this. 246325 5 tonikitoo 2010-07-03 09:39:28 -0700 *** Bug 39597 has been marked as a duplicate of this bug. *** 246349 6 robert 2010-07-03 14:37:15 -0700 Committed r62450: <http://trac.webkit.org/changeset/62450> 58413 2010-06-10 14:31:30 -0700 2010-07-03 07:43:15 -0700 Patch bug-40445-20100610223128.patch text/plain 3853 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NWZmNWZkYWYxYmYxYjU4YzI0NTc1ZmM5ZGIyOWY0NWMwM2U0Yjc2Li5hNDlmMjlm MWY0ZmI0ZGQ0Y2E3YjkwMjYyNWE1ZGJkMWJhMjYyMDk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTcgQEAK IDIwMTAtMDYtMTAgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmV0dXJuIHVzYWJs ZSBwcm9wZXJ0eSBuYW1lcyBmcm9tIERSVCdzIGNvbXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVk SW5mbygpCisKKyAgICAgICAgVW5za2lwIGZhc3QvaGlzdG9yeS9zZWxmLWlzLXZpc2l0ZWQuaHRt bAorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQ0 NQorCisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKworMjAxMC0wNi0xMCAgUm9iZXJ0 IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0 aCBSb2hkZSBDaHJpc3RpYW5zZW4uCiAKICAgICAgICAgW1F0XSBGaXggUXQtc3BlY2lmaWMgZXZl bnQtc2VuZGVyLWtleWRvd24tZnJhbWUuaHRtbCB0ZXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApp bmRleCAwNGZiNGM2NmE1MTVjOWNmNGYwMjc1ZGZjNzI4ODEyM2ZkYTQ0NzJjLi40YjkzNjg4NWQ0 ODM3MjhiYWFiMTQwNDVjN2UxMWY3MDY1YjY0ZTZhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQK QEAgLTI0MzMsOSArMjQzMyw2IEBAIGVkaXRpbmcvdW5zdXBwb3J0ZWQtY29udGVudC90YWJsZS10 eXBlLWJlZm9yZS5odG1sCiAjIGZhaWxpbmcgZmFzdCB0ZXN0cwogIyA9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PSAjCiAKLSMgUG9zc2libGUgYnVnIGluIGxheW91dFRlc3RDb250cm9sbGVyLmNvbXB1dGVk U3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbygpCi1mYXN0L2hpc3Rvcnkvc2VsZi1pcy12aXNpdGVk Lmh0bWwKLQogIyBGYWlsaW5nIHRlc3RzIGludHJvZHVjZWQgYnkgY2hhbmdpbmcgdGhlIGRlZmF1 bHQgZm9udCBzaXplcyB0bwogIyBjb25mb3JtIG90aGVyIHBsYXRmb3Jtcy4gUHJvYmFibHkgY2F1 c2VkIGJ5IHByZXZpb3VzbHkgaGlkZGVuIGJ1Z3MuCiBmYXN0L2Nzcy9nZXRDb21wdXRlZFN0eWxl L2NvbXB1dGVkLXN0eWxlLXdpdGhvdXQtcmVuZGVyZXIuaHRtbApkaWZmIC0tZ2l0IGEvV2ViS2l0 L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXggYzE1YTQ4ODllYzRkOGEy OWMxZGM0MDJjYmQxMTlhNDNkOTE3MWRmNS4uNDMwMzg3NWZmYzQ1NDYyNjA0ZmYxODU3ODcxMTg4 MjcyMDgxOTA3YyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQv cXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDYtMTAgIFJvYmVydCBIb2dhbiAg PHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gUmV0dXJuIHVzYWJsZSBwcm9wZXJ0eSBuYW1lcyBmcm9tIERSVCdz IGNvbXB1dGVkU3R5bGVJbmNsdWRpbmdWaXNpdGVkSW5mbygpCisKKyAgICAgICAgT2JqZWN0IHBy b3BlcnR5IG5hbWVzIHN1Y2ggYXMgJ2JhY2tncm91bmQtY29sb3InIG5lZWQgdG8gYmUgcmV0dXJu ZWQgaW4gY2FtZWwKKyAgICAgICAgY2FzZSwgaS5lLiBiYWNrZ3JvdW5kQ29sb3Igc28gdGhhdCBK UyBjYW4gcmVmZXJlbmNlIHRoZW0uIEFkZCBzdXBwb3J0IGZvciB0aGlzCisgICAgICAgIHRvIER1 bXBSZW5kZXJUcmVlU3VwcG9ydFF0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD00MDQ0NQorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJl bmRlclRyZWVTdXBwb3J0UXQuY3BwOgorICAgICAgICAoY29udmVydFRvUHJvcGVydHlOYW1lKToK KyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0Ojpjb21wdXRlZFN0eWxlSW5jbHVkaW5n VmlzaXRlZEluZm8pOgorCiAyMDEwLTA2LTEwICBNYWhlc2ggS3Vsa2FybmkgIDxtYWhlc2gua3Vs a2FybmlAbm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9y dFF0LmNwcCBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR dC5jcHAKaW5kZXggMzExN2U0NDNmYWVmZDI5YzMwYmViYjFkMjg2NWYxZTRiNWFmMDJjYS4uMTEz OTljY2Q2Y2MwOTY1ZjgyM2MzYTk1OWQ0MmE1ZGQ1ZGEwZDYwYiAxMDA2NDQKLS0tIGEvV2ViS2l0 L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAorKysgYi9XZWJL aXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCkBAIC0zOTEs NiArMzkxLDIwIEBAIFFTdHJpbmcgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6Om1hcmtlclRleHRG b3JMaXN0SXRlbShjb25zdCBRV2ViRWxlbWVudCYgbGlzdEl0CiAgICAgcmV0dXJuIFdlYkNvcmU6 Om1hcmtlclRleHRGb3JMaXN0SXRlbShsaXN0SXRlbS5tX2VsZW1lbnQpOwogfQogCitzdGF0aWMg UVN0cmluZyBjb252ZXJ0VG9Qcm9wZXJ0eU5hbWUoY29uc3QgUVN0cmluZyYgbmFtZSkKK3sKKyAg ICBRU3RyaW5nTGlzdCBwYXJ0cyA9IG5hbWUuc3BsaXQoJy0nKTsKKyAgICBRU3RyaW5nIGNhbWVs Q2FzZU5hbWU7CisgICAgZm9yIChpbnQgaiA9IDA7IGogPCBwYXJ0cy5jb3VudCgpOyArK2opIHsK KyAgICAgICAgUVN0cmluZyBwYXJ0ID0gcGFydHMuYXQoaik7CisgICAgICAgIGlmIChqKQorICAg ICAgICAgICAgY2FtZWxDYXNlTmFtZS5hcHBlbmQocGFydC5yZXBsYWNlKDAsIDEsIHBhcnQubGVm dCgxKS50b1VwcGVyKCkpKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgY2FtZWxDYXNlTmFt ZS5hcHBlbmQocGFydCk7CisgICAgfQorICAgIHJldHVybiBjYW1lbENhc2VOYW1lOworfQorCiBR VmFyaWFudE1hcCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6Y29tcHV0ZWRTdHlsZUluY2x1ZGlu Z1Zpc2l0ZWRJbmZvKGNvbnN0IFFXZWJFbGVtZW50JiBlbGVtZW50KQogewogICAgIFFWYXJpYW50 TWFwIHJlczsKQEAgLTQwMyw3ICs0MTcsNyBAQCBRVmFyaWFudE1hcCBEdW1wUmVuZGVyVHJlZVN1 cHBvcnRRdDo6Y29tcHV0ZWRTdHlsZUluY2x1ZGluZ1Zpc2l0ZWRJbmZvKGNvbnN0IFFXZQogICAg IGZvciAoaW50IGkgPSAwOyBpIDwgc3R5bGUtPmxlbmd0aCgpOyBpKyspIHsKICAgICAgICAgUVN0 cmluZyBuYW1lID0gc3R5bGUtPml0ZW0oaSk7CiAgICAgICAgIFFTdHJpbmcgdmFsdWUgPSAoc3Rh dGljX2Nhc3Q8V2ViQ29yZTo6Q1NTU3R5bGVEZWNsYXJhdGlvbio+KHN0eWxlLmdldCgpKSktPmdl dFByb3BlcnR5VmFsdWUobmFtZSk7Ci0gICAgICAgIHJlc1tuYW1lXSA9IFFWYXJpYW50KHZhbHVl KTsKKyAgICAgICAgcmVzW2NvbnZlcnRUb1Byb3BlcnR5TmFtZShuYW1lKV0gPSBRVmFyaWFudCh2 YWx1ZSk7CiAgICAgfQogICAgIHJldHVybiByZXM7CiB9Cg==