40441 2010-06-10 12:40:04 -0700 REGRESSION: Continuous wheel event deltas are way too large. 2010-06-18 16:55:52 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P1 Major --- 1 hyatt hyatt aestes ap ddkilzer eric mitz pkchan+bugzilla=webkit oldest_to_newest 236490 0 hyatt 2010-06-10 12:40:04 -0700 https://lists.webkit.org/pipermail/webkit-dev/2010-June/013179.html 236491 1 hyatt 2010-06-10 12:44:27 -0700 This is a regression from: https://bugs.webkit.org/show_bug.cgi?id=29601 236492 2 mrowe 2010-06-10 12:47:16 -0700 <rdar://problem/8073715> 236497 3 hyatt 2010-06-10 13:07:20 -0700 Best way to handle this is to revert all the native platform code, since it was all correct and just do the minimum line clamping at DOM event generation time. That way any code in WebCore that uses wheel events natively (without exposing them to the DOM) will be accurate. This could be important when we move off NSScrollView in WebKit2 and end up using this event for wheeling. 236505 4 hyatt 2010-06-10 13:26:54 -0700 Another possibility is to use an accumulator strategy at the DOM level and send the event once you have moved 1 full line. This would still result in no movement in response to small events until the threshold was crossed though. I am guessing a minimum line movement of 1, although it will result in slightly-too-rapid scrolling, will probably work best, but really we should just be evangelizing the Web sites, as what we were doing in Safari 4 wasn't wrong. 236519 5 58410 hyatt 2010-06-10 14:03:53 -0700 Created attachment 58410 Patch This is just a straight-up backout of the fix for 29601. I will be reopening that bug once this lands. 236521 6 58410 sullivan 2010-06-10 14:05:29 -0700 Comment on attachment 58410 Patch As I hang my head in shame, I acknowledge that the lack of this code is better than its presence, despite my earlier review. 236525 7 eric 2010-06-10 14:11:03 -0700 Attachment 58410 did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3230112 236540 8 hyatt 2010-06-10 14:33:25 -0700 Fixed in r60974. 58410 2010-06-10 14:03:53 -0700 2010-06-10 14:05:29 -0700 Patch patch.txt text/plain 5189 hyatt SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDk3MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMDYtMTAgIERhdmlkIEh5YXR0ICA8aHlhdHRAYXBwbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQ0MSwgYmFjayBvdXQgdGhlIG9y aWdpbmFsIGZpeCBmb3IgMjk2MDEsIHNpbmNlIGl0IGhhcyBicm9rZW4gY29udGludW91cworICAg ICAgICB3aGVlbCBkZWx0YSB2YWx1ZXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvV2ViQ29y ZVN5c3RlbUludGVyZmFjZS5oOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVt SW50ZXJmYWNlLm1tOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9XaGVlbEV2ZW50TWFjLm1tOgor ICAgICAgICAoV2ViQ29yZTo6UGxhdGZvcm1XaGVlbEV2ZW50OjpQbGF0Zm9ybVdoZWVsRXZlbnQp OgorCiAyMDEwLTA2LTA5ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3Jt L21hYy9XZWJDb3JlU3lzdGVtSW50ZXJmYWNlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5oCShyZXZpc2lvbiA2MDUwOSkKKysrIFdl YkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UuaAkod29ya2luZyBjb3B5 KQpAQCAtMTE3LDcgKzExNyw3IEBAIGV4dGVybiBBVFNVRm9udElEICgqd2tHZXROU0ZvbnRBVFNV Rm9udEkKIGV4dGVybiBkb3VibGUgKCp3a0dldE5TVVJMUmVzcG9uc2VDYWxjdWxhdGVkRXhwaXJh dGlvbikoTlNVUkxSZXNwb25zZSAqcmVzcG9uc2UpOwogZXh0ZXJuIE5TRGF0ZSAqKCp3a0dldE5T VVJMUmVzcG9uc2VMYXN0TW9kaWZpZWREYXRlKShOU1VSTFJlc3BvbnNlICpyZXNwb25zZSk7CiBl eHRlcm4gQk9PTCAoKndrR2V0TlNVUkxSZXNwb25zZU11c3RSZXZhbGlkYXRlKShOU1VSTFJlc3Bv bnNlICpyZXNwb25zZSk7Ci1leHRlcm4gdm9pZCAoKndrR2V0V2hlZWxFdmVudERlbHRhcykoTlNF dmVudCosIGZsb2F0KiBkZWx0YVgsIGZsb2F0KiBkZWx0YVksIGZsb2F0KiB3aGVlbFRpY2tzWCwg ZmxvYXQqIHdoZWVsVGlja3NZLCBCT09MKiBjb250aW51b3VzKTsKK2V4dGVybiB2b2lkICgqd2tH ZXRXaGVlbEV2ZW50RGVsdGFzKShOU0V2ZW50KiwgZmxvYXQqIGRlbHRhWCwgZmxvYXQqIGRlbHRh WSwgQk9PTCogY29udGludW91cyk7CiBleHRlcm4gQk9PTCAoKndrSGl0VGVzdE1lZGlhVUlQYXJ0 KShpbnQgcGFydCwgaW50IHRoZW1lU3R5bGUsIENHUmVjdCBib3VuZHMsIENHUG9pbnQgcG9pbnQp OwogZXh0ZXJuIHZvaWQgKCp3a01lYXN1cmVNZWRpYVVJUGFydCkoaW50IHBhcnQsIGludCB0aGVt ZVN0eWxlLCBDR1JlY3QgKmJvdW5kcywgQ0dTaXplICpuYXR1cmFsU2l6ZSk7CiBleHRlcm4gQk9P TCAoKndrTWVkaWFDb250cm9sbGVyVGhlbWVBdmFpbGFibGUpKGludCB0aGVtZVN0eWxlKTsKSW5k ZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFjL1dlYkNvcmVTeXN0ZW1JbnRlcmZhY2UubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9tYWMvV2ViQ29yZVN5c3RlbUludGVyZmFjZS5tbQko cmV2aXNpb24gNjA1MDkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL21hYy9XZWJDb3JlU3lzdGVtSW50 ZXJmYWNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC01Miw3ICs1Miw3IEBAIE5TU3RyaW5nKiAoKndr R2V0TUlNRVR5cGVGb3JFeHRlbnNpb24pKE4KIE5TVGltZUludGVydmFsICgqd2tHZXROU1VSTFJl c3BvbnNlQ2FsY3VsYXRlZEV4cGlyYXRpb24pKE5TVVJMUmVzcG9uc2UgKnJlc3BvbnNlKTsKIE5T RGF0ZSAqKCp3a0dldE5TVVJMUmVzcG9uc2VMYXN0TW9kaWZpZWREYXRlKShOU1VSTFJlc3BvbnNl ICpyZXNwb25zZSk7CiBCT09MICgqd2tHZXROU1VSTFJlc3BvbnNlTXVzdFJldmFsaWRhdGUpKE5T VVJMUmVzcG9uc2UgKnJlc3BvbnNlKTsKLXZvaWQgKCp3a0dldFdoZWVsRXZlbnREZWx0YXMpKE5T RXZlbnQqLCBmbG9hdCogZGVsdGFYLCBmbG9hdCogZGVsdGFZLCBmbG9hdCogd2hlZWxUaWNrc1gs IGZsb2F0KiB3aGVlbFRpY2tzWSwgQk9PTCogY29udGludW91cyk7Cit2b2lkICgqd2tHZXRXaGVl bEV2ZW50RGVsdGFzKShOU0V2ZW50KiwgZmxvYXQqIGRlbHRhWCwgZmxvYXQqIGRlbHRhWSwgQk9P TCogY29udGludW91cyk7CiB2b2lkICgqd2tQb3B1cE1lbnUpKE5TTWVudSosIE5TUG9pbnQgbG9j YXRpb24sIGZsb2F0IHdpZHRoLCBOU1ZpZXcqLCBpbnQgc2VsZWN0ZWRJdGVtLCBOU0ZvbnQqKTsK IHVuc2lnbmVkICgqd2tRVEluY2x1ZGVPbmx5TW9kZXJuTWVkaWFGaWxlVHlwZXMpKHZvaWQpOwog aW50ICgqd2tRVE1vdmllRGF0YVJhdGUpKFFUTW92aWUqKTsKSW5kZXg6IFdlYkNvcmUvcGxhdGZv cm0vbWFjL1doZWVsRXZlbnRNYWMubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9t YWMvV2hlZWxFdmVudE1hYy5tbQkocmV2aXNpb24gNjA1MDkpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L21hYy9XaGVlbEV2ZW50TWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00MywxMiArNDMsMTggQEAg UGxhdGZvcm1XaGVlbEV2ZW50OjpQbGF0Zm9ybVdoZWVsRXZlbnQoTgogICAgICwgbV9tZXRhS2V5 KFtldmVudCBtb2RpZmllckZsYWdzXSAmIE5TQ29tbWFuZEtleU1hc2spCiB7CiAgICAgQk9PTCBj b250aW51b3VzOwotICAgIHdrR2V0V2hlZWxFdmVudERlbHRhcyhldmVudCwgJm1fZGVsdGFYLCAm bV9kZWx0YVksICZtX3doZWVsVGlja3NYLCAmbV93aGVlbFRpY2tzWSwgJmNvbnRpbnVvdXMpOwot Ci0gICAgaWYgKCFjb250aW51b3VzKSB7Ci0gICAgICAgIG1fZGVsdGFYICo9IHN0YXRpY19jYXN0 PGZsb2F0PihTY3JvbGxiYXI6OnBpeGVsc1BlckxpbmVTdGVwKCkpOwotICAgICAgICBtX2RlbHRh WSAqPSBzdGF0aWNfY2FzdDxmbG9hdD4oU2Nyb2xsYmFyOjpwaXhlbHNQZXJMaW5lU3RlcCgpKTsK KyAgICAKKyAgICB3a0dldFdoZWVsRXZlbnREZWx0YXMoZXZlbnQsICZtX2RlbHRhWCwgJm1fZGVs dGFZLCAmY29udGludW91cyk7CisgICAgaWYgKGNvbnRpbnVvdXMpIHsKKyAgICAgICAgbV93aGVl bFRpY2tzWCA9IG1fZGVsdGFYIC8gc3RhdGljX2Nhc3Q8ZmxvYXQ+KFNjcm9sbGJhcjo6cGl4ZWxz UGVyTGluZVN0ZXAoKSk7CisgICAgICAgIG1fd2hlZWxUaWNrc1kgPSBtX2RlbHRhWSAvIHN0YXRp Y19jYXN0PGZsb2F0PihTY3JvbGxiYXI6OnBpeGVsc1BlckxpbmVTdGVwKCkpOworICAgIH0gZWxz ZSB7CisgICAgICAgIG1fd2hlZWxUaWNrc1ggPSBtX2RlbHRhWDsKKyAgICAgICAgbV93aGVlbFRp Y2tzWSA9IG1fZGVsdGFZOwogICAgIH0KKworICAgIG1fZGVsdGFYICo9IHN0YXRpY19jYXN0PGZs b2F0PihTY3JvbGxiYXI6OnBpeGVsc1BlckxpbmVTdGVwKCkpOworICAgIG1fZGVsdGFZICo9IHN0 YXRpY19jYXN0PGZsb2F0PihTY3JvbGxiYXI6OnBpeGVsc1BlckxpbmVTdGVwKCkpOwogfQogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4OiBXZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJLaXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gNjA5NzEpCisrKyBXZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA2LTEw ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA0NDEsIGJhY2sgb3V0IHRoZSBvcmlnaW5hbCBmaXggZm9yIDI5NjAxLCBzaW5j ZSBpdCBoYXMgYnJva2VuIGNvbnRpbnVvdXMKKyAgICAgICAgd2hlZWwgZGVsdGEgdmFsdWVzLgor CisgICAgICAgICogV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcubW06CisgICAgICAg ICgtW1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldyBzY3JvbGxXaGVlbDpdKToKKwogMjAxMC0wNi0w OSAgU2hlcmlmZiBCb3QgIDx3ZWJraXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAg VW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjYwODg5LgpJbmRleDogV2ViS2l0L21hYy9XZWJWaWV3 L1dlYkR5bmFtaWNTY3JvbGxCYXJzVmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1dl YlZpZXcvV2ViRHluYW1pY1Njcm9sbEJhcnNWaWV3Lm1tCShyZXZpc2lvbiA2MDUwOSkKKysrIFdl YktpdC9tYWMvV2ViVmlldy9XZWJEeW5hbWljU2Nyb2xsQmFyc1ZpZXcubW0JKHdvcmtpbmcgY29w eSkKQEAgLTQ3MCwxMCArNDcwLDggQEAgLSAodm9pZClzY3JvbGxXaGVlbDooTlNFdmVudCAqKWV2 ZW50CiB7CiAgICAgZmxvYXQgZGVsdGFYOwogICAgIGZsb2F0IGRlbHRhWTsKLSAgICBmbG9hdCB3 aGVlbFRpY2tzWDsKLSAgICBmbG9hdCB3aGVlbFRpY2tzWTsKICAgICBCT09MIGlzQ29udGludW91 czsKLSAgICBXS0dldFdoZWVsRXZlbnREZWx0YXMoZXZlbnQsICZkZWx0YVgsICZkZWx0YVksICZ3 aGVlbFRpY2tzWCwgJndoZWVsVGlja3NZLCAmaXNDb250aW51b3VzKTsKKyAgICBXS0dldFdoZWVs RXZlbnREZWx0YXMoZXZlbnQsICZkZWx0YVgsICZkZWx0YVksICZpc0NvbnRpbnVvdXMpOwogCiAg ICAgQk9PTCBpc0xhdGNoaW5nRXZlbnQgPSBXS0lzTGF0Y2hpbmdXaGVlbEV2ZW50KGV2ZW50KTsK IAo=