40430 2010-06-10 10:48:20 -0700 [Chromium] Plumbing for top-level frame names 2010-06-18 22:27:23 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson abarth commit-queue dglazkov eric fishd levin webkit.review.bot oldest_to_newest 236435 0 atwilson 2010-06-10 10:48:20 -0700 We need to enable Chromium to set the name of frames that it creates, and also to have the name of top level frames passed along when creating a view. This is the upstream portion of http://codereview.chromium.org/2775003 236467 1 58395 atwilson 2010-06-10 11:41:30 -0700 Created attachment 58395 Patch containing plumbing for passing frame names to Chromium This is dependent on this downstream patch: http://codereview.chromium.org/2775003 so I won't land this until after that patch lands. 236667 2 58395 levin 2010-06-10 21:27:14 -0700 Comment on attachment 58395 Patch containing plumbing for passing frame names to Chromium Marking cq- per Drew's comment in bug. 237300 3 atwilson 2010-06-12 09:04:36 -0700 The downstream patch has landed - just waiting for anyone to r+ this patch now. 237342 4 58567 atwilson 2010-06-12 15:03:40 -0700 Created attachment 58567 Updated chromium DRT to match new createView() API Realized that there was one more place in the code that needed to change to match the new createView() API (Chromium DRT). 237422 5 58567 tkent 2010-06-12 19:09:28 -0700 Comment on attachment 58567 Updated chromium DRT to match new createView() API OK. 239039 6 58567 fishd 2010-06-16 13:18:20 -0700 Comment on attachment 58567 Updated chromium DRT to match new createView() API WebKit/chromium/public/WebFrame.h:106 + virtual void setName(const WebString&) = 0; What's the difference between clearName and setName(WebString())? Looking at the code, setName(WebString()) will assign a unique name to the frame. Is that what you want this API to do? It seems like you should document this behavior. 239044 7 58567 commit-queue 2010-06-16 13:29:08 -0700 Comment on attachment 58567 Updated chromium DRT to match new createView() API Clearing flags on attachment: 58567 Committed r61278: <http://trac.webkit.org/changeset/61278> 239045 8 commit-queue 2010-06-16 13:29:13 -0700 All reviewed patches have been landed. Closing bug. 239104 9 atwilson 2010-06-16 14:45:55 -0700 Reopening bug so I can address Darin's comments. clearName() is currently used in exactly one place - as part of TestShell::ResetBeforeTestRun(), to reset the frame state between tests. I am going to confirm the difference between clearName() and setName(WebString()) - I think the behavior is identical for top-level frames, but I'm not 100% sure - and I'll document the exact behavior. 239438 10 fishd 2010-06-17 09:56:25 -0700 atwilson, if we only need clearName to clear the top-level frame name, and if setName(WebString()) would be equivalent in that case, then can you also eliminate the clearName method? 239483 11 atwilson 2010-06-17 11:06:00 -0700 That's what I'm doing. I have the chrome-side change out in the trybots now. 239661 12 59051 atwilson 2010-06-17 17:12:58 -0700 Created attachment 59051 Patch that removes clearName() Darin, I've removed clearName() as we discussed and added documentation about setName()'s behavior. Please take a look when you get a chance. 239691 13 webkit.review.bot 2010-06-17 18:15:04 -0700 Attachment 59051 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3299308 239693 14 atwilson 2010-06-17 18:18:54 -0700 BTW, I can only assume the chromium build failure was spurious, since the code that generated the error was changed in this CL: http://src.chromium.org/viewvc/chrome?view=rev&revision=50171 239739 15 59051 levin 2010-06-17 21:27:27 -0700 Comment on attachment 59051 Patch that removes clearName() The build failure is real. You need to change 'chromium_rev' in WebKit/chromium/DEPS to avoid it. If you do it in this patch, the build will still fail because ews doesn't do another update-webkit --chromium (aka gclient sync) after applying the patch, so it is nice to do the DEPS roll as a separate patch to ensure that your patch builds correctly. 239764 16 atwilson 2010-06-17 22:38:20 -0700 (In reply to comment #15) > (From update of attachment 59051 [details]) > The build failure is real. > > You need to change 'chromium_rev' in WebKit/chromium/DEPS to avoid it. OK, thanks, I didn't know that. I'll submit a separate patch for that DEPS roll. Is there a way to force EWS to retry this patch, or do I just need to re-upload this same patch again after rolling DEPS? 239787 17 levin 2010-06-18 00:03:10 -0700 (In reply to comment #16) > (In reply to comment #15) > > (From update of attachment 59051 [details] [details]) > > The build failure is real. > > > > You need to change 'chromium_rev' in WebKit/chromium/DEPS to avoid it. > > OK, thanks, I didn't know that. > > I'll submit a separate patch for that DEPS roll. Is there a way to force EWS to retry this patch, or do I just need to re-upload this same patch again after rolling DEPS? I don't know (ask Eric or Adam in irc?). I would guess that you need to upload a new patch. 240017 18 59131 atwilson 2010-06-18 10:27:54 -0700 Created attachment 59131 Reuploaded patch so it can go through EWS again after DEPS roll. 240106 19 59131 fishd 2010-06-18 13:34:28 -0700 Comment on attachment 59131 Reuploaded patch so it can go through EWS again after DEPS roll. WebKit/chromium/public/WebFrame.h:108 + // frame name unique within the hierarchy (see FrameTree::uniqueChildName() nit: let's avoid references to WebCore implementation details in the WebKit API headers. I'm concerned that these comments will not be maintained if someone renames WebCore types. otherwise, LGTM 240224 20 atwilson 2010-06-18 17:16:18 -0700 Landed as r61458 240273 21 webkit.review.bot 2010-06-18 22:27:23 -0700 http://trac.webkit.org/changeset/61458 might have broken Leopard Intel Debug (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/61458 http://trac.webkit.org/changeset/61459 58395 2010-06-10 11:41:30 -0700 2010-06-12 15:03:40 -0700 Patch containing plumbing for passing frame names to Chromium x text/plain 3827 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA0ZDg0NzEuLjJjMjJkYzYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDEwLTA2LTEwICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBw bHVtYmluZyB0byBDaHJvbWl1bSBXZWJLaXQgQVBJIHRvIGFsbG93IHNldHRpbmcvZ2V0dGluZyB0 aGUgbmFtZQorICAgICAgICBvZiB0b3AgbGV2ZWwgZnJhbWVzLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQzMAorICAgICAgICAqIHB1YmxpYy9X ZWJGcmFtZS5oOgorICAgICAgICBBZGRlZCBzZXROYW1lKCkgQVBJLgorICAgICAgICAqIHB1Ymxp Yy9XZWJWaWV3Q2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6OmNyZWF0 ZVZpZXcpOgorICAgICAgICBOb3cgdGFrZXMgYSAibmFtZSIgcGFyYW1ldGVyLgorICAgICAgICAq IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50 SW1wbDo6Y3JlYXRlV2luZG93KToKKyAgICAgICAgUGFzc2VzIGEgbmFtZSBwYXJhbWV0ZXIuCisg ICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1l SW1wbDo6c2V0TmFtZSk6CisgICAgICAgIEFsbG93cyBzZXR0aW5nIHRoZSBmcmFtZSBuYW1lIGJ5 IGNhbGxpbmcgdGhyb3VnaCB0byB0aGUgV2ViQ29yZSBBUEkuCisgICAgICAgICogc3JjL1dlYkZy YW1lSW1wbC5oOgorCiAyMDEwLTA2LTA5ICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90 QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNjA4ODkuCmRp ZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmggYi9XZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkZyYW1lLmgKaW5kZXggNzcyZGI3NS4uNDAzYTk5OCAxMDA2NDQKLS0t IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCisrKyBiL1dlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViRnJhbWUuaApAQCAtMTAzLDYgKzEwMyw3IEBAIHB1YmxpYzoKICAgICAvLyBU aGUgbmFtZSBvZiB0aGlzIGZyYW1lLgogICAgIHZpcnR1YWwgV2ViU3RyaW5nIG5hbWUoKSBjb25z dCA9IDA7CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyTmFtZSgpID0gMDsKKyAgICB2aXJ0dWFsIHZv aWQgc2V0TmFtZShjb25zdCBXZWJTdHJpbmcmKSA9IDA7CiAKICAgICAvLyBUaGUgdXJsIG9mIHRo ZSBkb2N1bWVudCBsb2FkZWQgaW4gdGhpcyBmcmFtZS4gIFRoaXMgaXMgZXF1aXZhbGVudCB0bwog ICAgIC8vIGRhdGFTb3VyY2UoKS0+cmVxdWVzdCgpLnVybCgpLgpkaWZmIC0tZ2l0IGEvV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYlZpZXdDbGllbnQuaAppbmRleCA0YTc5MWMyLi41ZmY0MDY3IDEwMDY0NAotLS0gYS9XZWJL aXQvY2hyb21pdW0vcHVibGljL1dlYlZpZXdDbGllbnQuaAorKysgYi9XZWJLaXQvY2hyb21pdW0v cHVibGljL1dlYlZpZXdDbGllbnQuaApAQCAtNzMsNyArNzMsOCBAQCBwdWJsaWM6CiAgICAgLy8g c28gYW55IHN1YnNlcXVlbnQgY2FsbHMgdG8gY3JlYXRlU2Vzc2lvblN0b3JhZ2VOYW1lc3BhY2Ug Y29uZm9ybSB0byB0aGUKICAgICAvLyBXZWJTdG9yYWdlIHNwZWNpZmljYXRpb24uCiAgICAgdmly dHVhbCBXZWJWaWV3KiBjcmVhdGVWaWV3KFdlYkZyYW1lKiBjcmVhdG9yLAotICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYgZmVhdHVyZXMpIHsg cmV0dXJuIDA7IH0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViV2lu ZG93RmVhdHVyZXMmIGZlYXR1cmVzLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBj b25zdCBXZWJTdHJpbmcmIG5hbWUpIHsgcmV0dXJuIDA7IH0KIAogICAgIC8vIENyZWF0ZSBhIG5l dyBXZWJQb3B1cE1lbnUuICBJbiB0aGUgc2Vjb25kIGZvcm0sIHRoZSBjbGllbnQgaXMKICAgICAv LyByZXNwb25zaWJsZSBmb3IgcmVuZGVyaW5nIHRoZSBjb250ZW50cyBvZiB0aGUgcG9wdXAgbWVu dS4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAg Yi9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCmluZGV4IDY1OTEwZjgu LjFiMjZjZGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1w bC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcApAQCAt MjMwLDcgKzIzMCw3IEBAIFBhZ2UqIENocm9tZUNsaWVudEltcGw6OmNyZWF0ZVdpbmRvdygKICAg ICAgICAgcmV0dXJuIDA7CiAKICAgICBXZWJWaWV3SW1wbCogbmV3VmlldyA9IHN0YXRpY19jYXN0 PFdlYlZpZXdJbXBsKj4oCi0gICAgICAgIG1fd2ViVmlldy0+Y2xpZW50KCktPmNyZWF0ZVZpZXco V2ViRnJhbWVJbXBsOjpmcm9tRnJhbWUoZnJhbWUpLCBmZWF0dXJlcykpOworICAgICAgICBtX3dl YlZpZXctPmNsaWVudCgpLT5jcmVhdGVWaWV3KFdlYkZyYW1lSW1wbDo6ZnJvbUZyYW1lKGZyYW1l KSwgZmVhdHVyZXMsIHIuZnJhbWVOYW1lKCkpKTsKICAgICBpZiAoIW5ld1ZpZXcpCiAgICAgICAg IHJldHVybiAwOwogCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKaW5kZXggYmIxZjZj ZS4uZWJhOWZhZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwu Y3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcApAQCAtNDc3LDYg KzQ3NywxMSBAQCB2b2lkIFdlYkZyYW1lSW1wbDo6Y2xlYXJOYW1lKCkKICAgICBtX2ZyYW1lLT50 cmVlKCktPmNsZWFyTmFtZSgpOwogfQogCit2b2lkIFdlYkZyYW1lSW1wbDo6c2V0TmFtZShjb25z dCBXZWJTdHJpbmcmIG5hbWUpCit7CisgICAgbV9mcmFtZS0+dHJlZSgpLT5zZXROYW1lKG5hbWUp OworfQorCiBXZWJVUkwgV2ViRnJhbWVJbXBsOjp1cmwoKSBjb25zdAogewogICAgIGNvbnN0IFdl YkRhdGFTb3VyY2UqIGRzID0gZGF0YVNvdXJjZSgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBs LmgKaW5kZXggYThiMjcyZi4uNWQ3ODU5OSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJGcmFtZUltcGwuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5o CkBAIC02NSw2ICs2NSw3IEBAIHB1YmxpYzoKICAgICAvLyBXZWJGcmFtZSBtZXRob2RzOgogICAg IHZpcnR1YWwgV2ViU3RyaW5nIG5hbWUoKSBjb25zdDsKICAgICB2aXJ0dWFsIHZvaWQgY2xlYXJO YW1lKCk7CisgICAgdmlydHVhbCB2b2lkIHNldE5hbWUoY29uc3QgV2ViU3RyaW5nJik7CiAgICAg dmlydHVhbCBXZWJVUkwgdXJsKCkgY29uc3Q7CiAgICAgdmlydHVhbCBXZWJVUkwgZmF2SWNvblVS TCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVVJMIG9wZW5TZWFyY2hEZXNjcmlwdGlvblVSTCgp IGNvbnN0Owo= 58567 2010-06-12 15:03:40 -0700 2010-06-17 17:12:58 -0700 Updated chromium DRT to match new createView() API x text/plain 6307 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGQ3MzFmNmUuLmE2YTgxZjMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDI0IEBACisyMDEwLTA2LTEwICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBw bHVtYmluZyB0byBDaHJvbWl1bSBXZWJLaXQgQVBJIHRvIGFsbG93IHNldHRpbmcvZ2V0dGluZyB0 aGUgbmFtZQorICAgICAgICBvZiB0b3AgbGV2ZWwgZnJhbWVzLgorCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQzMAorICAgICAgICAqIHB1YmxpYy9X ZWJGcmFtZS5oOgorICAgICAgICBBZGRlZCBzZXROYW1lKCkgQVBJLgorICAgICAgICAqIHB1Ymxp Yy9XZWJWaWV3Q2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdDbGllbnQ6OmNyZWF0 ZVZpZXcpOgorICAgICAgICBOb3cgdGFrZXMgYSAibmFtZSIgcGFyYW1ldGVyLgorICAgICAgICAq IHNyYy9DaHJvbWVDbGllbnRJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6Q2hyb21lQ2xpZW50 SW1wbDo6Y3JlYXRlV2luZG93KToKKyAgICAgICAgUGFzc2VzIGEgbmFtZSBwYXJhbWV0ZXIuCisg ICAgICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1l SW1wbDo6c2V0TmFtZSk6CisgICAgICAgIEFsbG93cyBzZXR0aW5nIHRoZSBmcmFtZSBuYW1lIGJ5 IGNhbGxpbmcgdGhyb3VnaCB0byB0aGUgV2ViQ29yZSBBUEkuCisgICAgICAgICogc3JjL1dlYkZy YW1lSW1wbC5oOgorCiAyMDEwLTA2LTEwICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0u b3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFN0ZXZlIEJsb2NrLgpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJGcmFtZS5oCmluZGV4IDc3MmRiNzUuLjQwM2E5OTggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViRnJhbWUuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZy YW1lLmgKQEAgLTEwMyw2ICsxMDMsNyBAQCBwdWJsaWM6CiAgICAgLy8gVGhlIG5hbWUgb2YgdGhp cyBmcmFtZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBuYW1lKCkgY29uc3QgPSAwOwogICAgIHZp cnR1YWwgdm9pZCBjbGVhck5hbWUoKSA9IDA7CisgICAgdmlydHVhbCB2b2lkIHNldE5hbWUoY29u c3QgV2ViU3RyaW5nJikgPSAwOwogCiAgICAgLy8gVGhlIHVybCBvZiB0aGUgZG9jdW1lbnQgbG9h ZGVkIGluIHRoaXMgZnJhbWUuICBUaGlzIGlzIGVxdWl2YWxlbnQgdG8KICAgICAvLyBkYXRhU291 cmNlKCktPnJlcXVlc3QoKS51cmwoKS4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJs aWMvV2ViVmlld0NsaWVudC5oIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3Q2xpZW50 LmgKaW5kZXggMzFlZjAyOC4uNzhlZmEzNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1 YmxpYy9XZWJWaWV3Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJWaWV3 Q2xpZW50LmgKQEAgLTczLDcgKzczLDggQEAgcHVibGljOgogICAgIC8vIHNvIGFueSBzdWJzZXF1 ZW50IGNhbGxzIHRvIGNyZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlIGNvbmZvcm0gdG8gdGhl CiAgICAgLy8gV2ViU3RvcmFnZSBzcGVjaWZpY2F0aW9uLgogICAgIHZpcnR1YWwgV2ViVmlldyog Y3JlYXRlVmlldyhXZWJGcmFtZSogY3JlYXRvciwKLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3QgV2ViV2luZG93RmVhdHVyZXMmIGZlYXR1cmVzKSB7IHJldHVybiAwOyB9Cisg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYldpbmRvd0ZlYXR1cmVzJiBm ZWF0dXJlcywKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgY29uc3QgV2ViU3RyaW5n JiBuYW1lKSB7IHJldHVybiAwOyB9CiAKICAgICAvLyBDcmVhdGUgYSBuZXcgV2ViUG9wdXBNZW51 LiAgSW4gdGhlIHNlY29uZCBmb3JtLCB0aGUgY2xpZW50IGlzCiAgICAgLy8gcmVzcG9uc2libGUg Zm9yIHJlbmRlcmluZyB0aGUgY29udGVudHMgb2YgdGhlIHBvcHVwIG1lbnUuCmRpZmYgLS1naXQg YS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwIGIvV2ViS2l0L2Nocm9t aXVtL3NyYy9DaHJvbWVDbGllbnRJbXBsLmNwcAppbmRleCBhOTQ0ZDQ4Li45MDA0NjExIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vc3JjL0Nocm9tZUNsaWVudEltcGwuY3BwCisrKyBiL1dl YktpdC9jaHJvbWl1bS9zcmMvQ2hyb21lQ2xpZW50SW1wbC5jcHAKQEAgLTIzMCw3ICsyMzAsNyBA QCBQYWdlKiBDaHJvbWVDbGllbnRJbXBsOjpjcmVhdGVXaW5kb3coCiAgICAgICAgIHJldHVybiAw OwogCiAgICAgV2ViVmlld0ltcGwqIG5ld1ZpZXcgPSBzdGF0aWNfY2FzdDxXZWJWaWV3SW1wbCo+ KAotICAgICAgICBtX3dlYlZpZXctPmNsaWVudCgpLT5jcmVhdGVWaWV3KFdlYkZyYW1lSW1wbDo6 ZnJvbUZyYW1lKGZyYW1lKSwgZmVhdHVyZXMpKTsKKyAgICAgICAgbV93ZWJWaWV3LT5jbGllbnQo KS0+Y3JlYXRlVmlldyhXZWJGcmFtZUltcGw6OmZyb21GcmFtZShmcmFtZSksIGZlYXR1cmVzLCBy LmZyYW1lTmFtZSgpKSk7CiAgICAgaWYgKCFuZXdWaWV3KQogICAgICAgICByZXR1cm4gMDsKIApk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCmluZGV4IGJiMWY2Y2UuLmViYTlmYWUgMTAw NjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAKQEAgLTQ3Nyw2ICs0NzcsMTEgQEAgdm9p ZCBXZWJGcmFtZUltcGw6OmNsZWFyTmFtZSgpCiAgICAgbV9mcmFtZS0+dHJlZSgpLT5jbGVhck5h bWUoKTsKIH0KIAordm9pZCBXZWJGcmFtZUltcGw6OnNldE5hbWUoY29uc3QgV2ViU3RyaW5nJiBu YW1lKQoreworICAgIG1fZnJhbWUtPnRyZWUoKS0+c2V0TmFtZShuYW1lKTsKK30KKwogV2ViVVJM IFdlYkZyYW1lSW1wbDo6dXJsKCkgY29uc3QKIHsKICAgICBjb25zdCBXZWJEYXRhU291cmNlKiBk cyA9IGRhdGFTb3VyY2UoKTsKZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJh bWVJbXBsLmggYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCmluZGV4IGE4YjI3 MmYuLjVkNzg1OTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBs LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaApAQCAtNjUsNiArNjUs NyBAQCBwdWJsaWM6CiAgICAgLy8gV2ViRnJhbWUgbWV0aG9kczoKICAgICB2aXJ0dWFsIFdlYlN0 cmluZyBuYW1lKCkgY29uc3Q7CiAgICAgdmlydHVhbCB2b2lkIGNsZWFyTmFtZSgpOworICAgIHZp cnR1YWwgdm9pZCBzZXROYW1lKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIHZpcnR1YWwgV2ViVVJM IHVybCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVVJMIGZhdkljb25VUkwoKSBjb25zdDsKICAg ICB2aXJ0dWFsIFdlYlVSTCBvcGVuU2VhcmNoRGVzY3JpcHRpb25VUkwoKSBjb25zdDsKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRl eCA3ZjA1NzVlLi4xYzYxMTNiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDYtMTIgIERy ZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gUGx1bWJpbmcgZm9yIHRvcC1s ZXZlbCBmcmFtZSBuYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA0MzAKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmNwcDoKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpjcmVhdGVWaWV3KToKKyAgICAgICAg TWlncmF0ZSB0byBuZXcgY3JlYXRlVmlldygpIEFQSS4KKyAgICAgICAgKiBEdW1wUmVuZGVyVHJl ZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oOgorICAgICAgICBSZW1vdmUgb2Jzb2xldGUgY3JlYXRl VmlldygpIG1ldGhvZHMsIGFkZCBuZXcgY3JlYXRlVmlldygpIEFQSSB0aGF0IHRha2VzIGEgZnJh bWVOYW1lIHBhcmFtZXRlci4KKwogMjAxMC0wNi0xMCAgT2phbiBWYWZhaSAgPG9qYW5AY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZpc2hlci4KZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcCBiL1dl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcAppbmRleCBk M2FhZGM4Li4xNTM3ZDAwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9j aHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv Y2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCkBAIC0yNTMsMTIgKzI1Myw3IEBAIHN0YXRpYyBzdHJp bmcgdGV4dEFmZmluaXR5RGVzY3JpcHRpb24oV2ViVGV4dEFmZmluaXR5IGFmZmluaXR5KQogCiAv LyBXZWJWaWV3Q2xpZW50IC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0KIAotV2ViVmlldyogV2ViVmlld0hvc3Q6OmNyZWF0ZVZpZXco V2ViRnJhbWUqIGNyZWF0b3IpCi17Ci0gICAgcmV0dXJuIGNyZWF0ZVZpZXcoY3JlYXRvciwgV2Vi V2luZG93RmVhdHVyZXMoKSk7Ci19Ci0KLVdlYlZpZXcqIFdlYlZpZXdIb3N0OjpjcmVhdGVWaWV3 KFdlYkZyYW1lKiwgY29uc3QgV2ViV2luZG93RmVhdHVyZXMmKQorV2ViVmlldyogV2ViVmlld0hv c3Q6OmNyZWF0ZVZpZXcoV2ViRnJhbWUqLCBjb25zdCBXZWJXaW5kb3dGZWF0dXJlcyYsIGNvbnN0 IFdlYlN0cmluZyYpCiB7CiAgICAgaWYgKCFsYXlvdXRUZXN0Q29udHJvbGxlcigpLT5jYW5PcGVu V2luZG93cygpKQogICAgICAgICByZXR1cm4gMDsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmggYi9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5oCmluZGV4IDhmYjlkMDQuLjFlNTFiZTcgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmgKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3Qu aApAQCAtOTAsOCArOTAsNyBAQCBjbGFzcyBXZWJWaWV3SG9zdCA6IHB1YmxpYyBXZWJLaXQ6Oldl YlZpZXdDbGllbnQsIHB1YmxpYyBXZWJLaXQ6OldlYkZyYW1lQ2xpZW50LAogICAgIHZpcnR1YWwg Ym9vbCBuYXZpZ2F0ZShjb25zdCBUZXN0TmF2aWdhdGlvbkVudHJ5JiwgYm9vbCByZWxvYWQpOwog CiAgICAgLy8gV2ViS2l0OjpXZWJWaWV3Q2xpZW50Ci0gICAgdmlydHVhbCBXZWJLaXQ6OldlYlZp ZXcqIGNyZWF0ZVZpZXcoV2ViS2l0OjpXZWJGcmFtZSopOwotICAgIHZpcnR1YWwgV2ViS2l0OjpX ZWJWaWV3KiBjcmVhdGVWaWV3KFdlYktpdDo6V2ViRnJhbWUqLCBjb25zdCBXZWJLaXQ6OldlYldp bmRvd0ZlYXR1cmVzJik7CisgICAgdmlydHVhbCBXZWJLaXQ6OldlYlZpZXcqIGNyZWF0ZVZpZXco V2ViS2l0OjpXZWJGcmFtZSosIGNvbnN0IFdlYktpdDo6V2ViV2luZG93RmVhdHVyZXMmLCBjb25z dCBXZWJLaXQ6OldlYlN0cmluZyYpOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJXaWRnZXQqIGNy ZWF0ZVBvcHVwTWVudShXZWJLaXQ6OldlYlBvcHVwVHlwZSk7CiAgICAgdmlydHVhbCBXZWJLaXQ6 OldlYldpZGdldCogY3JlYXRlUG9wdXBNZW51KGNvbnN0IFdlYktpdDo6V2ViUG9wdXBNZW51SW5m byYpOwogICAgIHZpcnR1YWwgV2ViS2l0OjpXZWJTdG9yYWdlTmFtZXNwYWNlKiBjcmVhdGVTZXNz aW9uU3RvcmFnZU5hbWVzcGFjZSh1bnNpZ25lZCBxdW90YSk7Cg== 59051 2010-06-17 17:12:58 -0700 2010-06-18 10:27:54 -0700 Patch that removes clearName() x text/plain 3699 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDYzMDE5N2UuLjFiODAyYzUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDEwLTA2LTE3ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21p dW1dIFBsdW1iaW5nIGZvciB0b3AtbGV2ZWwgZnJhbWUgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNDMwCisKKyAgICAgICAgKiBwdWJsaWMv V2ViRnJhbWUuaDoKKyAgICAgICAgUmVtb3ZlZCBvYnNvbGV0ZSBjbGVhck5hbWUoKSBBUEkgYW5k IGFkZGVkIGJldHRlciBkb2N1bWVudGF0aW9uIGZvcgorICAgICAgICBzZXROYW1lKCkuCisgICAg ICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIFJlbW92ZWQgY2xlYXJOYW1lKCkg QVBJLgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKyAgICAgICAgUmVtb3ZlZCBjbGVh ck5hbWUoKSBBUEkuCisKIDIwMTAtMDYtMTcgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBjaHJv bWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZDogY2hyb21pdW0gdGVzdHMgZml4LiBBZGRl ZCBJbnNwZWN0b3JCYWNrZW5kIGRlbGVnYXRlcyBmb3IgbmV3IGluc3BlY3RvciBtZXRob2RzLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCmluZGV4IDQwM2E5OTguLjMyZTkwMWIgMTAwNjQ0Ci0t LSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAorKysgYi9XZWJLaXQvY2hyb21p dW0vcHVibGljL1dlYkZyYW1lLmgKQEAgLTEwMiw3ICsxMDIsMTEgQEAgcHVibGljOgogCiAgICAg Ly8gVGhlIG5hbWUgb2YgdGhpcyBmcmFtZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBuYW1lKCkg Y29uc3QgPSAwOwotICAgIHZpcnR1YWwgdm9pZCBjbGVhck5hbWUoKSA9IDA7CisKKyAgICAvLyBT ZXRzIHRoZSBuYW1lIG9mIHRoaXMgZnJhbWUuIEZvciBjaGlsZCBmcmFtZXMgKGZyYW1lcyB0aGF0 IGFyZSBub3QgYQorICAgIC8vIHRvcC1tb3N0IGZyYW1lKSB0aGUgYWN0dWFsIG5hbWUgbWF5IGhh dmUgYSBzdWZmaXggYXBwZW5kZWQgdG8gbWFrZSB0aGUKKyAgICAvLyBmcmFtZSBuYW1lIHVuaXF1 ZSB3aXRoaW4gdGhlIGhpZXJhcmNoeSAoc2VlIEZyYW1lVHJlZTo6dW5pcXVlQ2hpbGROYW1lKCkK KyAgICAvLyBmb3IgbW9yZSBkZXRhaWxzKS4KICAgICB2aXJ0dWFsIHZvaWQgc2V0TmFtZShjb25z dCBXZWJTdHJpbmcmKSA9IDA7CiAKICAgICAvLyBUaGUgdXJsIG9mIHRoZSBkb2N1bWVudCBsb2Fk ZWQgaW4gdGhpcyBmcmFtZS4gIFRoaXMgaXMgZXF1aXZhbGVudCB0bwpkaWZmIC0tZ2l0IGEvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9X ZWJGcmFtZUltcGwuY3BwCmluZGV4IGViYTlmYWUuLjBhZmJjODAgMTAwNjQ0Ci0tLSBhL1dlYktp dC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkZyYW1lSW1wbC5jcHAKQEAgLTQ3MiwxMSArNDcyLDYgQEAgV2ViU3RyaW5nIFdlYkZyYW1l SW1wbDo6bmFtZSgpIGNvbnN0CiAgICAgcmV0dXJuIG1fZnJhbWUtPnRyZWUoKS0+bmFtZSgpOwog fQogCi12b2lkIFdlYkZyYW1lSW1wbDo6Y2xlYXJOYW1lKCkKLXsKLSAgICBtX2ZyYW1lLT50cmVl KCktPmNsZWFyTmFtZSgpOwotfQotCiB2b2lkIFdlYkZyYW1lSW1wbDo6c2V0TmFtZShjb25zdCBX ZWJTdHJpbmcmIG5hbWUpCiB7CiAgICAgbV9mcmFtZS0+dHJlZSgpLT5zZXROYW1lKG5hbWUpOwpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1dlYktpdC9j aHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgKaW5kZXggNWQ3ODU5OS4uZTY1NmIzNyAxMDA2NDQK LS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9XZWJLaXQvY2hy b21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCkBAIC02NCw3ICs2NCw2IEBAIGNsYXNzIFdlYkZyYW1l SW1wbCA6IHB1YmxpYyBXZWJGcmFtZSwgcHVibGljIFJlZkNvdW50ZWQ8V2ViRnJhbWVJbXBsPiB7 CiBwdWJsaWM6CiAgICAgLy8gV2ViRnJhbWUgbWV0aG9kczoKICAgICB2aXJ0dWFsIFdlYlN0cmlu ZyBuYW1lKCkgY29uc3Q7Ci0gICAgdmlydHVhbCB2b2lkIGNsZWFyTmFtZSgpOwogICAgIHZpcnR1 YWwgdm9pZCBzZXROYW1lKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIHZpcnR1YWwgV2ViVVJMIHVy bCgpIGNvbnN0OwogICAgIHZpcnR1YWwgV2ViVVJMIGZhdkljb25VUkwoKSBjb25zdDsKZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRl eCAwYTMxN2QyLi5iMTBiMTcyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTcgIERy ZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gUGx1bWJpbmcgZm9yIHRvcC1s ZXZlbCBmcmFtZSBuYW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA0MzAKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmNwcDoKKyAgICAgICAgKFdlYlZpZXdIb3N0OjpyZXNldCk6CisgICAgICAgIENoYW5n ZWQgb2Jzb2xldGUgY2FsbCB0byBjbGVhck5hbWUoKSB0byB1c2Ugc2V0TmFtZShXZWJTdHJpbmco KSkgaW5zdGVhZC4KKwogMjAxMC0wNi0xNyAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+ CiAKICAgICAgICAgT25lIG1vcmUgdHJ5IGF0IGZpeCBmb3IgQ2hyb21pdW0gYnVpbGQuCmRpZmYg LS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5j cHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAK aW5kZXggMTlmNDI0Yi4uMjliOGFkOSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcApAQCAtMTAzMSw3ICsxMDMxLDcgQEAgdm9p ZCBXZWJWaWV3SG9zdDo6cmVzZXQoKQogICAgIHRoaXMtPn5XZWJWaWV3SG9zdCgpOwogICAgIG5l dyAodGhpcykgV2ViVmlld0hvc3Qoc2hlbGwpOwogICAgIHNldFdlYldpZGdldCh3aWRnZXQpOwot ICAgIHdlYlZpZXcoKS0+bWFpbkZyYW1lKCktPmNsZWFyTmFtZSgpOworICAgIHdlYlZpZXcoKS0+ bWFpbkZyYW1lKCktPnNldE5hbWUoV2ViU3RyaW5nKCkpOwogfQogCiB2b2lkIFdlYlZpZXdIb3N0 OjpzZXRTZWxlY3RUcmFpbGluZ1doaXRlc3BhY2VFbmFibGVkKGJvb2wgZW5hYmxlZCkK 59131 2010-06-18 10:27:54 -0700 2010-06-18 13:34:28 -0700 Reuploaded patch so it can go through EWS again after DEPS roll. y text/plain 3616 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDdmODYwMTMuLjNkYTFiYjggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE4IEBACisyMDEwLTA2LTE3ICBEcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNocm9taXVtLm9yZz4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbQ2hyb21p dW1dIFBsdW1iaW5nIGZvciB0b3AtbGV2ZWwgZnJhbWUgbmFtZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNDMwCisKKyAgICAgICAgKiBwdWJsaWMv V2ViRnJhbWUuaDoKKyAgICAgICAgUmVtb3ZlZCBvYnNvbGV0ZSBjbGVhck5hbWUoKSBBUEkgYW5k IGFkZGVkIGJldHRlciBkb2N1bWVudGF0aW9uIGZvcgorICAgICAgICBzZXROYW1lKCkuCisgICAg ICAgICogc3JjL1dlYkZyYW1lSW1wbC5jcHA6CisgICAgICAgIFJlbW92ZWQgY2xlYXJOYW1lKCkg QVBJLgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuaDoKKyAgICAgICAgUmVtb3ZlZCBjbGVh ck5hbWUoKSBBUEkuCisKIDIwMTAtMDYtMTUgIER1bWl0cnUgRGFuaWxpdWMgIDxkdW1pQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oIGIvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJGcmFtZS5oCmluZGV4IDQwM2E5OTguLjMyZTkwMWIgMTAwNjQ0Ci0tLSBhL1dlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkZyYW1lLmgKQEAgLTEwMiw3ICsxMDIsMTEgQEAgcHVibGljOgogCiAgICAgLy8gVGhlIG5hbWUg b2YgdGhpcyBmcmFtZS4KICAgICB2aXJ0dWFsIFdlYlN0cmluZyBuYW1lKCkgY29uc3QgPSAwOwot ICAgIHZpcnR1YWwgdm9pZCBjbGVhck5hbWUoKSA9IDA7CisKKyAgICAvLyBTZXRzIHRoZSBuYW1l IG9mIHRoaXMgZnJhbWUuIEZvciBjaGlsZCBmcmFtZXMgKGZyYW1lcyB0aGF0IGFyZSBub3QgYQor ICAgIC8vIHRvcC1tb3N0IGZyYW1lKSB0aGUgYWN0dWFsIG5hbWUgbWF5IGhhdmUgYSBzdWZmaXgg YXBwZW5kZWQgdG8gbWFrZSB0aGUKKyAgICAvLyBmcmFtZSBuYW1lIHVuaXF1ZSB3aXRoaW4gdGhl IGhpZXJhcmNoeSAoc2VlIEZyYW1lVHJlZTo6dW5pcXVlQ2hpbGROYW1lKCkKKyAgICAvLyBmb3Ig bW9yZSBkZXRhaWxzKS4KICAgICB2aXJ0dWFsIHZvaWQgc2V0TmFtZShjb25zdCBXZWJTdHJpbmcm KSA9IDA7CiAKICAgICAvLyBUaGUgdXJsIG9mIHRoZSBkb2N1bWVudCBsb2FkZWQgaW4gdGhpcyBm cmFtZS4gIFRoaXMgaXMgZXF1aXZhbGVudCB0bwpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJGcmFtZUltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwu Y3BwCmluZGV4IGViYTlmYWUuLjBhZmJjODAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9z cmMvV2ViRnJhbWVJbXBsLmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAKQEAgLTQ3MiwxMSArNDcyLDYgQEAgV2ViU3RyaW5nIFdlYkZyYW1lSW1wbDo6bmFtZSgp IGNvbnN0CiAgICAgcmV0dXJuIG1fZnJhbWUtPnRyZWUoKS0+bmFtZSgpOwogfQogCi12b2lkIFdl YkZyYW1lSW1wbDo6Y2xlYXJOYW1lKCkKLXsKLSAgICBtX2ZyYW1lLT50cmVlKCktPmNsZWFyTmFt ZSgpOwotfQotCiB2b2lkIFdlYkZyYW1lSW1wbDo6c2V0TmFtZShjb25zdCBXZWJTdHJpbmcmIG5h bWUpCiB7CiAgICAgbV9mcmFtZS0+dHJlZSgpLT5zZXROYW1lKG5hbWUpOwpkaWZmIC0tZ2l0IGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaCBiL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViRnJhbWVJbXBsLmgKaW5kZXggNWQ3ODU5OS4uZTY1NmIzNyAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuaAorKysgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YkZyYW1lSW1wbC5oCkBAIC02NCw3ICs2NCw2IEBAIGNsYXNzIFdlYkZyYW1lSW1wbCA6IHB1Ymxp YyBXZWJGcmFtZSwgcHVibGljIFJlZkNvdW50ZWQ8V2ViRnJhbWVJbXBsPiB7CiBwdWJsaWM6CiAg ICAgLy8gV2ViRnJhbWUgbWV0aG9kczoKICAgICB2aXJ0dWFsIFdlYlN0cmluZyBuYW1lKCkgY29u c3Q7Ci0gICAgdmlydHVhbCB2b2lkIGNsZWFyTmFtZSgpOwogICAgIHZpcnR1YWwgdm9pZCBzZXRO YW1lKGNvbnN0IFdlYlN0cmluZyYpOwogICAgIHZpcnR1YWwgV2ViVVJMIHVybCgpIGNvbnN0Owog ICAgIHZpcnR1YWwgV2ViVVJMIGZhdkljb25VUkwoKSBjb25zdDsKZGlmZiAtLWdpdCBhL1dlYktp dFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAxYjk5MzZkLi4w ZjRjMzI3IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTcgIERyZXcgV2lsc29uICA8 YXR3aWxzb25AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gUGx1bWJpbmcgZm9yIHRvcC1sZXZlbCBmcmFtZSBu YW1lcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA0 MzAKKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0LmNwcDoK KyAgICAgICAgKFdlYlZpZXdIb3N0OjpyZXNldCk6CisgICAgICAgIENoYW5nZWQgb2Jzb2xldGUg Y2FsbCB0byBjbGVhck5hbWUoKSB0byB1c2Ugc2V0TmFtZShXZWJTdHJpbmcoKSkgaW5zdGVhZC4K KwogMjAxMC0wNi0xNyAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbnQgVGFtdXJhLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vV2ViVmlld0hvc3QuY3BwCmluZGV4IDE5ZjQyNGIuLjI5YjhhZDkgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZpZXdIb3N0 LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9z dC5jcHAKQEAgLTEwMzEsNyArMTAzMSw3IEBAIHZvaWQgV2ViVmlld0hvc3Q6OnJlc2V0KCkKICAg ICB0aGlzLT5+V2ViVmlld0hvc3QoKTsKICAgICBuZXcgKHRoaXMpIFdlYlZpZXdIb3N0KHNoZWxs KTsKICAgICBzZXRXZWJXaWRnZXQod2lkZ2V0KTsKLSAgICB3ZWJWaWV3KCktPm1haW5GcmFtZSgp LT5jbGVhck5hbWUoKTsKKyAgICB3ZWJWaWV3KCktPm1haW5GcmFtZSgpLT5zZXROYW1lKFdlYlN0 cmluZygpKTsKIH0KIAogdm9pZCBXZWJWaWV3SG9zdDo6c2V0U2VsZWN0VHJhaWxpbmdXaGl0ZXNw YWNlRW5hYmxlZChib29sIGVuYWJsZWQpCg==