40427 2010-06-10 10:12:15 -0700 [Qt] There should be a way to enable popups in QtTestBrowser 2010-06-11 01:41:27 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 yael webkit-unassigned commit-queue oldest_to_newest 236407 0 yael 2010-06-10 10:12:15 -0700 Some layout tests open a second window during the test. Currently, there is no way to run those tests, since QtTestBrowser blocks all popups. 236410 1 58380 yael 2010-06-10 10:17:06 -0700 Created attachment 58380 Patch 236493 2 58380 laszlo.gombos 2010-06-10 12:48:51 -0700 Comment on attachment 58380 Patch looks good, r+. 236729 3 58380 commit-queue 2010-06-11 01:41:19 -0700 Comment on attachment 58380 Patch Clearing flags on attachment: 58380 Committed r60997: <http://trac.webkit.org/changeset/60997> 236730 4 commit-queue 2010-06-11 01:41:27 -0700 All reviewed patches have been landed. Closing bug. 58380 2010-06-10 10:17:06 -0700 2010-06-11 01:41:19 -0700 Patch 40427.patch text/plain 2277 yael SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwOTYyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMTAgIFlhZWwgQWhhcm9uICA8eWFl bC5haGFyb25Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIFtRdF0gVGhlcmUgc2hvdWxkIGJlIGEgd2F5IHRvIGVuYWJsZSBwb3B1cHMg aW4gUXRUZXN0QnJvd3NlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDA0MjcKKworICAgICAgICAqIFF0VGVzdEJyb3dzZXIvbWFpbi5jcHA6CisgICAg ICAgIChMYXVuY2hlcldpbmRvdzo6dG9nZ2xlSmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzKToKKyAg ICAgICAgKExhdW5jaGVyV2luZG93OjpjcmVhdGVDaHJvbWUpOgorCiAyMDEwLTA2LTEwICBEaWVn byBHb256YWxleiAgPGRpZWdvaGNnQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg S2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJLaXRUb29scy9RdFRlc3RCcm93 c2VyL21haW4uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1F0VGVzdEJyb3dzZXIvbWFp bi5jcHAJKHJldmlzaW9uIDYwOTU3KQorKysgV2ViS2l0VG9vbHMvUXRUZXN0QnJvd3Nlci9tYWlu LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTY2LDYgKzE2Niw3IEBAIHByb3RlY3RlZCBzbG90czoK ICAgICB2b2lkIGNoYW5nZVZpZXdwb3J0VXBkYXRlTW9kZShpbnQgbW9kZSk7CiAgICAgdm9pZCB0 b2dnbGVGcmFtZUZsYXR0ZW5pbmcoYm9vbCB0b2dnbGUpOwogICAgIHZvaWQgdG9nZ2xlSW50ZXJy dXB0aW5nSmF2YVNjcmlwdEVuYWJsZWQoYm9vbCBlbmFibGUpOworICAgIHZvaWQgdG9nZ2xlSmF2 YXNjcmlwdENhbk9wZW5XaW5kb3dzKGJvb2wgZW5hYmxlKTsKIAogI2lmIGRlZmluZWQoUVRfQ09O RklHVVJFRF9XSVRIX09QRU5HTCkKICAgICB2b2lkIHRvZ2dsZVFHTFdpZGdldFZpZXdwb3J0KGJv b2wgZW5hYmxlKTsKQEAgLTczMSw2ICs3MzIsMTEgQEAgdm9pZCBMYXVuY2hlcldpbmRvdzo6dG9n Z2xlSW50ZXJydXB0aW5nSgogICAgIHBhZ2UoKS0+c2V0SW50ZXJydXB0aW5nSmF2YVNjcmlwdEVu YWJsZWQoZW5hYmxlKTsKIH0KIAordm9pZCBMYXVuY2hlcldpbmRvdzo6dG9nZ2xlSmF2YXNjcmlw dENhbk9wZW5XaW5kb3dzKGJvb2wgZW5hYmxlKQoreworICAgIHBhZ2UoKS0+c2V0dGluZ3MoKS0+ c2V0QXR0cmlidXRlKFFXZWJTZXR0aW5nczo6SmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzLCBlbmFi bGUpOworfQorCiAjaWYgZGVmaW5lZChRVF9DT05GSUdVUkVEX1dJVEhfT1BFTkdMKQogdm9pZCBM YXVuY2hlcldpbmRvdzo6dG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQoYm9vbCBlbmFibGUpCiB7CkBA IC05MzAsNiArOTM2LDEwIEBAIHZvaWQgTGF1bmNoZXJXaW5kb3c6OmNyZWF0ZUNocm9tZSgpCiAg ICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkLT5zZXRDaGVja2FibGUodHJ1 ZSk7CiAgICAgdG9nZ2xlSW50ZXJydXB0aW5nSmF2YVNjcmlwdGVFbmFibGVkLT5zZXRDaGVja2Vk KGZhbHNlKTsKIAorICAgIFFBY3Rpb24qIHRvZ2dsZUphdmFzY3JpcHRDYW5PcGVuV2luZG93cyA9 IHRvb2xzTWVudS0+YWRkQWN0aW9uKCJFbmFibGUganMgcG9wdXAgd2luZG93cyIsIHRoaXMsIFNM T1QodG9nZ2xlSmF2YXNjcmlwdENhbk9wZW5XaW5kb3dzKGJvb2wpKSk7CisgICAgdG9nZ2xlSmF2 YXNjcmlwdENhbk9wZW5XaW5kb3dzLT5zZXRDaGVja2FibGUodHJ1ZSk7CisgICAgdG9nZ2xlSmF2 YXNjcmlwdENhbk9wZW5XaW5kb3dzLT5zZXRDaGVja2VkKGZhbHNlKTsKKwogI2lmIGRlZmluZWQo UVRfQ09ORklHVVJFRF9XSVRIX09QRU5HTCkKICAgICBRQWN0aW9uKiB0b2dnbGVRR0xXaWRnZXRW aWV3cG9ydCA9IGdyYXBoaWNzVmlld01lbnUtPmFkZEFjdGlvbigiVG9nZ2xlIHVzZSBvZiBRR0xX aWRnZXQgVmlld3BvcnQiLCB0aGlzLCBTTE9UKHRvZ2dsZVFHTFdpZGdldFZpZXdwb3J0KGJvb2wp KSk7CiAgICAgdG9nZ2xlUUdMV2lkZ2V0Vmlld3BvcnQtPnNldENoZWNrYWJsZSh0cnVlKTsK