40423 2010-06-10 06:30:19 -0700 Fix invalid access to non-static data member warning in JITPropertyAccess32_64 on ARM 2010-06-15 02:14:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Other All RESOLVED FIXED P3 Normal --- 1 loki webkit-unassigned eric oliver oldest_to_newest 236331 0 loki 2010-06-10 06:30:19 -0700 The offsetof(struct JITStackFrame, args[2]) expression cause an invalid access to non-static data member 'JSC::JITStackFrame::args' of NULL object warning. Using OBJECT_OFFSETOF macro instead of objectof one will fix this issue. 236334 1 58372 loki 2010-06-10 06:32:40 -0700 Created attachment 58372 Fix invalid access to non-static data member warning in JITPropertyAccess32_64 237401 2 58372 eric 2010-06-12 18:52:04 -0700 Comment on attachment 58372 Fix invalid access to non-static data member warning in JITPropertyAccess32_64 rs=me. 237402 3 eric 2010-06-12 18:52:19 -0700 Is this testable? 238306 4 loki 2010-06-15 02:07:54 -0700 What do you mean? With a layout test? It is already tested in jscore tests. Just turn on WTF_USE_JSVALUE32_64 if it is not enabled by default (like on ARM). 238307 5 loki 2010-06-15 02:14:43 -0700 Committed revision 61180. 58372 2010-06-10 06:32:40 -0700 2010-06-12 18:52:04 -0700 Fix invalid access to non-static data member warning in JITPropertyAccess32_64 0001-Fix-invalid-access-to-non-static-data-member-warning.patch text/plain 2272 loki RnJvbSA5ODBiM2JlMjQ3MDczN2ZiMGJkZjcwNDcyMTU1ZGYzODY5YzIzMTRjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHYWJvciBMb2tpIDxsb2tpQGluZi51LXN6ZWdlZC5odT4KRGF0 ZTogVGh1LCAxMCBKdW4gMjAxMCAxNTozMToxNCArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEZpeCBp bnZhbGlkIGFjY2VzcyB0byBub24tc3RhdGljIGRhdGEgbWVtYmVyIHdhcm5pbmcgaW4gSklUUHJv cGVydHlBY2Nlc3MzMl82NCBvbiBBUk0KClNpZ25lZC1vZmYtYnk6IEdhYm9yIExva2kgPGxva2lA aW5mLnUtc3plZ2VkLmh1PgotLS0KIEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvaml0L0pJVFBy b3BlcnR5QWNjZXNzMzJfNjQuY3BwIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE1IGlu c2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUv Q2hhbmdlTG9nIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDdmZTllNTkuLmM5MTY0 NDkgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZworKysgYi9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNi0xMCAgR2Fib3IgTG9raSAg PGxva2lAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXggaW52YWxpZCBhY2Nlc3MgdG8gbm9uLXN0YXRpYyBkYXRhIG1lbWJlciB3 YXJuaW5nIGluIEpJVFByb3BlcnR5QWNjZXNzMzJfNjQgb24gQVJNCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQyMworCisgICAgICAgIFVzaW5nIE9C SkVDVF9PRkZTRVRPRiBtYWNybyBpbnN0ZWFkIG9mIG9iamVjdG9mIHRvIGJ5cGFzcyBhY2Nlc3Mg dG8KKyAgICAgICAgbm9uLXN0YXRpYyBkYXRhIG1lbWJlciB3YXJuaW5nLgorCisgICAgICAgICog aml0L0pJVFByb3BlcnR5QWNjZXNzMzJfNjQuY3BwOgorICAgICAgICAoSlNDOjpKSVQ6OnByaXZh dGVDb21waWxlUHV0QnlJZFRyYW5zaXRpb24pOgorCiAyMDEwLTA2LTEwICBLd2FuZyBZdWwgU2Vv ICA8c2t5dWxAY29tcGFueTEwMC5uZXQ+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82 NC5jcHAgYi9KYXZhU2NyaXB0Q29yZS9qaXQvSklUUHJvcGVydHlBY2Nlc3MzMl82NC5jcHAKaW5k ZXggNmI4YWY3Yy4uZTAzZWVjYSAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVFBy b3BlcnR5QWNjZXNzMzJfNjQuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRQcm9wZXJ0 eUFjY2VzczMyXzY0LmNwcApAQCAtNjI4LDggKzYyOCw4IEBAIHZvaWQgSklUOjpwcml2YXRlQ29t cGlsZVB1dEJ5SWRUcmFuc2l0aW9uKFN0cnVjdHVyZVN0dWJJbmZvKiBzdHViSW5mbywgU3RydWN0 dXJlCiAgICAgYWRkMzIoSW1tMzIoMSksIEFic29sdXRlQWRkcmVzcyhuZXdTdHJ1Y3R1cmUtPmFk ZHJlc3NPZkNvdW50KCkpKTsKICAgICBzdG9yZVB0cihJbW1QdHIobmV3U3RydWN0dXJlKSwgQWRk cmVzcyhyZWdUMCwgT0JKRUNUX09GRlNFVE9GKEpTQ2VsbCwgbV9zdHJ1Y3R1cmUpKSk7CiAgICAg Ci0gICAgbG9hZDMyKEFkZHJlc3Moc3RhY2tQb2ludGVyUmVnaXN0ZXIsIG9mZnNldG9mKHN0cnVj dCBKSVRTdGFja0ZyYW1lLCBhcmdzWzJdKSArIHNpemVvZih2b2lkKikpLCByZWdUMyk7Ci0gICAg bG9hZDMyKEFkZHJlc3Moc3RhY2tQb2ludGVyUmVnaXN0ZXIsIG9mZnNldG9mKHN0cnVjdCBKSVRT dGFja0ZyYW1lLCBhcmdzWzJdKSArIHNpemVvZih2b2lkKikgKyA0KSwgcmVnVDIpOworICAgIGxv YWQzMihBZGRyZXNzKHN0YWNrUG9pbnRlclJlZ2lzdGVyLCBPQkpFQ1RfT0ZGU0VUT0YoSklUU3Rh Y2tGcmFtZSwgYXJnc1syXSkgKyBzaXplb2Yodm9pZCopKSwgcmVnVDMpOworICAgIGxvYWQzMihB ZGRyZXNzKHN0YWNrUG9pbnRlclJlZ2lzdGVyLCBPQkpFQ1RfT0ZGU0VUT0YoSklUU3RhY2tGcmFt ZSwgYXJnc1syXSkgKyBzaXplb2Yodm9pZCopICsgNCksIHJlZ1QyKTsKICAgICAKICAgICAvLyBX cml0ZSB0aGUgdmFsdWUKICAgICBjb21waWxlUHV0RGlyZWN0T2Zmc2V0KHJlZ1QwLCByZWdUMiwg cmVnVDMsIG5ld1N0cnVjdHVyZSwgY2FjaGVkT2Zmc2V0KTsKLS0gCjEuNS40LjMKCg==