40416 2010-06-10 03:34:12 -0700 HTML5 Parser should continue parsing after script execution 2010-06-10 11:18:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 eric eric abarth tonyg oldest_to_newest 236285 0 eric 2010-06-10 03:34:12 -0700 HTML5 Parser should continue parsing after script execution 236287 1 58356 eric 2010-06-10 03:38:35 -0700 Created attachment 58356 Patch 236412 2 58356 abarth 2010-06-10 10:20:44 -0700 Comment on attachment 58356 Patch Nice, but can you add your reduced test case? That's a lot easier to understand than the crazy JavaScript test that this actually fixes. 236431 3 abarth 2010-06-10 10:44:46 -0700 Here's the reduction eric sent me in email: <pre id="log"></pre> <script> function log(string) { document.getElementById("log").innerHTML += string + "\n"; } log("1"); document.write("<script>log('2')<"+"/script>"); document.write("<script>log('3')<"+"/script>"); log("4"); </script> I've converted it to a layout test locally. I just need to build and test it and I can land this for him. 236457 4 abarth 2010-06-10 11:18:06 -0700 Committed r60966: <http://trac.webkit.org/changeset/60966> 58356 2010-06-10 03:38:35 -0700 2010-06-10 10:20:44 -0700 Patch bug-40416-20100610033833.patch text/plain 4863 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGNkYzczZWI1YjFiNmI4OTdkNTExZWU3MzJlZWViNmUwNGQ5NDI5ZS4uNmRiNzVlYTc0MjY1ZWZh NDMzZTgyYzZmMDFhMGViNGQzNzQxMjVlOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwzOCBAQAogMjAxMC0wNi0xMCAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSFRNTDUgUGFyc2VyIHNob3VsZCBjb250aW51ZSBwYXJzaW5n IGFmdGVyIHNjcmlwdCBleGVjdXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQwNDE2CisKKyAgICAgICAgVGhlIHByZXZpb3VzIGNvZGUgd2FzIGp1 c3Qgd3JvbmcuICBXZSB3ZXJlIGFsd2F5cyBibG9ja2luZworICAgICAgICB0aGUgcGFyc2VyIGFm dGVyIGFueSBzY3JpcHQgZXhlY3V0aW9uLiAgTm93IHdlIGNvcnJlY3RseSBjb250aW51ZQorICAg ICAgICBwYXJzaW5nIGFmdGVyIGEgc3VjY2Vzc2Z1bCBzY3JpcHQgZXhlY3V0aW9uIGFuZCBvbmx5 IGJsb2NrIHRoZQorICAgICAgICBwYXJzZXIgd2hlbiB3ZSB3ZXJlbid0IGFibGUgdG8gZXhlY3V0 ZSB0aGUgc2NyaXB0IGltbWVkaWF0ZWx5LgorCisgICAgICAgIEFkZGVkIGEgbmV3IGhhdmVQYXJz aW5nQmxvY2tpbmdTY3JpcHQoKSBmdW5jdGlvbiB0byBIVE1MNVNjcmlwdFJ1bm5lcgorICAgICAg ICB0byBtYWtlIHNvbWUgb2YgdGhlIGNvZGUgbW9yZSBzZWxmLWRvY3VtZW50aW5nLgorCisgICAg ICAgIENvdmVyZWQgYnkgZmFzdC9qcy9pbXBsaWNpdC1jYWxsLXdpdGgtZ2xvYmFsLXJlZW50cnku aHRtbC4KKworICAgICAgICAqIGh0bWwvSFRNTDVTY3JpcHRSdW5uZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6SFRNTDVTY3JpcHRSdW5uZXI6OmV4ZWN1dGUpOgorICAgICAgICAgLSBSZW1vdmUg c29tZSBvbGQgKG5vdyBib2d1cykgRklYTUVzIGFuZCBub3RJbXBsZW1lbnRlZCgpIGNhbGxzLgor ICAgICAgICAgLSBGaXggdGhlIGxvZ2ljIHRvIG1hdGNoIHRoZSBIVE1MNSBzcGVjIGJ5IGNvbnRp bnVpbmcgcGFyc2luZworICAgICAgICAgICBhZnRlciBzY3JpcHQgZXhlY3V0aW9uIGFuZCBvbmx5 IGJsb2NraW5nIHRoZSBwYXJzZXIgd2hlbiB0aGUKKyAgICAgICAgICAgc2NyaXB0IHdhc24ndCBh YmxlIHRvIGltbWVkaWF0ZWx5IHJ1bi4KKyAgICAgICAgKFdlYkNvcmU6OkhUTUw1U2NyaXB0UnVu bmVyOjpoYXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KToKKyAgICAgICAgIC0gTmV3IGZ1bmN0aW9u IHRvIG1ha2Ugc29tZSBvZiB0aGUgY29kZSByZWFkIGJldHRlci4KKyAgICAgICAgKFdlYkNvcmU6 OkhUTUw1U2NyaXB0UnVubmVyOjpleGVjdXRlUGFyc2luZ0Jsb2NraW5nU2NyaXB0cyk6CisgICAg ICAgICAtIFVzZSBoYXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KCkuCisgICAgICAgIChXZWJDb3Jl OjpIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhlY3V0ZVNjcmlwdHNXYWl0aW5nRm9yTG9hZCk6CisgICAg ICAgICAtIFVzZSBoYXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KCkuCisgICAgICAgIChXZWJDb3Jl OjpIVE1MNVNjcmlwdFJ1bm5lcjo6cnVuU2NyaXB0KToKKyAgICAgICAgIC0gVXNlIGhhdmVQYXJz aW5nQmxvY2tpbmdTY3JpcHQoKS4KKyAgICAgICAgKiBodG1sL0hUTUw1U2NyaXB0UnVubmVyLmg6 CisKKzIwMTAtMDYtMTAgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCiAgICAgICAg IFJldmlld2VkIGJ5IEFkYW0gQmFydGguCiAKICAgICAgICAgUmVkdWNlIEZyYW1lVmlldy5oIGlu Y2x1ZGVzIHRvIHNwZWVkIHVwIGJ1aWxkIHRpbWVzCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwv SFRNTDVTY3JpcHRSdW5uZXIuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUw1U2NyaXB0UnVubmVyLmNw cAppbmRleCA0ZTRhOTI1ZDRiZjhjNmVlOTVmZDRlZGEwZDNlZDM5NmM5NDY0MDRiLi5hZWY1Y2U0 NTFkNDZkOWViNTdmOWE0MGZkZDNhYzVhZWNlZTNhZWVmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0 bWwvSFRNTDVTY3JpcHRSdW5uZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1 bm5lci5jcHAKQEAgLTE2NCwxOSArMTY0LDI0IEBAIGJvb2wgSFRNTDVTY3JpcHRSdW5uZXI6OmV4 ZWN1dGUoUGFzc1JlZlB0cjxFbGVtZW50PiBzY3JpcHRFbGVtZW50LCBpbnQgc3RhcnRMaW5lCiAK ICAgICAvLyBUcnkgdG8gZXhlY3V0ZSB0aGUgc2NyaXB0IGdpdmVuIHRvIHVzLgogICAgIHJ1blNj cmlwdChzY3JpcHRFbGVtZW50LmdldCgpLCBzdGFydExpbmUpOwotICAgIGlmIChtX3NjcmlwdE5l c3RpbmdMZXZlbCkKLSAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBEb24ndCBjb250aW51ZSBwYXJz aW5nLgotICAgIGlmICghZXhlY3V0ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdHMoKSkKLSAgICAgICAg cmV0dXJuIGZhbHNlOwogCi0gICAgbm90SW1wbGVtZW50ZWQoKTsgLy8gUmVzdG9yZSBpbnNlcnRp b24gcG9pbnQ/Ci0gICAgLy8gRklYTUU6IEhhbmRsZSByZS1lbnRyYW50IHNjcmlwdHMgYW5kIG1f cGVuZGluZ1BhcnNpbmdCbG9ja2luU2NyaXB0LgotICAgIHJldHVybiB0cnVlOworICAgIGlmICho YXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KCkpIHsKKyAgICAgICAgaWYgKG1fc2NyaXB0TmVzdGlu Z0xldmVsKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBCbG9jayB0aGUgcGFyc2VyLiAg VW53aW5kIHRvIHRoZSBvdXRlcm1vc3QgSFRNTDVTY3JpcHRSdW5uZXI6OmV4ZWN1dGUgYmVmb3Jl IGNvbnRpbnVpbmcgcGFyc2luZy4KKyAgICAgICAgaWYgKCFleGVjdXRlUGFyc2luZ0Jsb2NraW5n U2NyaXB0cygpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOyAvLyBXZSBzdGlsbCBoYXZlIGEg cGFyc2luZyBibG9ja2luZyBzY3JpcHQsIGJsb2NrIHRoZSBwYXJzZXIuCisgICAgfQorICAgIHJl dHVybiB0cnVlOyAvLyBTY3JpcHRzIGV4ZWN1dGVkIGFzIGV4cGVjdGVkLCBjb250aW51ZSBwYXJz aW5nLgorfQorCitib29sIEhUTUw1U2NyaXB0UnVubmVyOjpoYXZlUGFyc2luZ0Jsb2NraW5nU2Ny aXB0KCkgY29uc3QKK3sKKyAgICByZXR1cm4gISFtX3BhcnNpbmdCbG9ja2luZ1NjcmlwdC5lbGVt ZW50OwogfQogCiBib29sIEhUTUw1U2NyaXB0UnVubmVyOjpleGVjdXRlUGFyc2luZ0Jsb2NraW5n U2NyaXB0cygpCiB7Ci0gICAgd2hpbGUgKG1fcGFyc2luZ0Jsb2NraW5nU2NyaXB0LmVsZW1lbnQp IHsKKyAgICB3aGlsZSAoaGF2ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdCgpKSB7CiAgICAgICAgIC8v IFdlIG9ubHkgcmVhbGx5IG5lZWQgdG8gY2hlY2sgb25jZS4KICAgICAgICAgaWYgKCFpc1BlbmRp bmdTY3JpcHRSZWFkeShtX3BhcnNpbmdCbG9ja2luZ1NjcmlwdCkpCiAgICAgICAgICAgICByZXR1 cm4gZmFsc2U7CkBAIC0xODgsNyArMTkzLDcgQEAgYm9vbCBIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhl Y3V0ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdHMoKQogYm9vbCBIVE1MNVNjcmlwdFJ1bm5lcjo6ZXhl Y3V0ZVNjcmlwdHNXYWl0aW5nRm9yTG9hZChDYWNoZWRSZXNvdXJjZSopCiB7CiAgICAgQVNTRVJU KCFtX3NjcmlwdE5lc3RpbmdMZXZlbCk7Ci0gICAgQVNTRVJUKG1fcGFyc2luZ0Jsb2NraW5nU2Ny aXB0LmVsZW1lbnQpOworICAgIEFTU0VSVChoYXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KCkpOwog ICAgIEFTU0VSVChtX3BhcnNpbmdCbG9ja2luZ1NjcmlwdC5jYWNoZWRTY3JpcHQtPmlzTG9hZGVk KCkpOwogICAgIHJldHVybiBleGVjdXRlUGFyc2luZ0Jsb2NraW5nU2NyaXB0cygpOwogfQpAQCAt MjM0LDcgKzIzOSw3IEBAIHZvaWQgSFRNTDVTY3JpcHRSdW5uZXI6OnJlcXVlc3RTY3JpcHQoRWxl bWVudCogc2NyaXB0KQogLy8gaHR0cDovL3d3dy53aGF0d2cub3JnL3NwZWNzL3dlYi1hcHBzL2N1 cnJlbnQtd29yay9tdWx0aXBhZ2Uvc2NyaXB0aW5nLTEuaHRtbCNydW5uaW5nLWEtc2NyaXB0CiB2 b2lkIEhUTUw1U2NyaXB0UnVubmVyOjpydW5TY3JpcHQoRWxlbWVudCogc2NyaXB0LCBpbnQgc3Rh cnRpbmdMaW5lTnVtYmVyKQogewotICAgIEFTU0VSVCghbV9wYXJzaW5nQmxvY2tpbmdTY3JpcHQu ZWxlbWVudCk7CisgICAgQVNTRVJUKCFoYXZlUGFyc2luZ0Jsb2NraW5nU2NyaXB0KCkpOwogICAg IG1fc2NyaXB0TmVzdGluZ0xldmVsKys7CiAgICAgLy8gQ2hlY2sgc2NyaXB0IHR5cGUgYW5kIGxh bmd1YWdlLCBjdXJyZW50IGNvZGUgdXNlcyBTY3JpcHRFbGVtZW50OjpzaG91bGRFeGVjdXRlQXNK YXZhU2NyaXB0KCksIGJ1dCB0aGF0IG1heSBub3QgYmUgSFRNTDUgY29tcGxpYW50LgogICAgIG5v dEltcGxlbWVudGVkKCk7IC8vIGV2ZW50IGZvciBzdXBwb3J0CmRpZmYgLS1naXQgYS9XZWJDb3Jl L2h0bWwvSFRNTDVTY3JpcHRSdW5uZXIuaCBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1bm5l ci5oCmluZGV4IDhiNWVmZDMyZjYxMjhmYjgzYWFkMDIxNDJmNWY5M2ZmMzg3ZDQwNDMuLjE5ZTcw YTZhNjQyNTFkMDM4NGNkOWU5ZjIwNmM0MzAwMmI1NzhmN2QgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv aHRtbC9IVE1MNVNjcmlwdFJ1bm5lci5oCisrKyBiL1dlYkNvcmUvaHRtbC9IVE1MNVNjcmlwdFJ1 bm5lci5oCkBAIC03Myw2ICs3Myw3IEBAIHByaXZhdGU6CiAKICAgICBGcmFtZSogZnJhbWUoKSBj b25zdDsKIAorICAgIGJvb2wgaGF2ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdCgpIGNvbnN0OwogICAg IGJvb2wgZXhlY3V0ZVBhcnNpbmdCbG9ja2luZ1NjcmlwdHMoKTsKICAgICB2b2lkIGV4ZWN1dGVQ ZW5kaW5nU2NyaXB0KCk7CiAK