40409 2010-06-10 01:54:16 -0700 Web Inspector: [REGRESSION] Tab complete in a command line jumps on next value 2010-06-11 01:12:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://screenr.com/9gK P2 Normal --- 0 me webkit-unassigned bweinstein commit-queue joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 236243 0 me 2010-06-10 01:54:16 -0700 How to reproduce the bug: 1. Type "document.get" in the command line. You should see document.get<CSSCanvasContext> (<> is an auto-suggestion) 2. Press Tab Expected: "document.get[CSSCanvasContext]" ([] is a selected text) Actual: "document.get[ElementById]" Screencast: http://screenr.com/9gK 236248 1 pfeldman 2010-06-10 02:09:15 -0700 https://bugs.webkit.org/show_bug.cgi?id=38753 is a primary suspect. 236263 2 58347 me 2010-06-10 02:47:23 -0700 Created attachment 58347 Then complete using a tab key, select very first value, not a second. 236266 3 58347 pfeldman 2010-06-10 02:51:21 -0700 Comment on attachment 58347 Then complete using a tab key, select very first value, not a second. Thanks for fixing this. I small nit about the changelog entry and you are good to land! WebCore/ChangeLog:5 + Web Inspector: Then complete using a tab key, select very first value, not a second. When completing using ... Please re-attach new path and I'll mark it as r+,cq+! 236267 4 58350 me 2010-06-10 02:58:52 -0700 Created attachment 58350 When completing using a tab key, select very first value, not a second. My terrible grammar fixed. 236336 5 loislo 2010-06-10 06:40:11 -0700 It was a conscious decision as far as we have auto-suggestion mechanic. If the first suggestion is not suitable for you it is possible to get the next by tab. In the other case you can complete suggested variant by arrow. Your scenario is fine if we have no auto-suggestions mechanics. 236357 6 me 2010-06-10 07:21:23 -0700 (In reply to comment #5) It makes sense, but: 1) Tab is easier to press than right arrow. I do it with my left little finger without leaving the pointer finger from F key. 2) I've never seen applications which behaves like this. Xcode have a similar gray auto-suggestion, but by pressing Tab you're completing a current suggestion, not the next one. 236471 7 58350 commit-queue 2010-06-10 11:45:58 -0700 Comment on attachment 58350 When completing using a tab key, select very first value, not a second. Rejecting patch 58350 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--ignore-tests', 'compositing', '--quiet']" exit_code: 1 Last 500 characters of output: ing Java tests make: Nothing to be done for `default'. Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Skipped list contained 'compositing/iframes/composited-iframe.html', but no file of that name could be found Testing 19073 test cases. svg/dom/SVGScriptElement/script-set-href.svg -> failed Exiting early after 1 failures. 16747 tests run. 362.26s total testing time 16746 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 15 test cases (<1%) had stderr output Full output: http://webkit-commit-queue.appspot.com/results/3217143 236714 8 joepeck 2010-06-11 00:12:12 -0700 That commit queue failure was unrelated. If no-body gets to this tomorrow I can try to land it manually (my tree is outdated on this machine, so I'll be updating and building overnight). Feel free to beat me to it! Otherwise, does re-flipping the cq+ flag make the commit queue try again? I'll try that. 236724 9 58350 commit-queue 2010-06-11 01:12:40 -0700 Comment on attachment 58350 When completing using a tab key, select very first value, not a second. Clearing flags on attachment: 58350 Committed r60995: <http://trac.webkit.org/changeset/60995> 236725 10 commit-queue 2010-06-11 01:12:47 -0700 All reviewed patches have been landed. Closing bug. 58347 2010-06-10 02:47:23 -0700 2010-06-10 02:58:52 -0700 Then complete using a tab key, select very first value, not a second. tab_complete.patch text/plain 1166 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGNkYzczZS4uNWZhMjUzZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xMCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGhlbiBjb21wbGV0ZSB1c2luZyBhIHRhYiBrZXks IHNlbGVjdCB2ZXJ5IGZpcnN0IHZhbHVlLCBub3QgYSBzZWNvbmQuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQwOQorCisgICAgICAgICogaW5zcGVj dG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRQ cm9tcHQucHJvdG90eXBlLl9jb21wbGV0aW9uc1JlYWR5KToKKwogMjAxMC0wNi0xMCAgRXJpYyBT ZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UZXh0UHJvbXB0Lmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMKaW5kZXggMmJiZTA3 NS4uYjZiY2Q1MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQ cm9tcHQuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanMK QEAgLTI0Miw3ICsyNDIsNyBAQCBXZWJJbnNwZWN0b3IuVGV4dFByb21wdC5wcm90b3R5cGUgPSB7 CiAgICAgICAgICAgICAgICAgd29yZFByZWZpeExlbmd0aCA9IGNvbW1vblByZWZpeC5sZW5ndGg7 CiAKICAgICAgICAgICAgICAgICBpZiAoc2VsZWN0aW9uLmlzQ29sbGFwc2VkKQotICAgICAgICAg ICAgICAgICAgICB2YXIgY29tcGxldGlvblRleHQgPSBjb21wbGV0aW9uc1sxXTsKKyAgICAgICAg ICAgICAgICAgICAgdmFyIGNvbXBsZXRpb25UZXh0ID0gY29tcGxldGlvbnNbMF07CiAgICAgICAg ICAgICAgICAgZWxzZSB7CiAgICAgICAgICAgICAgICAgICAgIHZhciBjdXJyZW50VGV4dCA9IGZ1 bGxXb3JkUmFuZ2UudG9TdHJpbmcoKTsKIAo= 58350 2010-06-10 02:58:52 -0700 2010-06-11 01:12:40 -0700 When completing using a tab key, select very first value, not a second. tab_complete.patch text/plain 1168 me ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NGNkYzczZS4uY2RkZDEzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0xMCAgTmlraXRhIFZhc2ls eWV2ICA8bWVAZWx2MXMucnU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV2hlbiBjb21wbGV0aW5nIHVzaW5nIGEgdGFiIGtl eSwgc2VsZWN0IHZlcnkgZmlyc3QgdmFsdWUsIG5vdCBhIHNlY29uZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwNDA5CisKKyAgICAgICAgKiBpbnNw ZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGV4 dFByb21wdC5wcm90b3R5cGUuX2NvbXBsZXRpb25zUmVhZHkpOgorCiAyMDEwLTA2LTEwICBFcmlj IFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJh cnRoLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RleHRQcm9tcHQu anMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5qcwppbmRleCAyYmJl MDc1Li5iNmJjZDUyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4 dFByb21wdC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGV4dFByb21wdC5q cwpAQCAtMjQyLDcgKzI0Miw3IEBAIFdlYkluc3BlY3Rvci5UZXh0UHJvbXB0LnByb3RvdHlwZSA9 IHsKICAgICAgICAgICAgICAgICB3b3JkUHJlZml4TGVuZ3RoID0gY29tbW9uUHJlZml4Lmxlbmd0 aDsKIAogICAgICAgICAgICAgICAgIGlmIChzZWxlY3Rpb24uaXNDb2xsYXBzZWQpCi0gICAgICAg ICAgICAgICAgICAgIHZhciBjb21wbGV0aW9uVGV4dCA9IGNvbXBsZXRpb25zWzFdOworICAgICAg ICAgICAgICAgICAgICB2YXIgY29tcGxldGlvblRleHQgPSBjb21wbGV0aW9uc1swXTsKICAgICAg ICAgICAgICAgICBlbHNlIHsKICAgICAgICAgICAgICAgICAgICAgdmFyIGN1cnJlbnRUZXh0ID0g ZnVsbFdvcmRSYW5nZS50b1N0cmluZygpOwogCg==