40407 2010-06-10 00:51:26 -0700 crash when focus is changed while trying to focus next element 2010-06-10 20:24:19 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 tony tony abarth ap eric webkit.review.bot oldest_to_newest 236210 0 tony 2010-06-10 00:51:26 -0700 See attached test case. I'm investigating a fix. 236254 1 58345 tony 2010-06-10 02:25:17 -0700 Created attachment 58345 Patch 236259 2 58345 tkent 2010-06-10 02:34:22 -0700 Comment on attachment 58345 Patch LayoutTests/fast/events/focus-change-crash-expected.txt:1 + Type something into the first input and press tab. The browser should not crash. nit: Can we insert "PASS" or "SUCCESS" into the document before the test finishes? 236496 3 ap 2010-06-10 13:04:36 -0700 <rdar://problem/8080788> 236607 4 tony 2010-06-10 17:49:33 -0700 Committed r60984: <http://trac.webkit.org/changeset/60984> 236620 5 webkit.review.bot 2010-06-10 18:10:32 -0700 http://trac.webkit.org/changeset/60984 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/60984 http://trac.webkit.org/changeset/60985 236662 6 tony 2010-06-10 20:24:19 -0700 (In reply to comment #4) > Committed r60984: <http://trac.webkit.org/changeset/60984> I added PASSED to the test before landing this patch. 58345 2010-06-10 02:25:17 -0700 2010-06-10 02:34:22 -0700 Patch bug-40407-20100610182515.patch text/plain 3387 tony ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0ZGFhNDZhZjNlNDU2ZThiODFkM2U3YjYxZGNmODAyNTk3YmNkNmI4Li4yNTIyZmJk MzEzMmI1MzhlY2ZhYzUxMjNhNmEwOGJlM2VjMjUyMWU3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDYtMTAgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjcmFzaCB3aGVuIGZvY3VzIGlz IGNoYW5nZWQgd2hpbGUgdHJ5aW5nIHRvIGZvY3VzIG5leHQgZWxlbWVudAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDA0MDcKKworICAgICAgICAqIGZh c3QvZXZlbnRzL2ZvY3VzLWNoYW5nZS1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAg ICAqIGZhc3QvZXZlbnRzL2ZvY3VzLWNoYW5nZS1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAxMC0w Ni0wOSAgUWkgWmhhbmcgIDxxaS4yLnpoYW5nQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBMYXN6bG8gR29tYm9zLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMv Zm9jdXMtY2hhbmdlLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRz L2ZvY3VzLWNoYW5nZS1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uODEyZGQ1MGJmMTA3 MjZlNjAyZWJjZDczNjRlZTlmOTVhOThjMjYwNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2ZvY3VzLWNoYW5nZS1jcmFzaC1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwyIEBACitUeXBlIHNvbWV0aGluZyBpbnRvIHRoZSBmaXJzdCBpbnB1dCBhbmQgcHJlc3MgdGFi LiBUaGUgYnJvd3NlciBzaG91bGQgbm90IGNyYXNoLgorCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9mb2N1cy1jaGFuZ2UtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2Zhc3Qv ZXZlbnRzL2ZvY3VzLWNoYW5nZS1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjU0YjBhZTkwOTc1M2Iz Yjk4ZWVjNGVmZTM4ZWRkNjBkZTZkM2UyZjEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2V2ZW50cy9mb2N1cy1jaGFuZ2UtY3Jhc2guaHRtbApAQCAtMCwwICsxLDI1IEBACis8 ZGl2PlR5cGUgc29tZXRoaW5nIGludG8gdGhlIGZpcnN0IGlucHV0IGFuZCBwcmVzcyB0YWIuICBU aGUgYnJvd3NlciBzaG91bGQgbm90IGNyYXNoLjwvZGl2PgorPGRpdiBpZD0icGFyZW50Ij4KKzxp bnB1dCBpZD0iYSIgLz4KKzxpbnB1dCBpZD0iYiIgLz4KKzwvZGl2PgorPHNjcmlwdD4KK2RvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJhIikuYWRkRXZlbnRMaXN0ZW5lcigiY2hhbmdlIiwgZnVuY3Rp b24oZSkgeworICAgIHZhciBwYXJlbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicGFyZW50 Iik7CisgICAgcGFyZW50LmlubmVySFRNTCA9ICI8aW5wdXQgaWQ9J2MnIC8+IjsKKyAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgiYyIpLnNlbGVjdCgpOworfSwgZmFsc2UpOworCitmdW5jdGlv biBydW5UZXN0KCkKK3sKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYSIpLmZvY3VzKCk7 CisgICAgaWYgKCF3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIHJldHVybjsK KyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CisgICAgZXZlbnRTZW5kZXIu a2V5RG93bigieCIpCisgICAgZXZlbnRTZW5kZXIua2V5RG93bigiXHQiKTsKK30KKworcnVuVGVz dCgpOworCis8L3NjcmlwdD4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggY2E0Yjg2ZTZkZDRkNTgwODQ5ZTI4Zjg5MzQyMWFhNTZlODExNDQz My4uY2Y5ODljYWNmMGY3Y2VlYTY2YTQ2OTAxMzM4NjRkMDdiNzI4NmM2YSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBA QAorMjAxMC0wNi0xMCAgVG9ueSBDaGFuZyAgPHRvbnlAY2hyb21pdW0ub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNyYXNoIHdoZW4gZm9jdXMg aXMgY2hhbmdlZCB3aGlsZSB0cnlpbmcgdG8gZm9jdXMgbmV4dCBlbGVtZW50CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDQwNworCisgICAgICAgIFRl c3Q6IGZhc3QvZXZlbnRzL2ZvY3VzLWNoYW5nZS1jcmFzaC5odG1sCisKKyAgICAgICAgKiBkb20v RWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpmb2N1cyk6CisKIDIwMTAt MDYtMDkgIFFpIFpoYW5nICA8cWkuMi56aGFuZ0Bub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTGFzemxvIEdvbWJvcy4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3Bw IGIvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggZDk1NDAzYTI4MGIxNGVmNWQxNzNlZGZj MTMzMTE0ZDU2MGVjNTgyMy4uODg3N2RmNTcwZmYyODVjN2NkYWZiZDRjMWE3ODlmMGVlODkzMzVi NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvV2ViQ29yZS9kb20v RWxlbWVudC5jcHAKQEAgLTEzMjAsOCArMTMyMCwxMiBAQCB2b2lkIEVsZW1lbnQ6OmZvY3VzKGJv b2wgcmVzdG9yZVByZXZpb3VzU2VsZWN0aW9uKQogICAgICAgICAgICAgcmV0dXJuOwogICAgIH0K IAotICAgIGlmIChQYWdlKiBwYWdlID0gZG9jLT5wYWdlKCkpCisgICAgUmVmUHRyPE5vZGU+IHBy b3RlY3Q7CisgICAgaWYgKFBhZ2UqIHBhZ2UgPSBkb2MtPnBhZ2UoKSkgeworICAgICAgICAvLyBG b2N1cyBhbmQgY2hhbmdlIGV2ZW50IGhhbmRsZXJzIGNhbiBjYXVzZSB1cyB0byBsb3NlIG91ciBs YXN0IHJlZi4KKyAgICAgICAgcHJvdGVjdCA9IHRoaXM7CiAgICAgICAgIHBhZ2UtPmZvY3VzQ29u dHJvbGxlcigpLT5zZXRGb2N1c2VkTm9kZSh0aGlzLCBkb2MtPmZyYW1lKCkpOworICAgIH0KIAog ICAgIC8vIFNldHRpbmcgdGhlIGZvY3VzZWQgbm9kZSBhYm92ZSBtaWdodCBoYXZlIGludmFsaWRh dGVkIHRoZSBsYXlvdXQgZHVlIHRvIHNjcmlwdHMuCiAgICAgZG9jLT51cGRhdGVMYXlvdXRJZ25v cmVQZW5kaW5nU3R5bGVzaGVldHMoKTsK