40401 2010-06-09 22:26:26 -0700 REGRESSION: [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All CLOSED FIXED Qt, QtTriaged P2 Normal --- 0 qt-info webkit-unassigned abarth eric hausmann webkit.review.bot oldest_to_newest 236161 0 58328 qt-info 2010-06-09 22:26:26 -0700 Created attachment 58328 Example HTML [Qt] When dragging onto a page that handles the drag in Javascript it will be a move and not a copy by default. This is fine in Qt 4.6.3, but not in Qt 4.7.0. Attached is a test html file, just drag a file into the draggable area (you should see some debug in the window) and then drop, this will cause the file to be deleted as it was a move event. Whereas in Qt 4.6.3 it was a copy event. The attached patch solves the problem by using the more correct acceptProposedAction() instead of accept(). 236162 1 58329 qt-info 2010-06-09 22:28:19 -0700 Created attachment 58329 Suggested patch 236207 2 hausmann 2010-06-10 00:48:34 -0700 Confirmed on X11, too. 236211 3 hausmann 2010-06-10 00:52:27 -0700 Andy's patch is correct 236215 4 hausmann 2010-06-10 01:03:19 -0700 Committed r60942: <http://trac.webkit.org/changeset/60942> 236225 5 hausmann 2010-06-10 01:22:46 -0700 Revision r60942 cherry-picked into qtwebkit-2.0 with commit 0f40b3b53c931a8161babfd2335067de0970dfd5 236238 6 webkit.review.bot 2010-06-10 01:42:24 -0700 http://trac.webkit.org/changeset/60942 might have broken Chromium Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/60942 http://trac.webkit.org/changeset/60943 58328 2010-06-09 22:26:26 -0700 2010-06-09 22:26:26 -0700 Example HTML dragdrop.html text/html 2061 qt-info PCFkb2N0eXBlIGh0bWw+CjxodG1sPgo8aGVhZD4KICAgIDx0aXRsZT5TcG9vbiBEcmFnIERyb3Ag VGVzdDwvdGl0bGU+CgogICAgPCEtLSBNZXRhIEluZm8gLS0+CiAgICA8bWV0YSBodHRwLWVxdWl2 PSJDb250ZW50LVR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNldD1VVEYtOCIgLz4KICAg IDxtZXRhIG5hbWU9ImRlc2NyaXB0aW9uIiBjb250ZW50PSIiIC8+CiAgICA8bWV0YSBuYW1lPSJr ZXl3b3JkcyIgY29udGVudD0iIiAvPgoKICAgIDwhLS0gRmF2SWNvbiAtLT4KICAgIDxsaW5rIHJl bD0iSWNvbiIgdHlwZT0iaW1hZ2UvcG5nIiBocmVmPSIvYXNzZXRzL2ltZy9mYXZpY29uLmljbyIg Lz4KCiAgICA8IS0tIEphdmFzY3JpcHRzIC0tPgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFz Y3JpcHQiIHNyYz0iaHR0cDovL2FqYXguZ29vZ2xlYXBpcy5jb20vYWpheC9saWJzL2pxdWVyeS8x LjQuMi9qcXVlcnkuanMiPjwvc2NyaXB0PgogICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3Jp cHQiPgogICAgICB2YXIgY2xlYXJEZWJ1ZyA9IGZ1bmN0aW9uKCkgewogICAgICAgICQoJyNkZWJ1 ZycpLmh0bWwoJycpOwogICAgICB9CiAgICAgIHZhciBhZGRUb0RlYnVnID0gZnVuY3Rpb24obXNn KSB7CiAgICAgICAgJCgnI2RlYnVnJykuYXBwZW5kKCQoJzxwPicgKyBtc2cgKyAnPHA+JykpCiAg ICAgIH0KCiAgICAgICQoZnVuY3Rpb24oKSB7CiAgICAgICAgJCgnI2Ryb3AnKVswXS5hZGRFdmVu dExpc3RlbmVyKCdkcmFnZW50ZXInLCBmdW5jdGlvbihldmVudCkgewogICAgICAgICAgYWRkVG9E ZWJ1ZygiRHJhZ0VudGVyIik7CiAgICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgpOwogICAg ICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uKCk7CiAgICAgICAgfSwgZmFsc2UpOwoKICAgICAg ICAkKCcjZHJvcCcpWzBdLmFkZEV2ZW50TGlzdGVuZXIoJ2RyYWdvdmVyJywgZnVuY3Rpb24oZXZl bnQpIHsKICAgICAgICAgIGFkZFRvRGVidWcoIkRyYWdPdmVyIik7CgogICAgICAgICAgZXZlbnQu cHJldmVudERlZmF1bHQoKTsKICAgICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOwogICAg ICAgICAgfSwgZmFsc2UpOwoKICAgICAgICAkKCcjZHJvcCcpWzBdLmFkZEV2ZW50TGlzdGVuZXIo J2RyYWdsZWF2ZScsIGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgICBhZGRUb0RlYnVnKCJEcmFn TGVhdmUiKTsKICAgICAgICAgIGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICBldmVu dC5zdG9wUHJvcGFnYXRpb24oKTsKCiAgICAgICAgICB9LCBmYWxzZSk7CgogICAgICAgICQoJyNk cm9wJylbMF0uYWRkRXZlbnRMaXN0ZW5lcignZHJvcCcsIGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAg ICAgICBhbGVydCgiZHJvcCIpOwoKICAgICAgICAgIHZhciBkYXRhID0gZXZlbnQuZGF0YVRyYW5z ZmVyLmdldERhdGEoJ3RleHQvdXJpLWxpc3QnKTsKICAgICAgICAgIGFkZFRvRGVidWcoIkRyb3A6 IGdldHRpbmcgJ3RleHQvdXJpLWxpc3QnIGV2ZW50IGRhdGE6ICIgKyBkYXRhKTsKICAgICAgICAg IGV2ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgICAgICBldmVudC5zdG9wUHJvcGFnYXRpb24o KTsKICAgICAgICB9LCBmYWxzZSk7CiAgICAgIH0pOwogICAgPC9zY3JpcHQ+CgogICAgPHN0eWxl PgogICAgICBib2R5IHsgCiAgICAgICAgaGVpZ2h0OiAxMDAlOwogICAgICAgIHdpZHRoOiAxMDAl OwogICAgICAgIGJhY2tncm91bmQ6IGdyYXk7CiAgICAgIH0KICAgICAgZGl2I2Ryb3AgewogICAg ICAgIGRpc3BsYXk6IGJsb2NrOwogICAgICAgIG1hcmdpbjogMCBhdXRvOwogICAgICAgIGhlaWdo dDogMjAwcHg7CiAgICAgICAgcGFkZGluZzogMTBweDsKICAgICAgICBib3JkZXI6IG9yYW5nZSA1 cHggZG90dGVkOwogICAgICAgIGJvcmRlci1yYWRpdXM6IDEwcHg7CiAgICAgIH0KICAgIDwvc3R5 bGU+CjwvaGVhZD4KPGJvZHk+CjxwPnBldGUgd2FzIGhlcmU8L3A+ICAKICA8ZGl2IGlkPSJkcm9w Ij5Ecm9wcGFibGUgQXJlYTwvZGl2PgoKICA8ZGl2IGlkPSJkZWJ1ZyI+PC9kaXY+Cgo8L2JvZHk+ CjwvaHRtbD4K 58329 2010-06-09 22:28:19 -0700 2010-06-09 22:28:19 -0700 Suggested patch patch.diff text/plain 2240 qt-info ZGlmZiAtLWdpdCBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAgYi9zcmMvM3JkcGFydHkvd2Via2l0L1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCmluZGV4 IDI3ODgwODUuLjU1OTgzNmQgMTAwNjQ0Ci0tLSBhL3NyYy8zcmRwYXJ0eS93ZWJraXQvV2ViS2l0 L3F0L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvc3JjLzNyZHBhcnR5L3dlYmtpdC9XZWJLaXQvcXQv QXBpL3F3ZWJwYWdlLmNwcApAQCAtMTE3NSw3ICsxMTc1LDcgQEAgdm9pZCBRV2ViUGFnZVByaXZh dGU6OmRyYWdFbnRlckV2ZW50KFFHcmFwaGljc1NjZW5lRHJhZ0Ryb3BFdmVudCogZXYpCiAgICAg UXQ6OkRyb3BBY3Rpb24gYWN0aW9uID0gZHJhZ09wVG9Ecm9wQWN0aW9uKHBhZ2UtPmRyYWdDb250 cm9sbGVyKCktPmRyYWdFbnRlcmVkKCZkcmFnRGF0YSkpOwogICAgIGV2LT5zZXREcm9wQWN0aW9u KGFjdGlvbik7CiAgICAgaWYgKGFjdGlvbiAhPSBRdDo6SWdub3JlQWN0aW9uKQotICAgICAgICBl di0+YWNjZXB0KCk7CisgICAgICAgIGV2LT5hY2NlcHRQcm9wb3NlZEFjdGlvbigpOwogI2VuZGlm CiB9CiAKQEAgLTExODgsNyArMTE4OCw3IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjpkcmFnRW50 ZXJFdmVudChRRHJhZ0VudGVyRXZlbnQqIGV2KQogICAgIGV2LT5zZXREcm9wQWN0aW9uKGFjdGlv bik7CiAgICAgLy8gV2UgbXVzdCBhY2NlcHQgdGhpcyBldmVudCBpbiBvcmRlciB0byByZWNlaXZl IHRoZSBkcmFnIG1vdmUgZXZlbnRzIHRoYXQgYXJlIHNlbnQKICAgICAvLyB3aGlsZSB0aGUgZHJh ZyBhbmQgZHJvcCBhY3Rpb24gaXMgaW4gcHJvZ3Jlc3MuCi0gICAgZXYtPmFjY2VwdCgpOworICAg IGV2LT5hY2NlcHRQcm9wb3NlZEFjdGlvbigpOwogI2VuZGlmCiB9CiAKQEAgLTEyMTgsNyArMTIx OCw3IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjpkcmFnTW92ZUV2ZW50KFFHcmFwaGljc1NjZW5l RHJhZ0Ryb3BFdmVudCogZXYpCiAgICAgUXQ6OkRyb3BBY3Rpb24gYWN0aW9uID0gZHJhZ09wVG9E cm9wQWN0aW9uKHBhZ2UtPmRyYWdDb250cm9sbGVyKCktPmRyYWdVcGRhdGVkKCZkcmFnRGF0YSkp OwogICAgIGV2LT5zZXREcm9wQWN0aW9uKGFjdGlvbik7CiAgICAgaWYgKGFjdGlvbiAhPSBRdDo6 SWdub3JlQWN0aW9uKQotICAgICAgICBldi0+YWNjZXB0KCk7CisgICAgICAgIGV2LT5hY2NlcHRQ cm9wb3NlZEFjdGlvbigpOwogI2VuZGlmCiB9CiAKQEAgLTEyMzIsNyArMTIzMiw3IEBAIHZvaWQg UVdlYlBhZ2VQcml2YXRlOjpkcmFnTW92ZUV2ZW50KFFEcmFnTW92ZUV2ZW50KiBldikKICAgICBl di0+c2V0RHJvcEFjdGlvbihhY3Rpb24pOwogICAgIC8vIFdlIG11c3QgYWNjZXB0IHRoaXMgZXZl bnQgaW4gb3JkZXIgdG8gcmVjZWl2ZSB0aGUgZHJhZyBtb3ZlIGV2ZW50cyB0aGF0IGFyZSBzZW50 CiAgICAgLy8gd2hpbGUgdGhlIGRyYWcgYW5kIGRyb3AgYWN0aW9uIGlzIGluIHByb2dyZXNzLgot ICAgIGV2LT5hY2NlcHQoKTsKKyAgICBldi0+YWNjZXB0UHJvcG9zZWRBY3Rpb24oKTsKICNlbmRp ZgogfQogCkBAIC0xMjQyLDcgKzEyNDIsNyBAQCB2b2lkIFFXZWJQYWdlUHJpdmF0ZTo6ZHJvcEV2 ZW50KFFHcmFwaGljc1NjZW5lRHJhZ0Ryb3BFdmVudCogZXYpCiAgICAgRHJhZ0RhdGEgZHJhZ0Rh dGEoZXYtPm1pbWVEYXRhKCksIGV2LT5wb3MoKS50b1BvaW50KCksCiAgICAgICAgICAgICBRQ3Vy c29yOjpwb3MoKSwgZHJvcEFjdGlvblRvRHJhZ09wKGV2LT5wb3NzaWJsZUFjdGlvbnMoKSkpOwog ICAgIGlmIChwYWdlLT5kcmFnQ29udHJvbGxlcigpLT5wZXJmb3JtRHJhZygmZHJhZ0RhdGEpKQot ICAgICAgICBldi0+YWNjZXB0KCk7CisgICAgICAgIGV2LT5hY2NlcHRQcm9wb3NlZEFjdGlvbigp OwogI2VuZGlmCiB9CiAKQEAgLTEyNTQsNyArMTI1NCw3IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRl Ojpkcm9wRXZlbnQoUURyb3BFdmVudCogZXYpCiAgICAgRHJhZ0RhdGEgZHJhZ0RhdGEoZXYtPm1p bWVEYXRhKCksIGV2LT5wb3MoKSwgUUN1cnNvcjo6cG9zKCksCiAgICAgICAgICAgICAgICAgICAg ICAgZHJvcEFjdGlvblRvRHJhZ09wKFF0OjpEcm9wQWN0aW9uKGV2LT5kcm9wQWN0aW9uKCkpKSk7 CiAgICAgaWYgKHBhZ2UtPmRyYWdDb250cm9sbGVyKCktPnBlcmZvcm1EcmFnKCZkcmFnRGF0YSkp Ci0gICAgICAgIGV2LT5hY2NlcHQoKTsKKyAgICAgICAgZXYtPmFjY2VwdFByb3Bvc2VkQWN0aW9u KCk7CiAjZW5kaWYKIH0KIAo=