40384 2010-06-09 12:38:34 -0700 Test how XML directives get attached to the DOM 2010-06-09 14:29:07 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 39259 1 abarth abarth eric oldest_to_newest 235941 0 abarth 2010-06-09 12:38:34 -0700 Test how XML directives get attached to the DOM 235946 1 58279 abarth 2010-06-09 12:44:05 -0700 Created attachment 58279 Patch 235962 2 58279 eric 2010-06-09 13:17:02 -0700 Comment on attachment 58279 Patch OK. So the new parser currently "fails" this test, right? Wouldn't it be better to just check for document.firstChild and see that it's a comment? 235985 3 abarth 2010-06-09 13:52:33 -0700 I liked the idea of crawling the DOM to make sure things were hooked up right. 235989 4 eric 2010-06-09 13:54:07 -0700 The problem with your new test is that its not self contained. Its not easy to see from it if it passed or failed. If you wanted to walk, you could check each type with some shouldBe's and that woudl be better. 235998 5 abarth 2010-06-09 14:09:47 -0700 You have to look at the expected results to see what we expect to happen... That doesn't seem unreasonable. 236002 6 eric 2010-06-09 14:12:30 -0700 Sure, but that requires a gold file. Ideally tests contain their own results with PASS, FAIL messages. Your test is OK, tests which contain their own expectations are better. I owe Darin Adler a "design doc" of sorts on this subject. 236006 7 abarth 2010-06-09 14:20:07 -0700 Committed r60913: <http://trac.webkit.org/changeset/60913> 236010 8 abarth 2010-06-09 14:29:07 -0700 Sometimes tests with embedded PASS/FAIL are more work because you need to edit the tests when something changes instead of just having different results. In any case, we're over engineering this test. :) 58279 2010-06-09 12:44:05 -0700 2010-06-09 13:17:02 -0700 Patch bug-40384-20100609124404.patch text/plain 3118 abarth SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDYwOTA3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjcgQEAKKzIwMTAtMDYtMDkgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBUZXN0IGhvdyBYTUwgZGlyZWN0aXZlcyBnZXQgYXR0YWNoZWQgdG8gdGhlIERPTQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzODQKKwor ICAgICAgICBJbiB0aGUgb2xkIHBhcnNlciwgdGhlIFhNTCBkaXJlY3RpdmUgZG9lc24ndCBnZXQg YWRkZWQgdG8gdGhlIERPTS4gIEluCisgICAgICAgIG5ldyBwYXJzZXIgKGFuZCBpbiBNaW5lZmll bGQpLCBpdCBnZXRzIGFkZGVkIGFzIGEgY29tbWVudCwgd2hpY2ggc2hvd3MKKyAgICAgICAgdXAg aW4gdGhpcyB0ZXN0LgorCisgICAgICAgIFRoaXMgYmVoYXZpb3Igd2FzIHRlc3RlZCBtb3JlIG9i bGlxdWVseSBieQorICAgICAgICBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ob3Zlci1zdHls ZS1jaGFuZ2UuaHRtbCBpbiBzb21lCisgICAgICAgIER1bXBSZW5kZXJUcmVlIG91dHB1dC4gIEkn dmUgcmVtb3ZlZCB0aGF0IGNvdmVyYWdlIGZyb20gdGhlIENTUyB0ZXN0CisgICAgICAgIGFuZCBt b3ZlZCBpdCB0byBhIG5ldyBwYXJzZXIgdGVzdCB0aGF0IGNhbiBhY3R1YWxseSBiZSBydW4gaW4g b3RoZXIKKyAgICAgICAgYnJvd3NlcnMuCisKKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQt Y29udGVudC9ob3Zlci1zdHlsZS1jaGFuZ2UuaHRtbDoKKyAgICAgICAgICAgIC0gUmVtb3ZlIFhN TCBkaXJlY3RpdmUgdGhhdCB3YXMgY2F1c2luZyB0aGlzIHRlc3QgdG8gZGVwZW5kIG9uCisgICAg ICAgICAgICAgIG91dC1vZi1zcGVjIHBhcnNlciBiZWhhdmlvciB3LnIudC4gd2hldGhlciB0byBh dHRhY2ggdGhlIFhNTAorICAgICAgICAgICAgICBkaXJlY3RpdmUgdG8gdGhlIERPTS4KKyAgICAg ICAgKiBmYXN0L3BhcnNlci94bWwtZGlyZWN0aXZlLWluLWRvbS1leHBlY3RlZC50eHQ6IEFkZGVk LgorICAgICAgICAqIGZhc3QvcGFyc2VyL3htbC1kaXJlY3RpdmUtaW4tZG9tLmh0bWw6IEFkZGVk LgorCiAyMDEwLTA2LTA5ICBLZW5uZXRoIFJ1c3NlbGwgIDxrYnJAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0 L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ob3Zlci1zdHlsZS1jaGFuZ2UuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9ob3Zlci1zdHlsZS1j aGFuZ2UuaHRtbAkocmV2aXNpb24gNjA4OTkpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5l cmF0ZWQtY29udGVudC9ob3Zlci1zdHlsZS1jaGFuZ2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MSw0ICsxLDMgQEAKLTw/eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+CiA8IURP Q1RZUEUgaHRtbCBQVUJMSUMgIi0vL1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOIgogCSJo dHRwOi8vd3d3LnczLm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KIDxodG1s IHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPgpJbmRl eDogTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveG1sLWRpcmVjdGl2ZS1pbi1kb20tZXhwZWN0ZWQu dHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3htbC1kaXJlY3RpdmUt aW4tZG9tLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcGFy c2VyL3htbC1kaXJlY3RpdmUtaW4tZG9tLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw0IEBACitbb2JqZWN0IEhUTUxIdG1sRWxlbWVudF0KK1tvYmplY3QgRG9jdW1lbnRUeXBl XQorCisKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3htbC1kaXJlY3RpdmUtaW4tZG9t Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIveG1sLWRpcmVjdGl2 ZS1pbi1kb20uaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvcGFyc2VyL3ht bC1kaXJlY3RpdmUtaW4tZG9tLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjMgQEAKKzw/ eG1sIHZlcnNpb249IjEuMCIgZW5jb2Rpbmc9InV0Zi04Ij8+Cis8IURPQ1RZUEUgaHRtbCBQVUJM SUMgIi0vL1czQy8vRFREIFhIVE1MIDEuMCBTdHJpY3QvL0VOIgorICAgICJodHRwOi8vd3d3Lncz Lm9yZy9UUi94aHRtbDEvRFREL3hodG1sMS1zdHJpY3QuZHRkIj4KKzxodG1sIHhtbG5zPSJodHRw Oi8vd3d3LnczLm9yZy8xOTk5L3hodG1sIiB4bWw6bGFuZz0iZW4iPgorPGhlYWQ+CisgICAgPHRp dGxlPlRlc3QgaG93IHByZWFtYmxlIGdldHMgYXR0YWNoZWQgdG8gRE9NPC90aXRsZT4KKyAgICA8 c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCI+CisgICAgICAgaWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikKKyAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4 dCgpOworICAgIDwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8cHJlPgorPHNjcmlwdD4KK3Zh ciBlbG10ID0gZG9jdW1lbnQuZG9jdW1lbnRFbGVtZW50Oword2hpbGUgKGVsbXQpIHsKKyAgICBk b2N1bWVudC53cml0ZWxuKGVsbXQpOworICAgIGVsbXQgPSBlbG10LnByZXZpb3VzU2libGluZzsK K30KKzwvc2NyaXB0PgorPC9wcmU+Cis8L2JvZHk+Cis8L2h0bWw+Cg==