40360 2010-06-09 05:31:50 -0700 Windows build break due to C4819 warning 2010-06-09 08:59:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED DUPLICATE 40358 P2 Normal --- 0 skyul webkit-unassigned tkent oldest_to_newest 235748 0 skyul 2010-06-09 05:31:50 -0700 WKCAImageQueue.cpp and MediaPlayerPrivateFullscreenWindow.cpp contain non-ASCII double quotation marks around "AS IS". This causes C4819 warning in Korean version of Windows. I think it may cause the warning in some of non-English Windows too. Replace the double quotation mark with ``. 6>WKCAImageQueue.cpp 6>..\platform\graphics\win\WKCAImageQueue.cpp : error C2220: warning treated as error - no 'object' file generated 6>..\platform\graphics\win\WKCAImageQueue.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 6>MediaPlayerPrivateFullscreenWindow.cpp 6>..\platform\graphics\win\MediaPlayerPrivateFullscreenWindow.cpp : error C2220: warning treated as error - no 'object' file generated 6>..\platform\graphics\win\MediaPlayerPrivateFullscreenWindow.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 235749 1 58236 skyul 2010-06-09 05:34:02 -0700 Created attachment 58236 Patch 235752 2 tkent 2010-06-09 05:50:34 -0700 *** This bug has been marked as a duplicate of bug 40358 *** 235809 3 58236 levin 2010-06-09 08:59:45 -0700 Comment on attachment 58236 Patch Already fixed in http://trac.webkit.org/changeset/60894 so I'm clearing the r?, etc. 58236 2010-06-09 05:34:02 -0700 2010-06-09 08:59:44 -0700 Patch buildfix.patch text/plain 2541 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MDg4NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDYtMDkgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaW5kb3dzIGJ1aWxkIGJyZWFrIGR1ZSB0byBDNDgxOSB3YXJuaW5nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDM2MAorCisgICAgICAgIFdLQ0FJ bWFnZVF1ZXVlLmNwcCBhbmQgTWVkaWFQbGF5ZXJQcml2YXRlRnVsbHNjcmVlbldpbmRvdy5jcHAg Y29udGFpbiBub24tQVNDSUkgZG91YmxlCisgICAgICAgIHF1b3RhdGlvbiBtYXJrcyBhcm91bmQg IkFTIElTIi4gIFRoaXMgY2F1c2VzIEM0ODE5IHdhcm5pbmcgaW4gbm9uLUVuZ2xpc2ggdmVyc2lv biBvZiBXaW5kb3dzLgorICAgICAgICBSZXBsYWNlIHRoZSBkb3VibGUgcXVvdGF0aW9uIG1hcmsg d2l0aCBgYC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3dpbi9NZWRpYVBsYXllclBy aXZhdGVGdWxsc2NyZWVuV2luZG93LmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy93 aW4vV0tDQUltYWdlUXVldWUuY3BwOgorCiAyMDEwLTA2LTA5ICBDc2FiYSBPc3p0cm9nb27DoWMg IDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBTY2h1bHplLgpJ bmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlRnVs bHNjcmVlbldpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy93aW4vTWVkaWFQbGF5ZXJQcml2YXRlRnVsbHNjcmVlbldpbmRvdy5jcHAJKHJldmlzaW9uIDYw ODg3KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vTWVkaWFQbGF5ZXJQcml2YXRl RnVsbHNjcmVlbldpbmRvdy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEwLDcgKzEwLDcgQEAKICAq ICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlz Y2xhaW1lciBpbiB0aGUgCiAgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlh bHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgogICogCi0gKiBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklCVVRPUlMgk0FTIElTlCAK KyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRS SUJVVE9SUyBgYEFTIElTYGAKICAqIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJ RVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAogICogVEhFIElNUExJRUQgV0FSUkFO VElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiAKICAq IFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVWRU5UIFNIQUxMIEFQUExFIElOQy4gT1Ig SVRTIENPTlRSSUJVVE9SUwpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy93aW4vV0tD QUltYWdlUXVldWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv d2luL1dLQ0FJbWFnZVF1ZXVlLmNwcAkocmV2aXNpb24gNjA4ODcpCisrKyBXZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3dpbi9XS0NBSW1hZ2VRdWV1ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEw LDcgKzEwLDcgQEAKICAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRo ZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBpbiB0aGUgCiAgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9v ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgogICogCi0g KiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIEFQUExFIElOQy4gQU5EIElUUyBDT05UUklC VVRPUlMgk0FTIElTlCAKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5D LiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTYGAgCiAgKiBBTkQgQU5ZIEVYUFJFU1MgT1Ig SU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywKICAqIFRI RSBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZPUiBB IFBBUlRJQ1VMQVIgCiAgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFM TCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMK