40353 2010-06-09 00:11:59 -0700 [Qt] Remove superfluous function calls 2010-07-09 00:11:35 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 agbakken agbakken commit-queue eric hausmann jedrzej.nowacki kenneth ossy oldest_to_newest 235678 0 agbakken 2010-06-09 00:11:59 -0700 [Qt] Remove superfluous function calls 235679 1 58217 agbakken 2010-06-09 00:13:20 -0700 Created attachment 58217 Patch 237407 2 58217 eric 2010-06-12 18:56:55 -0700 Comment on attachment 58217 Patch Why are the superfluous? Specifically the second one? Please explain in your ChangeLog. 237815 3 ossy 2010-06-14 07:54:01 -0700 Modifying of QWebFrame::setUrl(...) LGTM. But I'm not convinced if QWebFrame::load(...) is correct, because load is a public API function, not only the setUrl function can call it with absolute URL. But the question is if we would like to apply the first API (binary) change before Qt-4.7.0 release. Kenneth? Simon? 237855 4 58661 agbakken 2010-06-14 09:28:12 -0700 Created attachment 58661 Patch 237856 5 agbakken 2010-06-14 09:28:49 -0700 New patch with better description of why the calls are superfluous is uploadd. 237874 6 58661 kenneth 2010-06-14 09:48:25 -0700 Comment on attachment 58661 Patch WebKit/qt/Api/qwebframe.cpp:716 + load(QNetworkRequest(url)); You should add a comment here to why the ensureAbso... is not needed here. 237898 7 hausmann 2010-06-14 10:34:15 -0700 Nice change :) 237901 8 agbakken 2010-06-14 10:38:40 -0700 @Kenneth: You mean an inline comment? E.g. void QWebFrame::load(const QUrl &url) { // No need to call ensureAbsoluteUrl() here since ::load(QNetworkRequest) // will do it. load(QNetworkRequest(url)); } It seems a little un-qt-like to me I have to admit. 237919 9 kenneth 2010-06-14 11:03:47 -0700 (In reply to comment #8) > @Kenneth: > > You mean an inline comment? > > E.g. > > void QWebFrame::load(const QUrl &url) > { > // No need to call ensureAbsoluteUrl() here since ::load(QNetworkRequest) > // will do it. > load(QNetworkRequest(url)); > } > > It seems a little un-qt-like to me I have to admit. Well, not very un-WebKitish anyway. And apparently someone added the ensureAb... before. Something like: // The load() overload ensures that the url is absolute. load(QNetworkRequest(url)); 237921 10 58672 agbakken 2010-06-14 11:07:24 -0700 Created attachment 58672 Patch 237927 11 ossy 2010-06-14 11:17:03 -0700 (In reply to comment #10) > Created an attachment (id=58672) [details] > Patch LGTM, I see why both of them are superfluous. Only a little nit-pick, please remove the unnecessary newline from the end of ChangeLog before landing. (after Kenneth give you an r+ :) 237948 12 58676 agbakken 2010-06-14 11:43:10 -0700 Created attachment 58676 Patch 237955 13 ossy 2010-06-14 11:47:17 -0700 (In reply to comment #12) > Created an attachment (id=58676) [details] > Patch Kenneth r+ -ed your last patch, just commit it with this minor change. You don't have to wait for r+ again. 248774 14 58676 hausmann 2010-07-08 23:48:35 -0700 Comment on attachment 58676 Patch r=me Anders, please remember to set cq? if you don't want to land the change yourself. 248785 15 58676 commit-queue 2010-07-09 00:11:29 -0700 Comment on attachment 58676 Patch Clearing flags on attachment: 58676 Committed r62903: <http://trac.webkit.org/changeset/62903> 248786 16 commit-queue 2010-07-09 00:11:35 -0700 All reviewed patches have been landed. Closing bug. 58217 2010-06-09 00:13:20 -0700 2010-06-14 09:28:05 -0700 Patch bug-40353-20100609001451.patch text/plain 1518 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCA3YTI4ZjgzOTZhNDQ1ZmU1Y2I0MTEwMDQ4ZTFhZTU5ZmFkOGQ1 NGVhLi5jOGJlMGVmMTE3OTg1Y2NhMzM1ZmE0MGJkNzAyOTA3MzQzNTA5ZmYxIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJh bWUuY3BwCkBAIC02MTMsOSArNjEzLDEwIEBAIHN0YXRpYyBpbmxpbmUgUVVybCBlbnN1cmVBYnNv bHV0ZVVybChjb25zdCBRVXJsICZ1cmwpCiAKIHZvaWQgUVdlYkZyYW1lOjpzZXRVcmwoY29uc3Qg UVVybCAmdXJsKQogewotICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2luKGVu c3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGNvbnN0IFFVcmwgYWJzb2x1dGUgPSBlbnN1cmVB YnNvbHV0ZVVybCh1cmwpOworICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2lu KGFic29sdXRlKTsKICAgICBkLT5mcmFtZS0+bG9hZGVyKCktPndyaXRlcigpLT5lbmQoKTsKLSAg ICBsb2FkKGVuc3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGxvYWQoYWJzb2x1dGUpOwogfQog CiBRVXJsIFFXZWJGcmFtZTo6dXJsKCkgY29uc3QKQEAgLTcwNiw3ICs3MDcsNyBAQCBRV2ViUGFn ZSAqUVdlYkZyYW1lOjpwYWdlKCkgY29uc3QKICovCiB2b2lkIFFXZWJGcmFtZTo6bG9hZChjb25z dCBRVXJsICZ1cmwpCiB7Ci0gICAgbG9hZChRTmV0d29ya1JlcXVlc3QoZW5zdXJlQWJzb2x1dGVV cmwodXJsKSkpOworICAgIGxvYWQoUU5ldHdvcmtSZXF1ZXN0KHVybCkpOwogfQogCiAvKiEKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IDFiMzI2MGVhNDBjYWJkNDI3ZDRjN2E0Y2RjZWZhM2VlYTk1NTE4N2IuLjI0MGJiZjExMjNkMTE0 Y2YxZTQzNjYyYjllYmU5ZWU0ZDk2YzdlNmEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEwLTA2LTA5 ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHN1cGVyZmx1b3VzIGZ1 bmN0aW9uIGNhbGxzCisKKyAgICAgICAgRml4IG92ZXJseSBncmF0dWl0b3VzIHVzZSBvZiBlbnN1 cmVBYnNvbHV0ZVVybC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQwMzUzCisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKFFX ZWJGcmFtZTo6c2V0VXJsKToKKyAgICAgICAgKFFXZWJGcmFtZTo6bG9hZCk6CisKIDIwMTAtMDYt MDggIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBPamFuIFZhZmFpIGFuZCBEYXJpbiBBZGxlci4K 58661 2010-06-14 09:28:12 -0700 2010-06-14 11:07:15 -0700 Patch bug-40353-20100614092812.patch text/plain 1924 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCAzZWJhMDU4ZmVjMTRjMjc3NTViNDE3NTRjOTZjNjExY2Q0Mzhk NGU0Li4wYWJkMzlmYWU0NTk3YzZiY2JkYzgyMDU1ODc1NjY3OTBlNTM4YzExIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJh bWUuY3BwCkBAIC02MTksOSArNjE5LDEwIEBAIHN0YXRpYyBpbmxpbmUgUVVybCBlbnN1cmVBYnNv bHV0ZVVybChjb25zdCBRVXJsICZ1cmwpCiAKIHZvaWQgUVdlYkZyYW1lOjpzZXRVcmwoY29uc3Qg UVVybCAmdXJsKQogewotICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2luKGVu c3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGNvbnN0IFFVcmwgYWJzb2x1dGUgPSBlbnN1cmVB YnNvbHV0ZVVybCh1cmwpOworICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2lu KGFic29sdXRlKTsKICAgICBkLT5mcmFtZS0+bG9hZGVyKCktPndyaXRlcigpLT5lbmQoKTsKLSAg ICBsb2FkKGVuc3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGxvYWQoYWJzb2x1dGUpOwogfQog CiBRVXJsIFFXZWJGcmFtZTo6dXJsKCkgY29uc3QKQEAgLTcxMiw3ICs3MTMsNyBAQCBRV2ViUGFn ZSAqUVdlYkZyYW1lOjpwYWdlKCkgY29uc3QKICovCiB2b2lkIFFXZWJGcmFtZTo6bG9hZChjb25z dCBRVXJsICZ1cmwpCiB7Ci0gICAgbG9hZChRTmV0d29ya1JlcXVlc3QoZW5zdXJlQWJzb2x1dGVV cmwodXJsKSkpOworICAgIGxvYWQoUU5ldHdvcmtSZXF1ZXN0KHVybCkpOwogfQogCiAvKiEKZGlm ZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4 IDBjNzA4MDBmMWIwYTJiMWRmODg0NjJjZjJhNjdiOWM3YzhiMmVmYzYuLjAzNDc5NzA2Y2VjOWU5 Y2U0ZmFiZjI4MzFkMzdkYzc2ZjdjNzYwMTkgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEwLTA2LTE0 ICBBbmRlcnMgQmFra2VuICA8YWdiYWtrZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIHN1cGVyZmx1b3VzIGZ1 bmN0aW9uIGNhbGxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00MDM1MworCisgICAgICAgIFFXZWJGcmFtZTo6c2V0VXJsKCkgY2FsbHMgZW5zdXJlQWJz b2x1dGVVcmwoKSB0d2ljZS4gSXQncyBiZXR0ZXIgdG8KKyAgICAgICAgc3RvcmUgYSBsb2NhbCB2 YXJpYWJsZSBhbmQgcmV1c2UgdGhpcyBvbmUuCisKKyAgICAgICAgUVdlYkZyYW1lOjpsb2FkKFFV cmwpIGNhbGxzIFFXZWJGcmFtZTo6bG9hZChRTmV0d29ya1JlcXVlc3QpIHdoaWNoIGluCisgICAg ICAgIHR1cm4gd2lsbCBnZXQgdGhlIFFVcmwgZnJvbSB0aGUgcmVxdWVzdCBhbmQgbWFrZSBzdXJl IGl0J3MgYWJzb2x1dGUgYnkKKyAgICAgICAgY2FsbGluZyBlbnN1cmVBYnNvbHV0ZVVybCgpIG9u IGl0LgorCisgICAgICAgICogQXBpL3F3ZWJmcmFtZS5jcHA6CisgICAgICAgIChRV2ViRnJhbWU6 OnNldFVybCk6CisgICAgICAgIChRV2ViRnJhbWU6OmxvYWQpOgorCiAyMDEwLTA2LTE0ICBMYXN6 bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkLCBTeW1iaWFuIGJ1aWxkIGZpeC4KQEAgLTIzMzEwLDMgKzIzMzI4LDQgQEAKICAgICAgICAg KiBXZWJLaXRQYXJ0L1dlYktpdFBhcnRJbnRlcmZhY2UuaDogQWRkZWQuCiAgICAgICAgICogV2Vi S2l0UGFydC9vcmcua2RlLldlYktpdFBhcnQueG1sOiBBZGRlZC4KIAorCg== 58672 2010-06-14 11:07:24 -0700 2010-06-14 11:43:04 -0700 Patch bug-40353-20100614110724.patch text/plain 1986 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCAzZWJhMDU4ZmVjMTRjMjc3NTViNDE3NTRjOTZjNjExY2Q0Mzhk NGU0Li42YjVhNmM3N2JmMzcxOGI3NTExOGFjZThlMDFjMzAzMjVjMjRmZjlkIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJh bWUuY3BwCkBAIC02MTksOSArNjE5LDEwIEBAIHN0YXRpYyBpbmxpbmUgUVVybCBlbnN1cmVBYnNv bHV0ZVVybChjb25zdCBRVXJsICZ1cmwpCiAKIHZvaWQgUVdlYkZyYW1lOjpzZXRVcmwoY29uc3Qg UVVybCAmdXJsKQogewotICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2luKGVu c3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGNvbnN0IFFVcmwgYWJzb2x1dGUgPSBlbnN1cmVB YnNvbHV0ZVVybCh1cmwpOworICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2lu KGFic29sdXRlKTsKICAgICBkLT5mcmFtZS0+bG9hZGVyKCktPndyaXRlcigpLT5lbmQoKTsKLSAg ICBsb2FkKGVuc3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGxvYWQoYWJzb2x1dGUpOwogfQog CiBRVXJsIFFXZWJGcmFtZTo6dXJsKCkgY29uc3QKQEAgLTcxMiw3ICs3MTMsOCBAQCBRV2ViUGFn ZSAqUVdlYkZyYW1lOjpwYWdlKCkgY29uc3QKICovCiB2b2lkIFFXZWJGcmFtZTo6bG9hZChjb25z dCBRVXJsICZ1cmwpCiB7Ci0gICAgbG9hZChRTmV0d29ya1JlcXVlc3QoZW5zdXJlQWJzb2x1dGVV cmwodXJsKSkpOworICAgIC8vIFRoZSBsb2FkKCkgb3ZlcmxvYWQgZW5zdXJlcyB0aGF0IHRoZSB1 cmwgaXMgYWJzb2x1dGUuCisgICAgbG9hZChRTmV0d29ya1JlcXVlc3QodXJsKSk7CiB9CiAKIC8q IQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cK aW5kZXggMGM3MDgwMGYxYjBhMmIxZGY4ODQ2MmNmMmE2N2I5YzdjOGIyZWZjNi4uMDM0Nzk3MDZj ZWM5ZTljZTRmYWJmMjgzMWQzN2RjNzZmN2M3NjAxOSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0No YW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAt MDYtMTQgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgc3VwZXJmbHVv dXMgZnVuY3Rpb24gY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwMzUzCisKKyAgICAgICAgUVdlYkZyYW1lOjpzZXRVcmwoKSBjYWxscyBlbnN1 cmVBYnNvbHV0ZVVybCgpIHR3aWNlLiBJdCdzIGJldHRlciB0bworICAgICAgICBzdG9yZSBhIGxv Y2FsIHZhcmlhYmxlIGFuZCByZXVzZSB0aGlzIG9uZS4KKworICAgICAgICBRV2ViRnJhbWU6Omxv YWQoUVVybCkgY2FsbHMgUVdlYkZyYW1lOjpsb2FkKFFOZXR3b3JrUmVxdWVzdCkgd2hpY2ggaW4K KyAgICAgICAgdHVybiB3aWxsIGdldCB0aGUgUVVybCBmcm9tIHRoZSByZXF1ZXN0IGFuZCBtYWtl IHN1cmUgaXQncyBhYnNvbHV0ZSBieQorICAgICAgICBjYWxsaW5nIGVuc3VyZUFic29sdXRlVXJs KCkgb24gaXQuCisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKFFXZWJG cmFtZTo6c2V0VXJsKToKKyAgICAgICAgKFFXZWJGcmFtZTo6bG9hZCk6CisKIDIwMTAtMDYtMTQg IExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIFN5bWJpYW4gYnVpbGQgZml4LgpAQCAtMjMzMTAsMyArMjMzMjgsNCBAQAogICAg ICAgICAqIFdlYktpdFBhcnQvV2ViS2l0UGFydEludGVyZmFjZS5oOiBBZGRlZC4KICAgICAgICAg KiBXZWJLaXRQYXJ0L29yZy5rZGUuV2ViS2l0UGFydC54bWw6IEFkZGVkLgogCisK 58676 2010-06-14 11:43:10 -0700 2010-07-09 00:11:29 -0700 Patch bug-40353-20100614114310.patch text/plain 1853 agbakken ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmZyYW1lLmNwcCBiL1dlYktpdC9xdC9BcGkv cXdlYmZyYW1lLmNwcAppbmRleCAzZWJhMDU4ZmVjMTRjMjc3NTViNDE3NTRjOTZjNjExY2Q0Mzhk NGU0Li42YjVhNmM3N2JmMzcxOGI3NTExOGFjZThlMDFjMzAzMjVjMjRmZjlkIDEwMDY0NAotLS0g YS9XZWJLaXQvcXQvQXBpL3F3ZWJmcmFtZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2ViZnJh bWUuY3BwCkBAIC02MTksOSArNjE5LDEwIEBAIHN0YXRpYyBpbmxpbmUgUVVybCBlbnN1cmVBYnNv bHV0ZVVybChjb25zdCBRVXJsICZ1cmwpCiAKIHZvaWQgUVdlYkZyYW1lOjpzZXRVcmwoY29uc3Qg UVVybCAmdXJsKQogewotICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2luKGVu c3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGNvbnN0IFFVcmwgYWJzb2x1dGUgPSBlbnN1cmVB YnNvbHV0ZVVybCh1cmwpOworICAgIGQtPmZyYW1lLT5sb2FkZXIoKS0+d3JpdGVyKCktPmJlZ2lu KGFic29sdXRlKTsKICAgICBkLT5mcmFtZS0+bG9hZGVyKCktPndyaXRlcigpLT5lbmQoKTsKLSAg ICBsb2FkKGVuc3VyZUFic29sdXRlVXJsKHVybCkpOworICAgIGxvYWQoYWJzb2x1dGUpOwogfQog CiBRVXJsIFFXZWJGcmFtZTo6dXJsKCkgY29uc3QKQEAgLTcxMiw3ICs3MTMsOCBAQCBRV2ViUGFn ZSAqUVdlYkZyYW1lOjpwYWdlKCkgY29uc3QKICovCiB2b2lkIFFXZWJGcmFtZTo6bG9hZChjb25z dCBRVXJsICZ1cmwpCiB7Ci0gICAgbG9hZChRTmV0d29ya1JlcXVlc3QoZW5zdXJlQWJzb2x1dGVV cmwodXJsKSkpOworICAgIC8vIFRoZSBsb2FkKCkgb3ZlcmxvYWQgZW5zdXJlcyB0aGF0IHRoZSB1 cmwgaXMgYWJzb2x1dGUuCisgICAgbG9hZChRTmV0d29ya1JlcXVlc3QodXJsKSk7CiB9CiAKIC8q IQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cK aW5kZXggMGM3MDgwMGYxYjBhMmIxZGY4ODQ2MmNmMmE2N2I5YzdjOGIyZWZjNi4uYTJjN2NmNjdh MjQ0N2JkNDdmYzdiZTliNDRhNjFhMzAwY2UyMGZhMCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0No YW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAt MDYtMTQgIEFuZGVycyBCYWtrZW4gIDxhZ2Jha2tlbkBnbWFpbC5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBSZW1vdmUgc3VwZXJmbHVv dXMgZnVuY3Rpb24gY2FsbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQwMzUzCisKKyAgICAgICAgUVdlYkZyYW1lOjpzZXRVcmwoKSBjYWxscyBlbnN1 cmVBYnNvbHV0ZVVybCgpIHR3aWNlLiBJdCdzIGJldHRlciB0bworICAgICAgICBzdG9yZSBhIGxv Y2FsIHZhcmlhYmxlIGFuZCByZXVzZSB0aGlzIG9uZS4KKworICAgICAgICBRV2ViRnJhbWU6Omxv YWQoUVVybCkgY2FsbHMgUVdlYkZyYW1lOjpsb2FkKFFOZXR3b3JrUmVxdWVzdCkgd2hpY2ggaW4K KyAgICAgICAgdHVybiB3aWxsIGdldCB0aGUgUVVybCBmcm9tIHRoZSByZXF1ZXN0IGFuZCBtYWtl IHN1cmUgaXQncyBhYnNvbHV0ZSBieQorICAgICAgICBjYWxsaW5nIGVuc3VyZUFic29sdXRlVXJs KCkgb24gaXQuCisKKyAgICAgICAgKiBBcGkvcXdlYmZyYW1lLmNwcDoKKyAgICAgICAgKFFXZWJG cmFtZTo6c2V0VXJsKToKKyAgICAgICAgKFFXZWJGcmFtZTo6bG9hZCk6CisKIDIwMTAtMDYtMTQg IExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIFN5bWJpYW4gYnVpbGQgZml4Lgo=