40348 2010-06-08 21:01:12 -0700 [chromium] Menu key should act on current selection even if it is not editable 2010-06-12 19:10:08 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned commit-queue eric fishd tony oldest_to_newest 235632 0 estade 2010-06-08 21:01:12 -0700 In r52124, I reworked the menu key in a way that made it so that it only acted on selections in an editable node. A user pointed this out in <http://crbug.com/45434>. This reverts it to the old behavior. The rest of the issues that I fixed previously (see <https://bugs.webkit.org/show_bug.cgi?id=32347>) are unaffected. 235633 1 58208 estade 2010-06-08 21:03:48 -0700 Created attachment 58208 patch 235660 2 tony 2010-06-08 22:34:27 -0700 Is it possible to test this with eventSender.keyDown or does it not know about this key? Can we add this key to the method? 235897 3 estade 2010-06-09 11:22:01 -0700 we could test it with eventSender.keyDown, but I'm not sure how we'd verify that it's doing what we want from within a layout test. It's probably better suited to test via a chromium UI test. 237409 4 58208 eric 2010-06-12 18:58:42 -0700 Comment on attachment 58208 patch OK. rs=me. 237423 5 58208 commit-queue 2010-06-12 19:09:54 -0700 Comment on attachment 58208 patch Clearing flags on attachment: 58208 Committed r61072: <http://trac.webkit.org/changeset/61072> 237424 6 commit-queue 2010-06-12 19:10:08 -0700 All reviewed patches have been landed. Closing bug. 58208 2010-06-08 21:03:48 -0700 2010-06-12 19:09:53 -0700 patch tmp.diff text/plain 1299 estade ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDg3ZDBmZGUuLjdiZjY4NmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE1IEBACisyMDEwLTA2LTA4ICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1d IE1lbnUga2V5IHNob3VsZCBhY3Qgb24gY3VycmVudCBzZWxlY3Rpb24gZXZlbiBpZiBpdCBpcyBu b3QgZWRpdGFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQwMzQ4CisKKyAgICAgICAgQWxsb3cgdGhlIG1lbnUga2V5IHRvIGFjdCBvbiBub24tZWRp dGFibGUgc2VsZWN0aW9ucy4KKworICAgICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAg ICAgIChXZWJLaXQ6OldlYlZpZXdJbXBsOjpzZW5kQ29udGV4dE1lbnVFdmVudCk6CisKIDIwMTAt MDYtMDggIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBOb3QgcmV2 aWV3ZWQsIGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViVmll d0ltcGwuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKaW5kZXggNWI1 Mjg2Ny4uMDUzOTU0NiAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1w bC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJWaWV3SW1wbC5jcHAKQEAgLTY4MSw3 ICs2ODEsNyBAQCBib29sIFdlYlZpZXdJbXBsOjpzZW5kQ29udGV4dE1lbnVFdmVudChjb25zdCBX ZWJLZXlib2FyZEV2ZW50JiBldmVudCkKICAgICBOb2RlKiBmb2N1c2VkTm9kZSA9IGZvY3VzZWRG cmFtZS0+ZG9jdW1lbnQoKS0+Zm9jdXNlZE5vZGUoKTsKICAgICBQb3NpdGlvbiBzdGFydCA9IG1h aW5GcmFtZUltcGwtPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS5zdGFydCgpOwogCi0gICAgaWYg KGZvY3VzZWRGcmFtZS0+ZWRpdG9yKCkgJiYgZm9jdXNlZEZyYW1lLT5lZGl0b3IoKS0+Y2FuRWRp dCgpICYmIHN0YXJ0Lm5vZGUoKSkgeworICAgIGlmIChzdGFydC5ub2RlKCkpIHsKICAgICAgICAg UmVuZGVyT2JqZWN0KiByZW5kZXJlciA9IHN0YXJ0Lm5vZGUoKS0+cmVuZGVyZXIoKTsKICAgICAg ICAgaWYgKCFyZW5kZXJlcikKICAgICAgICAgICAgIHJldHVybiBmYWxzZTsK