40346 2010-06-08 19:01:42 -0700 Fix build breakage from 38145 2010-06-08 22:38:58 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 38145 1 kbr kbr cmarrin dglazkov oliver rolandsteiner zmo oldest_to_newest 235619 0 kbr 2010-06-08 19:01:42 -0700 The fix for bug 38145 broke the Chromium Win build because Microsoft's cmath doesn't define log2. Suggested fix by zmo is to change log2(x) to log(x) / log(2). Built and ran WebGL layout tests in Safari on Mac OS X. 235620 1 kbr 2010-06-08 19:11:50 -0700 Committed r60876: <http://trac.webkit.org/changeset/60876> 235663 2 rolandsteiner 2010-06-08 22:38:58 -0700 The fix didn't catch - now the log function calls are ambiguous between float, double or long double versions. I added a 2nd quick fix in r60881 - adding explicit casts to double and double constants - which seems to have done the trick, at least as far as compilation goes (see http://trac.webkit.org/changeset/60881)