40345 2010-06-08 18:07:23 -0700 Don't send mail for cancel/deny/granted for in-rietveld 2010-06-09 17:35:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent abarth ddkilzer ojan oldest_to_newest 235612 0 jparent 2010-06-08 18:07:23 -0700 We already don't send the regular flag change mail, but we also shouldn't send the specific mail for cancel/deny/granted that comes from state change from ? -> {+,-, ). 235875 1 58261 jparent 2010-06-09 10:56:19 -0700 Created attachment 58261 patch 235884 2 58261 abarth 2010-06-09 11:13:17 -0700 Comment on attachment 58261 patch LGTM, but BugsSite and I aren't friends. :) 235891 3 58261 ddkilzer 2010-06-09 11:17:37 -0700 Comment on attachment 58261 patch r=me 236100 4 jparent 2010-06-09 17:35:40 -0700 Committed http://trac.webkit.org/changeset/60904 58261 2010-06-09 10:56:19 -0700 2010-06-09 11:17:36 -0700 patch nomail.txt text/plain 1163 jparent SW5kZXg6IEJ1Z3NTaXRlL0J1Z3ppbGxhL0ZsYWcucG0NCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBCdWdzU2l0 ZS9CdWd6aWxsYS9GbGFnLnBtCShyZXZpc2lvbiA2MDg5OSkKKysrIEJ1Z3NTaXRlL0J1Z3ppbGxh L0ZsYWcucG0JKHdvcmtpbmcgY29weSkKQEAgLTEwNzAsNiArMTA3MCwxMiBAQCBvciBkZWxldGVk Lgogc3ViIG5vdGlmeSB7CiAgICAgbXkgKCRmbGFnLCAkYnVnLCAkYXR0YWNobWVudCkgPSBAXzsK IAorICAgICNpZiBXRUJLSVRfQ0hBTkdFUworICAgICMgRG9uJ3Qgc2VuZCBhIG5vdGlmaWNhdGlv biB3aGVuIHRoZSBmbGFnIGlzIGluLXJpZXR2ZWxkLAorICAgICMgc2luY2UgaXQgaXNuJ3QgYSB1 c2VyIHZpc2libGUgZmxhZywgYW5kIHRoYXQgbWFpbCBpcyBzcGFtbXkuCisgICAgcmV0dXJuIGlm ICgkZmxhZy0+dHlwZS0+bmFtZSBlcSAnaW4tcmlldHZlbGQnKTsKKyAgICAjZW5kaWYgLy8gV0VC S0lUX0NIQU5HRVMKKwogICAgICMgVGhlcmUgaXMgbm9ib2R5IHRvIG5vdGlmeS4KICAgICByZXR1 cm4gdW5sZXNzICgkZmxhZy0+eydhZGRyZXNzZWUnfSB8fCAkZmxhZy0+dHlwZS0+Y2NfbGlzdCk7 CiAKSW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZw0KPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQ0KLS0tIEJ1Z3NTaXRlL0No YW5nZUxvZwkocmV2aXNpb24gNjA5MDApCisrKyBCdWdzU2l0ZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNi0wOSAgSnVsaWUgUGFyZW50ICA8anBhcmVu dEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQnVnemlsbGE6IERvbid0IHNlbmQgbWFpbCBmb3IgY2FuY2VsL2RlbnkvZ3JhbnRl ZCBmb3IgaW4tcmlldHZlbGQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQwMzQ1CisKKyAgICAgICAgKiBCdWd6aWxsYS9GbGFnLnBtOgorCiAyMDEw LTA1LTE3ICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBPamFuIFZhZmFpLgo=