40341 2010-06-08 16:01:21 -0700 [chromium] webkit_unit_tests project fails to link when ACCELERATED_COMPOSITING is enabled 2010-06-11 05:29:03 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 vangelis webkit-unassigned commit-queue dglazkov fishd webkit.review.bot oldest_to_newest 235565 0 vangelis 2010-06-08 16:01:21 -0700 The unresolved symbols come from the lack of linking with the gles2 C library: webcore.lib(LayerRendererChromium.obj) : error LNK2019: unresolved external symbol _GLES2DeleteTextures referenced in function "public: __thiscall WebCore::LayerRendererChromium::~LayerRendererChromium(void)" (??1LayerRendererChromium@WebCore@@QAE@XZ) .... 235579 1 58196 vangelis 2010-06-08 16:47:34 -0700 Created attachment 58196 Proposed patch 235627 2 webkit.review.bot 2010-06-08 20:40:47 -0700 Attachment 58196 did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3238069 235650 3 fishd 2010-06-08 21:58:50 -0700 ^^^ looks like we need to add the angle project to chromium/DEPS? 235815 4 58196 levin 2010-06-09 09:10:02 -0700 Comment on attachment 58196 Proposed patch r- due to cr-linux build break. 236416 5 58196 vangelis 2010-06-10 10:23:17 -0700 Comment on attachment 58196 Proposed patch Hopefully now that ANGLE is in the DEPS file this will actually compile. 236461 6 58394 vangelis 2010-06-10 11:20:28 -0700 Created attachment 58394 Re-uploading the patch to kick the try bots on 236494 7 vangelis 2010-06-10 13:01:45 -0700 Looks like it's ready to go, this time! 236795 8 58394 commit-queue 2010-06-11 05:28:55 -0700 Comment on attachment 58394 Re-uploading the patch to kick the try bots on Clearing flags on attachment: 58394 Committed r61007: <http://trac.webkit.org/changeset/61007> 236796 9 commit-queue 2010-06-11 05:29:03 -0700 All reviewed patches have been landed. Closing bug. 58196 2010-06-08 16:47:34 -0700 2010-06-10 11:20:28 -0700 Proposed patch fixLinkError_40341.txt text/plain 1625 vangelis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjA4NzApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMDggIFZhbmdl bGlzIEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkaW5nIGEgYnVpbGQg ZGVwZW5kZW5jeSB0byB0aGUgZ2xlczIgQyBsaWJyYXJ5IHRvIHRoZSB3ZWJraXRfdW5pdF90ZXN0 cworICAgICAgICBwcm9qZWN0IHRvIGFsbG93IGl0IHRvIGxpbmsgd2hlbiBXZWJDb3JlIGlzIGNv bXBpbGVkIHdpdGggdGhlIEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HCisgICAgICAgIGZsYWcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDM0MQorCisg ICAgICAgICogV2ViS2l0Lmd5cDoKKwogMjAxMC0wNi0wOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1 cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL1dlYktpdC5neXAJKHJldmlzaW9uIDYwNzk4KQorKysgV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXAJKHdvcmtpbmcgY29weSkKQEAgLTUyMyw2ICs1MjMsNyBAQAogICAgICAgICAgICAg ICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Rlc3RpbmcvZ3Rlc3QuZ3lwOmd0ZXN0JywKICAgICAg ICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9iYXNlL2Jhc2UuZ3lwOmJhc2UnLAogICAg ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2Jhc2UvYmFzZS5neXA6YmFzZV9pMThu JywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9ncHUvZ3B1Lmd5cDpnbGVz Ml9jX2xpYicsCiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2luY2x1ZGVfZGlycyc6IFsK ICAgICAgICAgICAgICAgICAncHVibGljJywKQEAgLTU3Niw2ICs1NzcsNyBAQAogICAgICAgICAg ICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlw dENvcmUuZ3lwOnd0Zl9jb25maWcnLAogICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19k aXIpL3RoaXJkX3BhcnR5L2ljdS9pY3UuZ3lwOmljdXVjJywKICAgICAgICAgICAgICAgICAnPChj aHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5neXA6d2Via2l0 X3N1cHBvcnQnLAorICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2dwdS9ncHUu Z3lwOmdsZXMyX2NfbGliJwogICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdpbmNsdWRlX2Rp cnMnOiBbCiAgICAgICAgICAgICAgICAgJy4nLAo= 58394 2010-06-10 11:20:28 -0700 2010-06-11 05:28:54 -0700 Re-uploading the patch to kick the try bots on fixLinkError_40341.txt text/plain 1625 vangelis SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjA4NzApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDYtMDggIFZhbmdl bGlzIEtva2tldmlzICA8dmFuZ2VsaXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkaW5nIGEgYnVpbGQg ZGVwZW5kZW5jeSB0byB0aGUgZ2xlczIgQyBsaWJyYXJ5IHRvIHRoZSB3ZWJraXRfdW5pdF90ZXN0 cworICAgICAgICBwcm9qZWN0IHRvIGFsbG93IGl0IHRvIGxpbmsgd2hlbiBXZWJDb3JlIGlzIGNv bXBpbGVkIHdpdGggdGhlIEFDQ0VMRVJBVEVEX0NPTVBPU0lUSU5HCisgICAgICAgIGZsYWcuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDM0MQorCisg ICAgICAgICogV2ViS2l0Lmd5cDoKKwogMjAxMC0wNi0wOCAgWXVyeSBTZW1pa2hhdHNreSAgPHl1 cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJ bmRleDogV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL1dlYktpdC5neXAJKHJldmlzaW9uIDYwNzk4KQorKysgV2ViS2l0L2Nocm9taXVtL1dl YktpdC5neXAJKHdvcmtpbmcgY29weSkKQEAgLTUyMyw2ICs1MjMsNyBAQAogICAgICAgICAgICAg ICAgICc8KGNocm9taXVtX3NyY19kaXIpL3Rlc3RpbmcvZ3Rlc3QuZ3lwOmd0ZXN0JywKICAgICAg ICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9iYXNlL2Jhc2UuZ3lwOmJhc2UnLAogICAg ICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2Jhc2UvYmFzZS5neXA6YmFzZV9pMThu JywKKyAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9ncHUvZ3B1Lmd5cDpnbGVz Ml9jX2xpYicsCiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2luY2x1ZGVfZGlycyc6IFsK ICAgICAgICAgICAgICAgICAncHVibGljJywKQEAgLTU3Niw2ICs1NzcsNyBAQAogICAgICAgICAg ICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2YVNjcmlw dENvcmUuZ3lwOnd0Zl9jb25maWcnLAogICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19k aXIpL3RoaXJkX3BhcnR5L2ljdS9pY3UuZ3lwOmljdXVjJywKICAgICAgICAgICAgICAgICAnPChj aHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93ZWJraXRfc3VwcG9ydC5neXA6d2Via2l0 X3N1cHBvcnQnLAorICAgICAgICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL2dwdS9ncHUu Z3lwOmdsZXMyX2NfbGliJwogICAgICAgICAgICAgXSwKICAgICAgICAgICAgICdpbmNsdWRlX2Rp cnMnOiBbCiAgICAgICAgICAgICAgICAgJy4nLAo=