40340 2010-06-08 15:52:52 -0700 Zero-sized gradients should not be painted on the canvas. 2010-06-09 14:03:21 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 eros webkit-unassigned jchaffraix oldest_to_newest 235564 0 eros 2010-06-08 15:52:52 -0700 HTML5 spec: http://www.whatwg.org/specs/web-apps/current-work/#colors-and-styles This change will make WebKit pass the following test: http://philip.html5.org/tests/canvas/suite/tests/2d.gradient.interpolate.zerosize.html 235584 1 58198 eros 2010-06-08 17:00:10 -0700 Created attachment 58198 Proposed patch 235902 2 58198 ariya.hidayat 2010-06-09 11:29:46 -0700 Comment on attachment 58198 Proposed patch LGTM. 235993 3 jchaffraix 2010-06-09 14:03:21 -0700 Landed the fix in r60911. 58198 2010-06-08 17:00:10 -0700 2010-06-09 11:29:46 -0700 Proposed patch PATCH-webkit-40340-2d.gradient.interpolate.zerosize-v1.patch text/plain 5425 eros Y29tbWl0IGE3ZTA5ZWI1MjUwNTYzNDdiNzllMmUzODkwZjkzZjljMDI4NWVjNTUKQXV0aG9yOiBF bnJpY28gUm9zIDxlcm9zQGNvZGVhdXJvcmEub3JnPgpEYXRlOiAgIFR1ZSBKdW4gOCAxNjo0Mzo1 MSAyMDEwIC0wNzAwCgogICAgMjAxMC0wNi0wOCAgRW5yaWNvIFJvcyAgPGVyb3NAY29kZWF1cm9y YS5vcmc+CiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAgICAK ICAgICAgICAgICAgRml4IGRyYXdpbmcgemVyby1zaXplZCBncmFkaWVudHMgb24gQ2FudmFzLgog ICAgICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzNDAK ICAgIAogICAgICAgICAgICBIVE1MNSBkcmFmdCBzYXlzIHRoYXQgbm90aGluZyBtdXN0IGJlIHBh aW50ZWQgaWYgdGhlIGdyYWRpZW50IHN0YXJ0CiAgICAgICAgICAgIHBvaW50IGVxdWFscyB0aGUg c3RvcCBwb2ludC4KICAgIAogICAgICAgICAgICBUaGlzIGNvbW1pdCBmaXhlcyB0aGUgZm9sbG93 aW5nIGNhbnZhcyB0ZXN0OgogICAgICAgICAgICBodHRwOi8vcGhpbGlwLmh0bWw1Lm9yZy90ZXN0 cy9jYW52YXMvc3VpdGUvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuemVyb3NpemUuaHRt bAogICAgCiAgICAgICAgICAgICogaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJE LmNwcDoKICAgICAgICAgICAgKFdlYkNvcmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6Zmls bFJlY3QpOiBza2lwIHplcm8tc2l6ZWQgbGluZWFyIGdyYWRpZW50cwogICAgICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50Lmg6CiAgICAgICAgICAgIChXZWJDb3JlOjpHcmFkaWVu dDo6aXNSYWRpYWwpOiBtYWRlIHB1YmxpYwogICAgICAgICAgICAoV2ViQ29yZTo6R3JhZGllbnQ6 OmlzWmVyb1NpemUpOiB0cnVlIGlmIHN0YXJ0ID09IHN0b3AKCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYjAwOTVmNi4uOTdh OTdjNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA2LTA4ICBFbnJpY28gUm9zICA8ZXJv c0Bjb2RlYXVyb3JhLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBGaXhlZCB6ZXJvLXNpemVkIGdyYWRpZW50cyBvbiBjYW52YXMuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDM0MAorCisgICAgICAg ICogcGxhdGZvcm0vbWFjL1NraXBwZWQ6IFVuc2tpcCB0aGUgdGVzdCB0aGF0IGlzIHBhc3Npbmcg bm93LgorICAgICAgICAqIHBsYXRmb3JtL3F0L1NraXBwZWQ6IFVuc2tpcCB0aGUgdGVzdCB0aGF0 IGlzIHBhc3Npbmcgbm93LgorCiAyMDEwLTA2LTAxICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5z b25AaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRm b3JtL21hYy9Ta2lwcGVkCmluZGV4IGNjM2EwNjYuLmMxMjU4MzkgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9Ta2lwcGVkCkBAIC0yMjIsNyArMjIyLDYgQEAgY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxs U3R5bGUucGFyc2UucmdiLWNsYW1wLTMuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxs U3R5bGUucGFyc2UucmdiLWNsYW1wLTQuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxs U3R5bGUucGFyc2UucmdiLWNsYW1wLTUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5maWxs U3R5bGUucGFyc2Uuc3lzdGVtLmh0bWwKLWNhbnZhcy9waGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQu aW50ZXJwb2xhdGUuemVyb3NpemUuaHRtbAogY2FudmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVu dC5yYWRpYWwuY29uZS5mcm9udC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50 LnJhZGlhbC5jb25lLnRvcC5odG1sCiBjYW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJh ZGlhbC5pbnNpZGUyLmh0bWwKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1Nr aXBwZWQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDA0YjU3ZjMuLjA1 OGExMzUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIv TGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtNTEwMiw3ICs1MTAyLDYgQEAgY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UucmdiLWNsYW1wLTQuaHRtbAogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2UucmdiLWNsYW1wLTUuaHRtbAogY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5maWxsU3R5bGUucGFyc2Uuc3lzdGVtLmh0bWwKIGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQuZ3JhZGllbnQuaW50ZXJwb2xhdGUuY29sb3VyYWxwaGEuaHRtbAotY2Fu dmFzL3BoaWxpcC90ZXN0cy8yZC5ncmFkaWVudC5pbnRlcnBvbGF0ZS56ZXJvc2l6ZS5odG1sCiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmJlaGluZC5odG1sCiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmJlc2lkZS5odG1sCiBj YW52YXMvcGhpbGlwL3Rlc3RzLzJkLmdyYWRpZW50LnJhZGlhbC5jb25lLmJvdHRvbS5odG1sCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ4 ZGE2NDEuLjQ3ODcwMmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTAtMDYtMDggIEVucmljbyBSb3MgIDxl cm9zQGNvZGVhdXJvcmEub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEZpeCBkcmF3aW5nIHplcm8tc2l6ZWQgZ3JhZGllbnRzIG9uIENhbnZhcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQwMzQwCisK KyAgICAgICAgSFRNTDUgZHJhZnQgc2F5cyB0aGF0IG5vdGhpbmcgbXVzdCBiZSBwYWludGVkIGlm IHRoZSBncmFkaWVudCBzdGFydAorICAgICAgICBwb2ludCBlcXVhbHMgdGhlIHN0b3AgcG9pbnQu CisKKyAgICAgICAgVGhpcyBjb21taXQgZml4ZXMgdGhlIGZvbGxvd2luZyBjYW52YXMgdGVzdDoK KyAgICAgICAgaHR0cDovL3BoaWxpcC5odG1sNS5vcmcvdGVzdHMvY2FudmFzL3N1aXRlL3Rlc3Rz LzJkLmdyYWRpZW50LmludGVycG9sYXRlLnplcm9zaXplLmh0bWwKKworICAgICAgICAqIGh0bWwv Y2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpD YW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OmZpbGxSZWN0KTogc2tpcCB6ZXJvLXNpemVkIGxpbmVh ciBncmFkaWVudHMKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oOgorICAg ICAgICAoV2ViQ29yZTo6R3JhZGllbnQ6OmlzUmFkaWFsKTogbWFkZSBwdWJsaWMKKyAgICAgICAg KFdlYkNvcmU6OkdyYWRpZW50Ojppc1plcm9TaXplKTogdHJ1ZSBpZiBzdGFydCA9PSBzdG9wCisK IDIwMTAtMDYtMDEgIEFkYW0gTGFuZ2xleSAgPGFnbEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvY2FudmFz L0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHAgYi9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZh c1JlbmRlcmluZ0NvbnRleHQyRC5jcHAKaW5kZXggMTg0Y2MxNC4uZTRiMTk1NiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQuY3BwCisrKyBi L1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcApAQCAtNzUz LDYgKzc1MywxMiBAQCB2b2lkIENhbnZhc1JlbmRlcmluZ0NvbnRleHQyRDo6ZmlsbFJlY3QoZmxv YXQgeCwgZmxvYXQgeSwgZmxvYXQgd2lkdGgsIGZsb2F0IGhlaQogICAgIGlmICghc3RhdGUoKS5t X2ludmVydGlibGVDVE0pCiAgICAgICAgIHJldHVybjsKIAorICAgIC8vIGZyb20gdGhlIEhUTUw1 IENhbnZhcyBzcGVjOgorICAgIC8vIElmIHgwID0geDEgYW5kIHkwID0geTEsIHRoZW4gdGhlIGxp bmVhciBncmFkaWVudCBtdXN0IHBhaW50IG5vdGhpbmcKKyAgICBHcmFkaWVudCogZ3JhZGllbnQg PSBjLT5maWxsR3JhZGllbnQoKTsKKyAgICBpZiAoZ3JhZGllbnQgJiYgZ3JhZGllbnQtPmlzWmVy b1NpemUoKSAmJiAhZ3JhZGllbnQtPmlzUmFkaWFsKCkpCisgICAgICAgIHJldHVybjsKKwogICAg IEZsb2F0UmVjdCByZWN0KHgsIHksIHdpZHRoLCBoZWlnaHQpOwogICAgIHdpbGxEcmF3KHJlY3Qp OwogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmggYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYWRpZW50LmgKaW5kZXggZTE3YzA3YS4uODg3N2Y2 ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFkaWVudC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhZGllbnQuaApAQCAtODgsMTIgKzg4LDE0IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgICAgICB2b2lkIGdldENvbG9yKGZsb2F0IHZhbHVl LCBmbG9hdCogciwgZmxvYXQqIGcsIGZsb2F0KiBiLCBmbG9hdCogYSkgY29uc3Q7CiAKKyAgICAg ICAgYm9vbCBpc1JhZGlhbCgpIGNvbnN0IHsgcmV0dXJuIG1fcmFkaWFsOyB9CisgICAgICAgIGJv b2wgaXNaZXJvU2l6ZSgpIGNvbnN0IHsgcmV0dXJuIG1fcDAueCgpID09IG1fcDEueCgpICYmIG1f cDAueSgpID09IG1fcDEueSgpOyB9CisKICNpZiBPUyhXSU5DRSkgJiYgIVBMQVRGT1JNKFFUKQog ICAgICAgICBjb25zdCBGbG9hdFBvaW50JiBwMCgpIGNvbnN0IHsgcmV0dXJuIG1fcDA7IH0KICAg ICAgICAgY29uc3QgRmxvYXRQb2ludCYgcDEoKSBjb25zdCB7IHJldHVybiBtX3AxOyB9CiAgICAg ICAgIGZsb2F0IHIwKCkgY29uc3QgeyByZXR1cm4gbV9yMDsgfQogICAgICAgICBmbG9hdCByMSgp IGNvbnN0IHsgcmV0dXJuIG1fcjE7IH0KLSAgICAgICAgYm9vbCBpc1JhZGlhbCgpIGNvbnN0IHsg cmV0dXJuIG1fcmFkaWFsOyB9CiAgICAgICAgIGNvbnN0IFZlY3RvcjxDb2xvclN0b3A+JiBnZXRT dG9wcygpIGNvbnN0OwogI2Vsc2UKICAgICAgICAgUGxhdGZvcm1HcmFkaWVudCBwbGF0Zm9ybUdy YWRpZW50KCk7Cg==