<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>40335</bug_id>
          
          <creation_ts>2010-06-08 14:45:23 -0700</creation_ts>
          <short_desc>Add three more non-core Chromium builders to start testing DumpRenderTree.</short_desc>
          <delta_ts>2010-06-23 04:59:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>41057</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Dimitri Glazkov (Google)">dglazkov</reporter>
          <assigned_to name="Dimitri Glazkov (Google)">dglazkov</assigned_to>
          <cc>abarth</cc>
    
    <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>tony</cc>
    
    <cc>wsiegrist</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>235533</commentid>
    <comment_count>0</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-06-08 14:45:23 -0700</bug_when>
    <thetext>Add three more non-core Chromium builders to start testing DumpRenderTree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>235535</commentid>
    <comment_count>1</comment_count>
      <attachid>58187</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-06-08 14:46:03 -0700</bug_when>
    <thetext>Created attachment 58187
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>235537</commentid>
    <comment_count>2</comment_count>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-06-08 14:48:09 -0700</bug_when>
    <thetext>From what I understand, these are non-core by default. Right? They will stay red for a while (we&apos;re still catching up on the implementation), but we&apos;re close enough to start monitoring progress.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>235539</commentid>
    <comment_count>3</comment_count>
      <attachid>58187</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2010-06-08 14:50:33 -0700</bug_when>
    <thetext>Comment on attachment 58187
Patch

Yes.  core builders is a white-list:
https://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/net/buildbot.py#L312</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>237379</commentid>
    <comment_count>4</comment_count>
      <attachid>58187</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2010-06-12 17:50:37 -0700</bug_when>
    <thetext>Comment on attachment 58187
Patch

rs=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>239977</commentid>
    <comment_count>5</comment_count>
      <attachid>58187</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2010-06-18 09:26:10 -0700</bug_when>
    <thetext>Comment on attachment 58187
Patch

let cq do it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240281</commentid>
    <comment_count>6</comment_count>
      <attachid>58187</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-19 00:12:54 -0700</bug_when>
    <thetext>Comment on attachment 58187
Patch

Clearing flags on attachment: 58187

Committed r61469: &lt;http://trac.webkit.org/changeset/61469&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240282</commentid>
    <comment_count>7</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-06-19 00:12:58 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240496</commentid>
    <comment_count>8</comment_count>
    <who name="William Siegrist">wsiegrist</who>
    <bug_when>2010-06-20 12:02:14 -0700</bug_when>
    <thetext>Buildbot master has been updated and password info sent to Dimitri. 

And on a side note, the whitelist for Chromium was very broad, so I had to make it more specific so these new builders were not considered core. See also &lt;http://trac.webkit.org/changeset/61508&gt;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240508</commentid>
    <comment_count>9</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-20 12:43:51 -0700</bug_when>
    <thetext>I might have chosen to put &quot;build&quot; in the regex, but that&apos;s probably fine for now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240599</commentid>
    <comment_count>10</comment_count>
    <who name="William Siegrist">wsiegrist</who>
    <bug_when>2010-06-20 23:07:11 -0700</bug_when>
    <thetext>(In reply to comment #9)
&gt; I might have chosen to put &quot;build&quot; in the regex, but that&apos;s probably fine for now.

The regexp matches the builder names, which do not contain &quot;build&quot;, and renaming your builders seemed outside my jurisdiction.  Feel free to rename them so their name ends in (Build). I agree that the regexp could be a little more self-documenting.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>240759</commentid>
    <comment_count>11</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2010-06-21 10:01:03 -0700</bug_when>
    <thetext>&gt; renaming your builders seemed outside my jurisdiction.

&quot;my&quot; builders.  Haha.  :)

Hopefully we&apos;ll end up with separate build and test builders for Chromium.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>58187</attachid>
            <date>2010-06-08 14:46:03 -0700</date>
            <delta_ts>2010-06-19 00:12:53 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-40335-20100608144602.patch</filename>
            <type>text/plain</type>
            <size>4490</size>
            <attacher name="Dimitri Glazkov (Google)">dglazkov</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5v
cmctY29uZmlnL2NvbmZpZy5qc29uIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp
bGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KaW5kZXggZGI3Mzc5ZGUxMWFjMDM5OWVk
M2M0YWVkZTVmNzVkNmE2MGM0MTY4ZS4uODFlM2Y5MTJlNDY5YjQ2ZmNhMDc0NmIxZWQ1Y2VlZGUx
ZTlhNGFkYiAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQu
d2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KKysrIGIvV2ViS2l0VG9vbHMvQnVpbGRTbGF2
ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb24KQEAgLTM4LDYgKzM4
LDkgQEAKICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJnb29nbGUtd2luZG93cy0xIiwg
InBsYXRmb3JtIjogImNocm9taXVtIiB9LAogICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjog
Imdvb2dsZS1tYWMtMSIsICJwbGF0Zm9ybSI6ICJjaHJvbWl1bSIgfSwKICAgICAgICAgICAgICAg
ICAgICAgeyAibmFtZSI6ICJnb29nbGUtbGludXgtMSIsICJwbGF0Zm9ybSI6ICJjaHJvbWl1bSIg
fSwKKyAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJnb29nbGUtd2luZG93cy0yIiwgInBs
YXRmb3JtIjogImNocm9taXVtIiB9LAorICAgICAgICAgICAgICAgICAgICB7ICJuYW1lIjogImdv
b2dsZS1tYWMtMiIsICJwbGF0Zm9ybSI6ICJjaHJvbWl1bSIgfSwKKyAgICAgICAgICAgICAgICAg
ICAgeyAibmFtZSI6ICJnb29nbGUtbGludXgtMiIsICJwbGF0Zm9ybSI6ICJjaHJvbWl1bSIgfSwK
ICAgICAgICAgICAgICAgICAgICAgeyAibmFtZSI6ICJnb29nbGUtbmV3LXRlc3RzIiwgInBsYXRm
b3JtIjogIm1hYy1sZW9wYXJkIiB9CiAgICAgICAgICAgICAgICAgICBdLAogCkBAIC0xNjUsMTEg
KzE2OCwyNiBAQAogICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJjaHJvbWl1bSIs
ICJjb25maWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6IFsiaTM4NiJdLAog
ICAgICAgICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJnb29nbGUtbGludXgtMSJdCiAg
ICAgICAgICAgICAgICAgICAgIH0sCi0JCSAgICB7Ci0JCSAgICAgICJuYW1lIjogIk5ldyBydW4t
d2Via2l0LXRlc3RzIiwgInR5cGUiOiAiTmV3QnVpbGRBbmRUZXN0IiwgImJ1aWxkZGlyIjogImdv
b2dsZS1uZXctdGVzdHMiLAotCQkgICAgICAicGxhdGZvcm0iOiAibWFjLWxlb3BhcmQiLCAiY29u
ZmlndXJhdGlvbiI6ICJyZWxlYXNlIiwgImFyY2hpdGVjdHVyZXMiOiBbImkzODYiXSwKLQkJICAg
ICAgInNsYXZlbmFtZXMiOiBbImdvb2dsZS1uZXctdGVzdHMiXQotCQkgICAgfQorICAgICAgICAg
ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiQ2hyb21pdW0gV2lu
IFJlbGVhc2UgKFRlc3RzKSIsICJ0eXBlIjogIk5ld0J1aWxkQW5kVGVzdCIsICJidWlsZGRpciI6
ICJjaHJvbWl1bS13aW4tcmVsZWFzZS10ZXN0cyIsCisgICAgICAgICAgICAgICAgICAgICAgInBs
YXRmb3JtIjogImNocm9taXVtIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRl
Y3R1cmVzIjogWyJpMzg2Il0sCisgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBb
Imdvb2dsZS13aW5kb3dzLTIiXQorICAgICAgICAgICAgICAgICAgICB9LAorICAgICAgICAgICAg
ICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgICAgIm5hbWUiOiAiQ2hyb21pdW0gTWFjIFJl
bGVhc2UgKFRlc3RzKSIsICJ0eXBlIjogIk5ld0J1aWxkQW5kVGVzdCIsICJidWlsZGRpciI6ICJj
aHJvbWl1bS1tYWMtcmVsZWFzZS10ZXN0cyIsCisgICAgICAgICAgICAgICAgICAgICAgInBsYXRm
b3JtIjogImNocm9taXVtIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1
cmVzIjogWyJpMzg2Il0sCisgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImdv
b2dsZS1tYWMtMiJdCisgICAgICAgICAgICAgICAgICAgIH0sCisgICAgICAgICAgICAgICAgICAg
IHsKKyAgICAgICAgICAgICAgICAgICAgICAibmFtZSI6ICJDaHJvbWl1bSBMaW51eCBSZWxlYXNl
IChUZXN0cykiLCAidHlwZSI6ICJOZXdCdWlsZEFuZFRlc3QiLCAiYnVpbGRkaXIiOiAiY2hyb21p
dW0tbGludXgtcmVsZWFzZS10ZXN0cyIsCisgICAgICAgICAgICAgICAgICAgICAgInBsYXRmb3Jt
IjogImNocm9taXVtIiwgImNvbmZpZ3VyYXRpb24iOiAicmVsZWFzZSIsICJhcmNoaXRlY3R1cmVz
IjogWyJpMzg2Il0sCisgICAgICAgICAgICAgICAgICAgICAgInNsYXZlbmFtZXMiOiBbImdvb2ds
ZS1saW51eC0yIl0KKyAgICAgICAgICAgICAgICAgICAgfSwKKyAgICAgICAgICAgICAgICAgICAg
eworICAgICAgICAgICAgICAgICAgICAgICJuYW1lIjogIk5ldyBydW4td2Via2l0LXRlc3RzIiwg
InR5cGUiOiAiTmV3QnVpbGRBbmRUZXN0IiwgImJ1aWxkZGlyIjogImdvb2dsZS1uZXctdGVzdHMi
LAorICAgICAgICAgICAgICAgICAgICAgICJwbGF0Zm9ybSI6ICJtYWMtbGVvcGFyZCIsICJjb25m
aWd1cmF0aW9uIjogInJlbGVhc2UiLCAiYXJjaGl0ZWN0dXJlcyI6IFsiaTM4NiJdLAorICAgICAg
ICAgICAgICAgICAgICAgICJzbGF2ZW5hbWVzIjogWyJnb29nbGUtbmV3LXRlc3RzIl0KKyAgICAg
ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgXSwKIAogICAgICJzY2hlZHVsZXJz
IjogWyB7ICJ0eXBlIjogIkFueUJyYW5jaFNjaGVkdWxlciIsICJuYW1lIjogInRydW5rIiwgImJy
YW5jaGVzIjogWyJ0cnVuayJdLCAidHJlZVN0YWJsZVRpbWVyIjogNDUuMCwKQEAgLTE3OSw3ICsx
OTcsOCBAQAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIkdUSyBMaW51
eCAzMi1iaXQgUmVsZWFzZSIsICJHVEsgTGludXggMzItYml0IERlYnVnIiwgIkdUSyBMaW51eCA2
NC1iaXQgRGVidWciLCAiR1RLIExpbnV4IDY0LWJpdCBSZWxlYXNlIiwKICAgICAgICAgICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICJRdCBMaW51eCBSZWxlYXNlIiwgIlF0IExpbnV4IFJl
bGVhc2UgbWluaW1hbCIsICJRdCBMaW51eCBBUk12NSBSZWxlYXNlIiwgIlF0IExpbnV4IEFSTXY3
IFJlbGVhc2UiLCAKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJRdCBX
aW5kb3dzIDMyLWJpdCBSZWxlYXNlIiwgIlF0IFdpbmRvd3MgMzItYml0IERlYnVnIiwKLSAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJDaHJvbWl1bSBXaW4gUmVsZWFzZSIs
ICJDaHJvbWl1bSBNYWMgUmVsZWFzZSIsICJDaHJvbWl1bSBMaW51eCBSZWxlYXNlIl0KKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJDaHJvbWl1bSBXaW4gUmVsZWFzZSIs
ICJDaHJvbWl1bSBNYWMgUmVsZWFzZSIsICJDaHJvbWl1bSBMaW51eCBSZWxlYXNlIiwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJDaHJvbWl1bSBXaW4gUmVsZWFzZSAo
VGVzdHMpIiwgIkNocm9taXVtIE1hYyBSZWxlYXNlIChUZXN0cykiLCAiQ2hyb21pdW0gTGludXgg
UmVsZWFzZSAoVGVzdHMpIl0KICAgICAgICAgICAgICAgICAgICAgfSwKICAgICAgICAgICAgICAg
ICAgICAgeyAidHlwZSI6ICJUcmlnZ2VyYWJsZSIsICJuYW1lIjogImxlb3BhcmQtaW50ZWwtcmVs
ZWFzZS10ZXN0cyIsCiAgICAgICAgICAgICAgICAgICAgICAgImJ1aWxkZXJOYW1lcyI6IFsiTGVv
cGFyZCBJbnRlbCBSZWxlYXNlIChUZXN0cykiXQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hh
bmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGU1ZjExNjQ0NGE5NjMzNGIxOWFj
ODI2MGJmZTliMzMzNjFhZDg3MzQuLjBiOWQzNWE3NTdlNjZmZjU1ZDJlZGRjNjRlODMwYzE5ZmVj
Njc3MDYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29s
cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0wNi0wOCAgRGltaXRyaSBHbGF6a292
ICA8ZGdsYXprb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo
T09QUyEpLgorCisgICAgICAgIEFkZCB0aHJlZSBtb3JlIG5vbi1jb3JlIENocm9taXVtIGJ1aWxk
ZXJzIHRvIHN0YXJ0IHRlc3RpbmcgRHVtcFJlbmRlclRyZWUuCisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMzNQorCisgICAgICAgICogQnVpbGRTbGF2
ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvY29uZmlnLmpzb246IEFkZGVkIDMgYnVp
bGRlcnMuCisKIDIwMTAtMDYtMDggIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgog
CiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjYwNDc5Lgo=
</data>

          </attachment>
      

    </bug>

</bugzilla>