40330 2010-06-08 13:41:59 -0700 [Qt] Add support for callShouldCloseOnWebView() to DRT 2010-06-13 06:30:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 robert robert oldest_to_newest 235490 0 robert 2010-06-08 13:41:59 -0700 [Qt] Add support for callShouldCloseOnWebView() to DRT 235497 1 58176 robert 2010-06-08 13:45:40 -0700 Created attachment 58176 Patch 237412 2 58176 eric 2010-06-12 19:01:41 -0700 Comment on attachment 58176 Patch Why the void setCallCloseOnWebViews() {} change? Seems unrelated. please remove if not needed. 237534 3 robert 2010-06-13 03:22:18 -0700 (In reply to comment #2) > (From update of attachment 58176 [details]) > Why the void setCallCloseOnWebViews() {} change? Seems unrelated. please remove if not needed. On Qt I think it just needs to be supported as a no-op. Adding it also allows the real DRT bug in plugins/open-and-close-window-with-plugin.html and plugins/geturlnotify-during-document-teardown.html to be exposed. This is tracked at https://bugs.webkit.org/show_bug.cgi?id=33333. I'll add a comment to it so people know why it's there. 237553 4 robert 2010-06-13 06:30:10 -0700 Committed r61090: <http://trac.webkit.org/changeset/61090> 58176 2010-06-08 13:45:40 -0700 2010-06-12 19:01:40 -0700 Patch bug-40330-20100608214539.patch text/plain 6407 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhNzk2OGViYTNjNTA1NDJmYWI5Y2JmNjUyYjg0MzE3ZTQzNWU2NTRkLi43YTNiMTBj Mjk5MDYxYjM0MWM3MTVkNTc5YTBmMzQxMDY4MjkzOWUxIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTQgQEAK IDIwMTAtMDYtMDggIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQWRkIHN1cHBvcnQg Zm9yIGNhbGxTaG91bGRDbG9zZU9uV2ViVmlldygpIHRvIERSVAorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDAzMzAKKworICAgICAgICAqIHBsYXRmb3Jt L3F0L1NraXBwZWQ6IFVuc2tpcCBmYXN0L2V2ZW50cy9vbmJlZm9yZXVubG9hZC1mb2N1c2VkLWlm cmFtZS5odG1sCisKKzIwMTAtMDYtMDggIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3Jn PgorCiAgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2Vu LgogCiAgICAgICAgIFtRdF0gUHV0IGV2ZW4gbW9yZSBzdHJ1Y3R1cmUgb24gU2tpcHBlZCBmaWxl LgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCBiL0xheW91dFRl c3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKaW5kZXggZTAxZGFjYjYxMmUyNWMzYzIxNDI3OGJkNzEz YzMzYjljNzM5YjM3Ny4uODRkMWE3MmU3OWNlMjEzZGNkMjA1ZjkyZWQxZmU1NzFmZjRkYWFlZSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAorKysgYi9MYXlvdXRU ZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCkBAIC00MjEsOCArNDIxLDEyIEBAIGVkaXRpbmcvcGFz dGVib2FyZC9nZXQtZGF0YS10ZXh0LXBsYWluLWRyb3AuaHRtbAogcGx1Z2lucy9nZXQtdXJsLXRo YXQtdGhlLXJlc291cmNlLWxvYWQtZGVsZWdhdGUtd2lsbC1kaXNhbGxvdy5odG1sCiAjIC0tLS0g aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM2NzIxCiBwbHVnaW5zL2dl dC11cmwtd2l0aC1ibGFuay10YXJnZXQuaHRtbAorCisjIHBsdWdpbiBsb2dkZXN0cm95IG1lc3Nh Z2UgcmVhY2hlcyBkZXN0cm95ZWQgd2VicGFnZQogIyAtLS0tIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzMzMwogcGx1Z2lucy9vcGVuLWFuZC1jbG9zZS13aW5kb3ct d2l0aC1wbHVnaW4uaHRtbAorcGx1Z2lucy9nZXR1cmxub3RpZnktZHVyaW5nLWRvY3VtZW50LXRl YXJkb3duLmh0bWwKKwogIyAtLS0tIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zNjcwMgogcGx1Z2lucy9yZWVudHJhbnQtdXBkYXRlLXdpZGdldC1wb3NpdGlvbnMuaHRt bAogIyAtLS0tIHBsdWdpbnMgcmVuZGVyZWQgaW4gaW5jb3JyZWN0IHBvc2l0aW9uCkBAIC03ODIs MTAgKzc4Niw2IEBAIGxvYWRlci9nby1iYWNrLXRvLWRpZmZlcmVudC13aW5kb3ctc2l6ZS5odG1s CiAjIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODgwNQogZWRpdGlu Zy90ZXh0LWl0ZXJhdG9yL2Jhc2ljLWl0ZXJhdGlvbi5odG1sCiAKLSMgSW1wbGVtZW50IExheW91 dFRlc3RDb250cm9sbGVyOjpjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcoKQotZmFzdC9ldmVudHMv b25iZWZvcmV1bmxvYWQtZm9jdXNlZC1pZnJhbWUuaHRtbAotcGx1Z2lucy9nZXR1cmxub3RpZnkt ZHVyaW5nLWRvY3VtZW50LXRlYXJkb3duLmh0bWwKLQogIyBNaXNzaW5nIGxheW91dFRlc3RDb250 cm9sbGVyLm92ZXJyaWRlUHJlZmVyZW5jZSgpCiBmYXN0L2V2ZW50cy9wYWdlc2hvdy1wYWdlaGlk ZS1vbi1iYWNrLWNhY2hlZC5odG1sCiBmYXN0L2V2ZW50cy9wYWdlc2hvdy1wYWdlaGlkZS1vbi1i YWNrLWNhY2hlZC13aXRoLWZyYW1lcy5odG1sCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdl TG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCAxYjMyNjBlYTQwY2FiZDQyN2Q0YzdhNGNk Y2VmYTNlZWE5NTUxODdiLi43ODY1YjVlZDk3MTI5OGNmNTA2NmE4YThlMjE0NmFkZDM4YmUwZjBj IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNi0wOCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdl YmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW1F0XSBBZGQgc3VwcG9ydCBmb3IgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3KCkgdG8gRFJU CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMzMAor CisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwOgor ICAgICAgICAoRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNob3VsZENsb3NlKToKKyAgICAgICAg KiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5oOgorCiAyMDEwLTA2LTA4 ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgT2phbiBWYWZhaSBhbmQgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv V2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwIGIvV2ViS2l0L3F0L1dl YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAppbmRleCA1NGRlZWI1NTc3 MjRkNWZkODYzODA2Y2Y4NDg0MDU2NWE1ZWYxZjY5Li5iNjdjZDUwNGM3MmI3NmU2YWZhNjgwYTdk ZjI1MTQ0ZjAzMjcwMDc1IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVt cFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9E dW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKQEAgLTU2NSw2ICs1NjUsMTIgQEAgdm9pZCBEdW1w UmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0UmVxdWVzdFBlcm1pc3Npb25GdW5jdGlvbihSZXF1ZXN0 UGVybWlzc2lvbkZ1bmMKICAgICByZXF1ZXN0UGVybWlzc2lvbkZ1bmN0aW9uID0gZjsKIH0KIAor Ym9vbCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2hvdWxkQ2xvc2UoUVdlYkZyYW1lKiBmcmFt ZSkKK3sKKyAgICBXZWJDb3JlOjpGcmFtZSogY29yZUZyYW1lID0gUVdlYkZyYW1lUHJpdmF0ZTo6 Y29yZShmcmFtZSk7CisgICAgcmV0dXJuIGNvcmVGcmFtZS0+c2hvdWxkQ2xvc2UoKTsKK30KKwog Ly8gUHJvdmlkZSBhIGJhY2t3YXJkIGNvbXBhdGliaWxpdHkgd2l0aCBwcmV2aW91c2x5IGV4cG9y dGVkIHByaXZhdGUgc3ltYm9scyBhcyBvZiBRdFdlYktpdCA0LjYgcmVsZWFzZQogCiB2b2lkIFFX RUJLSVRfRVhQT1JUIHF0X3Jlc3VtZUFjdGl2ZURPTU9iamVjdHMoUVdlYkZyYW1lKiBmcmFtZSkK ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv cnRRdC5oIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0 LmgKaW5kZXggOTQwYjNkYmRhN2NhM2Q0MWYwMDhjMmFkYTAwMDZiNTY1NzQyMTFjYy4uNDk1YmRm ZWUxNDRiNTAwZGY2MzM4M2RkMmI2Mzg5ZTE4NWE5Y2ZkNCAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmgKKysrIGIvV2ViS2l0L3F0 L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmgKQEAgLTExOCw2ICsxMTgs OCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIHZvaWQgYWxsb3dOb3RpZmljYXRpb25Gb3JPcmlnaW4o Y29uc3QgUVN0cmluZyYgb3JpZ2luKTsKICAgICBzdGF0aWMgdm9pZCBzZXRDaGVja1Blcm1pc3Np b25GdW5jdGlvbihDaGVja1Blcm1pc3Npb25GdW5jdGlvblR5cGUqKTsKICAgICBzdGF0aWMgdm9p ZCBzZXRSZXF1ZXN0UGVybWlzc2lvbkZ1bmN0aW9uKFJlcXVlc3RQZXJtaXNzaW9uRnVuY3Rpb25U eXBlKik7CisKKyAgICBzdGF0aWMgYm9vbCBzaG91bGRDbG9zZShRV2ViRnJhbWUqIGZyYW1lKTsK IH07CiAKICNlbmRpZgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0 VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGU1ZjExNjQ0NGE5NjMzNGIxOWFjODI2MGJmZTliMzMzNjFh ZDg3MzQuLjc5OGRiMWY0MjIwMjg1YzI5OWRjNjE3NTE3MjNjMDA4NGNmOWM1MzYgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxNSBAQAorMjAxMC0wNi0wOCAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBBZGQgc3VwcG9ydCBmb3IgY2FsbFNob3VsZENsb3NlT25XZWJWaWV3KCkgdG8gRFJUCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00MDMzMAorCisgICAg ICAgICogRHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHA6CisgICAg ICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6Y2FsbFNob3VsZENsb3NlT25XZWJWaWV3KToKKyAg ICAgICAgKiBEdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0Lmg6CisgICAg ICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6c2V0Q2FsbENsb3NlT25XZWJWaWV3cyk6CisKIDIw MTAtMDYtMDggIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVu cmV2aWV3ZWQgYnVpbGRmaXggYWZ0ZXIgcjYwNDc5LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv RHVtcFJlbmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAgYi9XZWJLaXRUb29s cy9EdW1wUmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAppbmRleCAzZjI1 ODVkM2ZkMGUyYjcxMGQ1MGE3MTRjNmVjODg4ZGY5MTY5ZDRlLi41NmJiMDU3ZWVkY2NmN2I0Nzdm MTg5Yjk3NmE2MGY4NGNiM2E4MThjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcApAQCAtNTY0LDggKzU2NCw3 IEBAIGludCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bnVtYmVyT2ZQYWdlcyhmbG9hdCB3aWR0aCwg ZmxvYXQgaGVpZ2h0KQogCiBib29sIExheW91dFRlc3RDb250cm9sbGVyOjpjYWxsU2hvdWxkQ2xv c2VPbldlYlZpZXcoKQogewotICAgIC8vIEZJWE1FOiBJbXBsZW1lbnQgZm9yIHRlc3RpbmcgZml4 IGZvciBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjc0ODEKLSAgICBy ZXR1cm4gZmFsc2U7CisgICAgcmV0dXJuIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzaG91bGRD bG9zZShtX2RydC0+d2ViUGFnZSgpLT5tYWluRnJhbWUoKSk7CiB9CiAKIHZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OnNldFNjcm9sbGJhclBvbGljeShjb25zdCBRU3RyaW5nJiBvcmllbnRhdGlv biwgY29uc3QgUVN0cmluZyYgcG9saWN5KQpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5oCmluZGV4IGQ3YmI4Mzk1NTgzM2Vi MmVhMTU1ZjY2MzY0MDdiY2MzZTc1YTMxYjUuLjYwOTRhNTRkNzNjZjBhYWIzNTJmMjdiMDQxMmFk NmQyNmE0MGU4OTYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0xh eW91dFRlc3RDb250cm9sbGVyUXQuaAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9x dC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmgKQEAgLTE4MCw2ICsxODAsNyBAQCBwdWJsaWMgc2xv dHM6CiAgICAgaW50IHBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChjb25zdCBRU3RyaW5nJiBpZCwg ZmxvYXQgd2lkdGggPSAwLCBmbG9hdCBoZWlnaHQgPSAwKTsKICAgICBpbnQgbnVtYmVyT2ZQYWdl cyhmbG9hdCB3aWR0aCA9IG1heFZpZXdXaWR0aCwgZmxvYXQgaGVpZ2h0ID0gbWF4Vmlld0hlaWdo dCk7CiAgICAgYm9vbCBjYWxsU2hvdWxkQ2xvc2VPbldlYlZpZXcoKTsKKyAgICB2b2lkIHNldENh bGxDbG9zZU9uV2ViVmlld3MoKSB7fQogCiAgICAgLyoKICAgICAgICAgUG9saWN5IHZhbHVlczog J29uJywgJ2F1dG8nIG9yICdvZmYnLgo=